From 2bf18944ce0625b5a0489243889697ff34591756 Mon Sep 17 00:00:00 2001 From: Mathieu Lutfy Date: Mon, 13 Mar 2023 20:59:29 -0400 Subject: [PATCH] dev/core#4166 Fix Contribute Import Parser fatal when soft-credit is empty --- CRM/Contribute/Import/Parser/Contribution.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CRM/Contribute/Import/Parser/Contribution.php b/CRM/Contribute/Import/Parser/Contribution.php index e5dbf17244..a379e26bff 100644 --- a/CRM/Contribute/Import/Parser/Contribution.php +++ b/CRM/Contribute/Import/Parser/Contribution.php @@ -434,7 +434,7 @@ class CRM_Contribute_Import_Parser_Contribution extends CRM_Import_Parser { $softCreditParams = []; foreach ($params['SoftCreditContact'] ?? [] as $index => $softCreditContact) { $softCreditParams[$index]['soft_credit_type_id'] = $softCreditContact['soft_credit_type_id']; - $softCreditParams[$index]['contact_id'] = $this->getContactID($softCreditContact['Contact'], $softCreditContact['Contact']['id'] ?? NULL, 'SoftCreditContact', $this->getDedupeRulesForEntity('SoftCreditContact')); + $softCreditParams[$index]['contact_id'] = $this->getContactID($softCreditContact['Contact'], !empty($softCreditContact['Contact']['id']) ? $softCreditContact['Contact']['id'] : NULL, 'SoftCreditContact', $this->getDedupeRulesForEntity('SoftCreditContact')); if (empty($softCreditParams[$index]['contact_id']) && in_array($this->getActionForEntity('SoftCreditContact'), ['update', 'select'])) { throw new CRM_Core_Exception(ts('Soft Credit Contact not found')); } -- 2.25.1