From 2a5fbb1cb389edd56b271133546710a0566c4d79 Mon Sep 17 00:00:00 2001
From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Wed, 21 Jun 2023 09:32:10 -0700
Subject: [PATCH] Move sending of email to recur function

---
 CRM/Core/Payment/AuthorizeNetIPN.php | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/CRM/Core/Payment/AuthorizeNetIPN.php b/CRM/Core/Payment/AuthorizeNetIPN.php
index 99fcbe1109..8ac0a5d13e 100644
--- a/CRM/Core/Payment/AuthorizeNetIPN.php
+++ b/CRM/Core/Payment/AuthorizeNetIPN.php
@@ -58,15 +58,7 @@ class CRM_Core_Payment_AuthorizeNetIPN extends CRM_Core_Payment_BaseIPN {
       if ($contribution->contribution_status_id == 1) {
         $first = FALSE;
       }
-      $isFirstOrLastRecurringPayment = $this->recur($contributionRecur, $first);
-
-      if ($isFirstOrLastRecurringPayment) {
-        //send recurring Notification email for user
-        CRM_Contribute_BAO_ContributionPage::recurringNotify($contributionID, TRUE,
-          $contributionRecur
-        );
-      }
-
+      $this->recur($contributionRecur, $first);
       return TRUE;
     }
     catch (CRM_Core_Exception $e) {
@@ -79,7 +71,6 @@ class CRM_Core_Payment_AuthorizeNetIPN extends CRM_Core_Payment_BaseIPN {
    * @param \CRM_Contribute_BAO_ContributionRecur $recur
    * @param bool $first
    *
-   * @return bool
    * @throws \CRM_Core_Exception
    */
   public function recur($recur, $first) {
@@ -123,11 +114,16 @@ class CRM_Core_Payment_AuthorizeNetIPN extends CRM_Core_Payment_BaseIPN {
       // so we just fix the recurring contribution and not change any of
       // the existing contributions
       // CRM-9036
-      return FALSE;
+      return;
     }
 
     CRM_Contribute_BAO_Contribution::completeOrder($input, $recur->id, $first ? $this->getContributionID() : NULL);
-    return $isFirstOrLastRecurringPayment;
+    if ($isFirstOrLastRecurringPayment) {
+      //send recurring Notification email for user
+      CRM_Contribute_BAO_ContributionPage::recurringNotify($this->getContributionID(), TRUE,
+        $this->getContributionRecur()
+      );
+    }
   }
 
   /**
-- 
2.25.1