From 29b35cc506192d07b2d8bc846bc475357e4e4d1b Mon Sep 17 00:00:00 2001 From: Tim Otten Date: Wed, 5 Aug 2020 19:47:27 -0700 Subject: [PATCH] 5.28.0.md - Describe last minute PR. Random copyedits. --- release-notes/5.28.0.md | 139 ++++++++++++++++++---------------------- 1 file changed, 62 insertions(+), 77 deletions(-) diff --git a/release-notes/5.28.0.md b/release-notes/5.28.0.md index e0811aca6e..da6ba4cb63 100644 --- a/release-notes/5.28.0.md +++ b/release-notes/5.28.0.md @@ -31,11 +31,11 @@ Released August 5, 2020 Block sites from upgrading if on a MySQL version less than 5.6.5. -- **Feature Request: Ability to enable SSL for database connection. (Work - Towards [dev/core#1137](https://lab.civicrm.org/dev/core/-/issues/1137): +- **Ability to enable SSL for database connection. (Work Towards + [dev/core#1137](https://lab.civicrm.org/dev/core/-/issues/1137): [298](https://github.com/civicrm/civicrm-packages/pull/298))** - Makes ssl database connections without client certificates work in php7. + Makes SSL database connections without client certificates work in PHP 7. - **Create new customPre hook ([dev/core#1716](https://lab.civicrm.org/dev/core/-/issues/1716): @@ -44,7 +44,7 @@ Released August 5, 2020 Creates a new hook customPre which makes it so one can impact or observe custom data before it is saved. -- **Investigate php currency library +- **Investigate PHP currency library ([dev/translation#48](https://lab.civicrm.org/dev/translation/-/issues/48): [17608](https://github.com/civicrm/civicrm-core/pull/17608))** @@ -64,7 +64,7 @@ Released August 5, 2020 Work towards throwing exceptions instead of fatal errors. -- **V4 activity api has no default for activity_date_time +- **APIv4 - Activity has no default for activity_date_time ([dev/core#1782](https://lab.civicrm.org/dev/core/-/issues/1782): [17450](https://github.com/civicrm/civicrm-core/pull/17450))** @@ -142,11 +142,11 @@ Released August 5, 2020 Adds metadata to help APIv4 serialize/unserialize the domain.locales field correctly. -- **Add smarty error event +- **Add Smarty error event ([16918](https://github.com/civicrm/civicrm-core/pull/16918) and [292](https://github.com/civicrm/civicrm-packages/pull/292))** - Improves debugging errors in smarty templates. + Improves debugging errors in Smarty templates. - **Allow HEAD requests to generate a form key ([17321](https://github.com/civicrm/civicrm-core/pull/17321))** @@ -157,7 +157,7 @@ Released August 5, 2020 process in parallel ([15422](https://github.com/civicrm/civicrm-core/pull/15422))** - Adds a new Sql queue type which will allow multiple runners to fetch the next + Adds a new SQL queue type which will allow multiple runners to fetch the next available job from a queue and run in parallel. - **Allow adding datepicker to metadata based settings pages @@ -181,6 +181,7 @@ Released August 5, 2020 [17559](https://github.com/civicrm/civicrm-core/pull/17559), [17542](https://github.com/civicrm/civicrm-core/pull/17542), [17502](https://github.com/civicrm/civicrm-core/pull/17502), + [17500](https://github.com/civicrm/civicrm-core/pull/17500), [17597](https://github.com/civicrm/civicrm-core/pull/17597), [17592](https://github.com/civicrm/civicrm-core/pull/17592) and [17596](https://github.com/civicrm/civicrm-core/pull/17596))** @@ -194,7 +195,7 @@ Released August 5, 2020 Makes it so payment processor developers can identify the different contexts someone may be canceling from and display appropriate messaging. -- **Price Field Form: save the fid for the postProcess hook +- **Price Field Form - Save the fid for the postProcess hook ([17639](https://github.com/civicrm/civicrm-core/pull/17639))** Improves `postProcess` hook for Price Field Form by making the field id @@ -245,7 +246,7 @@ Released August 5, 2020 Remove database index on `medium_id` from `civicrm_activity`. -- **[Activity] Default priority value when add Activity +- **Activity - Default priority value when adding an activity ([dev/core#1801](https://lab.civicrm.org/dev/core/-/issues/1801): [17557](https://github.com/civicrm/civicrm-core/pull/17557))** @@ -263,7 +264,7 @@ Released August 5, 2020 - **APIv4 - Skip empty leaves in WHERE clause ([17576](https://github.com/civicrm/civicrm-core/pull/17576))** - Fixes a bug in search builder where APIv4 gives a sql error while building + Fixes a bug in search builder where APIv4 gives a SQL error while building your where clause. - **Offset is not respected in Date Preferences @@ -277,12 +278,12 @@ Released August 5, 2020 Ensures comments do not interfere with deduping. -- **Use PHPUnit7 as the primary test runner for PHP versions >= 7.1 when using - the phpunit script - ([17615](https://github.com/civicrm/civicrm-core/pull/17615))** - - Updates PHP unit tests to use PHPUnit7 when the PHP Unit version is 7.1 or - greater. +- **Use PHPUnit7 as the primary test runner + ([17615](https://github.com/civicrm/civicrm-core/pull/17615), + [17661](https://github.com/civicrm/civicrm-core/pull/17661), + [120](https://github.com/civicrm/civicrm-backdrop/pull/120), + [605](https://github.com/civicrm/civicrm-drupal/pull/605), + [206](https://github.com/civicrm/civicrm-wordpress/pull/206))** - **Fix isMultilingual to use static caching and respect current domain ([17646](https://github.com/civicrm/civicrm-core/pull/17646))** @@ -296,7 +297,7 @@ Released August 5, 2020 This field was incorrectly marked as a boolean; it's actually an int with an option list. -- **Payment Propertybag remove warning +- **Civi\Payment\PropertyBag - Remove warning ([17506](https://github.com/civicrm/civicrm-core/pull/17506))** - **Fix duplicate upgrade function @@ -318,7 +319,7 @@ Released August 5, 2020 ([dev/core#1749](https://lab.civicrm.org/dev/core/-/issues/1749): [17440](https://github.com/civicrm/civicrm-core/pull/17440))** -- **Regression : File fields export results in DB error +- **Regression - File fields export results in DB error ([dev/core#1787](https://lab.civicrm.org/dev/core/-/issues/1787): [17578](https://github.com/civicrm/civicrm-core/pull/17578))** @@ -339,7 +340,7 @@ Released August 5, 2020 ([dev/core#1860](https://lab.civicrm.org/dev/core/-/issues/1860): [17772](https://github.com/civicrm/civicrm-core/pull/17772))** -- **APIv4 - filter getActions results based on user permissions +- **APIv4 - Filter getActions results based on user permissions ([17540](https://github.com/civicrm/civicrm-core/pull/17540))** - **Pre-upgrade message for php-intl shows twice @@ -352,7 +353,7 @@ Released August 5, 2020 in crash ([dev/core#1841](https://lab.civicrm.org/dev/core/-/issues/1841): [17697](https://github.com/civicrm/civicrm-core/pull/17697))** -- **Use psr-4 instead of psr-0 in Civi directory +- **Use PSR-4 instead of PSR-0 in Civi directory ([17690](https://github.com/civicrm/civicrm-core/pull/17690))** - **Sort options without relying on unavailable buildOptions param @@ -393,14 +394,18 @@ Released August 5, 2020 - **Remove isThrowException from CRM_Utils_Type::validate() signature ([17546](https://github.com/civicrm/civicrm-core/pull/17546))** -- **codeVersion not displayed in system status check error message about db +- **`codeVersion` not displayed in system status check error message about db version vs codeversion ([dev/core#1882](https://lab.civicrm.org/dev/core/-/issues/1882): [17854](https://github.com/civicrm/civicrm-core/pull/17854))** +- **"Merge" form moves unchecked related entities (intra-RC regression) + ([dev/core#1930](https://lab.civicrm.org/dev/core/-/issues/1930): + [18079](https://github.com/civicrm/civicrm-core/pull/18079))** + ### CiviCase -- **Noncompliant query leads to (semi-)random sorting and failing unit test +- **Non-compliant query leads to (semi-)random sorting and failing unit test CRM_Case_BAO_CaseTest::testSortByCaseContact ([dev/core#1844](https://lab.civicrm.org/dev/core/-/issues/1844): [17708](https://github.com/civicrm/civicrm-core/pull/17708))** @@ -435,6 +440,14 @@ Released August 5, 2020 value ([dev/report#40](https://lab.civicrm.org/dev/report/-/issues/40): [17412](https://github.com/civicrm/civicrm-core/pull/17412))** +- **"Undefined offset" bug in BAO/FinancialAccount.php + ([dev/wordpress#61](https://lab.civicrm.org/dev/wordpress/-/issues/61): + [17701](https://github.com/civicrm/civicrm-core/pull/17701) and + [17689](https://github.com/civicrm/civicrm-core/pull/17689))** + + Ensures that the financial account is set correctly even when the name does + not match the label. + ### CiviEvent - **Event participant_listing_id field defaults to 0 instead of Null @@ -485,14 +498,6 @@ Released August 5, 2020 Ensures that the CiviCRM base page is correctly identified when it does not reside in the theme root directory. -- **undefined offset bug in BAO/FinancialAccount.php - ([dev/wordpress#61](https://lab.civicrm.org/dev/wordpress/-/issues/61): - [17701](https://github.com/civicrm/civicrm-core/pull/17701) and - [17689](https://github.com/civicrm/civicrm-core/pull/17689))** - - Ensures that the financial account is set correctly even when the name does - not match the label. - - **Prevent session from starting during WordPress pseudo cron procedures ([dev/core#1889](https://lab.civicrm.org/dev/core/-/issues/1889): [17890](https://github.com/civicrm/civicrm-core/pull/17890) and @@ -500,13 +505,17 @@ Released August 5, 2020 ## Miscellany +- **Ship Flexmailer extension with civicrm-core + ([17669](https://github.com/civicrm/civicrm-core/pull/17669), + ([17768](https://github.com/civicrm/civicrm-core/pull/17768))** + - **Support passing old method name into deprecatedFunctionWarning ([17552](https://github.com/civicrm/civicrm-core/pull/17552))** - **Add CRM_Core_Form::isFormInViewMode and CRM_Core_Form::isFormInEditMode ([17637](https://github.com/civicrm/civicrm-core/pull/17637))** -- **CRM_Utils_JS - also dedupe 'use strict' directive when deduping closures +- **CRM_Utils_JS - Dedupe 'use strict' directive ([17711](https://github.com/civicrm/civicrm-core/pull/17711))** - **Add isBackOffice, isPayLater, getPaymentMode helpers to @@ -543,7 +552,7 @@ Released August 5, 2020 - **EventInfo template cleanup ([17581](https://github.com/civicrm/civicrm-core/pull/17581))** -- **Misspelled word +- **[NFC] Misspelled word ([17652](https://github.com/civicrm/civicrm-core/pull/17652))** - **Remove a usage of deprecated funtion get_magic_quotes_gpc and also switch out @@ -556,65 +565,59 @@ Released August 5, 2020 - **Remove obsolete function formatWikiURL ([17726](https://github.com/civicrm/civicrm-core/pull/17726))** -- **[REF] Ship Flexmailer extension with Core - ([17669](https://github.com/civicrm/civicrm-core/pull/17669))** - -- **[Ref] Simplify the replacing of the email with the email from the url +- **[REF] Simplify the replacing of the email with the email from the url ([17491](https://github.com/civicrm/civicrm-core/pull/17491))** - **[REF] Replace incorrect usages of array_key_exists when the variable is not an array with property_exists and also fix the parameter order for an implode statement ([17573](https://github.com/civicrm/civicrm-core/pull/17573))** -- **[Ref] Convert Authorize.net to use Guzzle for update subscription class, add +- **[REF] Convert Authorize.net to use Guzzle for update subscription class, add test ([17585](https://github.com/civicrm/civicrm-core/pull/17585))** - **[REF] Using {} to access string or array offsets has been deprecated in PHP7.4 ([17574](https://github.com/civicrm/civicrm-core/pull/17574))** -- **[Ref] Mark unused date functions as deprecated +- **[REF] Mark unused date functions as deprecated ([17487](https://github.com/civicrm/civicrm-core/pull/17487))** - **[REF] Using ternary operation without nesting is deprecated and also using methods and properly instanciate the CiviCase Info object in test ([17575](https://github.com/civicrm/civicrm-core/pull/17575))** -- **[Ref] Convert Authorize.net doDirectPayment to use guzzle & add test +- **[REF] Convert Authorize.net doDirectPayment to use guzzle & add test ([17501](https://github.com/civicrm/civicrm-core/pull/17501))** - **[REF] Replace the deprecated system_rebuild_module_data function with equivilant extension.list.module service function calls to be Drupal 9 compatiable ([17515](https://github.com/civicrm/civicrm-core/pull/17515))** -- **[Ref] Remove never reachable lines. +- **[REF] Remove never reachable lines. ([17556](https://github.com/civicrm/civicrm-core/pull/17556))** -- **[Ref] Remove another instance of fatal() +- **[REF] Remove another instance of fatal() ([17549](https://github.com/civicrm/civicrm-core/pull/17549))** -- **[Ref] Readability extraction in Dummy class +- **[REF] Readability extraction in Dummy class ([17543](https://github.com/civicrm/civicrm-core/pull/17543))** -- **[Ref] Throw exceptions from Authorize.net rather than return errors - ([17500](https://github.com/civicrm/civicrm-core/pull/17500))** - - **[REF] Replace some instances of fatal with thrown exceptions. ([17533](https://github.com/civicrm/civicrm-core/pull/17533))** -- **[Ref] Remove calls to, and deprecate, unhandled function +- **[REF] Remove calls to, and deprecate, unhandled function ([17499](https://github.com/civicrm/civicrm-core/pull/17499))** - **[REF] Remove handling for 2 fields not on the form ([17504](https://github.com/civicrm/civicrm-core/pull/17504))** -- **[Ref] Remove some instances of fatal in BAO classes +- **[REF] Remove some instances of fatal in BAO classes ([17536](https://github.com/civicrm/civicrm-core/pull/17536))** -- **REF Access the method not the property directly to check if a payment +- **[REF] Access the method not the property directly to check if a payment processor supports recurring ([17602](https://github.com/civicrm/civicrm-core/pull/17602))** -- **[REF] Ensure that our custom error handler is called when jquery validates +- **[REF] Ensure that our custom error handler is called when jQuery validates and expand any collapsed accordions that are hiding required fields that haven't been filled in ([17673](https://github.com/civicrm/civicrm-core/pull/17673))** @@ -625,10 +628,10 @@ Released August 5, 2020 - **[REF] Cleanup function for retrieving contact types. ([17676](https://github.com/civicrm/civicrm-core/pull/17676))** -- **[REF] Fix javascript syntax error +- **[REF] Fix Javascript syntax error ([17678](https://github.com/civicrm/civicrm-core/pull/17678))** -- **[REF] Fix jquery error message display on select2 field validation +- **[REF] Fix jQuery error message display on select2 field validation ([17671](https://github.com/civicrm/civicrm-core/pull/17671))** - **[REF] Fix allowing users to clear values for raido custom fields when not @@ -637,8 +640,8 @@ Released August 5, 2020 - **[REF] Extract getTestTrxnID ([17642](https://github.com/civicrm/civicrm-core/pull/17642))** -- **[REF] Fix Compatability issue with flexmailer caused by the PHP7.4 fix - ([17660](https://github.com/civicrm/civicrm-core/pull/17660))** +- **Update Flexmailer to be PHP7.4 compatible + ([17779](https://github.com/civicrm/civicrm-core/pull/17779), [17660](https://github.com/civicrm/civicrm-core/pull/17660))** - **[REF] Ensure that the Manual Payment Processor sets the _paymentProcessor variable like other Processors to fix issues in PHP7.4 and UnitTests @@ -669,8 +672,8 @@ Released August 5, 2020 checked is an object ([17601](https://github.com/civicrm/civicrm-core/pull/17601))** -- **[REF] Remove deprecated methods of booting drupal container and getting - drupal timezone information +- **[REF] Remove deprecated methods of booting Drupal container and getting + Drupal timezone information ([17522](https://github.com/civicrm/civicrm-core/pull/17522))** - **[REF] Fix some additional issues where curly braces were being used to @@ -680,30 +683,18 @@ Released August 5, 2020 - **[NFC] Update existing APIv3 MembershipType Tests to also test against APIv4 as appropriate ([17528](https://github.com/civicrm/civicrm-core/pull/17528))** -- **NFC cleanup docblocks in CRM_Utils_JS +- **[NFC] cleanup docblocks in CRM_Utils_JS ([17714](https://github.com/civicrm/civicrm-core/pull/17714))** -- **[NFC] Update flexmailer to be PHP7.4 compatible - ([17779](https://github.com/civicrm/civicrm-core/pull/17779))** - -- **[NFC] Include flexmailer in distmaker - ([17768](https://github.com/civicrm/civicrm-core/pull/17768))** - - **[NFC] Fix some outdated wiki links ([17739](https://github.com/civicrm/civicrm-core/pull/17739))** - **[NFC] Fix contributor key for Lighthouse Consulting and Design ([17727](https://github.com/civicrm/civicrm-core/pull/17727))** -- **[NFC] Update PHPUnit Configuration file to be compatible with PHPUnit7 - ([605](https://github.com/civicrm/civicrm-drupal/pull/605))** - -- **[NFC] Fix Unit test failure on MySQL 8 due to mysql ordering issue +- **[NFC] Fix unit test failure on MySQL 8 due to ordering issue ([17674](https://github.com/civicrm/civicrm-core/pull/17674))** -- **[NFC] Fix tests in preparation for phpunit7 - ([17661](https://github.com/civicrm/civicrm-core/pull/17661))** - - **[NFC] Remove instances where html is passed to crmMoney ([17612](https://github.com/civicrm/civicrm-core/pull/17612))** @@ -713,18 +704,12 @@ Released August 5, 2020 - **[NFC] Update mocking to use getMockBuilder instead instead of createMock ([17606](https://github.com/civicrm/civicrm-core/pull/17606))** -- **NFC Formatting cleanup on contribution/recur templates +- **[NFC] Formatting cleanup on contribution/recur templates ([17603](https://github.com/civicrm/civicrm-core/pull/17603))** - **[NFC] Minor code cleanup ([17566](https://github.com/civicrm/civicrm-core/pull/17566))** -- **[NFC] Update PHPUnit configuration to be compatible with PHPUnit7 - ([120](https://github.com/civicrm/civicrm-backdrop/pull/120))** - -- **[NFC] Update PHPUnit configuration to be compatible with PHPUnit7 - ([206](https://github.com/civicrm/civicrm-wordpress/pull/206))** - - **MembershipRenewalTest - Fix failure ([17830](https://github.com/civicrm/civicrm-core/pull/17830))** -- 2.25.1