From 289826dc46b0399ff993a53ac85545e5096b0dc7 Mon Sep 17 00:00:00 2001 From: Andrew Browning Date: Wed, 2 Mar 2016 12:29:33 -0500 Subject: [PATCH] Fix #5435 - Bad comment links cause server error This patch addresses an issue where a server error is caused by entering a non-existent comment ID in a media URL. --- mediagoblin/notifications/__init__.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mediagoblin/notifications/__init__.py b/mediagoblin/notifications/__init__.py index 9d2f2b78..d554de2d 100644 --- a/mediagoblin/notifications/__init__.py +++ b/mediagoblin/notifications/__init__.py @@ -71,6 +71,11 @@ def mark_notification_seen(notification): def mark_comment_notification_seen(comment_id, user): comment = Comment.query.get(comment_id) + + # If there is no comment, there is no notification + if comment == None: + return + comment_gmr = GenericModelReference.query.filter_by( obj_pk=comment.id, model_type=comment.__tablename__ -- 2.25.1