From 287bd02ff8e6aec8b3cb647e78bb837e91d94b8a Mon Sep 17 00:00:00 2001
From: Coleman Watts <coleman@civicrm.org>
Date: Fri, 4 Jun 2021 09:06:09 -0400
Subject: [PATCH] APIv4 - Delete undocumented deprecated pseudoconstant lookup
 for Activity type

---
 .../ActivityPreCreationSubscriber.php         | 58 -------------------
 1 file changed, 58 deletions(-)
 delete mode 100644 Civi/Api4/Event/Subscriber/ActivityPreCreationSubscriber.php

diff --git a/Civi/Api4/Event/Subscriber/ActivityPreCreationSubscriber.php b/Civi/Api4/Event/Subscriber/ActivityPreCreationSubscriber.php
deleted file mode 100644
index ceb6ccc842..0000000000
--- a/Civi/Api4/Event/Subscriber/ActivityPreCreationSubscriber.php
+++ /dev/null
@@ -1,58 +0,0 @@
-<?php
-
-/*
- +--------------------------------------------------------------------+
- | Copyright CiviCRM LLC. All rights reserved.                        |
- |                                                                    |
- | This work is published under the GNU AGPLv3 license with some      |
- | permitted exceptions and without any warranty. For full license    |
- | and copyright information, see https://civicrm.org/licensing       |
- +--------------------------------------------------------------------+
- */
-
-/**
- *
- * @package CRM
- * @copyright CiviCRM LLC https://civicrm.org/licensing
- */
-
-
-namespace Civi\Api4\Event\Subscriber;
-
-use Civi\Api4\Generic\DAOCreateAction;
-use Civi\Api4\OptionValue;
-
-class ActivityPreCreationSubscriber extends Generic\PreCreationSubscriber {
-
-  /**
-   * @param \Civi\Api4\Generic\DAOCreateAction $request
-   * @throws \API_Exception
-   * @throws \Exception
-   */
-  protected function modify(DAOCreateAction $request) {
-    $activityType = $request->getValue('activity_type');
-    if ($activityType) {
-      \CRM_Core_Error::deprecatedFunctionWarning('Use activity_type_id:name instead of activity_type in APIv4');
-      $result = OptionValue::get(FALSE)
-        ->addWhere('name', '=', $activityType)
-        ->addWhere('option_group.name', '=', 'activity_type')
-        ->execute();
-
-      if ($result->count() !== 1) {
-        throw new \Exception('Activity type must match a *single* type');
-      }
-
-      $request->addValue('activity_type_id', $result->first()['value']);
-    }
-  }
-
-  /**
-   * @param \Civi\Api4\Generic\DAOCreateAction $request
-   *
-   * @return bool
-   */
-  protected function applies(DAOCreateAction $request) {
-    return $request->getEntityName() === 'Activity';
-  }
-
-}
-- 
2.25.1