From 26dd92e60ddff86d347475a027577ad315dc57ee Mon Sep 17 00:00:00 2001 From: Coleman Watts Date: Thu, 3 Feb 2022 23:24:42 -0500 Subject: [PATCH] SearchKit - Better user feedback if search entity is missing Before: After disabling the Afform extension, the search display appears editable but crashes on missing AfformSubmission entity After: Not editable, shows message that entity is missing. --- .../crmSearchAdminSearchListing.component.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/ext/search_kit/ang/crmSearchAdmin/searchListing/crmSearchAdminSearchListing.component.js b/ext/search_kit/ang/crmSearchAdmin/searchListing/crmSearchAdminSearchListing.component.js index 80fbb10432..46cea6c5a7 100644 --- a/ext/search_kit/ang/crmSearchAdmin/searchListing/crmSearchAdminSearchListing.component.js +++ b/ext/search_kit/ang/crmSearchAdmin/searchListing/crmSearchAdminSearchListing.component.js @@ -73,6 +73,10 @@ this.onPostRun.push(function(result) { _.each(result, function(row) { row.permissionToEdit = CRM.checkPerm('all CiviCRM permissions and ACLs') || !_.includes(row.data.display_acl_bypass, true); + // If main entity doesn't exist, no can edit + if (!row.data['api_entity:label']) { + row.permissionToEdit = false; + } // Saves rendering cycles to not show an empty menu of search displays if (!row.data.display_name) { row.openDisplayMenu = false; @@ -177,6 +181,10 @@ }), searchMeta.fieldToColumn('api_entity:label', { label: ts('For'), + empty_value: ts('Missing'), + cssRules: [ + ['font-italic', 'api_entity:label', 'IS EMPTY'] + ] }), { type: 'include', -- 2.25.1