From 26659f0c3aaf438e25acd7c23da1207e764b0da5 Mon Sep 17 00:00:00 2001
From: Andreas Hennings <andreas@dqxtech.net>
Date: Tue, 11 Feb 2014 20:30:54 +0100
Subject: [PATCH] More @todo

---
 CRM/Utils/System.php      | 1 +
 CRM/Utils/System/Base.php | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/CRM/Utils/System.php b/CRM/Utils/System.php
index e5bbda8fcc..59a12af1ca 100644
--- a/CRM/Utils/System.php
+++ b/CRM/Utils/System.php
@@ -701,6 +701,7 @@ class CRM_Utils_System {
       return TRUE;
     }
     if (is_array($value)) {
+      // @todo Reuse of the $value variable = asking for trouble.
       foreach ($value as $key => $value) {
         if (!self::isNull($value)) {
           return FALSE;
diff --git a/CRM/Utils/System/Base.php b/CRM/Utils/System/Base.php
index 8dbb701109..bc4ab498ed 100644
--- a/CRM/Utils/System/Base.php
+++ b/CRM/Utils/System/Base.php
@@ -59,6 +59,9 @@ abstract class CRM_Utils_System_Base {
    * @return string|null
    *   NULL, If $print is FALSE, and some other criteria match up.
    *   The themed string, otherwise.
+   *
+   * @todo The return value is inconsistent.
+   * @todo Better to always return, and never print.
    */
   public function theme(&$content, $print = FALSE, $maintenance = FALSE) {
     $ret = FALSE;
-- 
2.25.1