From 2167da5fa94305105539950d677b79d1861bc114 Mon Sep 17 00:00:00 2001
From: Coleman Watts <coleman@civicrm.org>
Date: Tue, 10 Aug 2021 22:06:49 -0400
Subject: [PATCH] Afform - Code cleanup in LoadAdminData API action

---
 .../Civi/Api4/Action/Afform/LoadAdminData.php      | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/ext/afform/admin/Civi/Api4/Action/Afform/LoadAdminData.php b/ext/afform/admin/Civi/Api4/Action/Afform/LoadAdminData.php
index f8bd4cfafc..6caa450952 100644
--- a/ext/afform/admin/Civi/Api4/Action/Afform/LoadAdminData.php
+++ b/ext/afform/admin/Civi/Api4/Action/Afform/LoadAdminData.php
@@ -4,7 +4,7 @@ namespace Civi\Api4\Action\Afform;
 
 use Civi\AfformAdmin\AfformAdminMeta;
 use Civi\Api4\Afform;
-use Civi\Api4\Entity;
+use Civi\Api4\Utils\CoreUtil;
 use Civi\Api4\Query\SqlExpression;
 
 /**
@@ -209,6 +209,10 @@ class LoadAdminData extends \Civi\Api4\Generic\AbstractAction {
     $result[] = $info;
   }
 
+  /**
+   * @param string $name
+   * @return array|null
+   */
   private function loadForm($name) {
     return Afform::get($this->checkPermissions)
       ->setFormatWhitespace(TRUE)
@@ -262,10 +266,7 @@ class LoadAdminData extends \Civi\Api4\Generic\AbstractAction {
       else {
         $joinCount[$entityName] = 1;
       }
-      $label = Entity::get(FALSE)
-        ->addWhere('name', '=', $entityName)
-        ->addSelect('title')
-        ->execute()->first()['title'];
+      $label = CoreUtil::getInfoItem($entityName, 'title');
       $joinMap[$alias] = $label . $num;
     }
 
@@ -288,6 +289,9 @@ class LoadAdminData extends \Civi\Api4\Generic\AbstractAction {
     return $calcFields;
   }
 
+  /**
+   * @return array[]
+   */
   public function fields() {
     return [
       [
-- 
2.25.1