From 207c137b0fd5f1ff9164d9e7e84d29872c763472 Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Thu, 15 Jul 2021 12:32:34 +1200 Subject: [PATCH] Remove never-true-if This code is in the recur() function. the lines immediately before this function ensure contribution->contribution_status_id is unset if it is 1 - meaning this if can never be true --- CRM/Core/Payment/AuthorizeNetIPN.php | 7 ------- 1 file changed, 7 deletions(-) diff --git a/CRM/Core/Payment/AuthorizeNetIPN.php b/CRM/Core/Payment/AuthorizeNetIPN.php index c278ced641..72eae6f882 100644 --- a/CRM/Core/Payment/AuthorizeNetIPN.php +++ b/CRM/Core/Payment/AuthorizeNetIPN.php @@ -158,13 +158,6 @@ class CRM_Core_Payment_AuthorizeNetIPN extends CRM_Core_Payment_BaseIPN { return FALSE; } - // check if contribution is already completed, if so we ignore this ipn - if ($contribution->contribution_status_id == 1) { - CRM_Core_Error::debug_log_message("Returning since contribution has already been handled."); - echo 'Success: Contribution has already been handled

'; - return FALSE; - } - CRM_Contribute_BAO_Contribution::completeOrder($input, $recur->id, $contribution->id ?? NULL); return $isFirstOrLastRecurringPayment; } -- 2.25.1