From 1f7c417d6e7663d7d6b315704e63f80676415ea8 Mon Sep 17 00:00:00 2001 From: Ian Kelling Date: Tue, 11 Mar 2025 19:49:55 -0400 Subject: [PATCH] tiny refactor --- .../files/simple/usr/local/bin/savannah-virsh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/roles/kvmhost/files/simple/usr/local/bin/savannah-virsh b/roles/kvmhost/files/simple/usr/local/bin/savannah-virsh index 49e3a48..4812aab 100755 --- a/roles/kvmhost/files/simple/usr/local/bin/savannah-virsh +++ b/roles/kvmhost/files/simple/usr/local/bin/savannah-virsh @@ -107,6 +107,12 @@ path_regex='^[[:alnum:]/_-]+$' # The var comes with a leading space, remove it. args="${SSH_ORIGINAL_COMMAND# }" +# defensive check. Just guessing that 1000 is much longer than any valid arguments. +args_len="${#args}" +if (( args_len > 1000 )); then + arg-die args_len 1000 +fi + if [[ ! $args =~ $initial_input_regex ]]; then arg-die initial regex fi @@ -114,12 +120,6 @@ fi IFS=" " read -r -a arg_array <<<"$args" -args_len="${#args}" -if (( args_len > 1000 )); then - arg-die args_len 1000 -fi - - arg0="${arg_array[0]}" declare -i argc="${#arg_array[@]}" last_arg_i=$((argc - 1)) -- 2.25.1