From 1d8f04c7c93a06bb0262ba82088dedca83beaf28 Mon Sep 17 00:00:00 2001
From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Thu, 18 May 2023 11:41:25 +1200
Subject: [PATCH] Add is_active to link spec

In the process of adding weights to the links it
occurred to me that it might be cleaner in some cases for
hooks to fiddle with 'is_active' rather than setting &
unsetting.

An example would be that instead of excluding
a link that our core code thinks should not be available
we could include it with is_active = FALSE &
a hook could enable it.

I figured if it I add it now then while adding weights I could
bank it in too
---
 CRM/Core/Action.php | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/CRM/Core/Action.php b/CRM/Core/Action.php
index c815704a26..d23bd256a4 100644
--- a/CRM/Core/Action.php
+++ b/CRM/Core/Action.php
@@ -222,7 +222,8 @@ class CRM_Core_Action {
     });
 
     foreach ($seqLinks as $i => $link) {
-      if (!$mask || !array_key_exists('bit', $link) || ($mask & $link['bit'])) {
+      $isActive = $link['is_active'] ?? TRUE;
+      if ($isActive && (!$mask || !array_key_exists('bit', $link) || ($mask & $link['bit']))) {
         $extra = isset($link['extra']) ? self::replace($link['extra'], $values) : NULL;
 
         $frontend = isset($link['fe']);
@@ -257,10 +258,10 @@ class CRM_Core_Action {
 
         $linkContent = $link['name'];
         if (!empty($link['icon'])) {
-          if ($iconMode == 'icon') {
+          if ($iconMode === 'icon') {
             $linkContent = CRM_Core_Page::crmIcon($link['icon'], $link['name'], TRUE, ['title' => '']);
           }
-          elseif ($iconMode == 'both') {
+          elseif ($iconMode === 'both') {
             $linkContent = CRM_Core_Page::crmIcon($link['icon']) . ' ' . $linkContent;
           }
         }
@@ -283,7 +284,7 @@ class CRM_Core_Action {
     }
     else {
       $extra = '';
-      if ($iconMode != 'icon') {
+      if ($iconMode !== 'icon') {
         $extraLinks = array_splice($url, 2);
         if (count($extraLinks) > 1) {
           $mainLinks = array_slice($url, 0, 2);
-- 
2.25.1