From 1c0174c97a9e5fafac3adc7f775b3673612ef231 Mon Sep 17 00:00:00 2001 From: eileenmcnaugton Date: Mon, 1 Aug 2016 13:25:50 +1200 Subject: [PATCH] CRM-18259 do not set this on the form since BAO can do --- CRM/Pledge/BAO/Pledge.php | 3 +-- CRM/Pledge/Form/Pledge.php | 8 -------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/CRM/Pledge/BAO/Pledge.php b/CRM/Pledge/BAO/Pledge.php index ecc923aa92..022c7bada5 100644 --- a/CRM/Pledge/BAO/Pledge.php +++ b/CRM/Pledge/BAO/Pledge.php @@ -159,8 +159,7 @@ class CRM_Pledge_BAO_Pledge extends CRM_Pledge_DAO_Pledge { $params['amount'] = $params['installment_amount'] * $params['installments']; } - // update the pledge status only if it does NOT come from form - if (!isset($params['pledge_status_id'])) { + if (!isset($params['pledge_status_id']) && !isset($params['status_id'])) { if (isset($params['contribution_id'])) { if ($params['installments'] > 1) { $params['status_id'] = CRM_Core_PseudoConstant::getKey('CRM_Pledge_BAO_Pledge', 'status_id', 'In Progress'); diff --git a/CRM/Pledge/Form/Pledge.php b/CRM/Pledge/Form/Pledge.php index b8ffbdab41..555c4b0a4f 100644 --- a/CRM/Pledge/Form/Pledge.php +++ b/CRM/Pledge/Form/Pledge.php @@ -502,14 +502,6 @@ class CRM_Pledge_Form_Pledge extends CRM_Core_Form { $params[$f] = CRM_Utils_Array::value($f, $formValues); } - // defaults status is "Pending". - // if update get status. - if ($this->_id) { - $params['pledge_status_id'] = $params['status_id'] = $this->_values['status_id']; - } - else { - $params['pledge_status_id'] = $params['status_id'] = CRM_Core_PseudoConstant::getKey('CRM_Pledge_BAO_Pledge', 'status_id', 'Pending'); - } // format amount $params['amount'] = CRM_Utils_Rule::cleanMoney(CRM_Utils_Array::value('amount', $formValues)); $params['currency'] = CRM_Utils_Array::value('currency', $formValues); -- 2.25.1