From 1bce0c15ba97995ba7772296ab698b36a7dc41ca Mon Sep 17 00:00:00 2001 From: Rodney Ewing Date: Tue, 4 Jun 2013 07:58:17 -0700 Subject: [PATCH] minor changes from aaronw's review --- mediagoblin/app.py | 2 ++ .../templates/mediagoblin/bits/frontpage_welcome.html | 10 +++++----- .../templates/mediagoblin/user_pages/media.html | 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/mediagoblin/app.py b/mediagoblin/app.py index 982e570c..ecd3de0e 100644 --- a/mediagoblin/app.py +++ b/mediagoblin/app.py @@ -100,6 +100,8 @@ class MediaGoblinApp(object): # Check if authentication plugin is enabled and respond accordingly. self.auth = check_auth_enabled() + if not self.auth: + app_config['allow_comments'] = False # Set up storage systems self.public_store, self.queue_store = setup_storage() diff --git a/mediagoblin/templates/mediagoblin/bits/frontpage_welcome.html b/mediagoblin/templates/mediagoblin/bits/frontpage_welcome.html index 26153694..9ef28a4d 100644 --- a/mediagoblin/templates/mediagoblin/bits/frontpage_welcome.html +++ b/mediagoblin/templates/mediagoblin/bits/frontpage_welcome.html @@ -22,17 +22,17 @@

{% trans %}Hi there, welcome to this MediaGoblin site!{% endtrans %}

{% trans %}This site is running MediaGoblin, an extraordinarily great piece of media hosting software.{% endtrans %}

- {% if auth %} + {% if auth %}

{% trans %}To add your own media, place comments, and more, you can log in with your MediaGoblin account.{% endtrans %}

{% if allow_registration %}

{% trans %}Don't have one yet? It's easy!{% endtrans %}

{% trans register_url=request.urlgen('mediagoblin.auth.register') -%} Create an account at this site or - {%- endtrans %} - {% endif %} - {% endif %} - {% trans %} + {%- endtrans %} + {% endif %} + {% endif %} + {% trans %} Set up MediaGoblin on your own server {%- endtrans %} diff --git a/mediagoblin/templates/mediagoblin/user_pages/media.html b/mediagoblin/templates/mediagoblin/user_pages/media.html index 5420752f..fb892fd7 100644 --- a/mediagoblin/templates/mediagoblin/user_pages/media.html +++ b/mediagoblin/templates/mediagoblin/user_pages/media.html @@ -86,7 +86,7 @@

{{ media.description_html }}

{% endautoescape %} {% if comments %} - {% if app_config['allow_comments'] and auth %} + {% if app_config['allow_comments'] %}