From 1a1100ef00a6c394d3f1744ae18b91f6e4a2c018 Mon Sep 17 00:00:00 2001 From: Tim Otten Date: Tue, 11 May 2021 14:52:46 -0700 Subject: [PATCH] (REF) dev/core#2601 - Cleanup stale parameter Overview -------- This cleans up a parameter that became unused/unnecessary in #20256. History ------- This revision is a little bouncy. Instead of before/after, here's a history: * `<= v5.36`: `getAllModulePermissions($descriptions = FALSE)` * `= v5.37.0`: `getAllModulePermissions($descriptions = FALSE, &$permissions)` * `>= v.37.1`: `getAllModulePermissions($descriptions = FALSE)` I grepped `universe` to confirm that no other repos were using the intermediate signature. --- CRM/Core/Permission.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CRM/Core/Permission.php b/CRM/Core/Permission.php index ff27b7f9f6..36b5579bf0 100644 --- a/CRM/Core/Permission.php +++ b/CRM/Core/Permission.php @@ -591,7 +591,7 @@ class CRM_Core_Permission { $permissions = self::getCoreAndComponentPermissions($all); // Add any permissions defined in hook_civicrm_permission implementations. - $module_permissions = CRM_Core_Config::singleton()->userPermissionClass->getAllModulePermissions(TRUE, $permissions); + $module_permissions = CRM_Core_Config::singleton()->userPermissionClass->getAllModulePermissions(TRUE); $permissions = array_merge($permissions, $module_permissions); if (!$descriptions) { foreach ($permissions as $name => $attr) { -- 2.25.1