From 186628c36f9a832ca38b49630d96c3c477055fe9 Mon Sep 17 00:00:00 2001 From: eileenmcnaughton Date: Fri, 11 Dec 2015 01:10:55 +0000 Subject: [PATCH] preliminary tidy up --- CRM/Contact/Import/Parser/Contact.php | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/CRM/Contact/Import/Parser/Contact.php b/CRM/Contact/Import/Parser/Contact.php index 37fe638b39..53e0fb38f3 100644 --- a/CRM/Contact/Import/Parser/Contact.php +++ b/CRM/Contact/Import/Parser/Contact.php @@ -31,10 +31,6 @@ * @copyright CiviCRM LLC (c) 2004-2015 */ -//@todo calling api functions directly is not supported -require_once 'api/v3/utils.php'; -require_once 'api/v3/Contact.php'; - /** * class to parse contact csv files */ @@ -62,6 +58,16 @@ class CRM_Contact_Import_Parser_Contact extends CRM_Contact_Import_Parser { protected $_allEmails; protected $_phoneIndex; + + /** + * Is update only permitted on an id match. + * + * Note this historically was true for when id or external identifier was + * present. However, CRM-17275 determined that a dedupe-match could over-ride + * external identifier. + * + * @var bool + */ protected $_updateWithId; protected $_retCode; @@ -135,7 +141,7 @@ class CRM_Contact_Import_Parser_Contact extends CRM_Contact_Import_Parser { } /** - * The initializer code, called before the processing. + * The initializer code, called before processing. */ public function init() { $contactFields = CRM_Contact_BAO_Contact::importableFields($this->_contactType); @@ -284,7 +290,7 @@ class CRM_Contact_Import_Parser_Contact extends CRM_Contact_Import_Parser { * @param array $values * The array of values belonging to this line. * - * @return boo + * @return bool * the result of this processing */ public function summary(&$values) { -- 2.25.1