From 17eeaef96aa756d58cbc6e5bdc3c2e35f6565d80 Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Mon, 25 Aug 2014 13:36:08 +1200 Subject: [PATCH] CRM-15168 Update test to reflect almost all api are compliant --- tests/phpunit/api/v3/SyntaxConformanceTest.php | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/tests/phpunit/api/v3/SyntaxConformanceTest.php b/tests/phpunit/api/v3/SyntaxConformanceTest.php index 8cf4bebff8..bd65c38651 100644 --- a/tests/phpunit/api/v3/SyntaxConformanceTest.php +++ b/tests/phpunit/api/v3/SyntaxConformanceTest.php @@ -263,21 +263,7 @@ class api_v3_SyntaxConformanceTest extends CiviUnitTestCase { * @todo add metadata for ALL these entities */ public static function toBeSkipped_getfields($sequential = FALSE) { - $entitiesWithMetadataNotYetFixed = array('ActionSchedule', 'ActivityType', - 'ContactType', 'ContributionSoft', 'CustomField', 'CustomGroup', 'CustomValue','CustomSearch', - 'Domain', - 'Dashboard', 'DashboardContact', 'Extension', 'File', 'FinancialAccount', 'FinancialType', - 'GroupOrganization', 'GroupNesting', - 'Im', 'Job', 'LineItem','LocBlock', 'LocationType', - 'Mailing', 'MailingComponent', 'MailingEventResubscribe', 'MailingEventSubscribe', 'MailingEventUnsubscribe', - 'MailingEventConfirm', 'MailingGroup', - 'MailingRecipients', 'MailingJob', 'MailSettings', - 'MembershipBlock', 'MembershipPayment', 'MessageTemplate', - 'MembershipType', 'OptionGroup', 'OptionValue', 'MembershipStatus', - 'ParticipantPayment', 'ParticipantStatusType', - 'Premium', 'PaymentProcessorType', 'PaymentProcessor', - 'PrintLabel', 'Product', 'ReportTemplate', - 'Setting',); + $entitiesWithMetadataNotYetFixed = array('ReportTemplate', 'CustomSearch'); if ($sequential === TRUE) { return $entitiesWithMetadataNotYetFixed ; } @@ -1155,7 +1141,7 @@ class api_v3_SyntaxConformanceTest extends CiviUnitTestCase { foreach ($fields['values'] as $fieldName => $fieldSpec) { $this->assertArrayHasKey('title', $fieldSpec, "no title for $entity - $fieldName"); - $this->assertNotEmpty($fieldSpec['title']); + $this->assertNotEmpty($fieldSpec['title'], "empty title for $entity - $fieldName"); } if (!empty($ids)) { -- 2.25.1