From 17caeafe76fad4c33550a2bbe564d84ebd35a100 Mon Sep 17 00:00:00 2001 From: eileen Date: Wed, 2 Dec 2015 05:35:52 +1300 Subject: [PATCH] a couple more comments --- CRM/Contribute/Form/Task.php | 2 ++ CRM/Contribute/Selector/Search.php | 2 ++ 2 files changed, 4 insertions(+) diff --git a/CRM/Contribute/Form/Task.php b/CRM/Contribute/Form/Task.php index 423c67437a..984256b27d 100644 --- a/CRM/Contribute/Form/Task.php +++ b/CRM/Contribute/Form/Task.php @@ -124,6 +124,8 @@ class CRM_Contribute_Form_Task extends CRM_Core_Form { $query = new CRM_Contact_BAO_Query($queryParams, NULL, NULL, FALSE, FALSE, CRM_Contact_BAO_Query::MODE_CONTRIBUTE ); + // @todo the function CRM_Contribute_BAO_Query::isSoftCreditOptionEnabled should handle this + // can we remove? if not why not? if ($form->_includesSoftCredits) { $contactIds = $contributionContactIds = array(); $query->_rowCountClause = " count(civicrm_contribution.id)"; diff --git a/CRM/Contribute/Selector/Search.php b/CRM/Contribute/Selector/Search.php index ee9f1fa49e..e6c29c8786 100644 --- a/CRM/Contribute/Selector/Search.php +++ b/CRM/Contribute/Selector/Search.php @@ -194,6 +194,8 @@ class CRM_Contribute_Selector_Search extends CRM_Core_Selector_Base implements C NULL, FALSE, FALSE, CRM_Contact_BAO_Query::MODE_CONTRIBUTE ); + // @todo the function CRM_Contribute_BAO_Query::isSoftCreditOptionEnabled should handle this + // can we remove? if not why not? if ($this->_includeSoftCredits) { $this->_query->_rowCountClause = " count(civicrm_contribution.id)"; $this->_query->_groupByComponentClause = " GROUP BY contribution_search_scredit_combined.id, contribution_search_scredit_combined.contact_id, contribution_search_scredit_combined.scredit_id "; -- 2.25.1