From 15da63a8d82583ab00c46f1fa73244d5d29c2222 Mon Sep 17 00:00:00 2001
From: Coleman Watts <coleman@civicrm.org>
Date: Sat, 15 Nov 2014 20:21:57 -0500
Subject: [PATCH] CRM-15603 - Standardize edit & view activity messages

---
 CRM/Case/BAO/Case.php                                     | 2 +-
 .../message_templates/case_activity_html.tpl              | 4 ++--
 .../message_templates/case_activity_text.tpl              | 4 ++--
 .../message_templates/case_activity_html.tpl              | 4 ++--
 .../message_templates/case_activity_text.tpl              | 4 ++--
 templates/CRM/Case/Page/DashboardSelector.tpl             | 8 ++++----
 xml/templates/message_templates/case_activity_html.tpl    | 4 ++--
 xml/templates/message_templates/case_activity_text.tpl    | 4 ++--
 8 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/CRM/Case/BAO/Case.php b/CRM/Case/BAO/Case.php
index b95201d1a6..394dc02e10 100644
--- a/CRM/Case/BAO/Case.php
+++ b/CRM/Case/BAO/Case.php
@@ -1182,7 +1182,7 @@ SELECT case_status.label AS case_status, status_id, civicrm_case_type.title AS c
     $editUrl = "{$url}&action=update{$contextUrl}";
     $deleteUrl = "{$url}&action=delete{$contextUrl}";
     $restoreUrl = "{$url}&action=renew{$contextUrl}";
-    $viewTitle = ts('View this activity.');
+    $viewTitle = ts('View activity');
     $statusTitle = ts('Edit Status');
 
     $emailActivityTypeIDs = array(
diff --git a/CRM/Upgrade/3.2.alpha3.msg_template/message_templates/case_activity_html.tpl b/CRM/Upgrade/3.2.alpha3.msg_template/message_templates/case_activity_html.tpl
index 59dce775a2..a7007f03de 100644
--- a/CRM/Upgrade/3.2.alpha3.msg_template/message_templates/case_activity_html.tpl
+++ b/CRM/Upgrade/3.2.alpha3.msg_template/message_templates/case_activity_html.tpl
@@ -40,14 +40,14 @@
      {if $editActURL}
      <tr>
        <td colspan="2" {$valueStyle}>
-   <a href="{$editActURL}" title="{ts}Edit this activity{/ts}">{ts}Edit this activity{/ts}</a>
+   <a href="{$editActURL}" title="{ts}Edit activity{/ts}">{ts}Edit activity{/ts}</a>
        </td>
      </tr>
      {/if}
      {if $viewActURL}
      <tr>
        <td colspan="2" {$valueStyle}>
-   <a href="{$viewActURL}" title="{ts}View this activity{/ts}">{ts}View this activity{/ts}</a>
+   <a href="{$viewActURL}" title="{ts}View activity{/ts}">{ts}View activity{/ts}</a>
        </td>
      </tr>
      {/if}
diff --git a/CRM/Upgrade/3.2.alpha3.msg_template/message_templates/case_activity_text.tpl b/CRM/Upgrade/3.2.alpha3.msg_template/message_templates/case_activity_text.tpl
index daec479e47..15317d4bb3 100644
--- a/CRM/Upgrade/3.2.alpha3.msg_template/message_templates/case_activity_text.tpl
+++ b/CRM/Upgrade/3.2.alpha3.msg_template/message_templates/case_activity_text.tpl
@@ -6,10 +6,10 @@
 {/if}
 
 {if $editActURL}
-{ts}Edit this Activity{/ts} : {$editActURL}
+{ts}Edit activity{/ts} : {$editActURL}
 {/if}
 {if $viewActURL}
-{ts}View this Activity{/ts} : {$viewActURL}
+{ts}View activity{/ts} : {$viewActURL}
 {/if}
 
 {foreach from=$activity.fields item=field}
diff --git a/CRM/Upgrade/3.3.2.msg_template/message_templates/case_activity_html.tpl b/CRM/Upgrade/3.3.2.msg_template/message_templates/case_activity_html.tpl
index 8749ee13af..04816ca83f 100644
--- a/CRM/Upgrade/3.3.2.msg_template/message_templates/case_activity_html.tpl
+++ b/CRM/Upgrade/3.3.2.msg_template/message_templates/case_activity_html.tpl
@@ -47,14 +47,14 @@
      {if $editActURL}
      <tr>
        <td colspan="2" {$valueStyle}>
-     <a href="{$editActURL}" title="{ts}Edit this activity{/ts}">{ts}Edit this activity{/ts}</a>
+     <a href="{$editActURL}" title="{ts}Edit activity{/ts}">{ts}Edit activity{/ts}</a>
        </td>
      </tr>
      {/if}
      {if $viewActURL}
      <tr>
        <td colspan="2" {$valueStyle}>
-     <a href="{$viewActURL}" title="{ts}View this activity{/ts}">{ts}View this activity{/ts}</a>
+     <a href="{$viewActURL}" title="{ts}View activity{/ts}">{ts}View activity{/ts}</a>
        </td>
      </tr>
      {/if}
diff --git a/CRM/Upgrade/3.3.2.msg_template/message_templates/case_activity_text.tpl b/CRM/Upgrade/3.3.2.msg_template/message_templates/case_activity_text.tpl
index 70cd0d7db8..e7edad2fdf 100644
--- a/CRM/Upgrade/3.3.2.msg_template/message_templates/case_activity_text.tpl
+++ b/CRM/Upgrade/3.3.2.msg_template/message_templates/case_activity_text.tpl
@@ -9,10 +9,10 @@
 {/if}
 
 {if $editActURL}
-{ts}Edit this Activity{/ts} : {$editActURL}
+{ts}Edit activity{/ts} : {$editActURL}
 {/if}
 {if $viewActURL}
-{ts}View this Activity{/ts} : {$viewActURL}
+{ts}View activity{/ts} : {$viewActURL}
 {/if}
 
 {foreach from=$activity.fields item=field}
diff --git a/templates/CRM/Case/Page/DashboardSelector.tpl b/templates/CRM/Case/Page/DashboardSelector.tpl
index dca5a445bb..6b3631190d 100644
--- a/templates/CRM/Case/Page/DashboardSelector.tpl
+++ b/templates/CRM/Case/Page/DashboardSelector.tpl
@@ -63,13 +63,13 @@
     {if $list eq 'upcoming'}
        <td class="crm-case-case_scheduled_activity">
      {if $row.case_upcoming_activity_viewable}
-        <a class="crm-popup {$row.activity_status}" href="{crmURL p='civicrm/case/activity/view' h=0 q="cid="}{$row.contact_id}&aid={$row.case_scheduled_activity_id}" title="{ts}View this activity.{/ts}">{$row.case_scheduled_activity_type}</a>
+        <a class="crm-popup {$row.activity_status}" href="{crmURL p='civicrm/case/activity/view' h=0 q="cid="}{$row.contact_id}&aid={$row.case_scheduled_activity_id}" title="{ts}View activity{/ts}">{$row.case_scheduled_activity_type}</a>
      {else}
         {$row.case_scheduled_activity_type}
      {/if}
        &nbsp;&nbsp;
      {if $row.case_upcoming_activity_editable}
-       <a class="action-item crm-hover-button" href="{crmURL p="civicrm/case/activity" q="reset=1&cid=`$row.contact_id`&caseid=`$row.case_id`&action=update&id=`$row.case_scheduled_activity_id`"}" title="{ts}Edit this activity.{/ts}"><span class="icon edit-icon"></span></a>
+       <a class="action-item crm-hover-button" href="{crmURL p="civicrm/case/activity" q="reset=1&cid=`$row.contact_id`&caseid=`$row.case_id`&action=update&id=`$row.case_scheduled_activity_id`"}" title="{ts}Edit activity{/ts}"><span class="icon edit-icon"></span></a>
      {/if}
      <br />
      {$row.case_scheduled_activity_date|crmDate}
@@ -78,11 +78,11 @@
     {elseif $list eq 'recent'}
        <td class="crm-case-case_recent_activity">
    {if $row.case_recent_activity_viewable}
-       <a class="crm-popup" href="{crmURL p='civicrm/case/activity/view' h=0 q="cid="}{$row.contact_id}&aid={$row.case_recent_activity_id}" title="{ts}View this activity.{/ts}">{$row.case_recent_activity_type}</a>
+       <a class="crm-popup" href="{crmURL p='civicrm/case/activity/view' h=0 q="cid="}{$row.contact_id}&aid={$row.case_recent_activity_id}" title="{ts}View activity{/ts}">{$row.case_recent_activity_type}</a>
     {else}
        {$row.case_recent_activity_type}
     {/if}
-    {if $row.case_recent_activity_editable and $row.case_recent_activity_type_name != 'Inbound Email' && $row.case_recent_activity_type_name != 'Email'}&nbsp;&nbsp;<a href="{crmURL p="civicrm/case/activity" q="reset=1&cid=`$row.contact_id`&caseid=`$row.case_id`&action=update&id=`$row.case_recent_activity_id`"}" title="{ts}Edit this activity.{/ts}"><span class="icon edit-icon"></span></a>
+    {if $row.case_recent_activity_editable and $row.case_recent_activity_type_name != 'Inbound Email' && $row.case_recent_activity_type_name != 'Email'}&nbsp;&nbsp;<a href="{crmURL p="civicrm/case/activity" q="reset=1&cid=`$row.contact_id`&caseid=`$row.case_id`&action=update&id=`$row.case_recent_activity_id`"}" title="{ts}Edit activity{/ts}"><span class="icon edit-icon"></span></a>
     {/if}<br />
           {$row.case_recent_activity_date|crmDate}
    </td>
diff --git a/xml/templates/message_templates/case_activity_html.tpl b/xml/templates/message_templates/case_activity_html.tpl
index dd54906ce3..0dcc6c4765 100644
--- a/xml/templates/message_templates/case_activity_html.tpl
+++ b/xml/templates/message_templates/case_activity_html.tpl
@@ -47,14 +47,14 @@
      {if $editActURL}
      <tr>
        <td colspan="2" {$valueStyle}>
-   <a href="{$editActURL}" title="{ts}Edit this activity{/ts}">{ts}Edit this activity{/ts}</a>
+   <a href="{$editActURL}" title="{ts}Edit activity{/ts}">{ts}Edit activity{/ts}</a>
        </td>
      </tr>
      {/if}
      {if $viewActURL}
      <tr>
        <td colspan="2" {$valueStyle}>
-   <a href="{$viewActURL}" title="{ts}View this activity{/ts}">{ts}View this activity{/ts}</a>
+   <a href="{$viewActURL}" title="{ts}View activity{/ts}">{ts}View activity{/ts}</a>
        </td>
      </tr>
      {/if}
diff --git a/xml/templates/message_templates/case_activity_text.tpl b/xml/templates/message_templates/case_activity_text.tpl
index 3233e10052..0bfa04a85b 100644
--- a/xml/templates/message_templates/case_activity_text.tpl
+++ b/xml/templates/message_templates/case_activity_text.tpl
@@ -9,10 +9,10 @@
 {/if}
 
 {if $editActURL}
-{ts}Edit this Activity{/ts} : {$editActURL}
+{ts}Edit activity{/ts} : {$editActURL}
 {/if}
 {if $viewActURL}
-{ts}View this Activity{/ts} : {$viewActURL}
+{ts}View activity{/ts} : {$viewActURL}
 {/if}
 
 {foreach from=$activity.fields item=field}
-- 
2.25.1