From 1155dd581bcbcadff3075b4d987e2f1b4f3cab18 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Frank=20J=2E=20G=C3=B3mez?= Date: Wed, 16 Jul 2014 17:57:49 -0400 Subject: [PATCH] CRM-14990. Update strictness of param comparison for consistency with the rest of Civi's codebase, per Eileen's recommendation: https://github.com/civicrm/civicrm-core/commit/f329e1deb8ebc36b68b3fe4448b16fc6f5cf52bd#commitcomment-7036984. --- CRM/Core/BAO/CustomGroup.php | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/CRM/Core/BAO/CustomGroup.php b/CRM/Core/BAO/CustomGroup.php index 1bf03e1988..060dd7dd1f 100644 --- a/CRM/Core/BAO/CustomGroup.php +++ b/CRM/Core/BAO/CustomGroup.php @@ -161,12 +161,7 @@ class CRM_Core_BAO_CustomGroup extends CRM_Core_DAO_CustomGroup { } if (array_key_exists('is_reserved', $params)) { - if (in_array($params['is_reserved'], array(TRUE, 1, '1'), TRUE)) { - $is_reserved = 1; - } else { - $is_reserved = 0; - } - $group->is_reserved = $is_reserved; + $group->is_reserved = $params['is_reserved'] ? 1 : 0; } $op = isset($params['id']) ? 'edit' : 'create'; CRM_Utils_Hook::pre($op, 'CustomGroup', CRM_Utils_Array::value('id', $params), $params); -- 2.25.1