From 10f1f2f56b9ff1153b58cb938427d74c8211194b Mon Sep 17 00:00:00 2001 From: Sebastian Spaeth Date: Mon, 17 Dec 2012 12:56:29 +0100 Subject: [PATCH] Remove Mongoism query.skip() sqlalchemy supports slice() or [n:m] just fine. Right now, it seems we cannot distinguish beween "empty" results and out-of bound slices. It would be nice if we could distinguish these somehow. Signed-off-by: Sebastian Spaeth --- mediagoblin/db/sql/base.py | 3 --- mediagoblin/tools/pagination.py | 7 +++++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/mediagoblin/db/sql/base.py b/mediagoblin/db/sql/base.py index 8aa9cc3a..fbbac6f9 100644 --- a/mediagoblin/db/sql/base.py +++ b/mediagoblin/db/sql/base.py @@ -35,9 +35,6 @@ class GMGQuery(Query): key_col = desc(key_col) return self.order_by(key_col) - def skip(self, amount): - return self.offset(amount) - Session = scoped_session(sessionmaker(query_cls=GMGQuery)) diff --git a/mediagoblin/tools/pagination.py b/mediagoblin/tools/pagination.py index 141d91cc..af889abd 100644 --- a/mediagoblin/tools/pagination.py +++ b/mediagoblin/tools/pagination.py @@ -63,8 +63,11 @@ class Pagination(object): """ Returns slice of objects for the requested page """ - return self.cursor.skip( - (self.page - 1) * self.per_page).limit(self.per_page) + # TODO, return None for out of index so templates can + # distinguish between empty galleries and out-of-bound pages??? + return self.cursor.slice( + (self.page - 1) * self.per_page, + self.page * self.per_page) @property def pages(self): -- 2.25.1