From 0e480632b3647f07a66b76e523d845530115f768 Mon Sep 17 00:00:00 2001 From: Coleman Watts Date: Fri, 24 Jul 2020 15:10:29 -0400 Subject: [PATCH] NFC - Expand CRM-* comments with full @see annotations --- CRM/Contact/BAO/Query.php | 4 ++-- CRM/Contact/Form/Task.php | 2 +- CRM/Contact/Import/Parser/Contact.php | 2 +- CRM/Contribute/BAO/Contribution.php | 4 ++-- CRM/Contribute/BAO/Contribution/Utils.php | 2 +- CRM/Contribute/Form/Contribution.php | 2 +- CRM/Contribute/Form/Contribution/Confirm.php | 2 +- CRM/Core/BAO/Block.php | 2 +- CRM/Core/BAO/Job.php | 2 +- CRM/Core/Config.php | 2 +- CRM/Event/BAO/Participant.php | 2 +- CRM/Event/Form/Registration/ParticipantConfirm.php | 5 +++-- CRM/Event/Form/Registration/Register.php | 2 +- CRM/Financial/BAO/FinancialItem.php | 2 +- CRM/Financial/BAO/FinancialTypeAccount.php | 2 +- CRM/Mailing/Event/BAO/Opened.php | 2 +- CRM/Mailing/Event/BAO/TrackableURLOpen.php | 2 +- CRM/Report/Form.php | 3 +-- CRM/Report/Form/Activity.php | 3 +-- CRM/Report/Form/ActivitySummary.php | 3 +-- CRM/Report/Form/Case/Demographics.php | 3 +-- CRM/Report/Form/Contact/CurrentEmployer.php | 3 +-- CRM/Report/Form/Contact/Detail.php | 3 +-- CRM/Report/Form/Contact/Relationship.php | 3 +-- CRM/Report/Form/Contact/Summary.php | 3 +-- CRM/Report/Form/Contribute/Bookkeeping.php | 3 +-- CRM/Report/Form/Contribute/Detail.php | 3 +-- CRM/Report/Form/Contribute/Lybunt.php | 3 +-- CRM/Report/Form/Contribute/Recur.php | 3 +-- CRM/Report/Form/Contribute/Repeat.php | 3 +-- CRM/Report/Form/Contribute/SoftCredit.php | 3 +-- CRM/Report/Form/Contribute/Summary.php | 3 +-- CRM/Report/Form/Contribute/Sybunt.php | 3 +-- CRM/Report/Form/Contribute/TopDonor.php | 3 +-- CRM/Report/Form/Event/ParticipantListCount.php | 3 +-- CRM/Report/Form/Mailing/Bounce.php | 3 +-- CRM/Report/Form/Mailing/Clicks.php | 3 +-- CRM/Report/Form/Mailing/Detail.php | 3 +-- CRM/Report/Form/Mailing/Opened.php | 3 +-- CRM/Report/Form/Member/ContributionDetail.php | 3 +-- CRM/Report/Form/Member/Detail.php | 4 +--- CRM/Report/Form/Member/Lapse.php | 3 +-- CRM/Report/Form/Member/Summary.php | 3 +-- CRM/Report/Form/Pledge/Detail.php | 3 +-- CRM/Report/Form/Pledge/Summary.php | 3 +-- CRM/Upgrade/Incremental/php/FourSeven.php | 4 ++-- Civi/Test/ContactTestTrait.php | 2 +- tests/phpunit/CRM/Contact/BAO/QueryTest.php | 4 ++-- tests/phpunit/CRM/Contact/Import/Parser/ContactTest.php | 4 ++-- tests/phpunit/CRM/Core/BAO/ActionScheduleTest.php | 2 +- tests/phpunit/CRM/Event/BAO/AdditionalPaymentTest.php | 2 +- tests/phpunit/CRM/SMS/BAO/ProviderTest.php | 2 +- tests/phpunit/CRM/Utils/StringTest.php | 4 ++-- tests/phpunit/api/v3/ACLPermissionTest.php | 6 +++--- tests/phpunit/api/v3/ContactTest.php | 6 +++--- tests/phpunit/api/v3/ContributionPageTest.php | 2 +- tests/phpunit/api/v3/ExtensionTest.php | 6 +++--- 57 files changed, 71 insertions(+), 99 deletions(-) diff --git a/CRM/Contact/BAO/Query.php b/CRM/Contact/BAO/Query.php index 4a108032a0..648fd5d957 100644 --- a/CRM/Contact/BAO/Query.php +++ b/CRM/Contact/BAO/Query.php @@ -612,7 +612,7 @@ class CRM_Contact_BAO_Query { * * this code is primarily for search builder use case where different clauses can specify if they want deleted. * - * CRM-11971 + * @see https://issues.civicrm.org/jira/browse/CRM-11971 */ public function buildParamsLookup() { $trashParamExists = FALSE; @@ -4789,7 +4789,7 @@ civicrm_relationship.start_date > {$today} * Country is implicit from the state, but including both results in * a poor query as there is no combined index on state AND country. * - * CRM-18125 + * @see https://issues.civicrm.org/jira/browse/CRM-18125 * * @param array $formValues */ diff --git a/CRM/Contact/Form/Task.php b/CRM/Contact/Form/Task.php index 7a7d57093f..2f7695dc7d 100644 --- a/CRM/Contact/Form/Task.php +++ b/CRM/Contact/Form/Task.php @@ -334,7 +334,7 @@ class CRM_Contact_Form_Task extends CRM_Core_Form_Task { /** * Replace ids of household members in $this->_contactIds with the id of their household. * - * CRM-8338 + * @see https://issues.civicrm.org/jira/browse/CRM-8338 */ public function mergeContactIdsByHousehold() { if (empty($this->_contactIds)) { diff --git a/CRM/Contact/Import/Parser/Contact.php b/CRM/Contact/Import/Parser/Contact.php index 760d16059b..dc3441baaa 100644 --- a/CRM/Contact/Import/Parser/Contact.php +++ b/CRM/Contact/Import/Parser/Contact.php @@ -1955,7 +1955,7 @@ class CRM_Contact_Import_Parser_Contact extends CRM_Contact_Import_Parser { * 1) the chosen dedupe rule falling back to * 2) a check for the external ID. * - * CRM-17275 + * @see https://issues.civicrm.org/jira/browse/CRM-17275 * * @param array $params * diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php index 97632dc2a3..a258973138 100644 --- a/CRM/Contribute/BAO/Contribution.php +++ b/CRM/Contribute/BAO/Contribution.php @@ -3939,7 +3939,7 @@ INNER JOIN civicrm_activity ON civicrm_activity_contact.activity_id = civicrm_ac /** * Delete contribution of contact. * - * CRM-12155 + * @see https://issues.civicrm.org/jira/browse/CRM-12155 * * @param int $contactId * Contact id. @@ -4004,7 +4004,7 @@ INNER JOIN civicrm_activity ON civicrm_activity_contact.activity_id = civicrm_ac /** * Validate financial type. * - * CRM-13231 + * @see https://issues.civicrm.org/jira/browse/CRM-13231 * * @param int $financialTypeId * Financial Type id. diff --git a/CRM/Contribute/BAO/Contribution/Utils.php b/CRM/Contribute/BAO/Contribution/Utils.php index 8bbb2c51e1..21fd4716d4 100644 --- a/CRM/Contribute/BAO/Contribution/Utils.php +++ b/CRM/Contribute/BAO/Contribution/Utils.php @@ -485,7 +485,7 @@ LIMIT 1 /** * Format monetary amount: round and return to desired decimal place - * CRM-20145 + * @see https://issues.civicrm.org/jira/browse/CRM-20145 * * @param float $amount * Monetary amount diff --git a/CRM/Contribute/Form/Contribution.php b/CRM/Contribute/Form/Contribution.php index b063ed269d..09f05ba0bd 100644 --- a/CRM/Contribute/Form/Contribution.php +++ b/CRM/Contribute/Form/Contribution.php @@ -1737,7 +1737,7 @@ class CRM_Contribute_Form_Contribution extends CRM_Contribute_Form_AbstractEditP /** * Calculate non deductible amount. * - * CRM-11956 + * @see https://issues.civicrm.org/jira/browse/CRM-11956 * if non_deductible_amount exists i.e. Additional Details field set was opened [and staff typed something] - * if non_deductible_amount does NOT exist - then calculate it depending on: * $financialType->is_deductible and whether there is a product (premium). diff --git a/CRM/Contribute/Form/Contribution/Confirm.php b/CRM/Contribute/Form/Contribution/Confirm.php index f478e80e70..a1da2697a6 100644 --- a/CRM/Contribute/Form/Contribution/Confirm.php +++ b/CRM/Contribute/Form/Contribution/Confirm.php @@ -201,7 +201,7 @@ class CRM_Contribute_Form_Contribution_Confirm extends CRM_Contribute_Form_Contr * * This is a bit too much about wierd form interpretation to be this deep. * - * CRM-11885 + * @see https://issues.civicrm.org/jira/browse/CRM-11885 * if non_deductible_amount exists i.e. Additional Details fieldset was opened [and staff typed something] -> keep * it. * diff --git a/CRM/Core/BAO/Block.php b/CRM/Core/BAO/Block.php index 1da6725730..0689b0a495 100644 --- a/CRM/Core/BAO/Block.php +++ b/CRM/Core/BAO/Block.php @@ -439,7 +439,7 @@ class CRM_Core_BAO_Block { /* * If the only existing email is the one we are editing then we must set * is_primary to 1 - * CRM-10451 + * @see https://issues.civicrm.org/jira/browse/CRM-10451 */ if ($existingEntities->N == 1 && $existingEntities->id == CRM_Utils_Array::value('id', $params)) { $params['is_primary'] = 1; diff --git a/CRM/Core/BAO/Job.php b/CRM/Core/BAO/Job.php index c4214e60b5..e78458fd2c 100644 --- a/CRM/Core/BAO/Job.php +++ b/CRM/Core/BAO/Job.php @@ -109,7 +109,7 @@ class CRM_Core_BAO_Job extends CRM_Core_DAO_Job { /** * Trim job table on a regular basis to keep it at a good size. * - * CRM-10513 + * @see https://issues.civicrm.org/jira/browse/CRM-10513 * * @param int $maxEntriesToKeep * @param int $minDaysToKeep diff --git a/CRM/Core/Config.php b/CRM/Core/Config.php index a27d424d6a..3243ebb2a3 100644 --- a/CRM/Core/Config.php +++ b/CRM/Core/Config.php @@ -271,7 +271,7 @@ class CRM_Core_Config extends CRM_Core_Config_MagicMerge { /** * Do general cleanup of caches, temp directories and temp tables - * CRM-8739 + * @see https://issues.civicrm.org/jira/browse/CRM-8739 * * @param bool $sessionReset */ diff --git a/CRM/Event/BAO/Participant.php b/CRM/Event/BAO/Participant.php index 1a3e59a0be..aa0aaf6170 100644 --- a/CRM/Event/BAO/Participant.php +++ b/CRM/Event/BAO/Participant.php @@ -1769,7 +1769,7 @@ WHERE civicrm_participant.contact_id = {$contactID} AND /** * Delete participants of contact. * - * CRM-12155 + * @see https://issues.civicrm.org/jira/browse/CRM-12155 * * @param int $contactId * Contact id. diff --git a/CRM/Event/Form/Registration/ParticipantConfirm.php b/CRM/Event/Form/Registration/ParticipantConfirm.php index 5c1b850610..bf8a79203d 100644 --- a/CRM/Event/Form/Registration/ParticipantConfirm.php +++ b/CRM/Event/Form/Registration/ParticipantConfirm.php @@ -21,10 +21,11 @@ * */ class CRM_Event_Form_Registration_ParticipantConfirm extends CRM_Event_Form_Registration { - // optional credit card return status code + /** - * CRM-6060 + * Optional credit card return status code * @var string + * @see https://issues.civicrm.org/jira/browse/CRM-6060 */ protected $_cc = NULL; diff --git a/CRM/Event/Form/Registration/Register.php b/CRM/Event/Form/Registration/Register.php index 80e3f7c72f..0bb56e3e0e 100644 --- a/CRM/Event/Form/Registration/Register.php +++ b/CRM/Event/Form/Registration/Register.php @@ -45,9 +45,9 @@ class CRM_Event_Form_Registration_Register extends CRM_Event_Form_Registration { * Skip duplicate check. * * This can be set using hook_civicrm_buildForm() to override the registration dupe check. - * CRM-7604 * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-7604 */ public $_skipDupeRegistrationCheck = FALSE; diff --git a/CRM/Financial/BAO/FinancialItem.php b/CRM/Financial/BAO/FinancialItem.php index 317fb8dadb..fb5dca3d16 100644 --- a/CRM/Financial/BAO/FinancialItem.php +++ b/CRM/Financial/BAO/FinancialItem.php @@ -221,7 +221,7 @@ class CRM_Financial_BAO_FinancialItem extends CRM_Financial_DAO_FinancialItem { /** * Check if contact is present in financial_item table. * - * CRM-12929 + * @see https://issues.civicrm.org/jira/browse/CRM-12929 * * @param array $contactIds * An array contact id's. diff --git a/CRM/Financial/BAO/FinancialTypeAccount.php b/CRM/Financial/BAO/FinancialTypeAccount.php index 17be41a408..f7cb9652cb 100644 --- a/CRM/Financial/BAO/FinancialTypeAccount.php +++ b/CRM/Financial/BAO/FinancialTypeAccount.php @@ -164,7 +164,7 @@ class CRM_Financial_BAO_FinancialTypeAccount extends CRM_Financial_DAO_EntityFin /** * Create default entity financial accounts * for financial type - * CRM-12470 + * @see https://issues.civicrm.org/jira/browse/CRM-12470 * * @param $financialType * diff --git a/CRM/Mailing/Event/BAO/Opened.php b/CRM/Mailing/Event/BAO/Opened.php index f180fddb50..1ecc078839 100644 --- a/CRM/Mailing/Event/BAO/Opened.php +++ b/CRM/Mailing/Event/BAO/Opened.php @@ -112,7 +112,7 @@ class CRM_Mailing_Event_BAO_Opened extends CRM_Mailing_Event_DAO_Opened { } /** - * CRM-12814 + * @see https://issues.civicrm.org/jira/browse/CRM-12814 * Get opened count for each mailing for a given set of mailing IDs * * @param $mailingIDs diff --git a/CRM/Mailing/Event/BAO/TrackableURLOpen.php b/CRM/Mailing/Event/BAO/TrackableURLOpen.php index 6c314f04b6..856f577edb 100644 --- a/CRM/Mailing/Event/BAO/TrackableURLOpen.php +++ b/CRM/Mailing/Event/BAO/TrackableURLOpen.php @@ -169,7 +169,7 @@ class CRM_Mailing_Event_BAO_TrackableURLOpen extends CRM_Mailing_Event_DAO_Track /** * Get tracked url count for each mailing for a given set of mailing IDs. * - * CRM-12814 + * @see https://issues.civicrm.org/jira/browse/CRM-12814 * * @param array $mailingIDs * diff --git a/CRM/Report/Form.php b/CRM/Report/Form.php index 80308090e1..d202b84561 100644 --- a/CRM/Report/Form.php +++ b/CRM/Report/Form.php @@ -153,9 +153,8 @@ class CRM_Report_Form extends CRM_Core_Form { * separately marked every class with a groupFilter in the hope that will trigger * people to fix them as they touch them. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Activity.php b/CRM/Report/Form/Activity.php index e0c5b6408e..6d430a5a2c 100644 --- a/CRM/Report/Form/Activity.php +++ b/CRM/Report/Form/Activity.php @@ -28,9 +28,8 @@ class CRM_Report_Form_Activity extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/ActivitySummary.php b/CRM/Report/Form/ActivitySummary.php index 0e7e780f91..fe5df28649 100644 --- a/CRM/Report/Form/ActivitySummary.php +++ b/CRM/Report/Form/ActivitySummary.php @@ -28,9 +28,8 @@ class CRM_Report_Form_ActivitySummary extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Case/Demographics.php b/CRM/Report/Form/Case/Demographics.php index 6c9f105f85..99346e02e7 100644 --- a/CRM/Report/Form/Case/Demographics.php +++ b/CRM/Report/Form/Case/Demographics.php @@ -28,9 +28,8 @@ class CRM_Report_Form_Case_Demographics extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Contact/CurrentEmployer.php b/CRM/Report/Form/Contact/CurrentEmployer.php index 5a2479b14b..7ad996b7a7 100644 --- a/CRM/Report/Form/Contact/CurrentEmployer.php +++ b/CRM/Report/Form/Contact/CurrentEmployer.php @@ -23,9 +23,8 @@ class CRM_Report_Form_Contact_CurrentEmployer extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Contact/Detail.php b/CRM/Report/Form/Contact/Detail.php index edbff9f3e9..47c98364f3 100644 --- a/CRM/Report/Form/Contact/Detail.php +++ b/CRM/Report/Form/Contact/Detail.php @@ -33,9 +33,8 @@ class CRM_Report_Form_Contact_Detail extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Contact/Relationship.php b/CRM/Report/Form/Contact/Relationship.php index 9b7b5dc63d..18ec0c7241 100644 --- a/CRM/Report/Form/Contact/Relationship.php +++ b/CRM/Report/Form/Contact/Relationship.php @@ -33,9 +33,8 @@ class CRM_Report_Form_Contact_Relationship extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Contact/Summary.php b/CRM/Report/Form/Contact/Summary.php index c920b08f7d..9261fc6d08 100644 --- a/CRM/Report/Form/Contact/Summary.php +++ b/CRM/Report/Form/Contact/Summary.php @@ -38,9 +38,8 @@ class CRM_Report_Form_Contact_Summary extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Contribute/Bookkeeping.php b/CRM/Report/Form/Contribute/Bookkeeping.php index ebec5bd423..f70c7d29d1 100644 --- a/CRM/Report/Form/Contribute/Bookkeeping.php +++ b/CRM/Report/Form/Contribute/Bookkeeping.php @@ -32,9 +32,8 @@ class CRM_Report_Form_Contribute_Bookkeeping extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Contribute/Detail.php b/CRM/Report/Form/Contribute/Detail.php index c164f42cdf..14b5facbd9 100644 --- a/CRM/Report/Form/Contribute/Detail.php +++ b/CRM/Report/Form/Contribute/Detail.php @@ -59,9 +59,8 @@ class CRM_Report_Form_Contribute_Detail extends CRM_Report_Form { /** * This report has been optimised for group filtering. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = FALSE; diff --git a/CRM/Report/Form/Contribute/Lybunt.php b/CRM/Report/Form/Contribute/Lybunt.php index 4bba286d07..101717609d 100644 --- a/CRM/Report/Form/Contribute/Lybunt.php +++ b/CRM/Report/Form/Contribute/Lybunt.php @@ -51,9 +51,8 @@ class CRM_Report_Form_Contribute_Lybunt extends CRM_Report_Form { /** * This report has been optimised for group filtering. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = FALSE; diff --git a/CRM/Report/Form/Contribute/Recur.php b/CRM/Report/Form/Contribute/Recur.php index 53996b2766..6f0109d284 100644 --- a/CRM/Report/Form/Contribute/Recur.php +++ b/CRM/Report/Form/Contribute/Recur.php @@ -23,9 +23,8 @@ class CRM_Report_Form_Contribute_Recur extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Contribute/Repeat.php b/CRM/Report/Form/Contribute/Repeat.php index aa4846c532..d5044a08e7 100644 --- a/CRM/Report/Form/Contribute/Repeat.php +++ b/CRM/Report/Form/Contribute/Repeat.php @@ -69,9 +69,8 @@ class CRM_Report_Form_Contribute_Repeat extends CRM_Report_Form { /** * This report has been optimised for group filtering. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = FALSE; diff --git a/CRM/Report/Form/Contribute/SoftCredit.php b/CRM/Report/Form/Contribute/SoftCredit.php index 4da214930d..8370e74203 100644 --- a/CRM/Report/Form/Contribute/SoftCredit.php +++ b/CRM/Report/Form/Contribute/SoftCredit.php @@ -41,9 +41,8 @@ class CRM_Report_Form_Contribute_SoftCredit extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Contribute/Summary.php b/CRM/Report/Form/Contribute/Summary.php index 29dd59842e..b7c40f5a19 100644 --- a/CRM/Report/Form/Contribute/Summary.php +++ b/CRM/Report/Form/Contribute/Summary.php @@ -43,9 +43,8 @@ class CRM_Report_Form_Contribute_Summary extends CRM_Report_Form { /** * This report has been optimised for group filtering. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = FALSE; diff --git a/CRM/Report/Form/Contribute/Sybunt.php b/CRM/Report/Form/Contribute/Sybunt.php index ec142d1a4a..1b45af360e 100644 --- a/CRM/Report/Form/Contribute/Sybunt.php +++ b/CRM/Report/Form/Contribute/Sybunt.php @@ -33,9 +33,8 @@ class CRM_Report_Form_Contribute_Sybunt extends CRM_Report_Form { /** * This report has been optimised for group filtering. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = FALSE; diff --git a/CRM/Report/Form/Contribute/TopDonor.php b/CRM/Report/Form/Contribute/TopDonor.php index 72a7243df4..83d903950e 100644 --- a/CRM/Report/Form/Contribute/TopDonor.php +++ b/CRM/Report/Form/Contribute/TopDonor.php @@ -30,9 +30,8 @@ class CRM_Report_Form_Contribute_TopDonor extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Event/ParticipantListCount.php b/CRM/Report/Form/Event/ParticipantListCount.php index 31a0f70ab1..6e98f4be8b 100644 --- a/CRM/Report/Form/Event/ParticipantListCount.php +++ b/CRM/Report/Form/Event/ParticipantListCount.php @@ -30,9 +30,8 @@ class CRM_Report_Form_Event_ParticipantListCount extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Mailing/Bounce.php b/CRM/Report/Form/Mailing/Bounce.php index cfb798c179..4df4086508 100644 --- a/CRM/Report/Form/Mailing/Bounce.php +++ b/CRM/Report/Form/Mailing/Bounce.php @@ -42,9 +42,8 @@ class CRM_Report_Form_Mailing_Bounce extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Mailing/Clicks.php b/CRM/Report/Form/Mailing/Clicks.php index d3ef570d90..7634844176 100644 --- a/CRM/Report/Form/Mailing/Clicks.php +++ b/CRM/Report/Form/Mailing/Clicks.php @@ -42,9 +42,8 @@ class CRM_Report_Form_Mailing_Clicks extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Mailing/Detail.php b/CRM/Report/Form/Mailing/Detail.php index 5eab237061..f6902c03b7 100644 --- a/CRM/Report/Form/Mailing/Detail.php +++ b/CRM/Report/Form/Mailing/Detail.php @@ -32,9 +32,8 @@ class CRM_Report_Form_Mailing_Detail extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Mailing/Opened.php b/CRM/Report/Form/Mailing/Opened.php index 5db163b7eb..142d8d3d32 100644 --- a/CRM/Report/Form/Mailing/Opened.php +++ b/CRM/Report/Form/Mailing/Opened.php @@ -42,9 +42,8 @@ class CRM_Report_Form_Mailing_Opened extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Member/ContributionDetail.php b/CRM/Report/Form/Member/ContributionDetail.php index 3fbc4f9c60..69dd87b8c8 100644 --- a/CRM/Report/Form/Member/ContributionDetail.php +++ b/CRM/Report/Form/Member/ContributionDetail.php @@ -31,9 +31,8 @@ class CRM_Report_Form_Member_ContributionDetail extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Member/Detail.php b/CRM/Report/Form/Member/Detail.php index 425695ac8a..67ced4a650 100644 --- a/CRM/Report/Form/Member/Detail.php +++ b/CRM/Report/Form/Member/Detail.php @@ -35,10 +35,8 @@ class CRM_Report_Form_Member_Detail extends CRM_Report_Form { * The functionality for group filtering has been improved but not * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. - * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = FALSE; diff --git a/CRM/Report/Form/Member/Lapse.php b/CRM/Report/Form/Member/Lapse.php index 9b0f12b243..864c70ef34 100644 --- a/CRM/Report/Form/Member/Lapse.php +++ b/CRM/Report/Form/Member/Lapse.php @@ -30,9 +30,8 @@ class CRM_Report_Form_Member_Lapse extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Member/Summary.php b/CRM/Report/Form/Member/Summary.php index 1bd21077b7..7cb3dd125f 100644 --- a/CRM/Report/Form/Member/Summary.php +++ b/CRM/Report/Form/Member/Summary.php @@ -36,9 +36,8 @@ class CRM_Report_Form_Member_Summary extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Pledge/Detail.php b/CRM/Report/Form/Pledge/Detail.php index d8e66c78e5..75de4ab4e7 100644 --- a/CRM/Report/Form/Pledge/Detail.php +++ b/CRM/Report/Form/Pledge/Detail.php @@ -42,9 +42,8 @@ class CRM_Report_Form_Pledge_Detail extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Report/Form/Pledge/Summary.php b/CRM/Report/Form/Pledge/Summary.php index 042a06ce1e..d3f853e806 100644 --- a/CRM/Report/Form/Pledge/Summary.php +++ b/CRM/Report/Form/Pledge/Summary.php @@ -28,9 +28,8 @@ class CRM_Report_Form_Pledge_Summary extends CRM_Report_Form { * all reports have been adjusted to take care of it. This report has not * and will run an inefficient query until fixed. * - * CRM-19170 - * * @var bool + * @see https://issues.civicrm.org/jira/browse/CRM-19170 */ protected $groupFilterNotOptimised = TRUE; diff --git a/CRM/Upgrade/Incremental/php/FourSeven.php b/CRM/Upgrade/Incremental/php/FourSeven.php index 28267eebac..74f190a0f2 100644 --- a/CRM/Upgrade/Incremental/php/FourSeven.php +++ b/CRM/Upgrade/Incremental/php/FourSeven.php @@ -515,7 +515,7 @@ class CRM_Upgrade_Incremental_php_FourSeven extends CRM_Upgrade_Incremental_Base // } /** - * CRM-16354 + * @see https://issues.civicrm.org/jira/browse/CRM-16354 * * @return int */ @@ -1249,7 +1249,7 @@ FROM `civicrm_dashboard_contact` JOIN `civicrm_contact` WHERE civicrm_dashboard_ } /** - * CRM-19961 + * @see https://issues.civicrm.org/jira/browse/CRM-19961 * Poputate newly added domain id column and add foriegn key onto table. */ public static function populateSMSProviderDomainId() { diff --git a/Civi/Test/ContactTestTrait.php b/Civi/Test/ContactTestTrait.php index efb0b146e2..26991ea8cf 100644 --- a/Civi/Test/ContactTestTrait.php +++ b/Civi/Test/ContactTestTrait.php @@ -18,7 +18,7 @@ trait ContactTestTrait { /** * Emulate a logged in user since certain functions use that. * value to store a record in the DB (like activity) - * CRM-8180 + * @see https://issues.civicrm.org/jira/browse/CRM-8180 * * @return int * Contact ID of the created user. diff --git a/tests/phpunit/CRM/Contact/BAO/QueryTest.php b/tests/phpunit/CRM/Contact/BAO/QueryTest.php index 69495e08e7..e6ef3bd8b5 100644 --- a/tests/phpunit/CRM/Contact/BAO/QueryTest.php +++ b/tests/phpunit/CRM/Contact/BAO/QueryTest.php @@ -511,7 +511,7 @@ class CRM_Contact_BAO_QueryTest extends CiviUnitTestCase { /** * Test smart groups with non-numeric don't fail on range queries. * - * CRM-14720 + * @see https://issues.civicrm.org/jira/browse/CRM-14720 * * @throws \CRM_Core_Exception */ @@ -586,7 +586,7 @@ class CRM_Contact_BAO_QueryTest extends CiviUnitTestCase { /** * Test smart groups with non-numeric don't fail on equal queries. * - * CRM-14720 + * @see https://issues.civicrm.org/jira/browse/CRM-14720 * * @throws \CRM_Core_Exception */ diff --git a/tests/phpunit/CRM/Contact/Import/Parser/ContactTest.php b/tests/phpunit/CRM/Contact/Import/Parser/ContactTest.php index 536c9e08bb..d6e4ea58a2 100644 --- a/tests/phpunit/CRM/Contact/Import/Parser/ContactTest.php +++ b/tests/phpunit/CRM/Contact/Import/Parser/ContactTest.php @@ -158,7 +158,7 @@ class CRM_Contact_Import_Parser_ContactTest extends CiviUnitTestCase { * * In this case no primary match exists (e.g the details are not supplied) so it falls back on external identifier. * - * CRM-17275 + * @see https://issues.civicrm.org/jira/browse/CRM-17275 * * @throws \Exception */ @@ -183,7 +183,7 @@ class CRM_Contact_Import_Parser_ContactTest extends CiviUnitTestCase { * * In this case no primary match exists (e.g the details are not supplied) so it falls back on external identifier. * - * CRM-17275 + * @see https://issues.civicrm.org/jira/browse/CRM-17275 * * @throws \Exception */ diff --git a/tests/phpunit/CRM/Core/BAO/ActionScheduleTest.php b/tests/phpunit/CRM/Core/BAO/ActionScheduleTest.php index d173b7ea94..e46626e346 100644 --- a/tests/phpunit/CRM/Core/BAO/ActionScheduleTest.php +++ b/tests/phpunit/CRM/Core/BAO/ActionScheduleTest.php @@ -2319,7 +2319,7 @@ class CRM_Core_BAO_ActionScheduleTest extends CiviUnitTestCase { /** * Test that the various repetition units work correctly. - * CRM-17028 + * @see https://issues.civicrm.org/jira/browse/CRM-17028 */ public function testRepetitionFrequencyUnit() { $membershipTypeParams = [ diff --git a/tests/phpunit/CRM/Event/BAO/AdditionalPaymentTest.php b/tests/phpunit/CRM/Event/BAO/AdditionalPaymentTest.php index b5dcf0133a..8d0c38befc 100644 --- a/tests/phpunit/CRM/Event/BAO/AdditionalPaymentTest.php +++ b/tests/phpunit/CRM/Event/BAO/AdditionalPaymentTest.php @@ -194,7 +194,7 @@ class CRM_Event_BAO_AdditionalPaymentTest extends CiviUnitTestCase { } /** - * CRM-13964 + * @see https://issues.civicrm.org/jira/browse/CRM-13964 * * @throws \CRM_Core_Exception */ diff --git a/tests/phpunit/CRM/SMS/BAO/ProviderTest.php b/tests/phpunit/CRM/SMS/BAO/ProviderTest.php index 43b552f061..17a61c2fea 100644 --- a/tests/phpunit/CRM/SMS/BAO/ProviderTest.php +++ b/tests/phpunit/CRM/SMS/BAO/ProviderTest.php @@ -62,7 +62,7 @@ class CRM_SMS_BAO_ProviderTest extends CiviUnitTestCase { } /** - * CRM-20989 + * @see https://issues.civicrm.org/jira/browse/CRM-20989 * Add unit test to ensure that filtering by domain works in get Active Providers */ public function testActiveProviderCount() { diff --git a/tests/phpunit/CRM/Utils/StringTest.php b/tests/phpunit/CRM/Utils/StringTest.php index 7fad15bb2a..be31cfa8d0 100644 --- a/tests/phpunit/CRM/Utils/StringTest.php +++ b/tests/phpunit/CRM/Utils/StringTest.php @@ -229,8 +229,8 @@ class CRM_Utils_StringTest extends CiviUnitTestCase { } /** - * CRM-20821 - * CRM-14283 + * @see https://issues.civicrm.org/jira/browse/CRM-20821 + * @see https://issues.civicrm.org/jira/browse/CRM-14283 * * @param string $imageURL * @param book $forceHttps diff --git a/tests/phpunit/api/v3/ACLPermissionTest.php b/tests/phpunit/api/v3/ACLPermissionTest.php index ed1190ee01..be9b402285 100644 --- a/tests/phpunit/api/v3/ACLPermissionTest.php +++ b/tests/phpunit/api/v3/ACLPermissionTest.php @@ -806,7 +806,7 @@ class api_v3_ACLPermissionTest extends CiviUnitTestCase { /** * Test get activities multiple ids with check permissions - * CRM-20441 + * @see https://issues.civicrm.org/jira/browse/CRM-20441 * @param int $version * @dataProvider versionThreeAndFour */ @@ -832,7 +832,7 @@ class api_v3_ACLPermissionTest extends CiviUnitTestCase { /** * Test get activities multiple ids with check permissions * Limit access to One contact - * CRM-20441 + * @see https://issues.civicrm.org/jira/browse/CRM-20441 * @param int $version * @dataProvider versionThreeAndFour */ @@ -868,7 +868,7 @@ class api_v3_ACLPermissionTest extends CiviUnitTestCase { /** * Test get activities multiple ids with check permissions - * CRM-20441 + * @see https://issues.civicrm.org/jira/browse/CRM-20441 * @param int $version * @dataProvider versionThreeAndFour */ diff --git a/tests/phpunit/api/v3/ContactTest.php b/tests/phpunit/api/v3/ContactTest.php index 17218d3de4..bea3aed15c 100644 --- a/tests/phpunit/api/v3/ContactTest.php +++ b/tests/phpunit/api/v3/ContactTest.php @@ -2841,7 +2841,7 @@ class api_v3_ContactTest extends CiviUnitTestCase { /** * Test long display names. * - * CRM-21258 + * @see https://issues.civicrm.org/jira/browse/CRM-21258 * * @param int $version * @@ -4120,7 +4120,7 @@ class api_v3_ContactTest extends CiviUnitTestCase { * We are checking that there is no error due to attempting to add an activity for the * deleted contact. * - * CRM-18307 + * @see https://issues.civicrm.org/jira/browse/CRM-18307 */ public function testMergeNoTrash() { $this->createLoggedInUser(); @@ -4138,7 +4138,7 @@ class api_v3_ContactTest extends CiviUnitTestCase { /** * Ensure format with return=group shows comma-separated group IDs. * - * CRM-19426 + * @see https://issues.civicrm.org/jira/browse/CRM-19426 * * @throws \CRM_Core_Exception */ diff --git a/tests/phpunit/api/v3/ContributionPageTest.php b/tests/phpunit/api/v3/ContributionPageTest.php index dcf684ea7d..25eb05e65f 100644 --- a/tests/phpunit/api/v3/ContributionPageTest.php +++ b/tests/phpunit/api/v3/ContributionPageTest.php @@ -284,7 +284,7 @@ class api_v3_ContributionPageTest extends CiviUnitTestCase { /** * Test process with instant payment when more than one configured for the page. * - * CRM-16923 + * @see https://issues.civicrm.org/jira/browse/CRM-16923 * * @throws \CiviCRM_API3_Exception * @throws \CRM_Core_Exception diff --git a/tests/phpunit/api/v3/ExtensionTest.php b/tests/phpunit/api/v3/ExtensionTest.php index f804ce26f9..bcfc8f9f4b 100644 --- a/tests/phpunit/api/v3/ExtensionTest.php +++ b/tests/phpunit/api/v3/ExtensionTest.php @@ -43,7 +43,7 @@ class api_v3_ExtensionTest extends CiviUnitTestCase { /** * Test getting a single extension - * CRM-20532 + * @see https://issues.civicrm.org/jira/browse/CRM-20532 */ public function testExtensionGetSingleExtension() { $result = $this->callAPISuccess('extension', 'get', ['key' => 'test.extension.manager.moduletest']); @@ -54,7 +54,7 @@ class api_v3_ExtensionTest extends CiviUnitTestCase { /** * Test single Extension get with specific fields in return - * CRM-20532 + * @see https://issues.civicrm.org/jira/browse/CRM-20532 */ public function testSingleExtensionGetWithReturnFields() { $result = $this->callAPISuccess('extension', 'get', ['key' => 'test.extension.manager.moduletest', 'return' => ['name', 'status', 'key']]); @@ -67,7 +67,7 @@ class api_v3_ExtensionTest extends CiviUnitTestCase { /** * Test Extension Get returns detailed information * Note that this is likely to fail locally but will work on Jenkins due to the result count check - * CRM-20532 + * @see https://issues.civicrm.org/jira/browse/CRM-20532 */ public function testExtensionGet() { $result = $this->callAPISuccess('extension', 'get', ['options' => ['limit' => 0]]); -- 2.25.1