From 0cd30c8379aa5c8f7e15ba220933a1ff8173f846 Mon Sep 17 00:00:00 2001 From: eileen Date: Thu, 2 Jan 2020 10:44:22 +1300 Subject: [PATCH] dev/membership#21 fix regression on membership handling This turns https://lab.civicrm.org/dev/membership/issues/21#note_29439 into a patch. As new code it seems to have triggered an underlying issue. I also have https://github.com/civicrm/civicrm-core/pull/16139 open but would be happy to see this hit the rc & the other have a full rc cycle. The logic for this change makes sense as described & it is trivial. This has been a very hard bug to reproduce so I'm unable to give full steps --- CRM/Member/Utils/RelationshipProcessor.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CRM/Member/Utils/RelationshipProcessor.php b/CRM/Member/Utils/RelationshipProcessor.php index 396959f988..0279c0a5b6 100644 --- a/CRM/Member/Utils/RelationshipProcessor.php +++ b/CRM/Member/Utils/RelationshipProcessor.php @@ -87,7 +87,7 @@ class CRM_Member_Utils_RelationshipProcessor { 'options' => ['limit' => 0], ])['values']; foreach ($memberships as $id => $membership) { - if (!isset($membership['inheriting_membership_ids'])) { + if (!isset($memberships[$id]['inheriting_membership_ids'])) { $memberships[$id]['inheriting_membership_ids'] = []; $memberships[$id]['inheriting_contact_ids'] = []; } -- 2.25.1