From 07c535c876b22609ae0fdd9753f27296793cb1d4 Mon Sep 17 00:00:00 2001 From: Andrew Browning Date: Wed, 20 Sep 2017 00:20:43 -0400 Subject: [PATCH] Fix #5524 Zero division error in exif.py This patch implements the safe_gps_ratio_divide function for gps direction and altitude values to prevent a zero divide error on malformed GPS data. --- mediagoblin/tools/exif.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/mediagoblin/tools/exif.py b/mediagoblin/tools/exif.py index fafd987d..a428ddf1 100644 --- a/mediagoblin/tools/exif.py +++ b/mediagoblin/tools/exif.py @@ -175,18 +175,14 @@ def get_gps_data(tags): pass try: - gps_data['direction'] = ( - lambda d: - float(d.num) / float(d.den) - )(tags['GPS GPSImgDirection'].values[0]) + direction = tags['GPS GPSImgDirection'].values[0] + gps_data['direction'] = safe_gps_ratio_divide(direction) except KeyError: pass try: - gps_data['altitude'] = ( - lambda a: - float(a.num) / float(a.den) - )(tags['GPS GPSAltitude'].values[0]) + altitude = tags['GPS GPSAltitude'].values[0] + gps_data['altitude'] = safe_gps_ratio_divide(altitude) except KeyError: pass -- 2.25.1