From 049dd3d14ad72a9d624f6b67826e82ad1015c9dc Mon Sep 17 00:00:00 2001 From: pdontthink Date: Tue, 19 Dec 2017 05:02:38 +0000 Subject: [PATCH] Document bad assumption git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14747 7612ce4b-ef26-0410-bec9-ea0150e637f0 --- functions/options.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/functions/options.php b/functions/options.php index dc420953..8fde4ae8 100644 --- a/functions/options.php +++ b/functions/options.php @@ -235,6 +235,8 @@ class SquirrelOption { //Check for a current value. if (isset($GLOBALS[$name])) { $this->value = $GLOBALS[$name]; + // TODO: This code should be something more like the following, but who knows what would break if it was changed at this point + // } else if (initial_value !== '') { } else if (!empty($initial_value)) { $this->value = $initial_value; } else { -- 2.25.1