From 024311d5871fd7700b641a21c38392dbf02028ed Mon Sep 17 00:00:00 2001 From: Francis Whittle Date: Fri, 22 Apr 2016 15:11:53 +1000 Subject: [PATCH] CRM-18356: Fix incorrect logic Activity Report has when excluding NULL / NOT NULL filters in 'where' method. ---------------------------------------- * CRM-18356: Activity Reports show null Target Name fields incorrectly for some Activities https://issues.civicrm.org/jira/browse/CRM-18356 --- CRM/Report/Form/Activity.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CRM/Report/Form/Activity.php b/CRM/Report/Form/Activity.php index 7a9372a15e..67c4269f71 100644 --- a/CRM/Report/Form/Activity.php +++ b/CRM/Report/Form/Activity.php @@ -580,7 +580,7 @@ class CRM_Report_Form_Activity extends CRM_Report_Form { } else { $op = CRM_Utils_Array::value("{$fieldName}_op", $this->_params); - if ($op && ($op != 'nnll' || $op != 'nll')) { + if ($op && ($op != 'nnll' && $op != 'nll')) { $clause = $this->whereClause($field, $op, CRM_Utils_Array::value("{$fieldName}_value", $this->_params), -- 2.25.1