From 0139cfb463d112517d6b76ab8e9bb11f5d7f5a96 Mon Sep 17 00:00:00 2001
From: eileen <emcnaughton@wikimedia.org>
Date: Mon, 22 Feb 2021 17:11:27 +1300
Subject: [PATCH] Further simplification

---
 templates/CRM/Member/Form/Membership.tpl       | 14 +++-----------
 templates/CRM/Member/Form/MembershipCommon.tpl |  3 ++-
 2 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/templates/CRM/Member/Form/Membership.tpl b/templates/CRM/Member/Form/Membership.tpl
index 820a85dec1..b9b252a5e3 100644
--- a/templates/CRM/Member/Form/Membership.tpl
+++ b/templates/CRM/Member/Form/Membership.tpl
@@ -299,18 +299,10 @@
         var taxTerm = {/literal}{$taxTerm|@json_encode}{literal};
         var taxRate = taxRates[membershipType['financial_type_id']];
         var currency = {/literal}{$currency_symbol|@json_encode}{literal};
-        var taxAmount = (taxRate/100)*membershipType['total_amount_numeric'];
+        var taxExclusiveAmount = membershipType['total_amount_numeric'] * term;
+        var taxAmount = (taxRate/100)*taxExclusiveAmount;
         taxAmount = isNaN (taxAmount) ? 0:taxAmount;
-        if (term) {
-          if (!taxRate) {
-            var feeTotal = membershipType['total_amount_numeric'] * term;
-          }
-          else {
-            var feeTotal = Number((taxRate/100) * (membershipType['total_amount_numeric'] * term))+Number
-           (membershipType['total_amount_numeric'] * term );
-          }
-          cj("#total_amount").val(CRM.formatMoney(feeTotal, true));
-        }
+        cj("#total_amount").val(CRM.formatMoney(taxExclusiveAmount + taxAmount, true));
 
         var taxMessage = taxRate!=undefined ? 'Includes '+taxTerm+' amount of '+currency+' '+taxAmount:'';
         cj('.totaltaxAmount').html(taxMessage);
diff --git a/templates/CRM/Member/Form/MembershipCommon.tpl b/templates/CRM/Member/Form/MembershipCommon.tpl
index ae2e4eb1d0..c47fb31712 100644
--- a/templates/CRM/Member/Form/MembershipCommon.tpl
+++ b/templates/CRM/Member/Form/MembershipCommon.tpl
@@ -76,7 +76,8 @@
   <tr class="crm-{$formClass}-form-block-total_amount">
     <td class="label">{$form.total_amount.label}</td>
     <td>{$form.total_amount.html}<br />
-      <span class="description">{ts}Membership payment amount.{/ts}</span><div class="totaltaxAmount"></div>
+      <span class="description">{ts}Membership payment amount.{/ts}</span>
+      <div class="totaltaxAmount" data-tax_amount_raw=0></div>
     </td>
   </tr>
   <tr class="crm-membership-form-block-contribution-contact">
-- 
2.25.1