From 00e2484dc934f8ebb2d23365cf5b6fc2bcb58caf Mon Sep 17 00:00:00 2001 From: eileenmcnaugton Date: Fri, 10 May 2019 20:55:47 +1200 Subject: [PATCH] Update testGetActivityAccessCiviCRMEnough test for clarity --- tests/phpunit/api/v3/ACLPermissionTest.php | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/phpunit/api/v3/ACLPermissionTest.php b/tests/phpunit/api/v3/ACLPermissionTest.php index f72b0a8818..ff7534ff28 100644 --- a/tests/phpunit/api/v3/ACLPermissionTest.php +++ b/tests/phpunit/api/v3/ACLPermissionTest.php @@ -571,15 +571,19 @@ class api_v3_ACLPermissionTest extends CiviUnitTestCase { } /** - * View all activities is required unless id is passed in, in which case ACLs are used. + * Check the error message is not a permission error. */ - public function testGetActivityAccessCiviCRMNotEnough() { + public function testGetActivityAccessCiviCRMEnough() { $activity = $this->activityCreate(); $this->setPermissions(['access CiviCRM']); $this->callAPIFailure('Activity', 'getsingle', [ 'check_permissions' => 1, 'id' => $activity['id'], - ]); + ], 'Expected one Activity but found 0'); + $this->callAPISuccessGetCount('Activity', [ + 'check_permissions' => 1, + 'id' => $activity['id'], + ], 0); } /** -- 2.25.1