From ff4f08ffa2021f515fc7ec4c4b261d3a4738e68e Mon Sep 17 00:00:00 2001
From: philippe_mingo <philippe_mingo@7612ce4b-ef26-0410-bec9-ea0150e637f0>
Date: Mon, 11 Feb 2002 19:36:12 +0000
Subject: [PATCH] Bugfix in generate random string.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@2419 7612ce4b-ef26-0410-bec9-ea0150e637f0
---
 functions/strings.php | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/functions/strings.php b/functions/strings.php
index 722cedec..e9bac3f3 100644
--- a/functions/strings.php
+++ b/functions/strings.php
@@ -539,14 +539,15 @@ function GenerateRandomString($size, $chars, $flags = 0) {
     if (($size < 1) || (strlen($chars) < 1)) {
         return '';
     }
-    
+
     sq_mt_randomize(); /* Initialize the random number generator */
-    
+
     $String = '';
+    $j = strlen( $chars ) - 1;
     while (strlen($String) < $size) {
-        $String .= $chars[mt_rand(0, strlen($chars))];
+        $String .= $chars{mt_rand(0, $j)};
     }
-    
+
     return $String;
 }
 
-- 
2.25.1