[REF] Code readability changes on activity tokens.
authoreileen <emcnaughton@wikimedia.org>
Fri, 24 Apr 2020 04:33:26 +0000 (16:33 +1200)
committereileen <emcnaughton@wikimedia.org>
Fri, 24 Apr 2020 05:00:17 +0000 (17:00 +1200)
commit2ebb452b239c28e7ed2c50da69d324a8d40a7e88
treefc9cc973ea8f7d6d2bae60a8dee7d8eb32a44b8e
parent72dee2de8937860225e7a3400da42c1d6454b11b
[REF] Code readability changes on activity tokens.

I've been trying to get to grips with this code and this addresses 2 things I found very confusing - notably

- using activityId when we were referring to a fieldname - we use a combination of  &  for
variables but normally when it's closely related to a query we use activity_id
- the function name getEntityContextSchema() was unclear to me - I concluded that in fact we were retrieving
the nname of the field for the entity ID
CRM/Activity/Form/Task/PDFLetterCommon.php
CRM/Activity/Tokens.php
CRM/Core/TokenTrait.php
Civi/Token/TokenProcessor.php