civicrm-core.git
2 years agoEnhance examples to cover additional participants
Eileen McNaughton [Mon, 19 Jun 2023 01:25:27 +0000 (13:25 +1200)]
Enhance examples to cover additional participants

2 years agoMerge pull request #26572 from civicrm/5.63
Seamus Lee [Mon, 19 Jun 2023 04:51:49 +0000 (14:51 +1000)]
Merge pull request #26572 from civicrm/5.63

5.63

2 years agoMerge pull request #26569 from eileenmcnaughton/event_preview
Seamus Lee [Mon, 19 Jun 2023 03:17:53 +0000 (13:17 +1000)]
Merge pull request #26569 from eileenmcnaughton/event_preview

Fix broken event message template preview

2 years agoMerge pull request #26568 from eileenmcnaughton/event_test_
Seamus Lee [Mon, 19 Jun 2023 03:17:11 +0000 (13:17 +1000)]
Merge pull request #26568 from eileenmcnaughton/event_test_

Remove duplicate test

2 years agoMerge pull request #26041 from seamuslee001/negative_acls
Seamus Lee [Mon, 19 Jun 2023 01:55:04 +0000 (11:55 +1000)]
Merge pull request #26041 from seamuslee001/negative_acls

Permit ACL rules that negate (deny) access

2 years agoFix broken event message template preview
Eileen McNaughton [Mon, 19 Jun 2023 00:57:23 +0000 (12:57 +1200)]
Fix broken event message template preview

This is outside most live use cases but it currently fails on an api
error due to a mismatch between example data & expectations. It should be fixed in
the rc but it might not make sense to back port (or determine breakage further back)

2 years agoRemove duplicate test
Eileen McNaughton [Mon, 19 Jun 2023 00:48:14 +0000 (12:48 +1200)]
Remove duplicate test

2 years agoMerge pull request #26564 from mlutfy/uplang6
Eileen McNaughton [Mon, 19 Jun 2023 00:35:32 +0000 (12:35 +1200)]
Merge pull request #26564 from mlutfy/uplang6

extensions/uplang#6 Fix menu description translations on the Administration Console

2 years agoMerge pull request #26566 from mikeybeck/fix-membership-detail-report
Eileen McNaughton [Mon, 19 Jun 2023 00:34:47 +0000 (12:34 +1200)]
Merge pull request #26566 from mikeybeck/fix-membership-detail-report

Remove 'Payment Amount (most recent)' column from membership report

2 years agoFix capitalization in ACL form
colemanw [Mon, 19 Jun 2023 00:28:44 +0000 (20:28 -0400)]
Fix capitalization in ACL form

2 years agoAdd unit test of negative ACL rules
Seamus Lee [Mon, 19 Jun 2023 00:14:33 +0000 (10:14 +1000)]
Add unit test of negative ACL rules

2 years ago[WIP] Permit ACL rules that negate (deny)
Seamus Lee [Tue, 11 Apr 2023 01:18:41 +0000 (11:18 +1000)]
[WIP] Permit ACL rules that negate (deny)

Further fixes

Expose the deny field on the ACL form and fix current test failures

Update lanague as per Coleman

2 years agoRemove 'Payment Amount (most recent)' column from membership report
Mike Beck [Sun, 18 Jun 2023 21:23:50 +0000 (09:23 +1200)]
Remove 'Payment Amount (most recent)' column from membership report

2 years agoextensions/uplang#6 Fix translation of menu descriptions displayed on the Administrat...
Mathieu Lutfy [Sun, 18 Jun 2023 17:56:01 +0000 (13:56 -0400)]
extensions/uplang#6 Fix translation of menu descriptions displayed on the Administration Console

2 years agoMerge pull request #26540 from eileenmcnaughton/event_part_test
colemanw [Sat, 17 Jun 2023 23:53:35 +0000 (19:53 -0400)]
Merge pull request #26540 from eileenmcnaughton/event_part_test

Fix participantTest class to call createEventPaid

2 years agoMerge pull request #26552 from civicrm/5.63
Eileen McNaughton [Sat, 17 Jun 2023 04:09:35 +0000 (16:09 +1200)]
Merge pull request #26552 from civicrm/5.63

5.63

2 years agoFix participantTest class to call createEventPaid
Eileen McNaughton [Fri, 16 Jun 2023 02:05:50 +0000 (14:05 +1200)]
Fix participantTest class to call createEventPaid

This fixes one place that is called from several tests & updates the various bits of text that change

2 years agoMerge pull request #26538 from eileenmcnaughton/member_fix_rc
Tim Otten [Fri, 16 Jun 2023 22:00:01 +0000 (15:00 -0700)]
Merge pull request #26538 from eileenmcnaughton/member_fix_rc

Fix for membership discounts not showing in 5.62

2 years agoMerge pull request #26548 from demeritcowboy/upgrade-logging
Eileen McNaughton [Fri, 16 Jun 2023 20:20:47 +0000 (08:20 +1200)]
Merge pull request #26548 from demeritcowboy/upgrade-logging

dev/core#4369 - fix upgrade for logging tables

2 years agoMerge pull request #26542 from eileenmcnaughton/except
colemanw [Fri, 16 Jun 2023 20:13:49 +0000 (16:13 -0400)]
Merge pull request #26542 from eileenmcnaughton/except

Add deprecation notice to legacy exception class aliases

2 years agoMerge pull request #26486 from eileenmcnaughton/ee
colemanw [Fri, 16 Jun 2023 20:09:29 +0000 (16:09 -0400)]
Merge pull request #26486 from eileenmcnaughton/ee

Fix a couple more places to use the new event trait

2 years agoMerge pull request #26473 from colemanw/fixListEditable
colemanw [Fri, 16 Jun 2023 19:53:54 +0000 (15:53 -0400)]
Merge pull request #26473 from colemanw/fixListEditable

dev/core#4319 SearchKit - Fix in-place editable in list/grid displays

2 years agoMerge pull request #26550 from larssandergreen/Navigation-menu-select-ease-of-use
demeritcowboy [Fri, 16 Jun 2023 18:51:00 +0000 (14:51 -0400)]
Merge pull request #26550 from larssandergreen/Navigation-menu-select-ease-of-use

Improve select for Add Navigation Menu Item > Parent

2 years agoMerge pull request #25385 from mattwire/membershippending
demeritcowboy [Fri, 16 Jun 2023 17:47:31 +0000 (13:47 -0400)]
Merge pull request #25385 from mattwire/membershippending

Fix don't change membership status when saving a pending membership

2 years agoMerge pull request #26545 from eileenmcnaughton/sms
Yashodha Chaku [Fri, 16 Jun 2023 17:03:40 +0000 (22:33 +0530)]
Merge pull request #26545 from eileenmcnaughton/sms

Php8-proof SMSCommonTest

2 years agoAdd test that shows editing Pending membership should stay in Pending
Matthew Wire [Fri, 16 Jun 2023 16:08:20 +0000 (17:08 +0100)]
Add test that shows editing Pending membership should stay in Pending

2 years agoCheck membership status in form tests
Matthew Wire [Fri, 16 Jun 2023 10:13:40 +0000 (11:13 +0100)]
Check membership status in form tests

2 years agoFix don't change membership status when saving a pending membership
Matthew Wire [Thu, 19 Jan 2023 15:55:30 +0000 (15:55 +0000)]
Fix don't change membership status when saving a pending membership

2 years agoImprove select for Add Navigation Menu Item > Parent
larssandergreen [Fri, 16 Jun 2023 15:08:55 +0000 (09:08 -0600)]
Improve select for Add Navigation Menu Item > Parent

2 years agoMerge pull request #26296 from eileenmcnaughton/event_add
demeritcowboy [Fri, 16 Jun 2023 15:02:54 +0000 (11:02 -0400)]
Merge pull request #26296 from eileenmcnaughton/event_add

Add unit test cover + nl2br for location in event emails

2 years agofix upgrade for logging tables
demeritcowboy [Fri, 16 Jun 2023 14:27:28 +0000 (10:27 -0400)]
fix upgrade for logging tables

2 years agoMerge pull request #26547 from artfulrobot/artfulrobot-fix-recurring-event-tpl
Aidan Saunders [Fri, 16 Jun 2023 12:39:00 +0000 (13:39 +0100)]
Merge pull request #26547 from artfulrobot/artfulrobot-fix-recurring-event-tpl

Fix missing </table> tag on repeat event change confirm tpl.

2 years agoMerge pull request #26536 from colemanw/master-union-setops
colemanw [Fri, 16 Jun 2023 12:21:33 +0000 (08:21 -0400)]
Merge pull request #26536 from colemanw/master-union-setops

APIv4 - Add EntitySet api for set-ops such as UNION

2 years agoFix missing </table> tag on repeat event change confirm tpl.
Rich Lott / Artful Robot [Fri, 16 Jun 2023 11:52:32 +0000 (12:52 +0100)]
Fix missing </table> tag on repeat event change confirm tpl.

2 years agoMerge pull request #26282 from colemanw/schemaHandlerFix2
Aidan Saunders [Fri, 16 Jun 2023 08:39:23 +0000 (09:39 +0100)]
Merge pull request #26282 from colemanw/schemaHandlerFix2

SchemaHandler - Fix nonstandard index capitalization + code cleanup

2 years agoPhp8-proof SMSCommonTest
Eileen McNaughton [Fri, 16 Jun 2023 06:14:44 +0000 (18:14 +1200)]
Php8-proof SMSCommonTest

2 years agoCRM_Utils_SQL_Select - The default alias for subquery should be more distinctive
Tim Otten [Fri, 16 Jun 2023 02:56:34 +0000 (19:56 -0700)]
CRM_Utils_SQL_Select - The default alias for subquery should be more distinctive

1. If you're writing basic SQL from scratch, you would expect the symbol `a` to be available to you
   (e.g. for use in column-aliases or join-aliases). It shouldn't be a reserved word.

2. In the case of Api4EntitySetQuery, it's important to use the alias as `a` - because that matches the
   rest of the api4 query-building.

2 years agoAdd deprecation notice to legacy exception class aliases
Eileen McNaughton [Fri, 16 Jun 2023 03:50:09 +0000 (15:50 +1200)]
Add deprecation notice to legacy exception class aliases

2 years agoMerge pull request #26537 from colemanw/postPostSelectQuery
Eileen McNaughton [Fri, 16 Jun 2023 03:42:02 +0000 (15:42 +1200)]
Merge pull request #26537 from colemanw/postPostSelectQuery

APIv4 - Deprecate unused event

2 years agoFix a couple more places to use the new event trait
Eileen McNaughton [Fri, 9 Jun 2023 06:26:07 +0000 (18:26 +1200)]
Fix a couple more places to use the new event trait

2 years agoMerge pull request #26111 from adixon/membership-detail-report-4261
Eileen McNaughton [Fri, 16 Jun 2023 03:38:47 +0000 (15:38 +1200)]
Merge pull request #26111 from adixon/membership-detail-report-4261

Report on the most recent membership contribution, not the oldest

2 years agoMerge pull request #26541 from eileenmcnaughton/mem563
colemanw [Fri, 16 Jun 2023 03:24:48 +0000 (23:24 -0400)]
Merge pull request #26541 from eileenmcnaughton/mem563

don't show membership block on confirmation page if no membership exists

2 years agoAPIv4 Explorer - Expose entitySets with UNION ALL and UNION DISTINCT
colemanw [Sat, 10 Jun 2023 22:05:32 +0000 (18:05 -0400)]
APIv4 Explorer - Expose entitySets with UNION ALL and UNION DISTINCT

2 years agodon't show membership block on confirmation page if no membership exists
Jon Goldberg [Wed, 14 Jun 2023 15:03:17 +0000 (11:03 -0400)]
don't show membership block on confirmation page if no membership exists

2 years agoAdd unit test cover for location in event emails
Eileen McNaughton [Mon, 22 May 2023 02:34:27 +0000 (14:34 +1200)]
Add unit test cover for location in event emails

2 years agoFix for membership discounts not showing in 5.62
Eileen McNaughton [Fri, 16 Jun 2023 01:05:36 +0000 (13:05 +1200)]
Fix for membership discounts not showing in 5.62

2 years agoAPIv4 - Deprecate unused event
colemanw [Fri, 16 Jun 2023 00:54:02 +0000 (20:54 -0400)]
APIv4 - Deprecate unused event

2 years agoSchemaHandler - Fix nonstandard index names + code cleanup
colemanw [Sat, 20 May 2023 01:09:09 +0000 (21:09 -0400)]
SchemaHandler - Fix nonstandard index names + code cleanup

2 years agoAPIv4 - Add EntitySet api for set-ops such as UNION
colemanw [Thu, 15 Jun 2023 21:22:45 +0000 (17:22 -0400)]
APIv4 - Add EntitySet api for set-ops such as UNION

2 years agoMerge pull request #26530 from mlutfy/fixCssSiteURL
demeritcowboy [Thu, 15 Jun 2023 19:55:07 +0000 (15:55 -0400)]
Merge pull request #26530 from mlutfy/fixCssSiteURL

Fix for domains that have the string .css in them

2 years agoMerge pull request #26534 from larssandergreen/Add-additional-message-to-invoice...
demeritcowboy [Thu, 15 Jun 2023 19:54:09 +0000 (15:54 -0400)]
Merge pull request #26534 from larssandergreen/Add-additional-message-to-invoice-sent-from-Email-Invoice-form

Add additional message to invoice template if present

2 years agoCRM_Utils_SQL_Select - Fix missing derived table alias and add stricter validation
colemanw [Wed, 14 Jun 2023 19:27:06 +0000 (15:27 -0400)]
CRM_Utils_SQL_Select - Fix missing derived table alias and add stricter validation

Don't accept sql strings, all sets must be a CRM_Utils_SQL_Select object.

2 years agoFix for domains that have the string .css in them
Mathieu Lutfy [Wed, 14 Jun 2023 20:30:11 +0000 (16:30 -0400)]
Fix for domains that have the string .css in them

preg_match is used because we also have to match on items from the
asset builder, which have URL params in the filename.

Example:
[...]q=civicrm%2Fasset%2Fbuilder&an=crm-menubar.css&ad=9caf2150754dca162f3a

2 years agoAdd additional message to invoice template if present
larssandergreen [Thu, 15 Jun 2023 14:28:42 +0000 (08:28 -0600)]
Add additional message to invoice template if present

2 years agoMerge pull request #26528 from colemanw/fixDouble
demeritcowboy [Thu, 15 Jun 2023 13:50:31 +0000 (09:50 -0400)]
Merge pull request #26528 from colemanw/fixDouble

Fix dev/core#4359 doubled Afform fields

2 years agoMerge pull request #26533 from larssandergreen/Cleanup-send-invoice-email-form
demeritcowboy [Thu, 15 Jun 2023 13:24:27 +0000 (09:24 -0400)]
Merge pull request #26533 from larssandergreen/Cleanup-send-invoice-email-form

Cleanup Email Invoice form to remove longest ever field label

2 years agoMerge pull request #26498 from colemanw/skAggregateCurrency
Aidan Saunders [Thu, 15 Jun 2023 12:58:01 +0000 (13:58 +0100)]
Merge pull request #26498 from colemanw/skAggregateCurrency

Fix dev/core#4207 - Handle currency symbol in SK aggregates

2 years agoCleanup Invoice Email form
larssandergreen [Thu, 15 Jun 2023 04:15:09 +0000 (22:15 -0600)]
Cleanup Invoice Email form

2 years agoMerge pull request #26531 from demeritcowboy/google-prompt
Eileen McNaughton [Thu, 15 Jun 2023 01:04:28 +0000 (13:04 +1200)]
Merge pull request #26531 from demeritcowboy/google-prompt

dev/core#2184 - OAUTH - make google always return a refresh token

2 years agouse more consent-y prompt for google
demeritcowboy [Thu, 15 Jun 2023 00:05:53 +0000 (20:05 -0400)]
use more consent-y prompt for google

2 years agoMerge pull request #26526 from reflexive-communications/open-tracker-legacy-check
Eileen McNaughton [Wed, 14 Jun 2023 22:18:53 +0000 (10:18 +1200)]
Merge pull request #26526 from reflexive-communications/open-tracker-legacy-check

FlexMailer\Listener\OpenTracker: remove deprecated isLegacy check

2 years agoMerge pull request #26511 from colemanw/civiGrantTest
demeritcowboy [Wed, 14 Jun 2023 22:00:18 +0000 (18:00 -0400)]
Merge pull request #26511 from colemanw/civiGrantTest

[TEST] APIv4 - Include CiviGrant in conformance tests

2 years agoMerge pull request #26525 from yashodha/dev-4358
colemanw [Wed, 14 Jun 2023 18:53:37 +0000 (14:53 -0400)]
Merge pull request #26525 from yashodha/dev-4358

(dev/core#4358) Verbiage changes on Find Groups screen

2 years agoFix dev/core#4359 doubled Afform fields
colemanw [Wed, 14 Jun 2023 16:41:23 +0000 (12:41 -0400)]
Fix dev/core#4359 doubled Afform fields

2 years agoTests - Fix Api4TestTrait to create an option value if needed
colemanw [Wed, 14 Jun 2023 16:39:35 +0000 (12:39 -0400)]
Tests - Fix Api4TestTrait to create an option value if needed

2 years agofix format
Sandor Semsey [Wed, 14 Jun 2023 13:04:05 +0000 (15:04 +0200)]
fix format

2 years agoremove deprecated isLegacy check
Sandor Semsey [Wed, 14 Jun 2023 12:36:27 +0000 (14:36 +0200)]
remove deprecated isLegacy check

2 years ago(dev/core#4358) Verbiage changes on Find Groups screen
yashodha [Wed, 14 Jun 2023 10:08:24 +0000 (15:38 +0530)]
(dev/core#4358) Verbiage changes on Find Groups screen

2 years agoCRM_Utils_SQL_Select - Allow construction of UNION/INTERSECT with sub-queries
Tim Otten [Wed, 14 Jun 2023 08:50:23 +0000 (01:50 -0700)]
CRM_Utils_SQL_Select - Allow construction of UNION/INTERSECT with sub-queries

MySQL 5.7 supports "UNION" (which combines the result-sets from two queries). MySQL 8.0
and MariaDB 10.3 expand this more set-operations (eg "INTERSECT", "EXCEPT").

The patch allows CRM_Utils_SQL_Select to construct a range of queries with these
operators.

Before
------

Not supported

After
-----

A few examples:

```php
CRM_Utils_SQL_Select::fromSet()->union([$subQuery1, $subQuery2])

CRM_Utils_SQL_Select::fromSet()
  ->union($subQuery1)
  ->union($subQuery2);

CRM_Utils_SQL_Select::fromSet()
  ->setOp('UNION ALL', [$subQuery1, $subQuery2])
  ->setOp('EXCEPT', [$subQuery3]);
```

Comments
--------

In these examples, we build one top-level `SELECT` query, and then
use a sub-query to get the UNION/INTERSECT/EXCEPT data. This is not
strictly necessary. (SQL allows set-ops without a top-level SELECT.)
However, this pattern is powerful - because you can freely mix-in
other subclauses (`WHERE`/`GROUP BY`/`HAVING`/etc).

I'm not 100% certain that these signatures are best. Looking at the MySQL
BNF, this is still a bit reductive wrt precedence of the UNION / EXCEPT / INTERSECT
operations. However, `CRM_Utils_SQL_Select` is already reductive about precedence
of WHEREs.

Part of me wanted to model the UNION/setops as a separate object-type
(independent of SELECT) -- and then improve subquery support for SELECT, eg

```
$union = new CRM_Utils_SQL_SetOp('UNION', [$subQuery1, $subQuery2]);
$select = CRM_Utils_SQL_Select::from($union)->where('...');
```

However, in the CiviMail PR that uses UNION, there's an existing `Select`
object where they iteratively mix-in more union clauses. It seems that the
`Select::fromSet()->union()` might be a bit more amenable.

2 years agoMerge pull request #26520 from larssandergreen/Don't-add-contact-to-Domain-Group...
colemanw [Tue, 13 Jun 2023 18:12:47 +0000 (14:12 -0400)]
Merge pull request #26520 from larssandergreen/Don't-add-contact-to-Domain-Group-on-edit

Don't add Contact to Domain Group on edit

2 years agoMerge pull request #26519 from larssandergreen/Don't-try-to-add-Contacts-to-Groups...
colemanw [Tue, 13 Jun 2023 18:00:33 +0000 (14:00 -0400)]
Merge pull request #26519 from larssandergreen/Don't-try-to-add-Contacts-to-Groups-on-Edit

[REF] Don't add Contacts to Groups they are already Added to on Edit

2 years agoMerge pull request #26502 from larssandergreen/Select2-New-contribution-financial...
Yashodha Chaku [Tue, 13 Jun 2023 15:27:26 +0000 (20:57 +0530)]
Merge pull request #26502 from larssandergreen/Select2-New-contribution-financial-type

Add select2s for Contribution, etc

2 years agoDon't add Contact to Domain Group on edit
larssandergreen [Tue, 13 Jun 2023 14:02:13 +0000 (08:02 -0600)]
Don't add Contact to Domain Group on edit

2 years agoMerge pull request #26518 from demeritcowboy/reserved-move
colemanw [Tue, 13 Jun 2023 13:23:39 +0000 (09:23 -0400)]
Merge pull request #26518 from demeritcowboy/reserved-move

dev/core#4338 - Prevent people from sneakily adding fields to your extension's reserved custom groups by using the Move action

2 years agodon't allow moving fields into reserved groups
demeritcowboy [Wed, 7 Jun 2023 19:18:04 +0000 (15:18 -0400)]
don't allow moving fields into reserved groups

2 years agoDon't add Contacts to Groups they are Added to on Edit
larssandergreen [Tue, 13 Jun 2023 06:29:07 +0000 (00:29 -0600)]
Don't add Contacts to Groups they are Added to on Edit

2 years agoMerge pull request #26517 from demeritcowboy/mystery-index
Seamus Lee [Tue, 13 Jun 2023 03:08:47 +0000 (13:08 +1000)]
Merge pull request #26517 from demeritcowboy/mystery-index

dev/core#4355 - Fix crash for radio custom fields

2 years agofix crash for radio custom fields
demeritcowboy [Tue, 13 Jun 2023 00:57:13 +0000 (20:57 -0400)]
fix crash for radio custom fields

2 years agoMerge pull request #26516 from eileenmcnaughton/import_admin2
colemanw [Mon, 12 Jun 2023 23:13:02 +0000 (19:13 -0400)]
Merge pull request #26516 from eileenmcnaughton/import_admin2

Add All imports menu item for users with Administer Queues

2 years agoAdd All imports menu item for users with Administer QUeues
Eileen McNaughton [Mon, 12 Jun 2023 22:32:23 +0000 (10:32 +1200)]
Add All imports menu item for users with Administer QUeues

This adds the (only just added) search display for 'all imports' to the menu, but
only for users with 'Administer Queues' - for other users they would only see
their own imports, so it would duplicate 'my imports'.

This is useful for site admins etc trying to understand issues their users might be having
with imports.

Note the extension needs to be enabled

2 years agoMerge pull request #26514 from larssandergreen/Always-show-implicit-TRUE-Permissions...
colemanw [Mon, 12 Jun 2023 21:04:59 +0000 (17:04 -0400)]
Merge pull request #26514 from larssandergreen/Always-show-implicit-TRUE-Permissions-Check-in-API-4-Explorer

Make implicit TRUE permissions check explicit in API 4 Explorer for PHP

2 years agoMerge pull request #26515 from civicrm/5.63
Eileen McNaughton [Mon, 12 Jun 2023 20:25:45 +0000 (08:25 +1200)]
Merge pull request #26515 from civicrm/5.63

5.63

2 years agoMerge pull request #26512 from demeritcowboy/regen
colemanw [Mon, 12 Jun 2023 18:15:15 +0000 (14:15 -0400)]
Merge pull request #26512 from demeritcowboy/regen

regen after 26499 and 26492

2 years agoMake implicit TRUE permissions check explicit in API 4 Explorer for PHP
larssandergreen [Mon, 12 Jun 2023 17:47:44 +0000 (11:47 -0600)]
Make implicit TRUE permissions check explicit in API 4 Explorer for PHP

2 years agoMerge pull request #26513 from colemanw/fixGrantAccess
colemanw [Mon, 12 Jun 2023 17:44:22 +0000 (13:44 -0400)]
Merge pull request #26513 from colemanw/fixGrantAccess

CiviGrant - Fix error when creating grant without permissions

2 years agoCiviGrant - Fix error when creating grant without permissions
colemanw [Mon, 12 Jun 2023 16:21:55 +0000 (12:21 -0400)]
CiviGrant - Fix error when creating grant without permissions

When creating a grant with checkPermissions disabled (e.g. via API) the permissions
were getting tripped by the RecentItem create action

2 years agoregenerate civicrm_generated
demeritcowboy [Mon, 12 Jun 2023 16:19:23 +0000 (16:19 +0000)]
regenerate civicrm_generated

2 years agoMerge pull request #26465 from totten/master-test-fetchwith
demeritcowboy [Mon, 12 Jun 2023 16:09:01 +0000 (12:09 -0400)]
Merge pull request #26465 from totten/master-test-fetchwith

Smarty - When temporarily setting variable, fix cleanup for previously-undefined values.

2 years agoMerge pull request #26506 from larssandergreen/Reduce-PHP-warnings-on-Contribution
demeritcowboy [Mon, 12 Jun 2023 16:08:33 +0000 (12:08 -0400)]
Merge pull request #26506 from larssandergreen/Reduce-PHP-warnings-on-Contribution

Reduce PHP warnings on Contribution

2 years agoMerge pull request #26496 from colemanw/afformExposeOperators
colemanw [Mon, 12 Jun 2023 15:32:44 +0000 (11:32 -0400)]
Merge pull request #26496 from colemanw/afformExposeOperators

Afform - Enable search operators to be exposed on the form

2 years agoAPIv4 - Include CiviGrant in conformance tests
colemanw [Mon, 12 Jun 2023 14:35:02 +0000 (10:35 -0400)]
APIv4 - Include CiviGrant in conformance tests

2 years agoMerge pull request #26497 from colemanw/apiGuard
Yashodha Chaku [Mon, 12 Jun 2023 10:34:42 +0000 (16:04 +0530)]
Merge pull request #26497 from colemanw/apiGuard

Prevent API errors when CiviEvent is disabled

2 years agoMerge pull request #26508 from braders/php8.1-getDynamicCharacters
colemanw [Sun, 11 Jun 2023 11:47:31 +0000 (07:47 -0400)]
Merge pull request #26508 from braders/php8.1-getDynamicCharacters

[REF][PHP8.1] Don't pass null to strtoupper in getDynamicCharacters

2 years ago[REF][PHP8.1] Don't pass null to strtoupper in getDynamicCharacters
Bradley Taylor [Sun, 11 Jun 2023 08:01:19 +0000 (09:01 +0100)]
[REF][PHP8.1] Don't pass null to strtoupper in getDynamicCharacters

2 years agoCrmScopeTest - Use explicit value for default/global example
Tim Otten [Sat, 10 Jun 2023 21:40:06 +0000 (14:40 -0700)]
CrmScopeTest - Use explicit value for default/global example

Before: We rely on default/global value of `x=UNDEFINED` or `x=NULL`.
But this is a bit tempermental.

After: Clear default.

Note: There's a prior commit which adds another test (CRM_Core_SmartyTest)
where the global value is specifically undefined or specifically null.
So that still has coverage.

2 years agoReduce PHP warnings on Contribution
larssandergreen [Sat, 10 Jun 2023 19:00:38 +0000 (13:00 -0600)]
Reduce PHP warnings on Contribution

2 years agoMerge pull request #26503 from larssandergreen/Fix-Financial-Type-status
colemanw [Sat, 10 Jun 2023 17:11:26 +0000 (13:11 -0400)]
Merge pull request #26503 from larssandergreen/Fix-Financial-Type-status

Expire notifications for Shared Address Contact Delete & Financial Types

2 years agoMerge pull request #26504 from braders/findById-return-type
colemanw [Sat, 10 Jun 2023 17:04:17 +0000 (13:04 -0400)]
Merge pull request #26504 from braders/findById-return-type

[NFC] Change PHPDoc return type (findById)

2 years ago[NFC] Change PHPDoc return type (findById)
Bradley Taylor [Sat, 10 Jun 2023 16:35:58 +0000 (17:35 +0100)]
[NFC] Change PHPDoc return type (findById)

2 years agoExpire notifications for Shared Address Contact Delete & Financial Type
larssandergreen [Sat, 10 Jun 2023 15:54:46 +0000 (09:54 -0600)]
Expire notifications for Shared Address Contact Delete & Financial Type