colemanw [Thu, 6 Jul 2023 13:54:50 +0000 (06:54 -0700)]
Merge pull request #26745 from aydun/recur_metadata
Make the `recur_id` field of Contributions available to FormBuilder
Aidan Saunders [Thu, 6 Jul 2023 06:36:44 +0000 (07:36 +0100)]
Make the `recur_id` field of Contributions available to FormBuilder
Tim Otten [Thu, 6 Jul 2023 04:16:32 +0000 (21:16 -0700)]
Merge pull request #26744 from larssandergreen/Don't-remove-core-component-permissions-on-flush
dev/core#4413 Don't remove core component permissions when disabled
larssandergreen [Wed, 5 Jul 2023 23:52:40 +0000 (17:52 -0600)]
Don't remove core component permissions when disabled
Eileen McNaughton [Wed, 5 Jul 2023 19:23:50 +0000 (07:23 +1200)]
Merge pull request #26741 from artfulrobot/help-debug-afform-submissions
NFC: Add debug level log message when afform submissions catch exceptions
Eileen McNaughton [Wed, 5 Jul 2023 19:08:13 +0000 (07:08 +1200)]
Merge pull request #26659 from mattwire/paymenttrxnid
Fix regression caused by 26620
Rich Lott [Wed, 5 Jul 2023 16:41:49 +0000 (17:41 +0100)]
Use afform log channel
Rich Lott / Artful Robot [Wed, 5 Jul 2023 15:57:47 +0000 (16:57 +0100)]
Add debug level log message when afform submissions catch exceptions
The code comments suggest we don't really know what to do here,
previously we did nothing, which was not helpful to a developer
trying to figure out why their code did nothing.
Now we emit the exception's message to the log file.
colemanw [Wed, 5 Jul 2023 13:01:22 +0000 (06:01 -0700)]
Merge pull request #26190 from eileenmcnaughton/lang_fallback
Fix Translation to load related language more reliably
colemanw [Wed, 5 Jul 2023 12:59:39 +0000 (05:59 -0700)]
Merge pull request #26740 from eileenmcnaughton/api_fix
Fix apiv4 bug on custom fields with spaces in name
colemanw [Wed, 5 Jul 2023 12:57:27 +0000 (05:57 -0700)]
Merge pull request #26733 from aydun/adminui_mailsettings
AdminUI: Convert Mail Accounts page civicrm/admin/mailSettings
Matthew Wire [Wed, 5 Jul 2023 09:11:59 +0000 (10:11 +0100)]
Merge pull request #26737 from eileenmcnaughton/trxn
Update related contribution trxn_id before sending email [must go into 5.64]
Aidan Saunders [Tue, 4 Jul 2023 23:10:46 +0000 (00:10 +0100)]
AdminUI: Convert Mail Accounts page civicrm/admin/mailSettings
Make MailSettings available to SearchKit
Eileen McNaughton [Sat, 1 Jul 2023 04:21:01 +0000 (21:21 -0700)]
Fix apiv4 bug on custom fields with spaces in name
Eileen McNaughton [Wed, 5 Jul 2023 05:16:09 +0000 (17:16 +1200)]
Merge pull request #26738 from civicrm/5.63
5.63
demeritcowboy [Wed, 5 Jul 2023 03:57:08 +0000 (23:57 -0400)]
Merge pull request #26735 from eileenmcnaughton/merge_perms
Fix recent regression - Use consistent value for checkPermissions in merger
Tim Otten [Wed, 5 Jul 2023 03:46:57 +0000 (20:46 -0700)]
Merge pull request #26684 from artfulrobot/standalone-login-ux
Standalone login ux
demeritcowboy [Wed, 5 Jul 2023 03:38:40 +0000 (23:38 -0400)]
Merge pull request #26736 from eileenmcnaughton/weight_3
Fix another place weight is not passed
colemanw [Wed, 5 Jul 2023 03:02:08 +0000 (20:02 -0700)]
Merge pull request #26734 from eileenmcnaughton/weight_2
Remove unused variables, fix a couple of ==
Eileen McNaughton [Wed, 5 Jul 2023 01:39:42 +0000 (13:39 +1200)]
Update related contribution trxn_id before sending email
This will allow https://github.com/civicrm/civicrm-core/pull/26659 to pass & merge
Eileen McNaughton [Wed, 5 Jul 2023 01:29:41 +0000 (13:29 +1200)]
Fix another place weight is not passed
Eileen McNaughton [Wed, 5 Jul 2023 01:10:35 +0000 (13:10 +1200)]
Use consistent value for checkPermissions in merger
We recently added a permission check when retrieving metadata here
https://github.com/civicrm/civicrm-core/commit/
0e88731ff38f4bcf5a4d53c7e2ced01f70533ff1#diff-fe60c89ebe94bbd40114d135459371cc53708db1f2952ade6c0ce9b3468c4dabR2306
However, when that function is called from getFieldValueAndLabel that is not being passed
and is defaulting to TRUE. This is causing issues in a cron context where
checkPermissions is being used (well actually in a unit test in our custom code
simulating that possiblility)
Eileen McNaughton [Wed, 5 Jul 2023 00:46:35 +0000 (12:46 +1200)]
Remove unused variables, fix a couple of ==
Eileen McNaughton [Wed, 5 Jul 2023 00:38:13 +0000 (12:38 +1200)]
Merge pull request #26732 from aydun/adminui_joblog
AdminUI: Convert Job Log page civicrm/admin/joblog
colemanw [Wed, 5 Jul 2023 00:37:23 +0000 (17:37 -0700)]
Merge pull request #26719 from eileenmcnaughton/weight_2
Add weights to contact search actions
Aidan Saunders [Tue, 4 Jul 2023 23:24:31 +0000 (00:24 +0100)]
AdminUI: Convert Job Log page civicrm/admin/joblog
Eileen McNaughton [Mon, 3 Jul 2023 20:21:07 +0000 (08:21 +1200)]
Add weights to contact search actions
Eileen McNaughton [Tue, 4 Jul 2023 22:28:52 +0000 (10:28 +1200)]
Merge pull request #26725 from demeritcowboy/acl
[NFC] Update test that's no longer doing what it was doing
demeritcowboy [Tue, 4 Jul 2023 22:25:41 +0000 (18:25 -0400)]
Merge pull request #26731 from colemanw/killCrmUtilsArrayValue
REF - Replace CRM_Utils_Array::value with ??
Aidan Saunders [Tue, 4 Jul 2023 21:42:22 +0000 (22:42 +0100)]
Merge pull request #26730 from colemanw/fixSmartyRewrite
SearchKit - Fix check for smarty syntax in rewrite output
colemanw [Tue, 4 Jul 2023 21:21:32 +0000 (17:21 -0400)]
REF - Replace CRM_Utils_Array::value with ??
colemanw [Tue, 4 Jul 2023 17:57:31 +0000 (13:57 -0400)]
SearchKit - Fix check for smarty syntax in rewrite output
Fixes dev/core#4405
Aidan Saunders [Tue, 4 Jul 2023 16:54:35 +0000 (17:54 +0100)]
Merge pull request #26728 from howardshand/patch-1
Merged #26726 into master.
howardshand [Tue, 4 Jul 2023 16:46:42 +0000 (11:46 -0500)]
Merged #26726 into master.
colemanw [Tue, 4 Jul 2023 16:39:20 +0000 (09:39 -0700)]
Merge pull request #26726 from howardshand/patch-1
Update Api.php to correct external_identifier to type STRING
howardshand [Tue, 4 Jul 2023 16:22:17 +0000 (11:22 -0500)]
Update Api.php to correct external_identifier to type STRING
demeritcowboy [Tue, 4 Jul 2023 15:59:52 +0000 (11:59 -0400)]
Merge pull request #26724 from colemanw/shortArray
[REF] Autoformat php short array syntax
demeritcowboy [Tue, 4 Jul 2023 14:11:43 +0000 (10:11 -0400)]
update test
colemanw [Tue, 4 Jul 2023 13:40:56 +0000 (09:40 -0400)]
Autoformat php short array syntax
Monish Deb [Tue, 4 Jul 2023 04:17:06 +0000 (09:47 +0530)]
Merge pull request #26723 from colemanw/utilsArrayCleanup
[REF] Remove unnecessary CRM_Utils_Array::value and use short array syntax
Monish Deb [Tue, 4 Jul 2023 03:32:47 +0000 (09:02 +0530)]
Merge pull request #26699 from larssandergreen/Joomla-Permissions-warning
dev/joomla#51 Fix Joomla permissions warning
colemanw [Tue, 4 Jul 2023 03:12:12 +0000 (23:12 -0400)]
CRM - Remove unnecessary CRM_Utils_Array::value and use short array syntax
demeritcowboy [Tue, 4 Jul 2023 01:27:52 +0000 (21:27 -0400)]
Merge pull request #26669 from samuelsov/refAdminUI
#4360 #4384 fixing multiple regressions with path civicrm/contact/search
colemanw [Tue, 4 Jul 2023 00:46:32 +0000 (20:46 -0400)]
Add todo comment
Co-authored-by: demeritcowboy <demeritcowboy@hotmail.com>
Eileen McNaughton [Tue, 4 Jul 2023 00:09:48 +0000 (12:09 +1200)]
Merge pull request #26717 from eileenmcnaughton/event_test_data
Remove now unsed createEvent test function from test baseClass
demeritcowboy [Mon, 3 Jul 2023 23:07:54 +0000 (19:07 -0400)]
Merge pull request #23724 from mattwire/eventtest
Towards consistency for displaying test entities. Stop hiding test entities on some dashboards
Eileen McNaughton [Mon, 3 Jul 2023 19:38:44 +0000 (07:38 +1200)]
Remove now unsed createEvent test function
colemanw [Mon, 3 Jul 2023 21:52:53 +0000 (14:52 -0700)]
Merge pull request #26705 from colemanw/email
Render Email input as type="email"
Eileen McNaughton [Mon, 3 Jul 2023 21:29:47 +0000 (14:29 -0700)]
Merge pull request #26721 from eileenmcnaughton/group_bits
Add frontend_title to various data set up places
Eileen McNaughton [Mon, 3 Jul 2023 21:20:31 +0000 (14:20 -0700)]
Merge pull request #26715 from eileenmcnaughton/contact_trait
Include `entityTrait` in `ContactTestTrait`
Eileen McNaughton [Mon, 3 Jul 2023 21:18:57 +0000 (14:18 -0700)]
Merge pull request #26720 from eileenmcnaughton/unused
Remove some unused test functions
Eileen McNaughton [Mon, 3 Jul 2023 21:12:08 +0000 (14:12 -0700)]
Merge pull request #26646 from colemanw/actionMapping
Drop unused table civicrm_action_mapping
Eileen McNaughton [Mon, 3 Jul 2023 20:52:44 +0000 (13:52 -0700)]
Merge pull request #26718 from eileenmcnaughton/weight_1
Add weight to Group Links
Eileen McNaughton [Mon, 3 Jul 2023 20:49:46 +0000 (08:49 +1200)]
Add frontend_title to various data set up places
Eileen McNaughton [Mon, 3 Jul 2023 20:46:19 +0000 (08:46 +1200)]
Fix test set up to declare frontend_title
Eileen McNaughton [Mon, 3 Jul 2023 20:42:13 +0000 (13:42 -0700)]
Merge pull request #26716 from colemanw/searchContext
SearchKit - Provide context information to subscribers
Eileen McNaughton [Mon, 3 Jul 2023 19:18:54 +0000 (07:18 +1200)]
Include entityTrait in ContactTestTrait
Eileen McNaughton [Mon, 3 Jul 2023 20:31:57 +0000 (08:31 +1200)]
Remove some unused test functions
If I'm wrong jenkins will tell us
Eileen McNaughton [Mon, 3 Jul 2023 19:52:16 +0000 (07:52 +1200)]
Add weight to Group Links
colemanw [Mon, 3 Jul 2023 19:46:30 +0000 (12:46 -0700)]
Merge pull request #26505 from larssandergreen/PHP-warning-on-Contribution
Reduce PHP warnings with paymentBlock
colemanw [Sat, 24 Jun 2023 19:42:40 +0000 (12:42 -0700)]
Drop unused table civicrm_action_mapping
In 2015 this table was made obsolete by the new MappingInterface
and has not been used for anything since then.
colemanw [Mon, 3 Jul 2023 19:31:58 +0000 (12:31 -0700)]
Merge pull request #26709 from eileenmcnaughton/price_fee
Fix ChangeFeeSelectionTest to use eventCreatePaid
Eileen McNaughton [Mon, 3 Jul 2023 19:31:25 +0000 (12:31 -0700)]
Merge pull request #26710 from colemanw/customType
APIv4 - Add more metadata to CustomValue entities; use AutoService
Eileen McNaughton [Mon, 3 Jul 2023 19:30:21 +0000 (12:30 -0700)]
Merge pull request #26714 from colemanw/codeFixes
[REF] Code cleanup; remove unused vars and remove CRM_Utils_Array::value
Eileen McNaughton [Mon, 3 Jul 2023 19:25:03 +0000 (12:25 -0700)]
Merge pull request #26712 from larssandergreen/Install-SK-on-headless-tests
Install SK as part of headless test baseline
colemanw [Mon, 3 Jul 2023 19:22:09 +0000 (15:22 -0400)]
SearchKit - Provide context information to subscribers
colemanw [Mon, 3 Jul 2023 18:34:29 +0000 (14:34 -0400)]
Code cleanup; remove unused vars and remove CRM_Utils_Array::value
larssandergreen [Mon, 3 Jul 2023 18:14:54 +0000 (12:14 -0600)]
Install SK as part of headless test baseline
demeritcowboy [Mon, 3 Jul 2023 17:43:27 +0000 (13:43 -0400)]
Merge pull request #26696 from mlutfy/cleanupTmpTables
clearTempTables: fix condition for user_job check
colemanw [Mon, 3 Jul 2023 17:10:44 +0000 (10:10 -0700)]
Merge pull request #26713 from reflexive-communications/unsubscribe-properties
CRM_Mailing_Form_Optout, CRM_Mailing_Form_Unsubscribe: change properties to protected from private
colemanw [Mon, 3 Jul 2023 15:38:36 +0000 (08:38 -0700)]
Merge pull request #26711 from larssandergreen/Don't-show-SQL-text-in-SK-if-the-user-doesn't-have-permission
Don't show SQL text in SK if user does not have view debug permission
colemanw [Mon, 3 Jul 2023 02:05:56 +0000 (22:05 -0400)]
Render Email input as type="email"
Fixes dev/core#4300
colemanw [Mon, 3 Jul 2023 13:53:05 +0000 (09:53 -0400)]
APIv4 - Add more metadata to CustomValue entities; use AutoService
There are several places in SearchKit code that check an entity 'type' to see if it contains 'DAOEntity'; they all seem designed
to test if the query will go through (so does it support joins, etc?) and custom entities were getting overlooked.
While I was at it I switch to our new standard 'AutoService' style of event listener
Sandor Semsey [Mon, 3 Jul 2023 14:33:02 +0000 (16:33 +0200)]
make properties protected to get accessed by CRM_Core_Form::getVar()
Rich Lott / Artful Robot [Mon, 3 Jul 2023 11:17:57 +0000 (12:17 +0100)]
standalone: satisfy civilint on commented code
Rich Lott / Artful Robot [Mon, 3 Jul 2023 11:12:10 +0000 (12:12 +0100)]
standalone: add role list and (basic) edit UI
Matthew Wire [Sun, 25 Jun 2023 16:21:47 +0000 (17:21 +0100)]
Fix regression caused by 26620
Rich Lott / Artful Robot [Mon, 3 Jul 2023 10:28:10 +0000 (11:28 +0100)]
standalone: hide everyone role from UI
Rich Lott / Artful Robot [Mon, 3 Jul 2023 10:23:41 +0000 (11:23 +0100)]
standalone: grant certain perms to 'everyone' role
Aidan Saunders [Mon, 3 Jul 2023 10:18:43 +0000 (11:18 +0100)]
Merge pull request #26698 from colemanw/customJoin
SearchKit - Allow custom fields in join conditions
Rich Lott / Artful Robot [Mon, 3 Jul 2023 09:57:06 +0000 (10:57 +0100)]
standalone: change schema for RBAC; update tests
Eileen McNaughton [Mon, 3 Jul 2023 06:53:12 +0000 (18:53 +1200)]
Fix ChangeFeeSelectionTest to use eventCreatePaid
Seamus Lee [Mon, 3 Jul 2023 05:40:38 +0000 (01:40 -0400)]
Merge pull request #26708 from eileenmcnaughton/part_create
Use eventCreateUnpaid in participantCreate
Eileen McNaughton [Mon, 3 Jul 2023 04:11:35 +0000 (16:11 +1200)]
Use eventCreateUnpaid in participantCreate
Eileen McNaughton [Mon, 3 Jul 2023 04:51:39 +0000 (21:51 -0700)]
Merge pull request #26707 from eileenmcnaughton/event_change
Fix ACLPermissionTrait to use EventTest create function
larssandergreen [Mon, 3 Jul 2023 04:41:36 +0000 (22:41 -0600)]
Don't show SQL text in SK if user does not have view debug permission
Eileen McNaughton [Mon, 3 Jul 2023 03:40:24 +0000 (15:40 +1200)]
Fix ACLPermissionTrait to use EventTest create function
Cleanup in related classes
Seamus Lee [Mon, 3 Jul 2023 03:42:40 +0000 (23:42 -0400)]
Merge pull request #26706 from civicrm/5.63
5.63
Seamus Lee [Mon, 3 Jul 2023 03:01:34 +0000 (23:01 -0400)]
Merge pull request #26695 from alifrumin/rn5.63
[NFC] First pass at 5.63 release notes
Seamus Lee [Mon, 3 Jul 2023 02:59:30 +0000 (22:59 -0400)]
Merge pull request #26703 from larssandergreen/Give-webtest-user-permission-to-view-debug
Allow Drupal webstest user to view debug output
Seamus Lee [Mon, 3 Jul 2023 02:59:12 +0000 (22:59 -0400)]
Merge pull request #26702 from larssandergreen/Fix-debug-permissions-issue-in-API4
Fix debug permissions for API 4 Explorer debug
Eileen McNaughton [Mon, 3 Jul 2023 02:57:53 +0000 (19:57 -0700)]
Merge pull request #26704 from eileenmcnaughton/event_t
Test cleanup in BAO_ParticipantTest
Eileen McNaughton [Mon, 3 Jul 2023 02:05:39 +0000 (14:05 +1200)]
Test cleanup in BAO_ParticipantTest
Fixes to use the trait. Also simplifies the fixEventLevel test
- the fixEventLevel function has a lot of set up with
some legacy function calls. However, the set up is not
relevent the the string-processing function being tested
larssandergreen [Mon, 3 Jul 2023 01:45:41 +0000 (19:45 -0600)]
Fix debug permissions for API 4 Explorer debug
larssandergreen [Mon, 3 Jul 2023 01:40:11 +0000 (19:40 -0600)]
Allow Drupal webstest user to view debug output
Eileen McNaughton [Mon, 3 Jul 2023 01:34:10 +0000 (18:34 -0700)]
Merge pull request #26701 from eileenmcnaughton/event
[Tests] Fix a few more places to use eventTrait & remove `legacyEventCreate`
Eileen McNaughton [Mon, 3 Jul 2023 00:20:34 +0000 (12:20 +1200)]
Fix a few more places to use eventTrait & remove legacyEventCreate
Tim Otten [Sun, 2 Jul 2023 21:26:45 +0000 (14:26 -0700)]
Merge pull request #26672 from totten/master-standalone-obj
Standalone - Track logged-in user object
colemanw [Sun, 2 Jul 2023 20:27:54 +0000 (13:27 -0700)]
Merge pull request #26697 from larssandergreen/Re-order-SearchDisplay-Links-options
Put link first in SearchDisplay Links options
larssandergreen [Sun, 2 Jul 2023 19:21:31 +0000 (13:21 -0600)]
Fix Joomla permissions warning