demeritcowboy [Wed, 2 Aug 2023 20:17:17 +0000 (16:17 -0400)]
Merge pull request #26984 from colemanw/daoFixeyUppey
DAO - Normalize null values in the writeRecord function to avoid subtle bugs
colemanw [Wed, 2 Aug 2023 17:01:13 +0000 (13:01 -0400)]
Merge pull request #26950 from eileenmcnaughton/deprecate
Deprecate probably never true condition
Eileen McNaughton [Fri, 28 Jul 2023 02:22:01 +0000 (14:22 +1200)]
Fix test set up
Eileen McNaughton [Thu, 27 Jul 2023 23:27:53 +0000 (11:27 +1200)]
Deprecate probably never true condition
If we can clarify that price set is ALWAYS set it will simplify stuff
- comments suggest that the exception has been weird test config
colemanw [Tue, 1 Aug 2023 23:00:16 +0000 (19:00 -0400)]
DAO - Normalize null values in the writeRecord function to avoid subtle bugs
Passing around the string 'null' was a terrible practice and can lead to bugs when you use
an operator like `empty()` on the value.
Yashodha Chaku [Tue, 1 Aug 2023 06:20:32 +0000 (11:50 +0530)]
Merge pull request #26961 from eileenmcnaughton/quick_config
Use `isQuickConfig()` to determine isQuickConfig (towards php8.x fix)
Seamus Lee [Tue, 1 Aug 2023 01:57:20 +0000 (21:57 -0400)]
Merge pull request #26913 from eileenmcnaughton/subscribe_2
Update Group Subscribe message to use frontend_title
Seamus Lee [Tue, 1 Aug 2023 01:55:43 +0000 (21:55 -0400)]
Merge pull request #26962 from eileenmcnaughton/test_fix_mem
[php8.x] Fix test to use full form flow
Eileen McNaughton [Mon, 31 Jul 2023 23:38:34 +0000 (11:38 +1200)]
Merge pull request #26973 from aydun/adminui_price_paths2
Metadata tweaks for Price Sets, Fields & Values
Aidan Saunders [Mon, 31 Jul 2023 19:09:27 +0000 (20:09 +0100)]
Follow up to https://github.com/civicrm/civicrm-core/pull/26929
- fix unreleased regression relating to adding new price set fields and
values
- add Upgrader
Switch html type from Select to EntityRef for Price Fields and Values
Yashodha Chaku [Mon, 31 Jul 2023 14:52:16 +0000 (20:22 +0530)]
Merge pull request #26972 from civicrm/5.64
5.64
colemanw [Mon, 31 Jul 2023 14:25:02 +0000 (07:25 -0700)]
Merge pull request #25605 from kurund/radio-defaults
dev/core#3777 Afform: fix the setting defaults for radio and checkboxes when values are non-string
Kurund Jalmi [Fri, 17 Feb 2023 22:00:34 +0000 (22:00 +0000)]
fix the setting defaults for radio and checkboxes when values are non-string
Rich Lott [Mon, 31 Jul 2023 10:22:22 +0000 (11:22 +0100)]
Merge pull request #26966 from artfulrobot/standalone-login-redirects
standalone: Redirect to login
Rich Lott / Artful Robot [Mon, 31 Jul 2023 10:19:40 +0000 (11:19 +0100)]
standalone: redirect to login
Seamus Lee [Mon, 31 Jul 2023 03:51:47 +0000 (23:51 -0400)]
Merge pull request #26968 from alifrumin/5.64rn
[NFC] 5.64 release notes
colemanw [Sun, 30 Jul 2023 20:09:36 +0000 (13:09 -0700)]
Merge pull request #26674 from larssandergreen/Show-bounce-history-on-contact-summary
Show Email bounce history on Contact summary
colemanw [Sun, 30 Jul 2023 02:47:37 +0000 (19:47 -0700)]
Merge pull request #26971 from colemanw/colemanw-patch-1
ManagedEntityTest - Simplify reconciliation
colemanw [Sun, 30 Jul 2023 02:00:21 +0000 (22:00 -0400)]
ManagedEntityTest - Simplify reconciliation
Followup to #26970 which solved the problem; this removes the workarounds that are no longer needed.
colemanw [Sun, 30 Jul 2023 01:32:56 +0000 (18:32 -0700)]
Merge pull request #26970 from larssandergreen/Fix-Managed-Entity-test
Limit Managed Entity test reconciliation to the entities in the test
larssandergreen [Sun, 30 Jul 2023 00:20:47 +0000 (18:20 -0600)]
Limit Managed Entity test reconciliation to the entities in the test
colemanw [Fri, 28 Jul 2023 23:47:13 +0000 (16:47 -0700)]
Merge pull request #26960 from eileenmcnaughton/billing
Check `isBackOffice` before checking `billing_profile_id` (e-notice fix)
Eileen McNaughton [Fri, 28 Jul 2023 23:18:02 +0000 (11:18 +1200)]
Merge pull request #26576 from larssandergreen/Don't-allow-also-include-schedule-reminders-for-event
dev/core#4377 Disable broken Also Include for event scheduled reminders
Alice Frumin [Wed, 12 Jul 2023 02:08:01 +0000 (22:08 -0400)]
[NFC] 5.64 release notes
Aidan Saunders [Fri, 28 Jul 2023 18:05:56 +0000 (19:05 +0100)]
Merge pull request #26967 from colemanw/colemanw-patch-1
Add civicrm_search_ui to core-ext.txt
colemanw [Fri, 28 Jul 2023 17:30:48 +0000 (13:30 -0400)]
Add civicrm_search_ui to core-ext.txt
colemanw [Fri, 28 Jul 2023 13:09:43 +0000 (06:09 -0700)]
Merge pull request #26963 from totten/master-service-tags
AutoDefinition - Inherit service-tags from interfaces, traits, and parent classes
Tim Otten [Fri, 28 Jul 2023 09:44:07 +0000 (02:44 -0700)]
AutoDefinition - Inherit service-tags from interfaces, traits, and parent classes
Tim Otten [Fri, 28 Jul 2023 07:06:54 +0000 (00:06 -0700)]
Declare @serviceTags for HookInterface and SpecProviderInterface
Yashodha Chaku [Fri, 28 Jul 2023 10:11:47 +0000 (15:41 +0530)]
Merge pull request #26958 from eileenmcnaughton/smarty_campaign
Define soon as 'in 9 years'
Rich Lott [Fri, 28 Jul 2023 09:45:15 +0000 (10:45 +0100)]
Merge pull request #26942 from artfulrobot/standalone-breadcrumbs-v2
standalone: move breadcrumb rendering into template
Rich Lott / Artful Robot [Fri, 28 Jul 2023 09:00:46 +0000 (10:00 +0100)]
standalone: civilint
Seamus Lee [Fri, 28 Jul 2023 05:55:16 +0000 (01:55 -0400)]
Merge pull request #26954 from larssandergreen/Fix-saved-search-test-where-existing-managed-saved-search-is-present
Fix saved search test when there is an existing managed saved search
colemanw [Thu, 27 Jul 2023 03:57:29 +0000 (23:57 -0400)]
AutoDefinition - Remove never-true condition
The type-hint ensures the variable is never a string.
Eileen McNaughton [Fri, 28 Jul 2023 04:54:34 +0000 (16:54 +1200)]
Stop setting quickConfig for form that doesn't care
Seamus Lee [Fri, 28 Jul 2023 04:53:06 +0000 (00:53 -0400)]
Merge pull request #26959 from civicrm/5.64
5.64
Eileen McNaughton [Fri, 28 Jul 2023 04:49:22 +0000 (16:49 +1200)]
Use isQuickConfig to determine isQuickConfig
Eileen McNaughton [Fri, 28 Jul 2023 04:44:11 +0000 (16:44 +1200)]
[php8.x] Fix test to use full form flow
Eileen McNaughton [Fri, 28 Jul 2023 04:21:00 +0000 (16:21 +1200)]
Check isBackOffice before checking billing_profile_id
It won't be set from back office forms & will e-notice...
Seamus Lee [Fri, 28 Jul 2023 04:11:39 +0000 (00:11 -0400)]
Merge pull request #26953 from eileenmcnaughton/cont_name
dev/core#4453 fix clash over 'name' field on contribution page form
Eileen McNaughton [Fri, 28 Jul 2023 03:50:03 +0000 (15:50 +1200)]
Define soon as 9 years
larssandergreen [Fri, 28 Jul 2023 03:08:06 +0000 (21:08 -0600)]
Disable broken Also Include for event scheduled reminders
larssandergreen [Fri, 28 Jul 2023 02:13:41 +0000 (20:13 -0600)]
Fix saved search test with existing managed saved search
Eileen McNaughton [Fri, 28 Jul 2023 02:03:38 +0000 (14:03 +1200)]
dev/core#4453 fix clash over 'name' field on contribution page form
larssandergreen [Thu, 27 Jul 2023 22:27:09 +0000 (16:27 -0600)]
Show bounce history on Contact Summary
colemanw [Fri, 28 Jul 2023 00:39:50 +0000 (17:39 -0700)]
Merge pull request #26948 from colemanw/isInstall
Managed - skip errors in install as well as upgrade mode
Eileen McNaughton [Thu, 27 Jul 2023 23:56:10 +0000 (11:56 +1200)]
Merge pull request #26949 from eileenmcnaughton/dummy
Update ContributionMainTest to use full form flow
Eileen McNaughton [Thu, 27 Jul 2023 23:14:02 +0000 (11:14 +1200)]
Update ContributionMainTest to use full form flow
This updates the test to use postProcess and to check is_recur is passed to the
preApprove function rather than proxy that check by checking if is_recur
is set in the _params property (which is not used again after the preApprove
Seamus Lee [Thu, 27 Jul 2023 22:24:01 +0000 (18:24 -0400)]
Merge pull request #26945 from civicrm/5.64
5.64
Seamus Lee [Thu, 27 Jul 2023 22:23:48 +0000 (18:23 -0400)]
Merge pull request #26947 from eileenmcnaughton/report
[PHP8.2] Remove undeclared property
colemanw [Thu, 27 Jul 2023 22:10:32 +0000 (18:10 -0400)]
Managed - skip errors in install as well as upgrade mode
Followup from https://github.com/civicrm/civicrm-core/pull/26891
to exclude install as well as upgrade mode.
Eileen McNaughton [Thu, 27 Jul 2023 21:46:19 +0000 (09:46 +1200)]
[PHP8.2] Remove undeclared property
It appears to be copy & paste cos it is set but never used
Aidan Saunders [Thu, 27 Jul 2023 21:06:00 +0000 (22:06 +0100)]
Merge pull request #26944 from colemanw/fixSkArithmetic
Fix dev/core#4455 broken SK arithmetic display
colemanw [Thu, 27 Jul 2023 19:36:35 +0000 (15:36 -0400)]
Fix dev/core#4455 broken SK arithmetic display
Rich Lott / Artful Robot [Thu, 27 Jul 2023 15:41:29 +0000 (16:41 +0100)]
standalone: improve code efficiency
Rich Lott / Artful Robot [Thu, 27 Jul 2023 15:26:33 +0000 (16:26 +0100)]
standalone: prevent civi adding duplicate breadcrumbs (e.g. scheduled jobs)
Rich Lott / Artful Robot [Thu, 27 Jul 2023 15:20:37 +0000 (16:20 +0100)]
standalone: fix breadcrumb array_merge
Rich Lott / Artful Robot [Thu, 27 Jul 2023 15:03:27 +0000 (16:03 +0100)]
standalone: move breadcrumb rendering into template
demeritcowboy [Thu, 27 Jul 2023 13:40:49 +0000 (09:40 -0400)]
Merge pull request #26236 from ufundo/400-not-500-errors-for-bad-requests
dev/core#4298 - respond with 400 not 500 errors if wrong params passed to CiviMail urls
Seamus Lee [Thu, 27 Jul 2023 12:48:36 +0000 (08:48 -0400)]
Merge pull request #26941 from civicrm/5.64
5.64
Yashodha Chaku [Thu, 27 Jul 2023 05:44:34 +0000 (11:14 +0530)]
Merge pull request #26939 from demeritcowboy/upg-parent-id
dev/core#4451 - fix dangerous delete cascade
demeritcowboy [Thu, 27 Jul 2023 03:24:07 +0000 (23:24 -0400)]
Merge pull request #26938 from demeritcowboy/neverseen-ts
Remove ts for message that should never be seen by normal people
demeritcowboy [Thu, 27 Jul 2023 02:54:37 +0000 (22:54 -0400)]
fix dangerous delete cascade
demeritcowboy [Thu, 27 Jul 2023 01:40:41 +0000 (21:40 -0400)]
this message should never be seen by normal people
demeritcowboy [Thu, 27 Jul 2023 01:33:05 +0000 (21:33 -0400)]
Merge pull request #26935 from larssandergreen/Fix-upgrade-templates-message
dev/core#4445 Only show templates upgrade message when templates have changed
Seamus Lee [Thu, 27 Jul 2023 01:24:17 +0000 (21:24 -0400)]
Merge pull request #26937 from totten/master-retune
ClassScanner - Re-skip `_Form` classes
Tim Otten [Thu, 27 Jul 2023 00:42:45 +0000 (17:42 -0700)]
ClassScanner - Re-skip `_Form` classes
Follow-up to #26936. The prior commit was good in that it stopped scanning `CRM_Core_QuickForm_*` classes. But it also
turned-on unnecessary scanning of `CRM_*_Form_*`. Flip that back.
At time of writing, this represents ~500 unnecessary reads (e.g. scanning 1000 files vs 1500 files).
Seamus Lee [Thu, 27 Jul 2023 00:27:58 +0000 (20:27 -0400)]
Merge pull request #26936 from larssandergreen/Don't-scan-QuickForm-classes
Don't scan QuickForm classes
larssandergreen [Wed, 26 Jul 2023 23:19:17 +0000 (17:19 -0600)]
Don't scan QuickForm classes
Seamus Lee [Wed, 26 Jul 2023 22:55:23 +0000 (18:55 -0400)]
Merge pull request #26932 from demeritcowboy/slow3
dev/core#4449 - Avoid slow status checks
larssandergreen [Wed, 26 Jul 2023 21:04:01 +0000 (15:04 -0600)]
Only show templates upgrade message when templates have changed
colemanw [Wed, 26 Jul 2023 16:54:15 +0000 (09:54 -0700)]
Merge pull request #26929 from aydun/adminui_price_paths
Change Price paths
colemanw [Wed, 26 Jul 2023 16:27:27 +0000 (09:27 -0700)]
Merge pull request #26925 from aydun/adminui_aclentity
AdminUI: convert 'Assign Users to Roles' ACL configuration page
Mathieu Lu [Wed, 26 Jul 2023 15:27:34 +0000 (11:27 -0400)]
Merge pull request #26934 from mlutfy/standaloneAdmin
Standalone civi-setup: grant more permissions to anon, use ts
Yashodha Chaku [Wed, 26 Jul 2023 15:00:32 +0000 (20:30 +0530)]
Merge pull request #26930 from mlutfy/hookCopyOriginal
hook_civicrm_copy: Pass the original id when available
Aidan Saunders [Mon, 24 Jul 2023 17:09:48 +0000 (18:09 +0100)]
AdminUI: convert "Assign Users to Roles" ACL page to SearchKit/FormBuilder
demeritcowboy [Wed, 26 Jul 2023 14:10:59 +0000 (10:10 -0400)]
Merge pull request #26897 from mlutfy/financial216
dev/financial#216 Financial Batch: remove the Create/Edit activities
Aidan Saunders [Tue, 25 Jul 2023 16:27:58 +0000 (17:27 +0100)]
Price metadata changes for SearchKit
Aidan Saunders [Tue, 25 Jul 2023 16:12:25 +0000 (17:12 +0100)]
Add /edit paths for Price Sets, Price Fields and Price Field Values
Mathieu Lu [Wed, 26 Jul 2023 14:05:49 +0000 (10:05 -0400)]
Standalone civi-setup: grant more permissions to anon, use ts
Eileen McNaughton [Tue, 25 Jul 2023 01:28:26 +0000 (13:28 +1200)]
dev/core#2907 parse subject for tokens
Eileen McNaughton [Mon, 24 Jul 2023 02:26:35 +0000 (14:26 +1200)]
Update Group Subscribe message to use frontend_title
demeritcowboy [Tue, 25 Jul 2023 23:15:47 +0000 (19:15 -0400)]
avoid slow status checks
demeritcowboy [Tue, 25 Jul 2023 22:24:19 +0000 (18:24 -0400)]
Merge pull request #26912 from eileenmcnaughton/subscribe
Minor cleanup in test class
Tim Otten [Tue, 25 Jul 2023 19:58:33 +0000 (12:58 -0700)]
Merge pull request #26923 from colemanw/actionMappingService2
Autoload ActionMappings by enabling global class scanning (Variant 2)
Mathieu Lu [Tue, 25 Jul 2023 19:34:08 +0000 (15:34 -0400)]
hook_civicrm_copy: Pass the original id when available
Mathieu Lutfy [Fri, 21 Jul 2023 17:21:50 +0000 (13:21 -0400)]
dev/financial#216 Financial Batch: remove the Create/Edit activities
demeritcowboy [Tue, 25 Jul 2023 16:37:11 +0000 (12:37 -0400)]
Merge pull request #26928 from civicrm/5.64
5.64
colemanw [Tue, 25 Jul 2023 15:29:41 +0000 (08:29 -0700)]
Merge pull request #26927 from eileenmcnaughton/import_url
Fix Import Template path to be dynamic, depending on the entity
colemanw [Mon, 24 Jul 2023 17:38:51 +0000 (13:38 -0400)]
Autoload ActionMappings by enabling global class scanning
This adds the `AutoSubscriber` base class which is a little simpler to
implement than its cousin `AutoService` when all you need to do is
subscribe to events.
demeritcowboy [Tue, 25 Jul 2023 13:01:14 +0000 (09:01 -0400)]
Merge pull request #26902 from seamuslee001/dev_core_4429
dev/core#4429 Fix checking to see if a price option is able to be useā¦
demeritcowboy [Tue, 25 Jul 2023 12:51:55 +0000 (08:51 -0400)]
Merge pull request #26917 from eileenmcnaughton/test_fix
Minor improvement in test set up function
Seamus Lee [Tue, 25 Jul 2023 07:41:10 +0000 (03:41 -0400)]
Merge pull request #24683 from larssandergreen/check-if-employer-matches-employer-value-in-profile
Check if profile contact employer name matches existing contact employer name when saving profile
Eileen McNaughton [Tue, 25 Jul 2023 04:18:51 +0000 (16:18 +1200)]
Fix Import Template path to be dynamic, depending on the entity
Seamus Lee [Tue, 25 Jul 2023 01:59:39 +0000 (21:59 -0400)]
Merge pull request #26889 from demeritcowboy/slow
Status check - Use guzzle instead to avoid slowness reading zero-length file
Eileen McNaughton [Tue, 25 Jul 2023 01:53:06 +0000 (13:53 +1200)]
Merge pull request #26926 from eileenmcnaughton/import_part
Fix multi-value custom fields on participant import
Jon Goldberg [Tue, 4 Apr 2023 16:59:31 +0000 (12:59 -0400)]
Fix multi-value custom fields on participant import
Eileen McNaughton [Mon, 24 Jul 2023 05:51:48 +0000 (17:51 +1200)]
Minor improvement in test set up function
Eileen McNaughton [Mon, 24 Jul 2023 19:35:33 +0000 (07:35 +1200)]
Merge pull request #26924 from larssandergreen/Update-tests-to-ignore-packaged-saved-searches
Update tests to ignore packaged saved searches
Aidan Saunders [Mon, 24 Jul 2023 17:08:14 +0000 (18:08 +0100)]
setup.sh