Merging FIXME into one row.
Fixing typos.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13034 7612ce4b-ef26-0410-bec9-ea0150e637f0

Remove use of  in function copied from STABLE; change 'FIX ME' to 'FIXME'

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13033 7612ce4b-ef26-0410-bec9-ea0150e637f0

One more.  I wasn't done.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13031 7612ce4b-ef26-0410-bec9-ea0150e637f0

Includes for being called from plugins, etc

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13030 7612ce4b-ef26-0410-bec9-ea0150e637f0

Bug Report plugin: general cleanup per SM plugin specs, elimination of HTML output from the core, make it show SM version number again...

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13028 7612ce4b-ef26-0410-bec9-ea0150e637f0

Allow plugins to require CORE plugins

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13027 7612ce4b-ef26-0410-bec9-ea0150e637f0

Adding FIXME notes

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13026 7612ce4b-ef26-0410-bec9-ea0150e637f0

Fixing variable not parsed through PHP. Thanks to Scott Venier for the patch.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13025 7612ce4b-ef26-0410-bec9-ea0150e637f0

Updating use of sqgetGlobalVar.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13020 7612ce4b-ef26-0410-bec9-ea0150e637f0

Updating my previous comments.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13019 7612ce4b-ef26-0410-bec9-ea0150e637f0

Fix wrong comment syntax.  Thanks Thierry Godefroy.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13017 7612ce4b-ef26-0410-bec9-ea0150e637f0

Viewing unsafe images is a core functionality, so I remove these comments.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13013 7612ce4b-ef26-0410-bec9-ea0150e637f0

Add radio button group widget type SMOPT_TYPE_STRLIST_RADIO

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13012 7612ce4b-ef26-0410-bec9-ea0150e637f0

Add yes_text and no_text option attributes that allow the overriding of the Yes/No text for boolean radio widgets

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13008 7612ce4b-ef26-0410-bec9-ea0150e637f0

Boolean option widgets now default to checkboxes

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13004 7612ce4b-ef26-0410-bec9-ea0150e637f0

Make the caption for checkboxes a label for the checkbox

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13003 7612ce4b-ef26-0410-bec9-ea0150e637f0

Create specific boolean radio widget

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@13001 7612ce4b-ef26-0410-bec9-ea0150e637f0

Add info about new option widget types

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12999 7612ce4b-ef26-0410-bec9-ea0150e637f0

Add checkbox type of boolean option widget

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12995 7612ce4b-ef26-0410-bec9-ea0150e637f0

Fix spacing on options pages

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12994 7612ce4b-ef26-0410-bec9-ea0150e637f0

Add convenience function; keep track of multi-value widget types in one place

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12990 7612ce4b-ef26-0410-bec9-ea0150e637f0

Add FIXME

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12989 7612ce4b-ef26-0410-bec9-ea0150e637f0

get_magic_quotes_* functions deprecated in PHP 5.3.x. Check for
existance and ignore deprecation warnings.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12987 7612ce4b-ef26-0410-bec9-ea0150e637f0

Adding comments.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12979 7612ce4b-ef26-0410-bec9-ea0150e637f0

Add sq_send_mail()

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12978 7612ce4b-ef26-0410-bec9-ea0150e637f0

Guarantee we have an array

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12976 7612ce4b-ef26-0410-bec9-ea0150e637f0

Guarantee we have an array

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12974 7612ce4b-ef26-0410-bec9-ea0150e637f0

Avoid PHP errors when adding to empty list

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12972 7612ce4b-ef26-0410-bec9-ea0150e637f0

Add docs

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12969 7612ce4b-ef26-0410-bec9-ea0150e637f0

Prevent PHP notices when possible values is not given

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12968 7612ce4b-ef26-0410-bec9-ea0150e637f0

Just remove 'inside' hooks, which make no sense in templated output and were long deprecated

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12967 7612ce4b-ef26-0410-bec9-ea0150e637f0

Remove some HTML from the core

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12966 7612ce4b-ef26-0410-bec9-ea0150e637f0

Use a template for the edit list widget

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12964 7612ce4b-ef26-0410-bec9-ea0150e637f0

Add multiple select string list option widget

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12962 7612ce4b-ef26-0410-bec9-ea0150e637f0

Add 'edit list' type option widget

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12961 7612ce4b-ef26-0410-bec9-ea0150e637f0

Don't presume output format

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12960 7612ce4b-ef26-0410-bec9-ea0150e637f0

Fix broken MDN functionality

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12951 7612ce4b-ef26-0410-bec9-ea0150e637f0

Fix broken default value for 'save as draft' and fix explanation of 'move to sent' functionality

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12950 7612ce4b-ef26-0410-bec9-ea0150e637f0

Typo.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12946 7612ce4b-ef26-0410-bec9-ea0150e637f0

Fixed broken default link for plain text attachments

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12945 7612ce4b-ef26-0410-bec9-ea0150e637f0

Make To column header clickable like From is

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12942 7612ce4b-ef26-0410-bec9-ea0150e637f0

Change approach for making things like Message-ID available after sending.  Tracker #1322898 inspired me to do what I was originally thinking, even though this shows SM's design weaknesses.  I also now guarantee that the Message-ID and Date headers will be the same between that sent to the recipient and that stored in the Sent folder.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12940 7612ce4b-ef26-0410-bec9-ea0150e637f0

Correct since tag

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12939 7612ce4b-ef26-0410-bec9-ea0150e637f0

other part of r12925

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12937 7612ce4b-ef26-0410-bec9-ea0150e637f0

Don't capitalize PHP fxns

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12935 7612ce4b-ef26-0410-bec9-ea0150e637f0

Correct value of undefined hostname

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12933 7612ce4b-ef26-0410-bec9-ea0150e637f0

reset token when another < is detected, to ensure that HTML tags between
style tags do not break finding the end tag.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12930 7612ce4b-ef26-0410-bec9-ea0150e637f0

improve message ID generation: put together a string based on user-data
(username, IP, remote port), serial data (time in ms) and randomness,
and put this all through a one-way hash. This makes the chance on
collisions unrealistically small, and at the same time prevents all
kinds of trouble when some vars are not available or contain non-allowed
information (like IPv6 addresses).

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12929 7612ce4b-ef26-0410-bec9-ea0150e637f0

fix duplicate htmlspecialchars of $sTmp; this comes straight from
decodeHeader that already applies htmlspecialchars to the string.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12928 7612ce4b-ef26-0410-bec9-ea0150e637f0

add space to improve display

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12927 7612ce4b-ef26-0410-bec9-ea0150e637f0

fix spelling of variable name which made its meaning confusing

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12926 7612ce4b-ef26-0410-bec9-ea0150e637f0

separate multiple addresses with ",", put as much on a line
as can fit, by default display the first 3 (not 1)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12925 7612ce4b-ef26-0410-bec9-ea0150e637f0

add space for nicer formatting

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12924 7612ce4b-ef26-0410-bec9-ea0150e637f0

Reinserting support for the "iframe_height" option. This might be done in a better way - if so, please do it.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12923 7612ce4b-ef26-0410-bec9-ea0150e637f0

Correct disappearing addresses when address book entry has email address without host portion

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12922 7612ce4b-ef26-0410-bec9-ea0150e637f0

Make message ID available after message is sent.  Not the best solution, but it's smallish and SM design doesn't suit very well

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12919 7612ce4b-ef26-0410-bec9-ea0150e637f0

X-Priority Low is 5, not 3.  Thanks Thierry Godefroy.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12917 7612ce4b-ef26-0410-bec9-ea0150e637f0

Add "alreadyFocused" functionality to login page

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12910 7612ce4b-ef26-0410-bec9-ea0150e637f0

Fix undefined field problem

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12907 7612ce4b-ef26-0410-bec9-ea0150e637f0

Fix incorrect case of sort fields; strip repetative RE: type subject prefixes; strip FWD: subject prefixes; do not html-encode sort fields

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12906 7612ce4b-ef26-0410-bec9-ea0150e637f0

Don't let more general attachment plugins override changes made by specific ones; also judge by changes to the defaultlink in addition to added links.  Thanks to Thierry Godefroy.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12903 7612ce4b-ef26-0410-bec9-ea0150e637f0

Make sure plugins have the last say for all attachment types, even ones SM supports internally.  Thanks to Thierry Godefroy

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12902 7612ce4b-ef26-0410-bec9-ea0150e637f0

Avoid E_STRICT errors

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12901 7612ce4b-ef26-0410-bec9-ea0150e637f0

Avoid E_STRICT errors

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12900 7612ce4b-ef26-0410-bec9-ea0150e637f0

Just adding some notes

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12899 7612ce4b-ef26-0410-bec9-ea0150e637f0

make MiB/KiB translatable

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12898 7612ce4b-ef26-0410-bec9-ea0150e637f0

tree.php always requires a set of imap functionality, so let it require
it to make sure it's present. Thanks Thierry Godefroy.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12897 7612ce4b-ef26-0410-bec9-ea0150e637f0

only execute mailbox name manipulation when we actually use $mailbox,
thanks Thierry Godefroy.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12896 7612ce4b-ef26-0410-bec9-ea0150e637f0

fix string, thanks Thierry Godefroy

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12895 7612ce4b-ef26-0410-bec9-ea0150e637f0

Adding comments.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12888 7612ce4b-ef26-0410-bec9-ea0150e637f0

Revert last change

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12886 7612ce4b-ef26-0410-bec9-ea0150e637f0

Fixed recently changed string

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12885 7612ce4b-ef26-0410-bec9-ea0150e637f0

Using str_replace instead of sprintf because some languages need to change the order of the replaced strings

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12884 7612ce4b-ef26-0410-bec9-ea0150e637f0

Including more strings in the template.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12883 7612ce4b-ef26-0410-bec9-ea0150e637f0

Removing HTML from a string.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12882 7612ce4b-ef26-0410-bec9-ea0150e637f0

Fixing non-translatable strings. Thanks to intrigeri <intrigeri at boum.org> for the report.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12881 7612ce4b-ef26-0410-bec9-ea0150e637f0

Added "Secured Configuration" mode

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12880 7612ce4b-ef26-0410-bec9-ea0150e637f0

avoid E_STRICT errors

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12879 7612ce4b-ef26-0410-bec9-ea0150e637f0

Also use $nbsp here as well

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12878 7612ce4b-ef26-0410-bec9-ea0150e637f0

A few output elements are used often, so just retrieve them once and make them globally available

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12877 7612ce4b-ef26-0410-bec9-ea0150e637f0

Serialize option types whose values are not scalar.  At first, I strongly considered simply serializing ALL prefs when they are written to the pref backend, because that method automates prefs better and the user (developer) needn't concern themselves with the details thereof (with this solution, they have to know to unserialize certain prefs after calling getPref()).  I changed my mind, though, primarily because calling unserialize() for every pref that is loaded and serialize() for every pref that is stored seems like unnecessary overhead, and serializing prefs now might unstabilize what seems to be a fairly stable pref storage system to date.  Secondarily, I didn't want to screw everybody's pref files up.  The other bonus is that this can be backported to STABLE (which I just might do).  Again, this solution does mean that developers do have to manually unserialize any non-scalar pref settings.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12876 7612ce4b-ef26-0410-bec9-ea0150e637f0

Make message details link a non-relative URI.  Thanks Thierry Godefroy

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12875 7612ce4b-ef26-0410-bec9-ea0150e637f0

Fix missing return value for deliverMessage().  Thanks to Thierry Godefroy

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12874 7612ce4b-ef26-0410-bec9-ea0150e637f0

Clarify sloppy variable name usage

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12873 7612ce4b-ef26-0410-bec9-ea0150e637f0

sqsetcookie is called every time sqsession_is_active is called, which results in headers-already-sent notices after output has been initiated... here is a fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12872 7612ce4b-ef26-0410-bec9-ea0150e637f0

avoid E_STRICT errors

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12871 7612ce4b-ef26-0410-bec9-ea0150e637f0

avoid E_STRICT errors

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12870 7612ce4b-ef26-0410-bec9-ea0150e637f0

avoid E_STRICT errors

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12869 7612ce4b-ef26-0410-bec9-ea0150e637f0

avoid E_STRICT errors

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12868 7612ce4b-ef26-0410-bec9-ea0150e637f0

avoid E_STRICT errors

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12867 7612ce4b-ef26-0410-bec9-ea0150e637f0

avoid E_STRICT errors

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12866 7612ce4b-ef26-0410-bec9-ea0150e637f0

avoid E_STRICT errors

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12865 7612ce4b-ef26-0410-bec9-ea0150e637f0

avoid E_STRICT errors

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12864 7612ce4b-ef26-0410-bec9-ea0150e637f0

avoid E_STRICT errors

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12863 7612ce4b-ef26-0410-bec9-ea0150e637f0

avoid E_STRICT errors

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12862 7612ce4b-ef26-0410-bec9-ea0150e637f0

avoid E_STRICT errors

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12861 7612ce4b-ef26-0410-bec9-ea0150e637f0

Correct misplaced code

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12860 7612ce4b-ef26-0410-bec9-ea0150e637f0

Allow preview pane message list refresh mechanism to be forced by others

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12858 7612ce4b-ef26-0410-bec9-ea0150e637f0

Add ability to force message list refresh

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12857 7612ce4b-ef26-0410-bec9-ea0150e637f0

Form values come to PHP as strings, so default comparison should be consistent

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12855 7612ce4b-ef26-0410-bec9-ea0150e637f0