demeritcowboy [Sun, 19 Nov 2023 02:56:41 +0000 (21:56 -0500)]
Merge pull request #28196 from eileenmcnaughton/notice_event
Notice fix on payment block
Eileen McNaughton [Sat, 18 Nov 2023 23:45:55 +0000 (12:45 +1300)]
Merge pull request #28200 from braders/selector-context
[REF][PHP8.2] Declare _context in CRM_Contact_Selector
Eileen McNaughton [Sat, 18 Nov 2023 23:41:11 +0000 (12:41 +1300)]
Merge pull request #28204 from braders/donor-properties
[REF][PHP8.2] Declare donorEmail and donorDisplayName properties
demeritcowboy [Sat, 18 Nov 2023 17:56:17 +0000 (12:56 -0500)]
Merge pull request #28203 from braders/opencase-allowmulticlient
[REF][PHP8.2] Remove need for _allowMultiClient property
demeritcowboy [Sat, 18 Nov 2023 17:07:01 +0000 (12:07 -0500)]
Merge pull request #28201 from braders/php8-emailtest
[REF][PHP8.2] Remove unused property usage from test
Bradley Taylor [Sat, 18 Nov 2023 17:03:36 +0000 (17:03 +0000)]
[REF][PHP8.2] Declare donorEmail and donorDisplayName properties
Bradley Taylor [Sat, 18 Nov 2023 16:51:11 +0000 (16:51 +0000)]
[REF][PHP8.2] Remove need for _allowMultiClient property
demeritcowboy [Sat, 18 Nov 2023 16:38:56 +0000 (11:38 -0500)]
Merge pull request #28199 from braders/_redactionRegexRules
[REF][PHP8.2] Declare _redactionRegexRules property
Bradley Taylor [Sat, 18 Nov 2023 16:19:43 +0000 (16:19 +0000)]
[REF][PHP8.2] Remove unused property usage from test
Bradley Taylor [Sat, 18 Nov 2023 16:08:08 +0000 (16:08 +0000)]
[REF][PHP8.2] Declare _context in CRM_Contact_Selector
Bradley Taylor [Sat, 18 Nov 2023 13:48:37 +0000 (13:48 +0000)]
[REF][PHP8.2] Declare _redactionRegexRules property
Tim Otten [Sat, 18 Nov 2023 05:49:24 +0000 (22:49 -0700)]
Merge pull request #28197 from eileenmcnaughton/test_clean
Minor standardisation in test class
Eileen McNaughton [Sat, 18 Nov 2023 04:03:56 +0000 (17:03 +1300)]
Minor standardisation in test class
Refer to the payment processor in a way that is more consistent with other classes
Eileen McNaughton [Sat, 18 Nov 2023 04:17:09 +0000 (17:17 +1300)]
Notice fix on payment block
We don't need to check if we are dealing with a multiple participant event because that
is the only scenario where the field additional_participants is present
& it will fail gracefully if it is not present. This has been causing notices across
all flows that include the payment block
Eileen McNaughton [Sat, 18 Nov 2023 03:35:14 +0000 (16:35 +1300)]
Merge pull request #28174 from eileenmcnaughton/mem_online_2
Fix membership online preview to display subject (using token)
Eileen McNaughton [Fri, 17 Nov 2023 23:16:18 +0000 (12:16 +1300)]
Update CRM/Member/WorkflowMessage/Membership/Membership.php
Co-authored-by: colemanw <coleman@civicrm.org>
Tim Otten [Fri, 17 Nov 2023 22:33:16 +0000 (15:33 -0700)]
Merge pull request #28169 from demeritcowboy/l10ndir-check
System check for multiple l10n dirs
demeritcowboy [Thu, 16 Nov 2023 19:02:24 +0000 (14:02 -0500)]
system check for multiple l10n dirs
Eileen McNaughton [Fri, 17 Nov 2023 20:40:37 +0000 (09:40 +1300)]
Merge pull request #28193 from civicrm/5.68
5.68
Eileen McNaughton [Fri, 17 Nov 2023 20:39:30 +0000 (09:39 +1300)]
Merge pull request #28192 from lcdservices/civicrm-core-4780b
dev/core#4780 handle bounce processing when verp unverified
demeritcowboy [Fri, 17 Nov 2023 19:57:20 +0000 (14:57 -0500)]
Merge pull request #28187 from colemanw/groupConcatUiFix
SearchKit - Fix missing label on group concat distinct dropdown
demeritcowboy [Fri, 17 Nov 2023 19:27:21 +0000 (14:27 -0500)]
trying again to fix conflict
demeritcowboy [Fri, 17 Nov 2023 19:25:56 +0000 (14:25 -0500)]
try to fix merge conflict
Aidan Saunders [Fri, 17 Nov 2023 18:58:01 +0000 (18:58 +0000)]
Merge pull request #28164 from colemanw/groupFirst
APIv4 - Add GROUP_FIRST aggregate function
demeritcowboy [Fri, 17 Nov 2023 18:37:17 +0000 (13:37 -0500)]
Merge pull request #28189 from aydun/adminui_cp_fix_rc
dev/core#4783 Fix ability to clone and delete Contribution Pages when AdminUI enabled
Brian Shaughnessy [Fri, 17 Nov 2023 18:23:38 +0000 (13:23 -0500)]
dev/core#4780 handle bounce processing when verp unverified
Aidan Saunders [Thu, 16 Nov 2023 21:46:41 +0000 (21:46 +0000)]
Move civicrm/contribute/manage to civicrm/admin/contribute/manage
Update one reference to old path
Change Contribution Page clone and delete to use new path
colemanw [Fri, 17 Nov 2023 14:04:37 +0000 (09:04 -0500)]
SearchKit - Fix wrong flags shown when switching field functions
colemanw [Fri, 17 Nov 2023 01:15:59 +0000 (20:15 -0500)]
SearchKit - Support ORDER BY with aggregate functions
colemanw [Thu, 16 Nov 2023 01:12:18 +0000 (20:12 -0500)]
APIv4 - Add GROUP_FIRST aggregate function
This fills a gap in the MySql spec. It returns the first result of a GROUP_CONCAT set.
colemanw [Fri, 17 Nov 2023 14:17:39 +0000 (09:17 -0500)]
SearchKit - Fix missing label on group concat distinct dropdown
colemanw [Fri, 17 Nov 2023 13:33:00 +0000 (08:33 -0500)]
Merge pull request #28171 from eileenmcnaughton/568_tax
Fix tax total not showing on thank you
Seamus Lee [Fri, 17 Nov 2023 07:43:58 +0000 (18:43 +1100)]
Merge pull request #28180 from eileenmcnaughton/notice_n
Reverse variable check to fix notice
Eileen McNaughton [Fri, 17 Nov 2023 03:19:04 +0000 (16:19 +1300)]
Reverse variable check to fix notice
colemanw [Fri, 17 Nov 2023 02:55:22 +0000 (21:55 -0500)]
Merge pull request #28165 from colemanw/mockTestMove
[REF] Afform - Namespace mock tests for autoloading
colemanw [Fri, 17 Nov 2023 02:53:50 +0000 (21:53 -0500)]
Merge pull request #28179 from totten/master-langs
setup/res/languages.php - Always generate style-compliant code
Tim Otten [Fri, 17 Nov 2023 01:51:56 +0000 (18:51 -0700)]
Merge pull request #28177 from eileenmcnaughton/mem_online_white
Reformat whitespace in online membership receipt
Tim Otten [Fri, 17 Nov 2023 01:47:30 +0000 (17:47 -0800)]
Regenerate `languages.php` and `langs.php`
Tim Otten [Fri, 17 Nov 2023 01:30:16 +0000 (17:30 -0800)]
GenCode - When generating 'setup/res/languages.php', it should be pass linter
Eileen McNaughton [Thu, 16 Nov 2023 22:59:01 +0000 (11:59 +1300)]
Fix tests to not notice when faking form flow
Eileen McNaughton [Fri, 17 Nov 2023 00:19:21 +0000 (13:19 +1300)]
Reformat whitespace in online membership receipt
Seamus Lee [Fri, 17 Nov 2023 00:43:41 +0000 (11:43 +1100)]
Merge pull request #28172 from eileenmcnaughton/mem_online
Fix setting of misnamed property
colemanw [Thu, 16 Nov 2023 02:23:01 +0000 (21:23 -0500)]
Afform - Namespace mock tests for autoloading
Eileen McNaughton [Thu, 16 Nov 2023 20:53:38 +0000 (09:53 +1300)]
Fix tax total not showing on thank you
Eileen McNaughton [Thu, 16 Nov 2023 22:13:55 +0000 (11:13 +1300)]
Fix membership online preview to display subject (using token)
Eileen McNaughton [Thu, 16 Nov 2023 23:02:02 +0000 (12:02 +1300)]
Merge pull request #28170 from totten/5.68-mixin-since
(NFC) setting-admin@1 - Fix the `@since` metadata
Aidan Saunders [Thu, 16 Nov 2023 22:26:46 +0000 (22:26 +0000)]
Merge pull request #28173 from mattwire/contnewtab
Manage Contribution Pages: Open Live/Test page in new tab like old screen
Matthew Wire [Thu, 16 Nov 2023 21:04:46 +0000 (21:04 +0000)]
Manage Contribution Pages: Open Live/Test page in new tab like old screen
Eileen McNaughton [Thu, 16 Nov 2023 20:45:10 +0000 (09:45 +1300)]
Fix setting of misnamed property
The property is ID, not id
Tim Otten [Thu, 16 Nov 2023 20:00:00 +0000 (12:00 -0800)]
setting-admin@1 - Raise version to 1.1.0
The original implementation uses some small niceties that don't backport well. Let's call this 1.1.x.
I've got a separate variant that backports better. We'll call that 1.0.x.
Tim Otten [Thu, 16 Nov 2023 19:33:13 +0000 (11:33 -0800)]
(NFC) setting-admin@1 - Fix the `@since` metadata
The code was originally written during 5.67.alpha1 and then merged during
5.68.alpha. So the `@since` is slightly off.
demeritcowboy [Thu, 16 Nov 2023 15:43:00 +0000 (10:43 -0500)]
Merge pull request #28139 from mlutfy/l10nPartTwo
setup: Allow language selection regardless of whether languages are available
demeritcowboy [Thu, 16 Nov 2023 02:16:32 +0000 (21:16 -0500)]
Merge pull request #28163 from seamuslee001/notice_fixes_contribution_edit
[REF] Fix Smarty Notice Errors on Contribution Edit
Seamus Lee [Thu, 16 Nov 2023 01:31:44 +0000 (12:31 +1100)]
Merge pull request #28076 from eileenmcnaughton/parse
Clarify that the values passed are the submitted values, not altered values
Eileen McNaughton [Thu, 16 Nov 2023 01:25:31 +0000 (14:25 +1300)]
Merge pull request #28161 from totten/master-allflowstest
(REF) Authx - Split `AllFlowsTest` into smaller, themetic tests
Seamus Lee [Thu, 16 Nov 2023 00:50:56 +0000 (11:50 +1100)]
Merge pull request #28159 from civicrm/5.68
5.68
Seamus Lee [Thu, 16 Nov 2023 00:50:33 +0000 (11:50 +1100)]
Merge pull request #28160 from wikimediaWfan/upstream
Update Merger.php to compare strict type for checkboxes where a dummy…
Seamus Lee [Thu, 16 Nov 2023 00:36:56 +0000 (11:36 +1100)]
[REF] Fix Smarty Notice Errors on Contribution Edit
Tim Otten [Thu, 16 Nov 2023 00:04:24 +0000 (16:04 -0800)]
(REF) Split `AllFlowsTest` into smaller, thematic tests
wfan [Thu, 16 Nov 2023 00:04:07 +0000 (16:04 -0800)]
Update Merger.php to compare strict type for checkboxes where a dummy-string is being used, to prevent this matching 'true'
Seamus Lee [Thu, 16 Nov 2023 00:00:37 +0000 (11:00 +1100)]
Merge pull request #28137 from colemanw/havingFix
APIv4 - Fix index interfering with HAVING
Seamus Lee [Wed, 15 Nov 2023 23:42:31 +0000 (10:42 +1100)]
Merge pull request #28158 from seamuslee001/regen_28144
[REF] Regen after #28144
Tim Otten [Wed, 15 Nov 2023 23:24:28 +0000 (15:24 -0800)]
(REF) Extract base class `AbstractFlowsTest`
Aidan Saunders [Wed, 15 Nov 2023 22:58:29 +0000 (22:58 +0000)]
Merge pull request #28150 from colemanw/today
[REF] APIv4 - Minor cleanup of redundant variables
Seamus Lee [Wed, 15 Nov 2023 22:38:51 +0000 (09:38 +1100)]
[REF] Regen after #28144
Seamus Lee [Wed, 15 Nov 2023 22:35:28 +0000 (09:35 +1100)]
Merge pull request #28144 from eileenmcnaughton/online_receipt
Replace math in template with variable, smarty3 support
Seamus Lee [Wed, 15 Nov 2023 22:34:43 +0000 (09:34 +1100)]
Merge pull request #28140 from eileenmcnaughton/event_text
Remove last references to `_contributeMode`
Seamus Lee [Wed, 15 Nov 2023 21:25:03 +0000 (08:25 +1100)]
Merge pull request #28155 from totten/master-localtasks
Page Templates - Remove unused `$localTasks` (`localNav.tpl`)
demeritcowboy [Wed, 15 Nov 2023 21:03:21 +0000 (16:03 -0500)]
Merge pull request #28154 from civicrm/5.68
5.68
Tim Otten [Wed, 15 Nov 2023 20:19:38 +0000 (12:19 -0800)]
Page Templates - Remove unused `$localTasks` (`localNav.tpl`)
Seamus Lee [Wed, 15 Nov 2023 20:10:59 +0000 (07:10 +1100)]
Merge pull request #28153 from demeritcowboy/menu-missing
dev/core#4778 - php notice causes civi menu to go missing
demeritcowboy [Wed, 15 Nov 2023 20:01:38 +0000 (15:01 -0500)]
Merge pull request #28000 from seamuslee001/guzzle_update
Update Guzzle to 7.6.1 for Drupal 7/Backdrop/WordPress/Joomla
colemanw [Tue, 14 Nov 2023 18:40:29 +0000 (13:40 -0500)]
APIv4 - Fix index interfering with HAVING
It's not always safe to delete items from the SELECT clause... so let's not.
Fixes dev/core#4017
demeritcowboy [Wed, 15 Nov 2023 19:10:28 +0000 (14:10 -0500)]
php notice
demeritcowboy [Wed, 15 Nov 2023 18:38:54 +0000 (13:38 -0500)]
Merge pull request #28143 from eileenmcnaughton/online_cont_tax_check
Add test cover for tax details in Dummy payment online contribution receipt
demeritcowboy [Wed, 15 Nov 2023 18:03:44 +0000 (13:03 -0500)]
Merge pull request #28149 from civicrm/5.68
5.68
colemanw [Wed, 15 Nov 2023 16:34:45 +0000 (11:34 -0500)]
APIv4 - Minor cleanup of redundant variables
Is it just me, or does staring at the word today for too long stop making sense?
demeritcowboy [Wed, 15 Nov 2023 16:16:23 +0000 (11:16 -0500)]
Merge pull request #28136 from ErikHommel/master
fix issue #4770 Ensure the followup_assignee_contact_id is an array so all assignees are saved, not just the first one
colemanw [Wed, 15 Nov 2023 16:11:12 +0000 (11:11 -0500)]
Merge pull request #28145 from colemanw/parentNames
dev/core#4740 - Fix missing tagsets when label doesn't match name
Mathieu Lu [Wed, 15 Nov 2023 14:38:16 +0000 (09:38 -0500)]
Merge pull request #28117 from demeritcowboy/casedashboard-warnings2
[php8] php warnings on case dashboard
demeritcowboy [Wed, 15 Nov 2023 14:03:30 +0000 (09:03 -0500)]
Merge pull request #28146 from seamuslee001/fix_tests
[REF] Fix test fails caused by changes to mailing footer
colemanw [Wed, 15 Nov 2023 13:54:30 +0000 (08:54 -0500)]
Merge pull request #28070 from eileenmcnaughton/participant_backoffice
Clean up contributionParams - backoffice participant form
Erik Hommel [Wed, 15 Nov 2023 13:42:38 +0000 (14:42 +0100)]
fix on review
Co-authored-by: demeritcowboy <demeritcowboy@hotmail.com>
Tim Otten [Wed, 15 Nov 2023 07:55:45 +0000 (00:55 -0700)]
Merge pull request #28119 from lcdservices/dev-core-4772
dev/core#4772 fix authx on Joomla
Seamus Lee [Wed, 15 Nov 2023 05:05:16 +0000 (16:05 +1100)]
[REF] Fix test fails caused by changes to mailing footer
Seamus Lee [Thu, 2 Nov 2023 21:51:06 +0000 (08:51 +1100)]
Update Guzzle to 7.6.1 for Drupal 7/Backdrop/WordPress/Joomla
colemanw [Wed, 15 Nov 2023 01:10:38 +0000 (20:10 -0500)]
dev/core#4740 - Fix missing tagsets when label doesn't match name
CRM_Core_Form_Tag::buildQuickForm was previously being passed an array of [id => name]
but it was wastefully ignoring the passed ids and looking it up from the name.
Now due to
bcf668d is being passed an array of [id => label] which is all it needs,
just had to remove the wasteful id lookup when it's already there.
Eileen McNaughton [Wed, 15 Nov 2023 01:07:09 +0000 (14:07 +1300)]
Merge pull request #28142 from eileenmcnaughton/notice_cms
Fix notice on showCMS:
colemanw [Wed, 15 Nov 2023 00:48:55 +0000 (19:48 -0500)]
Merge pull request #28133 from colemanw/civiCasePerms
dev/core#4769 APIv4 - Fix access to case activities for administrators
Eileen McNaughton [Tue, 14 Nov 2023 23:21:37 +0000 (12:21 +1300)]
Merge pull request #28141 from eileenmcnaughton/object_notice
Fix notice on payment processor object
Eileen McNaughton [Tue, 14 Nov 2023 22:59:59 +0000 (11:59 +1300)]
Replace math in template with variable, smarty3 support
The handling for math in smarty2 & 3 differs wrt precedence, when used
with a modifier. It's a bit tricky supporting both but in this
case we can simply rely on another key in the array that already exists
and is equivalent
Note that the membership online template is excluded deliberately for now
as it does not currently access the same lineItems variable
as all the other templates
Eileen McNaughton [Tue, 14 Nov 2023 22:52:28 +0000 (11:52 +1300)]
Add test cover for tax details in Dummy payment online contribution receipt
Eileen McNaughton [Tue, 14 Nov 2023 22:27:38 +0000 (11:27 +1300)]
Fix notice on showCMS:
Eileen McNaughton [Tue, 14 Nov 2023 22:22:28 +0000 (11:22 +1300)]
Fix notice on payment processor object
demeritcowboy [Tue, 14 Nov 2023 22:10:57 +0000 (17:10 -0500)]
Merge pull request #28138 from eileenmcnaughton/online_cont_tax_check
Check tax is present in online contribution page receipt
Eileen McNaughton [Tue, 14 Nov 2023 21:39:44 +0000 (10:39 +1300)]
Remove last references to _contributeMode
Eileen McNaughton [Tue, 14 Nov 2023 21:35:56 +0000 (10:35 +1300)]
Merge pull request #28065 from eileenmcnaughton/event_text
Replace last tpl uses of `contributeMode`
Eileen McNaughton [Tue, 14 Nov 2023 19:27:48 +0000 (08:27 +1300)]
Check tax is present in online contribution page receipt
Eileen McNaughton [Fri, 22 Sep 2023 22:27:22 +0000 (10:27 +1200)]
Replace last tpl uses of contributeMode
This adds the strings to what the processor can determin, allowing us to stop checkign contributeMode
Mathieu Lu [Tue, 14 Nov 2023 20:44:14 +0000 (15:44 -0500)]
Merge pull request #28053 from agileware/CIVICRM-2190
Default mailing footer component incorrectly describes opt-out action as unsubscribe