Tim Otten [Wed, 1 Feb 2023 06:00:39 +0000 (22:00 -0800)]
CRM_Upgrade_Headless - The pre-up and post-up msgs should have same formatting
Tim Otten [Wed, 1 Feb 2023 05:43:43 +0000 (21:43 -0800)]
Merge pull request #25414 from seamuslee001/headless_pre_upgrade
[REF] Add in function to retrieve Pre Upgrade messages in headless
demeritcowboy [Wed, 1 Feb 2023 01:53:26 +0000 (20:53 -0500)]
Merge pull request #25484 from civicrm/5.58
5.58
demeritcowboy [Wed, 1 Feb 2023 01:53:16 +0000 (20:53 -0500)]
Merge pull request #25478 from braders/dynamic-properties-contact-test
[REF][PHP8.2] Declare properties in CRM_Contact_BAO_ContactType_ContactTest
demeritcowboy [Wed, 1 Feb 2023 00:58:03 +0000 (19:58 -0500)]
Merge pull request #25482 from mattwire/25232search
Fix internal server error when calling GetSearchTasks
Tim Otten [Tue, 31 Jan 2023 23:17:26 +0000 (15:17 -0800)]
Merge pull request #25481 from demeritcowboy/dot
Fix typo in upgrade message
Tim Otten [Tue, 31 Jan 2023 23:17:03 +0000 (15:17 -0800)]
Merge pull request #25483 from civicrm/5.58
5.58
Tim Otten [Tue, 31 Jan 2023 22:54:20 +0000 (14:54 -0800)]
Merge pull request #25477 from christianwach/userdata
Prevent PHP warnings when no WordPress user is found
Seamus Lee [Tue, 31 Jan 2023 21:18:13 +0000 (08:18 +1100)]
Merge pull request #25455 from braders/dynmaic-properties-entrytest
[REF][PHP8.2] Tidy up CRM_Batch_Form_EntryTest
Eileen McNaughton [Tue, 31 Jan 2023 21:14:42 +0000 (10:14 +1300)]
Merge pull request #25480 from demeritcowboy/err
Fix exception type in upgrade snapshot
Matthew Wire [Tue, 31 Jan 2023 21:03:19 +0000 (21:03 +0000)]
Fix internal server error when calling GetSearchTasks
Eileen McNaughton [Tue, 31 Jan 2023 20:45:34 +0000 (09:45 +1300)]
Merge pull request #25479 from braders/CustomValueContactTypeTest-tidy
[REF][PHP8.2] Tidy, and PHP8.2 compatiability for api_v3_CustomValueContactTypeTest
Eileen McNaughton [Tue, 31 Jan 2023 20:43:50 +0000 (09:43 +1300)]
Merge pull request #25456 from MegaphoneJon/lifetime-membership-fix-1
simplify calculation of lifetime memberships in CRM_Price_BAO_PriceSet
demeritcowboy [Tue, 31 Jan 2023 20:20:38 +0000 (15:20 -0500)]
typo
demeritcowboy [Tue, 31 Jan 2023 20:15:49 +0000 (15:15 -0500)]
fix exception type
Bradley Taylor [Tue, 31 Jan 2023 19:38:39 +0000 (19:38 +0000)]
[REF][PHP8.2] Tidy, and PHP8.2 compatiability for api_v3_CustomValueContactTypeTest
Matthew Wire [Tue, 31 Jan 2023 19:27:51 +0000 (19:27 +0000)]
Merge pull request #25427 from eileenmcnaughton/notice_import
Regression fix - fieldSeparator lost in 5.58 import screens
Bradley Taylor [Tue, 31 Jan 2023 19:11:47 +0000 (19:11 +0000)]
[REF][PHP8.2] Declare properties in CRM_Contact_BAO_ContactType_ContactTest
Bradley Taylor [Sun, 29 Jan 2023 11:28:00 +0000 (11:28 +0000)]
[REF][PHP8.2] Tidy up CRM_Batch_Form_EntryTest
colemanw [Tue, 31 Jan 2023 18:23:28 +0000 (13:23 -0500)]
Merge pull request #25420 from eileenmcnaughton/snap
Fix slow queries in snapshot process
colemanw [Tue, 31 Jan 2023 18:23:00 +0000 (13:23 -0500)]
Merge pull request #25473 from eileenmcnaughton/email
dev/core#4096 Rename Primary Email to Is Primary
colemanw [Tue, 31 Jan 2023 15:37:09 +0000 (10:37 -0500)]
Merge pull request #25433 from eileenmcnaughton/sk_admin
Do not crash the whole SearchKit UI if one entity fails
Jon Goldberg [Sun, 29 Jan 2023 22:00:35 +0000 (17:00 -0500)]
simplify calculation of lifetime memberships in CRM_Price_BAO_PriceSet
Christian Wach [Tue, 31 Jan 2023 10:39:32 +0000 (10:39 +0000)]
Prevent PHP warnings when no WordPress user is found
Yashodha Chaku [Tue, 31 Jan 2023 08:30:05 +0000 (14:00 +0530)]
Merge pull request #25475 from dontub/update-contributor-key
Add dontub to contributor-key.yml
Dominic Tubach [Tue, 31 Jan 2023 08:18:31 +0000 (09:18 +0100)]
Add dontub to contributor-key.yml
Eileen McNaughton [Tue, 31 Jan 2023 04:15:46 +0000 (17:15 +1300)]
dev/core#4096 Rename Primary Email to Is Primary
This field caused us problems because people mistook it
for .... the primary email field.... Renaming per agreement
on gitlab
Tim Otten [Tue, 31 Jan 2023 02:36:09 +0000 (18:36 -0800)]
(NFC) CRM/Upgrade/Snapshot.php - Work-around for bug in linter
The linter for `@return` has a bug; it expects to see a `return`
and doesn't recognize the `yield` notation (which is radically new,
having been added in PHP 5.5 circa 2013).
Mathieu Lu [Tue, 31 Jan 2023 02:28:20 +0000 (21:28 -0500)]
Merge pull request #25418 from eileenmcnaughton/imap
Increase timeout on imap
Tim Otten [Tue, 31 Jan 2023 01:51:09 +0000 (17:51 -0800)]
Merge pull request #25460 from eileenmcnaughton/558
dev/core#4063 fix lack of count info on soft credit listing
Eileen McNaughton [Tue, 31 Jan 2023 01:10:12 +0000 (14:10 +1300)]
Merge pull request #25468 from civicrm/5.58
5.58 to master
Eileen McNaughton [Tue, 31 Jan 2023 01:08:23 +0000 (14:08 +1300)]
Merge pull request #25467 from demeritcowboy/resubscribe
Some renames missing from #24982
demeritcowboy [Tue, 31 Jan 2023 01:03:49 +0000 (20:03 -0500)]
earlier rename missing this one
demeritcowboy [Tue, 31 Jan 2023 00:32:49 +0000 (19:32 -0500)]
Merge pull request #25334 from eileenmcnaughton/string_exception
Ensure useful exception thrown for all Smarty errors from user strings
Eileen McNaughton [Mon, 30 Jan 2023 01:04:26 +0000 (14:04 +1300)]
Add preUpgrade message
Seamus Lee [Mon, 30 Jan 2023 21:19:56 +0000 (08:19 +1100)]
Merge pull request #25463 from demeritcowboy/profile-null
php8 - don't pass null to htmlspecialchars on profile admin page
Eileen McNaughton [Thu, 12 Jan 2023 04:42:00 +0000 (17:42 +1300)]
Ensure useful exception thrown for all Smarty errors from user strings
Eileen McNaughton [Mon, 30 Jan 2023 20:54:06 +0000 (09:54 +1300)]
Merge pull request #25462 from demeritcowboy/number
dev/core#4097 - Add deprecation notice as per comments at #25448
demeritcowboy [Mon, 30 Jan 2023 18:11:25 +0000 (13:11 -0500)]
Merge pull request #25453 from eileenmcnaughton/notice_no_display
Smarty notice fix - check array key exists before querying
demeritcowboy [Mon, 30 Jan 2023 17:44:38 +0000 (12:44 -0500)]
don't pass null to htmlspecialchars
demeritcowboy [Mon, 30 Jan 2023 15:56:07 +0000 (10:56 -0500)]
Merge pull request #25323 from herbdool/core-4074
(dev/core#4074) Make CRM_Core_BAO_CMSUser CMS agnostic
demeritcowboy [Mon, 30 Jan 2023 13:12:38 +0000 (08:12 -0500)]
add deprecation notice
demeritcowboy [Mon, 30 Jan 2023 13:09:13 +0000 (08:09 -0500)]
Merge pull request #25448 from redcuillin/stringfix_formatLocaleNumeric
dev/core#4097 Fix empty string $amount error
Yashodha Chaku [Mon, 30 Jan 2023 09:13:21 +0000 (14:43 +0530)]
Merge pull request #25452 from eileenmcnaughton/notice
Report tpl enotices fix
Eileen McNaughton [Mon, 30 Jan 2023 04:41:16 +0000 (17:41 +1300)]
dev/core#4063 fix lack of count info on soft credit listing
https://lab.civicrm.org/dev/core/-/issues/4063
Seamus Lee [Mon, 30 Jan 2023 01:13:04 +0000 (12:13 +1100)]
Merge pull request #25459 from eileenmcnaughton/is_test
Fix some more smarty assignments to assign even when FALSE
Eileen McNaughton [Sun, 29 Jan 2023 23:29:22 +0000 (12:29 +1300)]
Fix some more smarty assignments to assign even when FALSE
Eileen McNaughton [Sun, 29 Jan 2023 00:26:34 +0000 (13:26 +1300)]
Another array_key_exists check for notice purposes
demeritcowboy [Sun, 29 Jan 2023 00:24:55 +0000 (19:24 -0500)]
Merge pull request #25451 from eileenmcnaughton/num
Do not attempt to format custom value of empty string
Eileen McNaughton [Sun, 29 Jan 2023 00:19:46 +0000 (13:19 +1300)]
Smarty notice fix - check array key exists before querying
Eileen McNaughton [Sun, 29 Jan 2023 00:09:22 +0000 (13:09 +1300)]
Report tpl enotice fix
Eileen McNaughton [Sat, 28 Jan 2023 23:35:19 +0000 (12:35 +1300)]
Do not attempt to format custom value of empty string
Seamus Lee [Sat, 28 Jan 2023 22:12:37 +0000 (09:12 +1100)]
Merge pull request #25450 from braders/tidyup-detail-test
[REF][PHP8.2] Tidy up of CRM_Report_Form_Member_DetailTest
Seamus Lee [Sat, 28 Jan 2023 22:11:55 +0000 (09:11 +1100)]
Merge pull request #25447 from braders/properties-hooktest
[REF][PHP8.2] Declare missing property on CRM_Utils_HookTest
Bradley Taylor [Sat, 28 Jan 2023 20:28:37 +0000 (20:28 +0000)]
[REF][PHP8.2] Tidy up of CRM_Report_Form_Member_DetailTest
Bradley Taylor [Fri, 27 Jan 2023 20:49:41 +0000 (20:49 +0000)]
[REF][PHP8.2] Declare missing property on CRM_Utils_HookTest
demeritcowboy [Sat, 28 Jan 2023 19:25:15 +0000 (14:25 -0500)]
Merge pull request #25449 from braders/dynamic-properties-participant-test
[REF][PHP8.2] Avoid dynamic properties in CRM_Event_BAO_ParticipantTest
demeritcowboy [Sat, 28 Jan 2023 19:22:21 +0000 (14:22 -0500)]
Merge pull request #25426 from seamuslee001/php82_payment_insturment_contribution
[REF][PHP8.2] Fix Dynamic property payment instrument id on back offi…
Bradley Taylor [Sat, 28 Jan 2023 13:30:49 +0000 (13:30 +0000)]
[REF][PHP8.2] Avoid dynamic properties in CRM_Event_BAO_ParticipantTest
redcuillin [Sat, 28 Jan 2023 04:11:26 +0000 (04:11 +0000)]
Fix empty string $amount error
demeritcowboy [Fri, 27 Jan 2023 22:50:00 +0000 (17:50 -0500)]
Merge pull request #25440 from dontub/fix/Case-CustomDataView
Fix display of custom data in cases
Herb v/d Dool [Wed, 11 Jan 2023 18:06:31 +0000 (13:06 -0500)]
dev/core#4074 make CRM_Core_BAO_CMSUser CMS agnostic
demeritcowboy [Fri, 27 Jan 2023 21:38:00 +0000 (16:38 -0500)]
Merge pull request #25419 from mlutfy/l10nExt
dev/translation#76 Allow extension gettext mo files to live in the I18N resource dir
demeritcowboy [Fri, 27 Jan 2023 21:33:55 +0000 (16:33 -0500)]
Merge pull request #25371 from herbdool/backdrop-77
(dev/backdrop#77) Fix fatal error with password validation
Seamus Lee [Thu, 26 Jan 2023 23:23:44 +0000 (10:23 +1100)]
Merge pull request #25409 from colemanw/entityAutocomplete
APIv4 - Support autocompletes of the Entity entity
Tim Otten [Thu, 26 Jan 2023 21:38:42 +0000 (13:38 -0800)]
Merge pull request #25401 from braders/declare-system-properties
[REF][PHP8.2] Declare system property in tests
Tim Otten [Thu, 26 Jan 2023 21:37:49 +0000 (13:37 -0800)]
Merge pull request #25439 from totten/master-test-tx
(NFC) Speed up random tests by 55-60%
Tim Otten [Thu, 26 Jan 2023 21:36:52 +0000 (13:36 -0800)]
Merge pull request #25405 from braders/dynamic-property-infotest
[REF][PHP8.2] Declare file property in CRM_Extension_InfoTest
Tim Otten [Thu, 26 Jan 2023 20:38:03 +0000 (12:38 -0800)]
Merge pull request #25443 from braders/dynamic-properties-ajaxtest
[REF][PHP8.2] Declare properties in CRM_Activity_Page_AJAXTest
Tim Otten [Thu, 26 Jan 2023 20:37:32 +0000 (12:37 -0800)]
Merge pull request #25442 from braders/dynamic-property-casetest
[REF][PHP8.2] Refactor CRM_Case_BAO_CaseTest to use const
Bradley Taylor [Thu, 26 Jan 2023 19:46:54 +0000 (19:46 +0000)]
[REF][PHP8.2] Declare properties in CRM_Activity_Page_AJAXTest
Bradley Taylor [Thu, 26 Jan 2023 19:33:35 +0000 (19:33 +0000)]
[REF][PHP8.2] Refactor CRM_Case_BAO_CaseTest to use const
Dominic Tubach [Thu, 26 Jan 2023 12:08:52 +0000 (13:08 +0100)]
Fix display of custom data in cases
Tim Otten [Thu, 26 Jan 2023 09:03:05 +0000 (01:03 -0800)]
(NFC) Speed up more random tests, part 4 (58s=>29s)
Tim Otten [Thu, 26 Jan 2023 08:51:33 +0000 (00:51 -0800)]
(NFC) Speed up more random tests, part 3 (26s=>15s)
Tim Otten [Thu, 26 Jan 2023 08:47:27 +0000 (00:47 -0800)]
(NFC) Speed up more random tests, part 2
Tim Otten [Thu, 26 Jan 2023 08:46:50 +0000 (00:46 -0800)]
(NFC) Speed up more random tests
Tim Otten [Thu, 26 Jan 2023 08:07:43 +0000 (00:07 -0800)]
(NFC) ArrayTest - Speed up ~50%
Before: On local i3-12100, takes ~17s (avg over two runs)
After: On local i3-12100, take ~8s (avg over two runs)
Tim Otten [Thu, 26 Jan 2023 08:05:32 +0000 (00:05 -0800)]
(NFC) StringTest - Speed up ~60%
Before: On local i3-12100, takes ~34s (avg over two runs)
After: On local i3-12100, take ~14s (avg over two runs)
Tim Otten [Thu, 26 Jan 2023 08:01:58 +0000 (00:01 -0800)]
(NFC) JSTest - Speed up ~60%
Before: On local i3-12100, takes ~34s (avg over two runs)
After: On local i3-12100, take ~14s (avg over two runs)
Tim Otten [Thu, 26 Jan 2023 07:57:12 +0000 (23:57 -0800)]
(NFC) RuleTest - Speed up ~55%
Before: On local i3-12100, takes ~64s (avg over two runs)
After: On local i3-12100, take ~28s (avg over two runs)
Tim Otten [Thu, 26 Jan 2023 07:42:16 +0000 (23:42 -0800)]
(NFC) DateTest - Speed up ~55%
Before: On local i3-12100, takes ~90s (avg over 2 runs)
After: On local i3-12100, take ~40s (avg over 2 runs)
Tim Otten [Thu, 26 Jan 2023 07:20:51 +0000 (23:20 -0800)]
Merge pull request #25435 from totten/5.58-upgrade-msg
Upgrade - Simplify call to action. Use URL redirect.
Tim Otten [Thu, 26 Jan 2023 07:08:06 +0000 (23:08 -0800)]
Merge pull request #25437 from totten/5.58-status-constraint
Status Checks - Add alert for bad foreign key
Tim Otten [Thu, 26 Jan 2023 05:59:12 +0000 (21:59 -0800)]
Merge pull request #25410 from larssandergreen/Fix-missing-default-values-for-required-fields-in-event-registration-setup
CiviEvent - Fix missing default values for required fields in event registration setup
Tim Otten [Thu, 26 Jan 2023 05:50:24 +0000 (21:50 -0800)]
Status Checks - Add alert for bad foreign key
Tim Otten [Thu, 26 Jan 2023 05:09:05 +0000 (21:09 -0800)]
FiveFiftySeven - Simplify call to action.
Tim Otten [Thu, 26 Jan 2023 04:33:11 +0000 (20:33 -0800)]
FiveFiftySeven - Point static link to adjustable redirect
larssandergreen [Thu, 26 Jan 2023 04:20:52 +0000 (21:20 -0700)]
Add required field to test data
Tim Otten [Thu, 26 Jan 2023 03:56:35 +0000 (19:56 -0800)]
Event Registration - Treat omission-by-unset and omission-by-blank-string as the same problem
Eileen McNaughton [Thu, 26 Jan 2023 03:19:18 +0000 (16:19 +1300)]
Do not crash the whole SearchKit UI if one entity fails
Eileen McNaughton [Thu, 26 Jan 2023 00:41:03 +0000 (13:41 +1300)]
Fix fieldSeparator field missing / notice regression
Seamus Lee [Thu, 26 Jan 2023 00:35:48 +0000 (00:35 +0000)]
[REF][PHP8.2] Fix Dynamic property payment instrument id on back office contribution form
Eileen McNaughton [Thu, 26 Jan 2023 00:03:00 +0000 (13:03 +1300)]
Superficial cleanup
Seamus Lee [Wed, 25 Jan 2023 23:39:28 +0000 (10:39 +1100)]
Merge pull request #25425 from civicrm/5.58
5.58
colemanw [Wed, 25 Jan 2023 23:04:15 +0000 (18:04 -0500)]
Merge pull request #25412 from eileenmcnaughton/api4trait
dev/core#4088 Convert api4 helper functionality to a trait & make available
Eileen McNaughton [Wed, 25 Jan 2023 22:55:31 +0000 (11:55 +1300)]
Merge pull request #25421 from aydun/fix_core_4095
dev/core#4095 - update log schema of civicrm_option_group before adding values
Seamus Lee [Wed, 25 Jan 2023 22:39:59 +0000 (09:39 +1100)]
Merge pull request #25424 from totten/5.58-json-wp
distmaker - Fix 'WordPress' entry in JSON report
Seamus Lee [Wed, 25 Jan 2023 22:36:54 +0000 (09:36 +1100)]
Merge pull request #25423 from seamuslee001/5.58
[REF] Bump UA Parser to 0.7.33
Tim Otten [Wed, 25 Jan 2023 22:18:18 +0000 (14:18 -0800)]
distmaker - Fix 'WordPress' entry in JSON report