colemanw [Wed, 1 Dec 2021 01:19:44 +0000 (20:19 -0500)]
Merge pull request #22184 from eileenmcnaughton/smarty10
[Smarty variables] Remove isset from add new group form
colemanw [Wed, 1 Dec 2021 00:04:00 +0000 (19:04 -0500)]
Merge pull request #22164 from eileenmcnaughton/parent
Remove empty check previously commented to be meaningless
Eileen McNaughton [Tue, 30 Nov 2021 23:27:55 +0000 (12:27 +1300)]
Merge pull request #22178 from demeritcowboy/custom-null
dev/core#2973 - All custom fields broken on edit forms
demeritcowboy [Tue, 30 Nov 2021 22:30:25 +0000 (17:30 -0500)]
Merge pull request #22081 from colemanw/searchKitSortable
SearchKit - Add drag-sortable weight functionality
Eileen McNaughton [Tue, 30 Nov 2021 21:27:26 +0000 (10:27 +1300)]
Remove isset from add new group form
civicrm/group/add?reset=1
demeritcowboy [Tue, 30 Nov 2021 20:26:11 +0000 (15:26 -0500)]
fix custom fields
Eileen McNaughton [Tue, 30 Nov 2021 19:40:13 +0000 (08:40 +1300)]
Merge pull request #21232 from colemanw/APIDelete
APIv4 - Use correct BAO delete function (fixes dev/core#2757)
colemanw [Tue, 30 Nov 2021 18:56:44 +0000 (13:56 -0500)]
Merge pull request #22171 from civicrm/5.44
5.44
colemanw [Tue, 30 Nov 2021 18:55:42 +0000 (13:55 -0500)]
Merge pull request #22170 from colemanw/fixSearchKitOptions
SearchKit - Fix regression for pseudoconstant selection
Coleman Watts [Sun, 29 Aug 2021 16:17:05 +0000 (12:17 -0400)]
APIv4 - Add useTrash option to soft-delete contacts
This sets Contact::delete to move contacts to the trash by default.
Coleman Watts [Mon, 23 Aug 2021 21:40:35 +0000 (17:40 -0400)]
APIv4 - Use correct BAO delete function
Uses BAO::del() only if it isn't deprecated.
Coleman Watts [Tue, 30 Nov 2021 17:02:47 +0000 (12:02 -0500)]
SearchKit - Fix regression for pseudoconstant selection
Fixes dev/report#83
Coleman Watts [Mon, 15 Nov 2021 14:47:37 +0000 (09:47 -0500)]
SearchKit - Add drag-sortable weight functionality
Drag-sortable weights are similar to in-place edit in that it uses the API
to update records in the table. In this case it updates the "weight" column when
the user drags a row into a different position.
colemanw [Tue, 30 Nov 2021 14:28:28 +0000 (09:28 -0500)]
Merge pull request #22169 from demeritcowboy/oauth-dropdown
dev/mail#105 - Oauth dropdown missing on mail settings form
demeritcowboy [Tue, 30 Nov 2021 13:26:04 +0000 (08:26 -0500)]
Merge pull request #22161 from eileenmcnaughton/pay_test2
Fix more tests to use full flow
demeritcowboy [Tue, 30 Nov 2021 13:21:31 +0000 (08:21 -0500)]
Merge pull request #22143 from mattwire/statuspagehigherfirst
Display higher severity status checks first
Yashodha Chaku [Tue, 30 Nov 2021 07:52:59 +0000 (13:22 +0530)]
Merge pull request #22142 from mattwire/envokextensionsnatcase
Sort list of extensions alphabetically in 'Extensions ok' check
Seamus Lee [Tue, 30 Nov 2021 04:28:26 +0000 (15:28 +1100)]
Merge pull request #22168 from demeritcowboy/useajax
Fix broken extension page smarty assignment
Seamus Lee [Tue, 30 Nov 2021 04:28:16 +0000 (15:28 +1100)]
Merge pull request #22167 from eileenmcnaughton/location_tpl
[Smarty Variables] Remove isset from location type form
colemanw [Tue, 30 Nov 2021 03:15:21 +0000 (22:15 -0500)]
Merge pull request #22166 from eileenmcnaughton/isset
[Smarty variables] Remove issets from scheduled job screen
Eileen McNaughton [Tue, 30 Nov 2021 00:02:43 +0000 (13:02 +1300)]
[Smarty Variables] Remove isset from location type form
https://dmaster.localhost:32353/civicrm/admin/locationType?reset=1
Eileen McNaughton [Tue, 30 Nov 2021 01:24:35 +0000 (14:24 +1300)]
Merge pull request #22162 from eileenmcnaughton/pay_test
Fix membership test to use full flow
demeritcowboy [Tue, 30 Nov 2021 01:22:03 +0000 (20:22 -0500)]
oauth dropdown missing on mail settings form
demeritcowboy [Tue, 30 Nov 2021 00:47:43 +0000 (19:47 -0500)]
fix smarty
Eileen McNaughton [Mon, 29 Nov 2021 23:36:49 +0000 (12:36 +1300)]
[Smarty variables] Remove issets from scheduled job screen
Eileen McNaughton [Mon, 29 Nov 2021 23:30:30 +0000 (12:30 +1300)]
Remove isset previously commented to be meaningless
colemanw [Mon, 29 Nov 2021 23:09:03 +0000 (18:09 -0500)]
Merge pull request #22074 from eileenmcnaughton/tags
[Smarty variables] Ensure groupElementType is always set
colemanw [Mon, 29 Nov 2021 23:08:07 +0000 (18:08 -0500)]
Merge pull request #22132 from eileenmcnaughton/test_con
[Smarty variables] [contact summary] Assign variable to determine whether to show email signature field
colemanw [Mon, 29 Nov 2021 23:07:39 +0000 (18:07 -0500)]
Merge pull request #22138 from eileenmcnaughton/cust_edit
[Smarty variables] [custom data form] Template notice cleanup - make sane
Eileen McNaughton [Mon, 29 Nov 2021 23:05:47 +0000 (12:05 +1300)]
Fix more tests to use full flow
Eileen McNaughton [Mon, 29 Nov 2021 23:06:05 +0000 (12:06 +1300)]
Fix membership test to use full flow
colemanw [Mon, 29 Nov 2021 23:06:10 +0000 (18:06 -0500)]
Merge pull request #22147 from eileenmcnaughton/pager
[Smarty variables] [report test]Ensure smarty variables are consistently assigned in report
colemanw [Mon, 29 Nov 2021 23:05:43 +0000 (18:05 -0500)]
Merge pull request #22152 from eileenmcnaughton/n1
[Smarty variables] [Activity form] Ensure separation,tag are assigned to the template
colemanw [Mon, 29 Nov 2021 23:04:36 +0000 (18:04 -0500)]
Merge pull request #22155 from eileenmcnaughton/n4
[Smarty variables] Specify isRepeatingEntity when including ConfirmRepeatMode.tpl
colemanw [Mon, 29 Nov 2021 23:02:02 +0000 (18:02 -0500)]
Merge pull request #22160 from colemanw/navigationPermission
APIv4 - Treat navigation permissions as array, add pseudoconstant for operator
Eileen McNaughton [Mon, 29 Nov 2021 21:46:08 +0000 (10:46 +1300)]
Merge pull request #22137 from colemanw/api4SortableEntity
APIv4 - Add SortableEntity type which auto-adjusts weights
Coleman Watts [Mon, 29 Nov 2021 19:26:35 +0000 (14:26 -0500)]
APIv4 - Treat navigation permissions as array, add pseudoconstant for operator
This gives consistency in how the fields are handled in the Navigation and Dashboard entities
colemanw [Mon, 29 Nov 2021 21:12:42 +0000 (16:12 -0500)]
Merge pull request #22121 from colemanw/bridgeEntitiesGoneWild
SearchKit - enable search by case role
Eileen McNaughton [Sun, 14 Nov 2021 18:23:31 +0000 (07:23 +1300)]
Ensure groupElementType is always set
Eileen McNaughton [Sun, 28 Nov 2021 06:26:38 +0000 (19:26 +1300)]
Ensure smarty variables are consistently assigned in report
Eileen McNaughton [Mon, 29 Nov 2021 19:08:35 +0000 (08:08 +1300)]
Merge pull request #22158 from colemanw/api4DeleteOptionList
APIv4 - Delete unused OptionList trait
colemanw [Mon, 29 Nov 2021 17:20:58 +0000 (12:20 -0500)]
Merge pull request #22118 from eileenmcnaughton/notices
Fix message templates screen to work with escape enabled by default
colemanw [Mon, 29 Nov 2021 15:13:51 +0000 (10:13 -0500)]
Merge pull request #22154 from eileenmcnaughton/n3
[Smarty variables] Use always-assigned isTagSet to determine if is tagset
colemanw [Mon, 29 Nov 2021 15:13:35 +0000 (10:13 -0500)]
Merge pull request #22153 from eileenmcnaughton/n2
[Smarty variables] [Activity form] Ensure activityTypeFile is always assigned
colemanw [Mon, 29 Nov 2021 15:12:25 +0000 (10:12 -0500)]
Merge pull request #22157 from eileenmcnaughton/testit
[Test] Fix tests to use form helper
colemanw [Mon, 29 Nov 2021 15:12:14 +0000 (10:12 -0500)]
Merge pull request #22156 from eileenmcnaughton/cont_tests
[Test] Test cleanup to use full-form methods
Coleman Watts [Mon, 29 Nov 2021 13:50:03 +0000 (08:50 -0500)]
APIv4 - Delete unused OptionList trait
This trait had been added for the sake of SearchKit to determine which entities should be
searchable and which were merely supplying option lists for other entities.
However, this logic broke down quickly as some option lists *should* be searchable,
so that path was abandoned in favor of the `@searchable` annotation.
The trait now does nothing and is just taking up space and adding unnecessary complexity.
Coleman Watts [Sun, 28 Nov 2021 21:14:42 +0000 (16:14 -0500)]
APIv4 - Limit SortableEntity exports by domain
Coleman Watts [Sun, 28 Nov 2021 16:06:21 +0000 (11:06 -0500)]
APIv4 - Add SortableEntity and ManagedEntity traits to Navigation menu entity
Excludes 'weight' from managed entity calculations for references,
adds unit tests for the interaction of managed entities and sortable entities
Coleman Watts [Sat, 27 Nov 2021 00:27:24 +0000 (19:27 -0500)]
Fix test for compatability with auto-weights
Coleman Watts [Fri, 26 Nov 2021 21:48:57 +0000 (16:48 -0500)]
Fix unit tests to enable components before using them
Coleman Watts [Fri, 26 Nov 2021 01:12:32 +0000 (20:12 -0500)]
SearchKit - Use order_by from metadata to supply default sort for searchDisplays
Coleman Watts [Fri, 26 Nov 2021 00:28:56 +0000 (19:28 -0500)]
APIv4 - Add SortableEntity type which auto-adjusts weights
This entity type will manage weight columns automatically, allowing items to be
re-ordered easily.
Simply by updating the weight of one record, others will auto-adjust to make room for it.
Eileen McNaughton [Mon, 29 Nov 2021 04:03:41 +0000 (17:03 +1300)]
Fix tests to use form helper
Eileen McNaughton [Mon, 29 Nov 2021 03:59:40 +0000 (16:59 +1300)]
Merge pull request #22151 from colemanw/optionValueSearch
SearchKit - Allow searches of OptionValues, LocationTypes, CustomFields
Eileen McNaughton [Mon, 29 Nov 2021 02:52:25 +0000 (15:52 +1300)]
Test cleanup to use full-form methods
Uses full form flow - via a helper
Eileen McNaughton [Mon, 29 Nov 2021 01:49:05 +0000 (14:49 +1300)]
Specify isRepeatingEntity when including ConfirmRepeatMode.tpl
Eileen McNaughton [Mon, 29 Nov 2021 01:42:40 +0000 (14:42 +1300)]
Use always-assigned isTagSet to determine if is tagset
Eileen McNaughton [Mon, 29 Nov 2021 01:43:10 +0000 (14:43 +1300)]
Ensure activityTypeFile is always assigned
Eileen McNaughton [Mon, 29 Nov 2021 01:30:24 +0000 (14:30 +1300)]
Ensure separation,tag are assigned to the template
Coleman Watts [Mon, 29 Nov 2021 01:27:17 +0000 (20:27 -0500)]
SearchKit - Enable for CustomField, CustomGroup & LocationType
Eileen McNaughton [Tue, 23 Nov 2021 22:02:30 +0000 (11:02 +1300)]
Fix message templates screen to work with escape enabled by default
Coleman Watts [Mon, 15 Nov 2021 14:47:08 +0000 (09:47 -0500)]
SearchKit - Allow searches of OptionGroups and OptionValues
Marks the entities searchable, and adds view/edit links for OptionValues
colemanw [Sun, 28 Nov 2021 23:36:09 +0000 (18:36 -0500)]
Merge pull request #22148 from eileenmcnaughton/link
Enotice fixes - ensure a couple more variables are consistently assigned
colemanw [Sun, 28 Nov 2021 23:29:57 +0000 (18:29 -0500)]
Merge pull request #22124 from eileenmcnaughton/cust
Remove isset from custom data tpls
Eileen McNaughton [Sun, 28 Nov 2021 06:41:14 +0000 (19:41 +1300)]
Enotice fixes - ensure a couple more variables are consistently assigned
Eileen McNaughton [Sun, 28 Nov 2021 06:26:38 +0000 (19:26 +1300)]
Ensure smarty variables are consistently assigned in report
Eileen McNaughton [Wed, 24 Nov 2021 01:39:32 +0000 (14:39 +1300)]
Remove isset from custom data tpls
Eileen McNaughton [Thu, 25 Nov 2021 06:40:10 +0000 (19:40 +1300)]
Assign variable to determine whether to show email signature field
This gets us around complex 'empty checks' and allows us to avoid enotices in smarty
Eileen McNaughton [Thu, 25 Nov 2021 06:59:23 +0000 (19:59 +1300)]
Ensure formal_title is assigned to the template.
This just gets past one enotice in the great juggle
Eileen McNaughton [Fri, 26 Nov 2021 01:40:03 +0000 (14:40 +1300)]
Template notice cleanup - make sane
The CRM/Custom/Form/CustomData.tpl is called with formEdit set from
1 place - CRM/Contact/Form/Edit/CustomData.tpl - when this is the
case only 1 line of code is shared with the code path if
formEdit is not true/ passed in. This is silly & can be avoided
colemanw [Sat, 27 Nov 2021 20:33:42 +0000 (15:33 -0500)]
Merge pull request #22140 from eileenmcnaughton/cust_case
Assign cgCount in Case custom data form
demeritcowboy [Sat, 27 Nov 2021 13:44:02 +0000 (08:44 -0500)]
Merge pull request #22125 from colemanw/searchKitEditing
SearchKit - Improve UX for refresh after editing
colemanw [Sat, 27 Nov 2021 06:39:18 +0000 (01:39 -0500)]
Merge pull request #21919 from braders/deprecated-jquery-xhr-usage
[REF] Remove usage of deprecated jqXHR.error in jQuery code
colemanw [Sat, 27 Nov 2021 06:34:13 +0000 (01:34 -0500)]
Merge pull request #22014 from colemanw/apiExport
APIv4 - Add export action for managed entities
colemanw [Sat, 27 Nov 2021 06:21:14 +0000 (01:21 -0500)]
Merge pull request #22139 from eileenmcnaughton/cust_opt
Ensure custom fields properties are assigned to the template
Seamus Lee [Sat, 27 Nov 2021 05:11:01 +0000 (16:11 +1100)]
Merge pull request #22145 from civicrm/5.44
5.44
colemanw [Sat, 27 Nov 2021 02:44:19 +0000 (21:44 -0500)]
Merge pull request #22141 from eileenmcnaughton/contexty
Ensure context is always assigned
Coleman Watts [Tue, 9 Nov 2021 13:57:28 +0000 (08:57 -0500)]
APIv4 - Add export action to managed entities
This action generates an exportable array suitable for use in a .mgd.php file.
Seamus Lee [Fri, 26 Nov 2021 22:04:50 +0000 (09:04 +1100)]
Merge pull request #22144 from alifrumin/rn5.44
NFC first stab at 5.44 release notes
Alice Frumin [Mon, 22 Nov 2021 18:17:31 +0000 (13:17 -0500)]
NFC release notes 5.44
Matthew Wire [Fri, 26 Nov 2021 17:31:37 +0000 (17:31 +0000)]
Display higher severity status checks first
Matthew Wire [Fri, 26 Nov 2021 17:19:44 +0000 (17:19 +0000)]
Sort list of extensions alphabetically in 'Extensions ok' check
Eileen McNaughton [Fri, 26 Nov 2021 03:12:51 +0000 (16:12 +1300)]
Ensure context is always assigned
Seamus Lee [Fri, 26 Nov 2021 02:59:35 +0000 (13:59 +1100)]
Merge pull request #22127 from colemanw/afformUiTweaks
FormBuilder - Hide configuration options that do not apply to certain form types
Eileen McNaughton [Fri, 26 Nov 2021 02:51:21 +0000 (15:51 +1300)]
Assign cgCount in Case custom data form
Eileen McNaughton [Fri, 26 Nov 2021 02:46:38 +0000 (15:46 +1300)]
Ensure custom fields properties are assigned to the template
Eileen McNaughton [Fri, 26 Nov 2021 01:40:03 +0000 (14:40 +1300)]
Template notice cleanup - make sane
The CRM/Custom/Form/CustomData.tpl is called with formEdit set from
1 place - CRM/Contact/Form/Edit/CustomData.tpl - when this is the
case only 1 line of code is shared with the code path if
formEdit is not true/ passed in. This is silly & can be avoided
Seamus Lee [Fri, 26 Nov 2021 00:24:35 +0000 (11:24 +1100)]
Merge pull request #22114 from colemanw/searchKitRevertButton
SearchKit - Improve search listing UI
Seamus Lee [Thu, 25 Nov 2021 23:32:40 +0000 (10:32 +1100)]
Merge pull request #22134 from eileenmcnaughton/url
Ensure CMSPrint variables are assigned to the template
Seamus Lee [Thu, 25 Nov 2021 23:32:22 +0000 (10:32 +1100)]
Merge pull request #22135 from eileenmcnaughton/pay_test
Ensure tab headers are assigned, fix widget form test
Seamus Lee [Thu, 25 Nov 2021 23:31:26 +0000 (10:31 +1100)]
Merge pull request #22136 from mlutfy/fixEventPrepositionTs
CRM/Event/BAO/Event: Fix ts usage on selfservice_preposition
Mathieu Lutfy [Thu, 25 Nov 2021 21:13:44 +0000 (16:13 -0500)]
CRM/Event/BAO/Event: Fix ts usage on selfservice_preposition
Eileen McNaughton [Thu, 25 Nov 2021 08:01:47 +0000 (21:01 +1300)]
Ensure tab headers are assigned, fix widget form test
This could regress notices elsewhere but I given the difficulty of getting a combo
of fixes that pass tests I think we should only worry if there are actual test fails
since most people won't see smarty notices anyway
Eileen McNaughton [Thu, 25 Nov 2021 07:41:45 +0000 (20:41 +1300)]
Ensure CMSPrint variables are assigned to the template
Eileen McNaughton [Thu, 25 Nov 2021 06:40:10 +0000 (19:40 +1300)]
Assign variable to determine whether to show email signature field
This gets us around complex 'empty checks' and allows us to avoid enotices in smarty
Seamus Lee [Wed, 24 Nov 2021 22:19:40 +0000 (09:19 +1100)]
Merge pull request #22128 from eileenmcnaughton/cus
Ensure buildForm is called to assign values
Seamus Lee [Wed, 24 Nov 2021 21:10:27 +0000 (08:10 +1100)]
Merge pull request #22131 from civicrm/5.44
5.44
colemanw [Wed, 24 Nov 2021 19:30:00 +0000 (14:30 -0500)]
Merge pull request #22130 from colemanw/fixSearchKitHaving
SearchKit - Fix selecting HAVING operator
colemanw [Wed, 24 Nov 2021 17:47:27 +0000 (12:47 -0500)]
Merge pull request #22129 from kurund/patch-4
Update Fields.tpl