Seamus Lee [Sun, 4 Jul 2021 05:52:11 +0000 (15:52 +1000)]
Merge pull request #20749 from colemanw/apiPrimaryKey
APIv4 - Rename id_field to primary_key and make it an array
Eileen McNaughton [Sun, 4 Jul 2021 04:09:44 +0000 (16:09 +1200)]
Merge pull request #20757 from eileenmcnaughton/phone_strip
dev/core#27 Move check for phone function to a check
colemanw [Sun, 4 Jul 2021 02:53:48 +0000 (22:53 -0400)]
Merge pull request #20743 from eileenmcnaughton/option_type
Improve api consistency on custom field creation
Coleman Watts [Fri, 2 Jul 2021 02:34:01 +0000 (22:34 -0400)]
Add primaryKey info to daos
Coleman Watts [Fri, 2 Jul 2021 02:10:52 +0000 (22:10 -0400)]
APIv4 - Rename `id_field` to `primary_key` and make it an array
Some entities have a combination of primary keys instead of a single field.
This is allowed in the schema so the API needs to be able to handle it too.
Renaming it for consistency with the schema.
colemanw [Sun, 4 Jul 2021 02:09:46 +0000 (22:09 -0400)]
Merge pull request #20748 from seamuslee001/npm_package_updates
[NFC] Update various npm depdencies used only in unit testing
Eileen McNaughton [Sat, 3 Jul 2021 02:17:27 +0000 (14:17 +1200)]
dev/core#27 Move check for phone function to a check
Fixes dev/core#27
colemanw [Sun, 4 Jul 2021 01:24:06 +0000 (21:24 -0400)]
Merge pull request #20759 from eileenmcnaughton/entry4
dev/core#2634 [REF] Move membership date calc from v3 api to BAO
Eileen McNaughton [Thu, 1 Jul 2021 05:50:57 +0000 (17:50 +1200)]
Improve api consistency on custom field creation
Api supports a key 'option_values' by always setting the 'magic' param
option_type to 1. v4 doesn't - but creating option values when creating
a custom field is desirable. This fixes so that the form still
'opts out' if it passes in '2' but otherwise we create the option values
if passed in.
Just a teensy bit less magic in the api layer & bao
Eileen McNaughton [Mon, 24 May 2021 08:29:08 +0000 (20:29 +1200)]
[REF] Move membership date calc from v3 api to BAO
This moves code to calculate membership dates for new memberships from the
v3 api Membership.create and the batch entry membership form to the membership bao.
I think more cleanup could follow this - in the api most obviously and
the BAO is a bit insane still
This has test cover in the v3 api membership test and in
CRM_Batch_Form_EntryTest
Eileen McNaughton [Sat, 3 Jul 2021 02:41:04 +0000 (14:41 +1200)]
Merge pull request #20729 from demeritcowboy/assign-cleanup
[REF] Remove unnecessary variable wrangling in case roles section
Eileen McNaughton [Sat, 3 Jul 2021 01:43:50 +0000 (13:43 +1200)]
Merge pull request #20754 from colemanw/fixContactSummarySmartyUndefinedVars
Fix undefined tpl vars on contact summary page
Coleman Watts [Fri, 2 Jul 2021 23:29:24 +0000 (19:29 -0400)]
Fix undefined tpl vars on contact summary page
Matthew Wire [Fri, 2 Jul 2021 19:29:05 +0000 (20:29 +0100)]
Merge pull request #20750 from mattwire/viewrecur
Add missing "View Recurring Contribution" link to contribution view
Matthew Wire [Fri, 2 Jul 2021 11:22:36 +0000 (12:22 +0100)]
View recurring contribution button when displaying lineitems
Seamus Lee [Fri, 2 Jul 2021 01:47:31 +0000 (11:47 +1000)]
Merge pull request #20747 from seamuslee001/part_guard
[REF] Add in template guard for not being always set as per html format
Seamus Lee [Fri, 2 Jul 2021 01:37:53 +0000 (11:37 +1000)]
Merge pull request #20586 from colemanw/is_current
APIv4 - add is_current as a pseudo (calculated) field
Seamus Lee [Fri, 2 Jul 2021 01:00:07 +0000 (01:00 +0000)]
[NFC] Update various npm depdencies used only in unit testing
Seamus Lee [Fri, 2 Jul 2021 00:09:23 +0000 (00:09 +0000)]
[REF] Add in template guard for not being always set as per html format
Regen SQL
Coleman Watts [Sun, 13 Jun 2021 01:36:39 +0000 (21:36 -0400)]
APIv4 - add is_current as a pseudo (calculated) field
This adds the first calculated field to APIv4. It works by injecting a SQL function and aliasing it
with the name of the fake field. This approach allows it to work as part of the WHERE clause
as well as the SELECT clause, even across joins.
Marking the old "is_current" api param deprecated because the field works better.
colemanw [Thu, 1 Jul 2021 22:32:13 +0000 (18:32 -0400)]
Merge pull request #20648 from eileenmcnaughton/ret1
[NFC] Improve use of return parameters in ContributionPage test class
demeritcowboy [Thu, 1 Jul 2021 22:15:52 +0000 (18:15 -0400)]
Merge pull request #20745 from demeritcowboy/test-20602
[NFC] Unit test for 20602
demeritcowboy [Thu, 1 Jul 2021 20:01:11 +0000 (16:01 -0400)]
test for 20602
demeritcowboy [Thu, 1 Jul 2021 19:22:23 +0000 (15:22 -0400)]
Merge pull request #20602 from ixiam/dev#PreserveActivityTabFilter
Fix activity_date_time_relative filter when `preserve_activity_tab_fi…
Monish Deb [Thu, 1 Jul 2021 17:22:25 +0000 (22:52 +0530)]
Merge pull request #20627 from demeritcowboy/currency-fixation
dev/financial#175 - Unable to remove a currency once added
Monish Deb [Thu, 1 Jul 2021 17:07:25 +0000 (22:37 +0530)]
Merge pull request #20744 from
deb1990/RSESPRT-64-fix-profile-submit-api
Support saving more than 25 records in Profile.submit api
Luciano Spiegel [Mon, 14 Jun 2021 17:07:12 +0000 (19:07 +0200)]
fix activity_date_time_relative filter when `preserve_activity_tab_filter` setting is on
Monish Deb [Thu, 1 Jul 2021 16:44:21 +0000 (22:14 +0530)]
Merge pull request #20396 from eileenmcnaughton/entry3
[REF] Remove isPayLater from membership batch screen
Monish Deb [Thu, 1 Jul 2021 16:34:16 +0000 (22:04 +0530)]
Merge pull request #20394 from eileenmcnaughton/entry
[REF] Extend testing on membership batch entry & minor cleanup
colemanw [Thu, 1 Jul 2021 14:51:15 +0000 (10:51 -0400)]
Merge pull request #20676 from eileenmcnaughton/recur
Fix test to use valid financials
colemanw [Thu, 1 Jul 2021 14:49:41 +0000 (10:49 -0400)]
Merge pull request #20742 from eileenmcnaughton/throw
Throw exception rather than fatal
colemanw [Thu, 1 Jul 2021 13:04:53 +0000 (09:04 -0400)]
Merge pull request #20734 from seamuslee001/fix_patch_php8
[REF] Fix trying to access array offset from boolean value
Seamus Lee [Thu, 1 Jul 2021 09:55:40 +0000 (19:55 +1000)]
Merge pull request #20731 from colemanw/apiExplorerWriteJoins
APIv4 Explorer: show joins for write actions
Debarshi Bhaumik [Wed, 30 Jun 2021 10:42:57 +0000 (16:12 +0530)]
RSESPRT-64: Support saving more than 25 records in Profile.submit api
Seamus Lee [Thu, 1 Jul 2021 04:36:03 +0000 (14:36 +1000)]
Merge pull request #20741 from civicrm/5.39
5.39
Seamus Lee [Thu, 1 Jul 2021 02:44:50 +0000 (12:44 +1000)]
Merge pull request #20737 from colemanw/fixUndefinedGroupTree
Fix possibly undefined custom groupTree tpl variable
Seamus Lee [Thu, 1 Jul 2021 02:21:45 +0000 (12:21 +1000)]
Merge pull request #20735 from eileenmcnaughton/tpl
Tpl enotice fix
Seamus Lee [Thu, 1 Jul 2021 02:18:34 +0000 (12:18 +1000)]
Merge pull request #20740 from seamuslee001/5.39
Add release-notes/5.38.1.md
Eileen McNaughton [Thu, 1 Jul 2021 02:17:31 +0000 (14:17 +1200)]
Throw exception rather than fatal
This makes it easier to debug if the entityName is not
resolved - in general this is a dev site issue as it is
to do with load order
Tim Otten [Thu, 1 Jul 2021 01:29:17 +0000 (18:29 -0700)]
Add release-notes/5.38.1.md
demeritcowboy [Thu, 1 Jul 2021 01:28:58 +0000 (21:28 -0400)]
Merge pull request #20717 from seamuslee001/use_civi_event_dispatcher_setup
[REF] Alter new Setup process to use CiviCRM's Event Dispatcher
Coleman Watts [Thu, 1 Jul 2021 01:11:03 +0000 (21:11 -0400)]
Fix possibly undefined custom groupTree tpl variable
Eileen McNaughton [Thu, 1 Jul 2021 00:30:36 +0000 (12:30 +1200)]
Tpl enotice fix
I searched for hideStepNumbers & believe it is never assigned
Seamus Lee [Wed, 30 Jun 2021 22:02:53 +0000 (22:02 +0000)]
[REF] Fix trying to access array offset from boolean value
Seamus Lee [Sun, 27 Jun 2021 23:23:52 +0000 (09:23 +1000)]
[REF] Alter new Setup process to use CiviCRM's Event Dispatcher
Apply patch from Tim to limit what events are dispatched
Coleman Watts [Wed, 30 Jun 2021 20:50:45 +0000 (16:50 -0400)]
Ensure APIv3 EntityRef fields always return the value of the `id_field`.
Usually it's safe to assume the `id_field` === "id", which is automatically returned
by APIv3. However in the case of looking up records by name, etc. we must ensure that value
gets returned.
Coleman Watts [Wed, 30 Jun 2021 20:49:05 +0000 (16:49 -0400)]
APIv4 Explorer - Show joins for write actions
It recently became possible in APIv4 to use joins during write operations;
now that feature is advertised in the Explorer.
Coleman Watts [Wed, 30 Jun 2021 20:48:40 +0000 (16:48 -0400)]
APIv4 explorer - move metadata into .ang.php file
demeritcowboy [Wed, 30 Jun 2021 15:45:28 +0000 (11:45 -0400)]
unnecessary wrangling
demeritcowboy [Wed, 30 Jun 2021 15:02:50 +0000 (11:02 -0400)]
Merge pull request #19737 from sunilpawar/show_inactive_active_case_role
dev/core#542 dev/core#1947 - Show inactive active case role for closed cases
colemanw [Wed, 30 Jun 2021 14:45:13 +0000 (10:45 -0400)]
Merge pull request #20724 from colemanw/apiFieldPermissions
APIv4 - Silently ignore non-permissioned fields instead of throwing exceptions
demeritcowboy [Wed, 30 Jun 2021 14:25:13 +0000 (10:25 -0400)]
Merge pull request #20662 from colemanw/contactSummaryImageRegion
Add contact-summary-image region
Matthew Wire [Wed, 30 Jun 2021 13:42:15 +0000 (14:42 +0100)]
Merge pull request #20450 from jaapjansma/dev_financials_6_reports
dev/financial#6 Do not include template contributions in reports
Jaap Jansma [Wed, 30 Jun 2021 11:30:43 +0000 (13:30 +0200)]
dev/financial#6 do not include template contributions in reports
Coleman Watts [Tue, 29 Jun 2021 03:14:32 +0000 (23:14 -0400)]
APIv4 - Silently ignore non-permissioned fields instead of throwing exceptions
Previously the api would throw an exception when the user did not have permission to use a field
in the WHERE or HAVING clause.
Monish Deb [Wed, 30 Jun 2021 06:57:57 +0000 (12:27 +0530)]
Merge pull request #20715 from colemanw/fixFkJoins
APIv4 - Fix same-table joins and remove unused code
Monish Deb [Wed, 30 Jun 2021 06:07:09 +0000 (11:37 +0530)]
Merge pull request #20654 from eileenmcnaughton/part_fix
Fix bug where only one participant registration is completed
Seamus Lee [Wed, 30 Jun 2021 00:05:48 +0000 (10:05 +1000)]
Merge pull request #20726 from colemanw/fixUndefinedTplVars
Fix undefined tpl vars on custom field page
Seamus Lee [Tue, 29 Jun 2021 21:58:11 +0000 (07:58 +1000)]
Merge pull request #20716 from colemanw/emitApi4NoticesAboutDeprecatedJoinAliases
APIv4 - Emit notices about deprecated join aliases
Coleman Watts [Tue, 29 Jun 2021 21:46:09 +0000 (17:46 -0400)]
Fix undefined tpl vars on custom field page
Seamus Lee [Tue, 29 Jun 2021 20:50:57 +0000 (06:50 +1000)]
Merge pull request #20725 from colemanw/fixUndefinedRowClass
Fix often undefined variable $row.class in tpl tables
Coleman Watts [Tue, 29 Jun 2021 18:26:13 +0000 (14:26 -0400)]
Fix often undefined variable $row.class in tpl tables
Coleman Watts [Mon, 28 Jun 2021 16:37:06 +0000 (12:37 -0400)]
APIv4 - Use non-deprecated join syntax internally
Updates APIv4 calls in CiviCRM core to use e.g. `event_id.title` instead of `event.title`
Seamus Lee [Tue, 29 Jun 2021 05:48:38 +0000 (15:48 +1000)]
Merge pull request #20723 from colemanw/api4ExplorerJoins
APIv4 Explorer - Render joins using addJoin function in OOP
Eileen McNaughton [Tue, 29 Jun 2021 03:35:36 +0000 (15:35 +1200)]
Merge pull request #20707 from colemanw/getIdField
APIv4 - Don't assume the identifier field for a table is named 'id'
Matthew Wire [Mon, 28 Jun 2021 22:35:01 +0000 (23:35 +0100)]
Merge pull request #20452 from jaapjansma/dev_financials_6_contactsummary
dev/financial#6 Template contributions on the contact summary
Matthew Wire [Mon, 28 Jun 2021 22:33:18 +0000 (23:33 +0100)]
Merge pull request #20451 from jaapjansma/dev_financials_6_search
dev/financial#6 Added is template to search screen
Seamus Lee [Mon, 28 Jun 2021 21:53:44 +0000 (07:53 +1000)]
Merge pull request #20722 from demeritcowboy/sms-translate
dev/core#1711 - small translation improvement
Coleman Watts [Sun, 27 Jun 2021 04:41:00 +0000 (00:41 -0400)]
APIv4 - Emit notices about deprecated join aliases
colemanw [Mon, 28 Jun 2021 19:51:18 +0000 (15:51 -0400)]
Merge pull request #20721 from colemanw/apiExplorerBridge
APIv4 Explorer - When joining via EntityBridge, make bridge fields selectable
Coleman Watts [Mon, 28 Jun 2021 19:47:53 +0000 (15:47 -0400)]
APIv4 Explorer - Render joins using addJoin function in OOP
demeritcowboy [Mon, 28 Jun 2021 18:47:55 +0000 (14:47 -0400)]
translation improvement - dev/core#1711
Coleman Watts [Mon, 28 Jun 2021 17:52:16 +0000 (13:52 -0400)]
APIv4 Explorer - When joining via EntityBridge, make bridge fields selectable
demeritcowboy [Mon, 28 Jun 2021 13:15:51 +0000 (09:15 -0400)]
Merge pull request #20720 from mattwire/extensionsaddnewdescription
Replace extension key with description in 'Add New' tab
Sunil Pawar [Fri, 5 Mar 2021 06:43:43 +0000 (12:13 +0530)]
show inactive role on closed case, and give option to active role on case
Fix php notice for case not having manager
Fix pagination count issue
Revert pagination code
revert additional pagination changes
Matthew Wire [Mon, 28 Jun 2021 08:47:13 +0000 (09:47 +0100)]
Replace extension key with description in 'Add New' tab as already done in main list
Seamus Lee [Mon, 28 Jun 2021 02:12:33 +0000 (12:12 +1000)]
Merge pull request #20220 from johntwyman/core-1711-show-sms-segment-count
dev/core#1711 - Display SMS segment count when constructing Mass SMS
Eileen McNaughton [Mon, 28 Jun 2021 01:22:05 +0000 (13:22 +1200)]
Merge pull request #20711 from demeritcowboy/dashboard-err
Some php warnings on case dashboard
John Twyman [Wed, 5 May 2021 01:11:56 +0000 (11:11 +1000)]
dev/core-1711 Show segment count for SMS construction
Use Standard methods for downloading third party js package
Update composer.lock
Seamus Lee [Sun, 27 Jun 2021 23:02:08 +0000 (09:02 +1000)]
Merge pull request #20713 from totten/5.39-setup-url
dev/core#2663 - Setup - Consistently handle special characters per URL conventions
Eileen McNaughton [Sun, 27 Jun 2021 20:52:04 +0000 (08:52 +1200)]
Merge pull request #20714 from demeritcowboy/fix-time
Hopefully fix time rollover problem in MessageTemplateTest
Coleman Watts [Sat, 26 Jun 2021 01:19:06 +0000 (21:19 -0400)]
APIv4 - Fix same-table joins and remove unused code
This fixes implicit joins between a table and itself, e.g. the Contact.employer_id which links to the Contact table
Also removes alpha code no longer used by APIv4.
demeritcowboy [Sat, 26 Jun 2021 23:34:07 +0000 (19:34 -0400)]
Merge pull request #20697 from eileenmcnaughton/prem
Remove deprecated use of format money
colemanw [Sat, 26 Jun 2021 00:58:48 +0000 (20:58 -0400)]
Merge pull request #20712 from demeritcowboy/newcase-1
Some php warnings on new case
Tim Otten [Fri, 25 Jun 2021 22:12:14 +0000 (15:12 -0700)]
dev/core#2663 - Setup - Consistently handle special characters per URL conventions
Overview
--------
This addresses a problem with the setup UI when installing CiviCRM with certain database credentials.
Specifically, it handles special characters more correctly.
https://lab.civicrm.org/dev/core/-/issues/2663
Before
------
If the database password requires any special characters (e.g. "#" or "&"), then they cannot correctly
entered.
There are two ways you might try to enter a password (e.g. plain
`mysql://myuser:top#secret...`or URL-encoded `mysql://myuser:top%23secret...`). Neither
of these work. (The plain notation might pass the validator, but it won't be written correctly to disk.
The URL-encoded notation won't pass the validator.)
After
-----
You may use special characters, as long as the URL is properly encoded, e.g. `mysql://myuser:top%23secret...`
demeritcowboy [Fri, 25 Jun 2021 22:03:03 +0000 (18:03 -0400)]
fix time rollover
Coleman Watts [Thu, 24 Jun 2021 20:24:34 +0000 (16:24 -0400)]
APIv4 - add test for id_field
Coleman Watts [Thu, 24 Jun 2021 19:36:23 +0000 (15:36 -0400)]
APIv4 - Don't assume the identifier field for a table is named 'id'
APIv4 getInfo() now returns the name of the "id_field" for any entity.
This modifies the selectQuery so that `get` actions rely on that metadata.
demeritcowboy [Fri, 25 Jun 2021 17:12:43 +0000 (13:12 -0400)]
php errors
demeritcowboy [Fri, 25 Jun 2021 16:29:35 +0000 (12:29 -0400)]
php warnings
Seamus Lee [Fri, 25 Jun 2021 07:53:54 +0000 (17:53 +1000)]
Merge pull request #20694 from colemanw/validateCustomGroupName
Ensure custom group name does not conflict with existing field
Seamus Lee [Fri, 25 Jun 2021 04:54:24 +0000 (14:54 +1000)]
Merge pull request #20708 from colemanw/cacheApi4Info
[REF] - Improve efficiency of APIv4 GetInfo
Seamus Lee [Fri, 25 Jun 2021 04:53:05 +0000 (14:53 +1000)]
Merge pull request #20696 from eileenmcnaughton/except
Throw exception when baoName is not found
Eileen McNaughton [Fri, 25 Jun 2021 03:30:34 +0000 (15:30 +1200)]
Merge pull request #20709 from colemanw/api4CleanupBridgeJoinable
APIv4 - Remove POC code leftover from early alpha development
Eileen McNaughton [Wed, 23 Jun 2021 05:31:40 +0000 (17:31 +1200)]
Throw exception when baoName is not found
It the BAO name is not found at this point we currently get a fatal error. This makes it more
recoverable. The specific case I'm hitting at the moment relates to monolog - the
caching of the symfony container means it persists between builds and is
accessed before the extension is installed. However the entity is not
yet registered. Historically I have hit this fatal in other
scenarios but I can't recall the details.
Coleman Watts [Thu, 24 Jun 2021 20:24:58 +0000 (16:24 -0400)]
APIv4 - Refactor getInfo calls to use new utility function
Coleman Watts [Thu, 24 Jun 2021 20:09:33 +0000 (16:09 -0400)]
APIv4 - Store entity info in metadata cache
Note that this caches the info returned by the generic function in
`AbstractEntity::getInfo()` and some entities override that function.
However the overrides generally call the parent and do not perform any expensive
computations of their own, so this seems like the best spot to add caching.
Coleman Watts [Fri, 25 Jun 2021 01:38:56 +0000 (21:38 -0400)]
APIv4 - Remove POC code from early alpha
During early APIv4 development there was an idea to create a BridgeJoinable class and
connect things like activity->assignees.
It was experimentally implemented for that field one field, but never documented or tested.
Seamus Lee [Thu, 24 Jun 2021 09:29:23 +0000 (19:29 +1000)]
Merge pull request #20631 from eileenmcnaughton/custom_ref
dev/core#2656 Add test to demonstrate issue / bug
Seamus Lee [Thu, 24 Jun 2021 09:27:15 +0000 (19:27 +1000)]
Merge pull request #20673 from colemanw/contactTabsCleanup
REF - Get Contact Summary tab counts after calling hook to avoid wasting time