Jon Goldberg [Thu, 26 Jan 2023 18:18:57 +0000 (13:18 -0500)]
getStatus() should be returning a string
Tim Otten [Tue, 10 Jan 2023 22:49:30 +0000 (14:49 -0800)]
Merge pull request #25314 from jofranz/added-name-to-contributor-key
added myself to contributor-key.yml
Jo Franz [Tue, 10 Jan 2023 22:13:36 +0000 (23:13 +0100)]
added myself to contributor-key.yml
Eileen McNaughton [Tue, 10 Jan 2023 22:08:43 +0000 (11:08 +1300)]
Merge pull request #25279 from demeritcowboy/party-test
[NFC] Remove broken test
Eileen McNaughton [Tue, 10 Jan 2023 22:07:14 +0000 (11:07 +1300)]
Merge pull request #25308 from jofranz/dlass-typo
typo: dlass --> class
Eileen McNaughton [Tue, 10 Jan 2023 21:57:18 +0000 (10:57 +1300)]
Merge pull request #25310 from braders/dynamic-properties-note-test
[REF][PHP8.2] Avoid dynamic properties in api_v3_NoteTest
Seamus Lee [Tue, 10 Jan 2023 21:14:43 +0000 (08:14 +1100)]
Merge pull request #25301 from braders/dynamic-properties-dedupe-exception
[REF][PHP8.2] Avoid dynamic properties in CRM_Contact_Page_DedupeException
Seamus Lee [Tue, 10 Jan 2023 21:04:58 +0000 (08:04 +1100)]
Merge pull request #25311 from braders/dynamic-properties-extension-container-static
[REF][PHP8.2] Avoid dynamic properties in CRM_Extension_Container_Static
Bradley Taylor [Tue, 10 Jan 2023 19:44:45 +0000 (19:44 +0000)]
[REF][PHP8.2] Avoid dynamic properties in CRM_Extension_Container_Static
Jo Franz [Tue, 10 Jan 2023 19:44:03 +0000 (20:44 +0100)]
fixed line break
Bradley Taylor [Tue, 10 Jan 2023 19:07:49 +0000 (19:07 +0000)]
[REF][PHP8.2] Avoid dynamic properties in api_v3_NoteTest
Jo Franz [Tue, 10 Jan 2023 17:01:35 +0000 (18:01 +0100)]
typo: dlass --> class
colemanw [Tue, 10 Jan 2023 13:31:09 +0000 (08:31 -0500)]
Merge pull request #25219 from eileenmcnaughton/cust_ed
[REF] [Merge custom fields] Copy complex function into merger class, ready to disentangle as little shared code is really used
Matthew Wire [Tue, 10 Jan 2023 12:15:34 +0000 (12:15 +0000)]
Merge pull request #25250 from eileenmcnaughton/civix
Run Civix upgrade on afform/core with template patch applied
Eileen McNaughton [Mon, 9 Jan 2023 23:20:24 +0000 (12:20 +1300)]
Merge pull request #25304 from civicrm/5.58
5.58 to master
Eileen McNaughton [Mon, 9 Jan 2023 23:00:56 +0000 (12:00 +1300)]
Merge pull request #25300 from artfulrobot/artfulrobot-fix-null-line-item-label-crash
Fix Contributions listing crash due to getLineItemTitle returning null
Bradley Taylor [Mon, 9 Jan 2023 19:49:15 +0000 (19:49 +0000)]
[REF][PHP8.2] Avoid dynamic properties in CRM_Contact_Page_DedupeException
Seamus Lee [Mon, 9 Jan 2023 21:34:39 +0000 (08:34 +1100)]
Merge pull request #25299 from braders/dynamic-properties-queue-tests
[REF][PHP8.2] Avoid dynamic properties in queue tests
Seamus Lee [Mon, 9 Jan 2023 20:53:18 +0000 (07:53 +1100)]
Merge pull request #25297 from braders/dynamic-properties-i18n-form
[REF][PHP8.2] Avoid dynamic properties in CRM_Core_I18n_Form
Rich Lott / Artful Robot [Mon, 9 Jan 2023 19:36:39 +0000 (19:36 +0000)]
Fix Contributions listing crash due to CRM_Financial_BAO_Order::getLineItemTitle
Bradley Taylor [Mon, 9 Jan 2023 19:38:52 +0000 (19:38 +0000)]
[REF][PHP8.2] Avoid dynamic properties in queue tests
Bradley Taylor [Mon, 9 Jan 2023 18:36:37 +0000 (18:36 +0000)]
[REF][PHP8.2] Avoid dynamic properties in CRM_Core_I18n_Form
demeritcowboy [Mon, 9 Jan 2023 15:55:11 +0000 (10:55 -0500)]
Merge pull request #25282 from yashodha/dev-3844
(dev/core#3844) Dummy payment processor should be flagged as such on …
yashodha [Thu, 5 Jan 2023 07:11:54 +0000 (12:41 +0530)]
(dev/core#3844) Dummy payment processor should be flagged as such on LIVE page
demeritcowboy [Sun, 8 Jan 2023 20:36:49 +0000 (15:36 -0500)]
Merge pull request #25295 from braders/reference-classes-correct-case
(NFC) Reference classes with correct case
Bradley Taylor [Sun, 8 Jan 2023 17:51:51 +0000 (17:51 +0000)]
(NFC) Reference classes with correct case
demeritcowboy [Sat, 7 Jan 2023 23:51:23 +0000 (18:51 -0500)]
Merge pull request #25293 from braders/prefelement-element-removal
(REF) Remove _prefElement dynamic property
demeritcowboy [Sat, 7 Jan 2023 23:44:08 +0000 (18:44 -0500)]
Merge pull request #25292 from braders/dynamic-properties-caseview
[REF][PHP8.2] Avoid dynamic properties in CRM_Case_Form_CaseView
Matthew Wire [Sat, 7 Jan 2023 19:19:12 +0000 (19:19 +0000)]
Merge pull request #25214 from JKingsnorth/dev/core#2559
dev/core#2559 Support tenancy in OAuth providers
Bradley Taylor [Sat, 7 Jan 2023 17:42:36 +0000 (17:42 +0000)]
(REF) Remove _prefElement dynamic property
Bradley Taylor [Sat, 7 Jan 2023 17:23:04 +0000 (17:23 +0000)]
[REF][PHP8.2] Avoid dynamic properties in CRM_Case_Form_CaseView
demeritcowboy [Sat, 7 Jan 2023 16:36:04 +0000 (11:36 -0500)]
Merge pull request #25288 from artfulrobot/artfulrobot-undefined-idx-msgtpl-send
Fix Undefined index: name Notice in civicrm_api3_message_template_send
demeritcowboy [Fri, 6 Jan 2023 21:41:40 +0000 (16:41 -0500)]
Merge pull request #25290 from civicrm/5.58
5.58
demeritcowboy [Fri, 6 Jan 2023 19:21:27 +0000 (14:21 -0500)]
Merge pull request #25289 from demeritcowboy/sk-update
searchkit - fix broken update task in dropdown
demeritcowboy [Fri, 6 Jan 2023 17:56:14 +0000 (12:56 -0500)]
fix broken update task
Rich Lott / Artful Robot [Fri, 6 Jan 2023 15:21:31 +0000 (15:21 +0000)]
Fix Undefined index: name Notice in civicrm_api3_message_template_send
Yashodha Chaku [Fri, 6 Jan 2023 11:24:50 +0000 (16:54 +0530)]
Merge pull request #25277 from jmcclelland/pcp-anon-redirect
avoid empty error message when submitting PCP page.
Tim Otten [Fri, 6 Jan 2023 06:02:11 +0000 (22:02 -0800)]
Merge pull request #25283 from demeritcowboy/testname
[NFC] Test classname should match filename
Yashodha Chaku [Thu, 5 Jan 2023 07:17:30 +0000 (12:47 +0530)]
Merge pull request #25251 from eileenmcnaughton/event_info
Unconditionally assign `registerClosed` on event info page
Tim Otten [Thu, 5 Jan 2023 05:57:18 +0000 (21:57 -0800)]
Set version to 5.59.alpha1
Tim Otten [Thu, 5 Jan 2023 05:57:00 +0000 (21:57 -0800)]
Set version to 5.58.beta1
demeritcowboy [Thu, 5 Jan 2023 05:01:53 +0000 (00:01 -0500)]
classname should match filename
Tim Otten [Thu, 5 Jan 2023 03:13:35 +0000 (19:13 -0800)]
Merge pull request #25281 from seamuslee001/move_help_test
Move newly added Help Test to Inline folder to match Core Folder stru…
Seamus Lee [Thu, 5 Jan 2023 00:52:58 +0000 (11:52 +1100)]
Move newly added Help Test to Inline folder to match Core Folder structure
Seamus Lee [Thu, 5 Jan 2023 00:45:13 +0000 (11:45 +1100)]
Merge pull request #25280 from civicrm/5.57
5.57
Tim Otten [Wed, 4 Jan 2023 02:32:08 +0000 (18:32 -0800)]
release-notes/5.57.0.md - Add security advisories
Tim Otten [Wed, 29 Jun 2022 05:06:05 +0000 (22:06 -0700)]
AssetBuilder - Validate checksum for requested parameters
Seamus Lee [Tue, 3 Jan 2023 01:54:11 +0000 (12:54 +1100)]
CiviEvent - Escape parameters in help text
Seamus Lee [Fri, 16 Dec 2022 00:55:57 +0000 (11:55 +1100)]
security/core#120 Use Rich's patch (ArtfulRobot) with minor variation to try to resolve the issue and add unit tests
Fix Regex and include test cases as per Rich's comments
Tim Otten [Thu, 5 Jan 2023 00:35:26 +0000 (16:35 -0800)]
Merge pull request #25170 from demeritcowboy/sortable
dev/core#4013 dev/core#4022 - Broken quicksearch options setting
demeritcowboy [Wed, 4 Jan 2023 22:34:17 +0000 (17:34 -0500)]
Merge pull request #25222 from eileenmcnaughton/cust_ed4
[REF] [merge custom fields] Only call function when applicable (well tested code)
demeritcowboy [Wed, 4 Jan 2023 21:31:44 +0000 (16:31 -0500)]
remove broken test
Tim Otten [Wed, 4 Jan 2023 20:59:26 +0000 (12:59 -0800)]
Merge pull request #25278 from totten/5.57-rn
release-notes/5.57.0.md - Add recent update
Tim Otten [Wed, 4 Jan 2023 20:58:20 +0000 (12:58 -0800)]
release-notes/5.57.0.md - Add recent update
Eileen McNaughton [Wed, 4 Jan 2023 20:40:57 +0000 (09:40 +1300)]
Merge pull request #25276 from demeritcowboy/turk
[NFC] Restore locale properly after test
Eileen McNaughton [Mon, 26 Dec 2022 22:15:29 +0000 (11:15 +1300)]
Only call function when applicable
Big whitespace change as IF is moved
Jamie McClelland [Wed, 4 Jan 2023 16:31:05 +0000 (11:31 -0500)]
avoid empty error message when submitting PCP page.
demeritcowboy [Wed, 4 Jan 2023 15:40:17 +0000 (10:40 -0500)]
Merge pull request #25245 from braders/php82_ical_dynamic_properties
[REF][PHP8.2] Avoid dynamic properties in CRM_Activity_BAO_ICalendar
Yashodha Chaku [Wed, 4 Jan 2023 06:51:47 +0000 (12:21 +0530)]
Merge pull request #25260 from eileenmcnaughton/prev_o
Remove Mar 2020 deprecated functions
demeritcowboy [Wed, 4 Jan 2023 03:08:54 +0000 (22:08 -0500)]
restore properly
Seamus Lee [Wed, 4 Jan 2023 00:31:16 +0000 (11:31 +1100)]
Merge pull request #25264 from eileenmcnaughton/leg_selector
Move legacy search selector file to legacy search extension
Seamus Lee [Wed, 4 Jan 2023 00:30:46 +0000 (11:30 +1100)]
Merge pull request #25275 from mlutfy/petitionMsgTypo
Petition ThankYou.tpl: fix strong typo
Mathieu Lutfy [Tue, 3 Jan 2023 21:47:17 +0000 (16:47 -0500)]
Petition ThankYou.tpl: fix strong typo
Eileen McNaughton [Tue, 3 Jan 2023 20:51:02 +0000 (09:51 +1300)]
Merge pull request #25274 from civicrm/5.57
5.57 to master
Eileen McNaughton [Tue, 3 Jan 2023 20:50:19 +0000 (09:50 +1300)]
Merge pull request #25273 from gellweiler/5.57
Add gellweiler to contributor-key.yml
Eileen McNaughton [Tue, 3 Jan 2023 20:49:42 +0000 (09:49 +1300)]
Merge pull request #25272 from eileenmcnaughton/557
dev/core#4049 Nested tags are not showing under some circumstances.
Sebastian Gellweiler [Tue, 3 Jan 2023 20:18:07 +0000 (21:18 +0100)]
Add gellweiler to contributor-key.yml
gellweiler [Sat, 24 Dec 2022 13:51:00 +0000 (14:51 +0100)]
Fix #4049
This commit fixes #4049: Nested tags are not showing under some circumstances.
John Kingsnorth [Fri, 23 Dec 2022 00:29:40 +0000 (00:29 +0000)]
dev/core#2559 Support tenancy in OAuth providers
Yashodha Chaku [Tue, 3 Jan 2023 04:47:23 +0000 (10:17 +0530)]
Merge pull request #25268 from eileenmcnaughton/is_separate
Remove unreachable code (since 2020)
Seamus Lee [Tue, 3 Jan 2023 00:54:42 +0000 (11:54 +1100)]
Merge pull request #25258 from eileenmcnaughton/search_test
NFC cleanup in test class
Seamus Lee [Tue, 3 Jan 2023 00:52:03 +0000 (11:52 +1100)]
Merge pull request #25269 from demeritcowboy/more-better-deleted
Better fix for is_deleted notice in 25261
Seamus Lee [Mon, 2 Jan 2023 22:08:16 +0000 (09:08 +1100)]
Merge pull request #25267 from eileenmcnaughton/no_input
Move part of deprecated function `loadRelatedObjects` to calling functions
demeritcowboy [Mon, 2 Jan 2023 22:07:04 +0000 (17:07 -0500)]
better fix for 25261
Eileen McNaughton [Mon, 2 Jan 2023 21:52:04 +0000 (10:52 +1300)]
Remove unreachable code (since 2020)
Seamus Lee [Mon, 2 Jan 2023 21:01:51 +0000 (08:01 +1100)]
Merge pull request #25253 from braders/api3-properties
[REF][PHP8.2] Avoid dynamic properties in civicrm_api3 class
Seamus Lee [Mon, 2 Jan 2023 21:01:17 +0000 (08:01 +1100)]
Merge pull request #25252 from braders/empty-param-annotations
Remove empty param declarations in docblocks
Eileen McNaughton [Mon, 2 Jan 2023 20:43:04 +0000 (09:43 +1300)]
Move part of deprecated function loadRelatedObjects to calling functions
Eileen McNaughton [Mon, 2 Jan 2023 20:07:54 +0000 (09:07 +1300)]
Merge pull request #25266 from braders/phpdoc-fixes3
PHPDoc corrections
Bradley Taylor [Sat, 31 Dec 2022 23:37:26 +0000 (23:37 +0000)]
Remove empty param declarations in docblocks
demeritcowboy [Mon, 2 Jan 2023 17:48:03 +0000 (12:48 -0500)]
Merge pull request #25265 from braders/tagelement-property-removal
(REF) Remove _tagElement dynamic property
demeritcowboy [Mon, 2 Jan 2023 17:31:30 +0000 (12:31 -0500)]
Merge pull request #25261 from eileenmcnaughton/notice
Smarty notice fix on contact search results
Bradley Taylor [Mon, 2 Jan 2023 16:52:10 +0000 (16:52 +0000)]
PHPDoc corrections
Bradley Taylor [Mon, 2 Jan 2023 16:18:47 +0000 (16:18 +0000)]
(REF) Remove _tagElement dynamic property
Matthew Wire [Mon, 2 Jan 2023 09:49:55 +0000 (09:49 +0000)]
Merge pull request #25238 from eileenmcnaughton/is_separate
Extract `getMembershipBlock`
Yashodha Chaku [Mon, 2 Jan 2023 07:52:10 +0000 (13:22 +0530)]
Merge pull request #25263 from eileenmcnaughton/by_ref
Remove unnecessary pass-by-ref
Eileen McNaughton [Mon, 2 Jan 2023 07:45:48 +0000 (20:45 +1300)]
Move legacy search selector file to legacy search extension
Eileen McNaughton [Mon, 2 Jan 2023 06:02:44 +0000 (19:02 +1300)]
Remove unnecessary pass-by-ref
Eileen McNaughton [Mon, 2 Jan 2023 04:34:14 +0000 (17:34 +1300)]
Smarty notice fix on contact search results
Eileen McNaughton [Mon, 2 Jan 2023 03:26:38 +0000 (16:26 +1300)]
Remove more deprecated functions
Eileen McNaughton [Mon, 2 Jan 2023 03:23:36 +0000 (16:23 +1300)]
Remove 2020 deprecated functions
demeritcowboy [Mon, 2 Jan 2023 01:57:50 +0000 (20:57 -0500)]
Merge pull request #25257 from eileenmcnaughton/unused
Remove unused variable
Eileen McNaughton [Mon, 2 Jan 2023 01:48:52 +0000 (14:48 +1300)]
Improve dataSet
It seems when writing this test I thought it was worth having more confusing code
in order to have a clearer failure message - I think that might have been more valid
when writing the test than it is now it rarely fails
Eileen McNaughton [Mon, 2 Jan 2023 01:05:02 +0000 (14:05 +1300)]
NFC cleanup in test class
Yashodha Chaku [Mon, 2 Jan 2023 01:45:09 +0000 (07:15 +0530)]
Merge pull request #25255 from eileenmcnaughton/test_simp
Simplify dataProvider in queryTest
Eileen McNaughton [Mon, 2 Jan 2023 00:16:48 +0000 (13:16 +1300)]
Remove unused variable
Eileen McNaughton [Mon, 2 Jan 2023 00:02:51 +0000 (13:02 +1300)]
Simplify dataProvider in queryTest
This data provider really is not doing much more than returning
an array - but it's adding confusing complexity and a maintenance
need (as can be seen by the fact it has been edited for php 8 compatibility
Bradley Taylor [Sun, 1 Jan 2023 15:09:54 +0000 (15:09 +0000)]
[REF][PHP8.2] Avoid dynamic properties in civicrm_api3 class
Eileen McNaughton [Sun, 1 Jan 2023 04:57:47 +0000 (17:57 +1300)]
Unconditionally assign registerClosed on event info page
Eileen McNaughton [Sun, 1 Jan 2023 02:58:11 +0000 (15:58 +1300)]
Run Civix upgrade on afform/core with template patch applied