Eileen McNaughton [Tue, 23 May 2023 22:12:01 +0000 (10:12 +1200)]
Merge pull request #26308 from eileenmcnaughton/public
Fix show_public regression
Eileen McNaughton [Tue, 23 May 2023 20:02:21 +0000 (08:02 +1200)]
Merge pull request #26298 from totten/5.62-htxt-dynamic
(dev/core#4303) Allow {htxt} guard to accommodate variable ID
Eileen McNaughton [Tue, 23 May 2023 07:59:27 +0000 (19:59 +1200)]
Fix show_public regression
This shows up as an e-notice but
would probably result in the is_public filter being broken.
The variable is no longer set since https://github.com/civicrm/civicrm-core/commit/
16c5faa5db26149e5f1b7d3f45e3d5f2c24bf422#diff-d20bbdac5d9d1d3ec28be6f1972f8cb747ead74dea90c9076daa2de2a627873cL110
Tim Otten [Tue, 23 May 2023 06:28:32 +0000 (23:28 -0700)]
Define {htxt} filter to allow some extra parameters.
Also: tighten the handling of ' and " to ensure that they are matched properly.
Tim Otten [Mon, 22 May 2023 04:48:57 +0000 (21:48 -0700)]
(dev/core#4303) Allow {htxt} guard to accommodate variable ID
Before
------
`{htxt}` guard works with static IDs (`{htxt id="abc"}`)
After
-----
`{htxt}` guard with with variable ID (`{htxt id=$abc}`)
Comments
--------
As discussed in dev/core#4303, one relevant use-case comes from `CustomField.hlp`.
In my copy of universe, there's a similar construction in
`nz.co.fuzion.entitysetting` (`entitysettingscommon.hlp`).
Tim Otten [Mon, 22 May 2023 05:26:10 +0000 (22:26 -0700)]
(dev/core#4303) Add test for {htxt}
demeritcowboy [Mon, 22 May 2023 01:33:17 +0000 (21:33 -0400)]
Merge pull request #26149 from stesi561/activityupgradewarning
dev/core/#1532 - Adds warning similar to 5.57 if Activity Revisions are present.
Luke Stewart [Mon, 22 May 2023 00:54:21 +0000 (12:54 +1200)]
Add empty upgrade step to force preUpgrade to run
Eileen McNaughton [Sat, 20 May 2023 00:06:31 +0000 (12:06 +1200)]
Merge pull request #26271 from colemanw/revertFileDeletions
dev/core#4302 Revert "Remove old deprecated class aliases"
colemanw [Fri, 19 May 2023 17:08:46 +0000 (13:08 -0400)]
Merge pull request #26268 from eileenmcnaughton/562_member
dev/core#4282 Fix isShowMembershipBlock Regression
colemanw [Fri, 19 May 2023 17:07:10 +0000 (13:07 -0400)]
Merge pull request #26267 from eileenmcnaughton/562
Enotice fix on frontend_title
colemanw [Fri, 19 May 2023 13:25:25 +0000 (09:25 -0400)]
dev/core#4302 Revert "Remove old deprecated class aliases"
This reverts the file deletions from
f687b5a4eed2b67411a873c3346487bd5599497
as the files were still in use by some extensions.
Eileen McNaughton [Fri, 19 May 2023 02:47:39 +0000 (14:47 +1200)]
dev/core#4282 Fix isShowMembershipBlock
As determined by Konadave & myself this
isShowMembershipBlock was always true when memberships were in
play in 5.60 - despite various code comments. I have renamed
& assigned it regardless of QuickConfig. Since it is
a condition of including the tpl & within it it already checks
the context I made the context check the top level check & removed the
isShowMembershipBlock check
Eileen McNaughton [Fri, 19 May 2023 02:28:23 +0000 (14:28 +1200)]
Enotice fix on frontend_title
Eileen McNaughton [Wed, 17 May 2023 21:13:56 +0000 (09:13 +1200)]
Merge pull request #26252 from demeritcowboy/missing-help
Import help text gone missing
demeritcowboy [Wed, 17 May 2023 20:42:36 +0000 (16:42 -0400)]
help gone missing
Seamus Lee [Wed, 17 May 2023 04:04:02 +0000 (14:04 +1000)]
Merge pull request #26193 from eileenmcnaughton/member
Fix code handling to pre-5.61 for membership block
Seamus Lee [Wed, 17 May 2023 01:01:26 +0000 (11:01 +1000)]
Merge pull request #26239 from totten/5.62-uninstall
setup - Fix uninstall on MySQL 8.0
Tim Otten [Tue, 16 May 2023 23:56:18 +0000 (16:56 -0700)]
setup - Fix uninstall on MySQL 8.0
Overview
--------
Fix a bug with uninstalling or reinstalling via cv (`cv core:uninstall` or `cv core:install -f`) on MySQL 8.0.
Before
------
On MySQL 8.0, it fails - because all table-names appear as null.
It's looking for a result column named `table_name` but actually receives `TABLE_NAME`.
After
-----
Doesn't matter if the column is called `table_name` or `TABLE_NAME`.
Luke Stewart [Mon, 15 May 2023 21:52:04 +0000 (09:52 +1200)]
Adds warning similar to 5.57 if Activity Revisions are present.
Checks if upgrade is from version after 5.57.alpha1
If so check for any activities which are not the current revision
Issue warning.
Notes:
- Doesn't check if Foreign Key on delete trigger was updated to prevent
deletion
- Doesn't warn about the above - we assume this is covered in the steps
people will follow in the link - or that they will have done this
already.
Yashodha Chaku [Fri, 12 May 2023 12:22:35 +0000 (17:52 +0530)]
Merge pull request #26172 from eileenmcnaughton/562_import
dev/core#4227 Fix import to not blank birth_date etc on update
demeritcowboy [Thu, 11 May 2023 18:11:29 +0000 (14:11 -0400)]
Merge pull request #26199 from pradpnayak/fatalerror
Regression: Fatal error when importing membership
Pradeep Nayak [Thu, 11 May 2023 17:22:58 +0000 (18:22 +0100)]
Fixed fatal error when importing membership
Eileen McNaughton [Wed, 10 May 2023 23:38:11 +0000 (11:38 +1200)]
Fix code handling to pre-5.61 for membership block
The work for #26170 concluded that membershipPriceset is always TRUE
at this point. Since we were pushing out a regression fix I left the
variable where it didn't seem to be causing regressions.
However, I think clarifying the variable and
removing the redundant if-else in the rc will set us up well as
1) if there is any further regression we haven't found in
5.61 then people will be able to check on the rc / master
2) if we need to do any further fixes / back-ports the
code will be more synced if we do this in the rc
Note there is some further clean up I feel should be done
folloiwng what we learnt dealing with #26170 - but
I want to let the dust settle so that I'm not creating a
hard-to-backport situation
Tim Otten [Mon, 8 May 2023 20:29:31 +0000 (13:29 -0700)]
Merge pull request #26170 from eileenmcnaughton/562_member
Fix regression whereby membership does not submit
Eileen McNaughton [Mon, 8 May 2023 08:03:50 +0000 (20:03 +1200)]
CiviDiscount fix - pass correct component
Eileen McNaughton [Mon, 8 May 2023 05:37:57 +0000 (17:37 +1200)]
dev/core#4227 Fix import to not blank birth_date etc on update
Eileen McNaughton [Mon, 8 May 2023 04:27:08 +0000 (16:27 +1200)]
Re-instate the renewal message
Eileen McNaughton [Mon, 8 May 2023 03:45:13 +0000 (15:45 +1200)]
Fix regression whereby membership does not submit
demeritcowboy [Fri, 5 May 2023 21:10:51 +0000 (17:10 -0400)]
Merge pull request #26159 from demeritcowboy/drupal-cache
Upgrade message for drupal9 sites to advise to clear drupal cache
demeritcowboy [Fri, 5 May 2023 20:15:48 +0000 (16:15 -0400)]
upgrade message
CiviCRM [Thu, 4 May 2023 03:57:33 +0000 (03:57 +0000)]
Set version to 5.62.beta1
Seamus Lee [Thu, 4 May 2023 01:59:28 +0000 (11:59 +1000)]
Merge pull request #26144 from yashodha/core_2855
(dev/core#2855) Preserve pristine ids' for further manipulation via h…
Seamus Lee [Thu, 4 May 2023 01:55:37 +0000 (11:55 +1000)]
Merge pull request #26156 from civicrm/5.61
5.61
Seamus Lee [Thu, 4 May 2023 01:36:56 +0000 (11:36 +1000)]
Merge pull request #26155 from seamuslee001/5.61
Bump engine.io and socket.io versions
Tim Otten [Thu, 4 May 2023 01:27:23 +0000 (18:27 -0700)]
Merge pull request #26153 from totten/5.61-rn0
release-notes/5.61.0.md - Last minute additions
Seamus Lee [Thu, 4 May 2023 01:26:46 +0000 (11:26 +1000)]
Merge pull request #26108 from eileenmcnaughton/import_template
Importer - Ensure mapping ID is set in all places using import templates
Seamus Lee [Thu, 4 May 2023 01:20:09 +0000 (11:20 +1000)]
Bump engine.io and socket.io versions
Tim Otten [Thu, 4 May 2023 00:42:57 +0000 (17:42 -0700)]
release-notes/5.61.0.md - Last minute additions
Seamus Lee [Thu, 4 May 2023 00:12:22 +0000 (10:12 +1000)]
Merge pull request #26152 from civicrm/5.61
5.61
Tim Otten [Thu, 4 May 2023 00:05:28 +0000 (17:05 -0700)]
Merge pull request #26150 from totten/master-562-dedupe
FiveSixtyTwo - Improve detection of identical configurations
Seamus Lee [Wed, 3 May 2023 23:27:21 +0000 (09:27 +1000)]
Merge pull request #26140 from eileenmcnaughton/561
dev/core#4225 Add test & fix for new regression - contact update fails when relationship exists & CiviMember disabled
Tim Otten [Wed, 3 May 2023 22:33:17 +0000 (15:33 -0700)]
FiveSixtyTwo - When deciding to show messages, treat "CiviMail,CiviEvent" as equal to "CiviEvent,CiviMail"
Eileen McNaughton [Wed, 3 May 2023 22:20:17 +0000 (10:20 +1200)]
Merge pull request #26146 from MegaphoneJon/import-fill-fix
fixes core#4269 - Import "fill" doesn't fill phone/email
demeritcowboy [Wed, 3 May 2023 19:59:28 +0000 (15:59 -0400)]
Merge pull request #26147 from civicrm/5.61
5.61
demeritcowboy [Wed, 3 May 2023 18:55:42 +0000 (14:55 -0400)]
Merge pull request #26141 from eileenmcnaughton/561_member
dev/core#4272 Fix unreleased regression on Membership form validation
Jon Goldberg [Wed, 3 May 2023 18:09:53 +0000 (14:09 -0400)]
Fixes core#4269 - import 'fill' doesn't work on phone/email
yashodha [Wed, 3 May 2023 06:10:11 +0000 (11:40 +0530)]
(dev/core#2855) Preserve pristine ids' for further manipulation via hooks for reports
Yashodha Chaku [Wed, 3 May 2023 05:27:41 +0000 (10:57 +0530)]
Merge pull request #26131 from eileenmcnaughton/report_notice2
Further notice fixes on Constituent report
Eileen McNaughton [Wed, 3 May 2023 01:17:28 +0000 (13:17 +1200)]
dev/core#4272 Fix unreleased regression on Membership form validation
Eileen McNaughton [Wed, 3 May 2023 00:39:14 +0000 (12:39 +1200)]
Add Civi-Member is enabled check
Eileen McNaughton [Wed, 3 May 2023 00:31:33 +0000 (12:31 +1200)]
dev/core#4225 Add test for new regression
Eileen McNaughton [Wed, 3 May 2023 00:27:24 +0000 (12:27 +1200)]
Merge pull request #26121 from colemanw/removeConfigUses
Use settings::get instead of $config object to retrieve enabled components
Eileen McNaughton [Tue, 2 May 2023 22:23:31 +0000 (10:23 +1200)]
Merge pull request #26125 from MegaphoneJon/configurable-import-batch
Importer - Add system-setting for batch size
demeritcowboy [Tue, 2 May 2023 21:27:50 +0000 (17:27 -0400)]
Merge pull request #26139 from totten/master-tpl-auto
dev/core#4262 - Drop auto_detect_line_endings from civicrm.settings.php.template
demeritcowboy [Tue, 2 May 2023 21:22:14 +0000 (17:22 -0400)]
Merge pull request #26090 from demeritcowboy/price-use
dev/core#4248 - Fix missing price-set usage table
demeritcowboy [Tue, 2 May 2023 21:21:01 +0000 (17:21 -0400)]
Merge pull request #26091 from demeritcowboy/file-on-case-revision
dev/core#4220 - Don't make case activity revisions anymore when file-on-case
demeritcowboy [Tue, 2 May 2023 21:20:38 +0000 (17:20 -0400)]
Merge pull request #26138 from larssandergreen/expire-group-remove-notifications
Expire notifications for adding and removing groups, tags and relationships
Tim Otten [Tue, 2 May 2023 20:56:44 +0000 (13:56 -0700)]
dev/core#4262 - Drop auto_detect_line_endings from civicrm.settings.php.template
If the upgrader is telling you to remove it from `civicrm.settings.php`,
then... we probably don't need it in `civicrm.settings.php.template`...
Tim Otten [Tue, 2 May 2023 20:51:54 +0000 (13:51 -0700)]
Merge pull request #26136 from demeritcowboy/upgrade-autodetect
dev/core#4262 - Upgrade message about obsolete civicrm.settings.php setting that generates php warnings
larssandergreen [Tue, 2 May 2023 19:39:25 +0000 (13:39 -0600)]
Let non-critical notifications expire
demeritcowboy [Tue, 2 May 2023 19:24:21 +0000 (15:24 -0400)]
Merge pull request #26137 from yashodha/dev_2104
Add target contact custom data to activity report
demeritcowboy [Tue, 2 May 2023 17:30:02 +0000 (13:30 -0400)]
Merge pull request #26135 from seamuslee001/instructions_i18n_support
Surveys: Fix I18n translation support and WYSIWYG support
yashodha [Tue, 2 May 2023 13:52:15 +0000 (19:22 +0530)]
Add target contact custom data to activity report
Mathieu Lu [Tue, 2 May 2023 13:29:26 +0000 (09:29 -0400)]
Merge pull request #26124 from colemanw/afformNumbers
dev/core#4115 Afform - Handle decimal number fields
Seamus Lee [Tue, 2 May 2023 01:49:17 +0000 (11:49 +1000)]
Add instructions field into the skip fields array
Yashodha Chaku [Mon, 1 May 2023 17:16:05 +0000 (22:46 +0530)]
Merge pull request #26132 from eileenmcnaughton/report_notice
Contribution reports, specify type for is pledge payment
demeritcowboy [Mon, 1 May 2023 15:47:14 +0000 (11:47 -0400)]
warn about obsolete setting
Yashodha Chaku [Mon, 1 May 2023 07:39:47 +0000 (13:09 +0530)]
Merge pull request #26134 from eileenmcnaughton/report_notice_group
Remove notices on group_by i reports (eg pledge report)
Seamus Lee [Mon, 1 May 2023 07:11:50 +0000 (17:11 +1000)]
[REF] Add in I18n front end translation support and update widget to be a RichTextEditor for the translation given it is already a wysiyg in singlelingual mode
Eileen McNaughton [Mon, 1 May 2023 01:08:16 +0000 (13:08 +1200)]
Remove notices on group_by i reports (eg pledge report)
Eileen McNaughton [Mon, 1 May 2023 00:01:43 +0000 (12:01 +1200)]
Ensure printOnly is assigned
Eileen McNaughton [Sun, 30 Apr 2023 23:52:20 +0000 (11:52 +1200)]
Reduce notices by checking if key exists
Eileen McNaughton [Sun, 30 Apr 2023 23:49:23 +0000 (11:49 +1200)]
Contribution reports, specify type for is pledge payment
Eileen McNaughton [Sun, 30 Apr 2023 23:42:08 +0000 (11:42 +1200)]
Merge pull request #26130 from eileenmcnaughton/report_notice
Fix notice on Constituent Summary report (strict smarty)
Eileen McNaughton [Sun, 30 Apr 2023 23:35:06 +0000 (11:35 +1200)]
Ensure no_display key exists
Eileen McNaughton [Sun, 30 Apr 2023 23:31:55 +0000 (11:31 +1200)]
Add title for is_deleted
Eileen McNaughton [Sun, 30 Apr 2023 23:28:04 +0000 (11:28 +1200)]
Further notice fixes on Constituent report
Eileen McNaughton [Sun, 30 Apr 2023 23:14:01 +0000 (11:14 +1200)]
Fix notice on Constituent Summary report (strict smarty)
Eileen McNaughton [Sun, 30 Apr 2023 22:33:43 +0000 (10:33 +1200)]
Merge pull request #26128 from demeritcowboy/membership-offline
Offline membership receipt - custom message text is wrong
demeritcowboy [Sun, 30 Apr 2023 16:24:28 +0000 (12:24 -0400)]
regen
demeritcowboy [Sun, 30 Apr 2023 16:06:27 +0000 (12:06 -0400)]
the else went missing
demeritcowboy [Sat, 29 Apr 2023 17:31:19 +0000 (13:31 -0400)]
add test
demeritcowboy [Thu, 20 Apr 2023 17:58:53 +0000 (13:58 -0400)]
don't make revisions anymore
demeritcowboy [Sun, 30 Apr 2023 15:59:46 +0000 (11:59 -0400)]
Merge pull request #25930 from eileenmcnaughton/mem_receipt_offline
Update membership offline receipt to run off WorkflowTemplate & tokens
Eileen McNaughton [Sat, 29 Apr 2023 23:54:17 +0000 (11:54 +1200)]
Merge pull request #26126 from seamuslee001/upgrade_league_csv
[REF] Update league/csv package to 9.7.4 to remove need for patching
Eileen McNaughton [Sat, 29 Apr 2023 23:53:47 +0000 (11:53 +1200)]
Merge pull request #26127 from alifrumin/rn5.61
[NFC] 5.61 release notes
Alice Frumin [Fri, 28 Apr 2023 03:21:40 +0000 (23:21 -0400)]
[NFC] 5.61 release notes
Seamus Lee [Sat, 29 Apr 2023 03:54:45 +0000 (13:54 +1000)]
[REF] Update league/csv package to 9.7.4 to remove need for patching
Jon Goldberg [Fri, 28 Apr 2023 20:27:07 +0000 (16:27 -0400)]
configurable import batch size
Coleman Watts [Fri, 28 Apr 2023 19:20:41 +0000 (15:20 -0400)]
Afform - Handle decimal number fields
demeritcowboy [Fri, 28 Apr 2023 17:41:04 +0000 (13:41 -0400)]
Merge pull request #26122 from colemanw/geocodeMethod
Remove unused broken $config->geocodeMethod
Coleman Watts [Fri, 28 Apr 2023 14:52:57 +0000 (10:52 -0400)]
Remove unused broken $config->geocodeMethod
This deprecated item in the $config object couldn't possibly work because
the class and function it refers to don't exist!
colemanw [Fri, 28 Apr 2023 16:29:29 +0000 (12:29 -0400)]
Merge pull request #25535 from mattwire/afformreqselect2
Afform: Add required flag to select2
Coleman Watts [Fri, 28 Apr 2023 14:18:56 +0000 (10:18 -0400)]
Use settings::get instead of $config object to retrieve enableComponents
Eileen McNaughton [Fri, 28 Apr 2023 06:00:44 +0000 (18:00 +1200)]
Merge pull request #26118 from colemanw/civiGrantUpgrade
CiviGrant - Fix upgrade to work on multiple domains
Eileen McNaughton [Fri, 28 Apr 2023 03:18:44 +0000 (15:18 +1200)]
Merge pull request #26119 from civicrm/5.61
5.61
Coleman Watts [Fri, 28 Apr 2023 00:46:59 +0000 (20:46 -0400)]
CiviGrant - Fix upgrade to work on multiple domains
Eileen McNaughton [Thu, 27 Apr 2023 22:58:31 +0000 (10:58 +1200)]
Merge pull request #24765 from colemanw/priceSet
PriceSet - Fix metadata for extends column, for SearchKit compatibility
Eileen McNaughton [Thu, 27 Apr 2023 22:53:58 +0000 (10:53 +1200)]
Fix : to be withing ts