demeritcowboy [Tue, 4 Jul 2023 22:25:41 +0000 (18:25 -0400)]
Merge pull request #26731 from colemanw/killCrmUtilsArrayValue
REF - Replace CRM_Utils_Array::value with ??
Aidan Saunders [Tue, 4 Jul 2023 21:42:22 +0000 (22:42 +0100)]
Merge pull request #26730 from colemanw/fixSmartyRewrite
SearchKit - Fix check for smarty syntax in rewrite output
colemanw [Tue, 4 Jul 2023 21:21:32 +0000 (17:21 -0400)]
REF - Replace CRM_Utils_Array::value with ??
colemanw [Tue, 4 Jul 2023 17:57:31 +0000 (13:57 -0400)]
SearchKit - Fix check for smarty syntax in rewrite output
Fixes dev/core#4405
Aidan Saunders [Tue, 4 Jul 2023 16:54:35 +0000 (17:54 +0100)]
Merge pull request #26728 from howardshand/patch-1
Merged #26726 into master.
howardshand [Tue, 4 Jul 2023 16:46:42 +0000 (11:46 -0500)]
Merged #26726 into master.
colemanw [Tue, 4 Jul 2023 16:39:20 +0000 (09:39 -0700)]
Merge pull request #26726 from howardshand/patch-1
Update Api.php to correct external_identifier to type STRING
howardshand [Tue, 4 Jul 2023 16:22:17 +0000 (11:22 -0500)]
Update Api.php to correct external_identifier to type STRING
demeritcowboy [Tue, 4 Jul 2023 15:59:52 +0000 (11:59 -0400)]
Merge pull request #26724 from colemanw/shortArray
[REF] Autoformat php short array syntax
colemanw [Tue, 4 Jul 2023 13:40:56 +0000 (09:40 -0400)]
Autoformat php short array syntax
Monish Deb [Tue, 4 Jul 2023 04:17:06 +0000 (09:47 +0530)]
Merge pull request #26723 from colemanw/utilsArrayCleanup
[REF] Remove unnecessary CRM_Utils_Array::value and use short array syntax
Monish Deb [Tue, 4 Jul 2023 03:32:47 +0000 (09:02 +0530)]
Merge pull request #26699 from larssandergreen/Joomla-Permissions-warning
dev/joomla#51 Fix Joomla permissions warning
colemanw [Tue, 4 Jul 2023 03:12:12 +0000 (23:12 -0400)]
CRM - Remove unnecessary CRM_Utils_Array::value and use short array syntax
demeritcowboy [Tue, 4 Jul 2023 01:27:52 +0000 (21:27 -0400)]
Merge pull request #26669 from samuelsov/refAdminUI
#4360 #4384 fixing multiple regressions with path civicrm/contact/search
colemanw [Tue, 4 Jul 2023 00:46:32 +0000 (20:46 -0400)]
Add todo comment
Co-authored-by: demeritcowboy <demeritcowboy@hotmail.com>
Eileen McNaughton [Tue, 4 Jul 2023 00:09:48 +0000 (12:09 +1200)]
Merge pull request #26717 from eileenmcnaughton/event_test_data
Remove now unsed createEvent test function from test baseClass
demeritcowboy [Mon, 3 Jul 2023 23:07:54 +0000 (19:07 -0400)]
Merge pull request #23724 from mattwire/eventtest
Towards consistency for displaying test entities. Stop hiding test entities on some dashboards
Eileen McNaughton [Mon, 3 Jul 2023 19:38:44 +0000 (07:38 +1200)]
Remove now unsed createEvent test function
colemanw [Mon, 3 Jul 2023 21:52:53 +0000 (14:52 -0700)]
Merge pull request #26705 from colemanw/email
Render Email input as type="email"
Eileen McNaughton [Mon, 3 Jul 2023 21:29:47 +0000 (14:29 -0700)]
Merge pull request #26721 from eileenmcnaughton/group_bits
Add frontend_title to various data set up places
Eileen McNaughton [Mon, 3 Jul 2023 21:20:31 +0000 (14:20 -0700)]
Merge pull request #26715 from eileenmcnaughton/contact_trait
Include `entityTrait` in `ContactTestTrait`
Eileen McNaughton [Mon, 3 Jul 2023 21:18:57 +0000 (14:18 -0700)]
Merge pull request #26720 from eileenmcnaughton/unused
Remove some unused test functions
Eileen McNaughton [Mon, 3 Jul 2023 21:12:08 +0000 (14:12 -0700)]
Merge pull request #26646 from colemanw/actionMapping
Drop unused table civicrm_action_mapping
Eileen McNaughton [Mon, 3 Jul 2023 20:52:44 +0000 (13:52 -0700)]
Merge pull request #26718 from eileenmcnaughton/weight_1
Add weight to Group Links
Eileen McNaughton [Mon, 3 Jul 2023 20:49:46 +0000 (08:49 +1200)]
Add frontend_title to various data set up places
Eileen McNaughton [Mon, 3 Jul 2023 20:46:19 +0000 (08:46 +1200)]
Fix test set up to declare frontend_title
Eileen McNaughton [Mon, 3 Jul 2023 20:42:13 +0000 (13:42 -0700)]
Merge pull request #26716 from colemanw/searchContext
SearchKit - Provide context information to subscribers
Eileen McNaughton [Mon, 3 Jul 2023 19:18:54 +0000 (07:18 +1200)]
Include entityTrait in ContactTestTrait
Eileen McNaughton [Mon, 3 Jul 2023 20:31:57 +0000 (08:31 +1200)]
Remove some unused test functions
If I'm wrong jenkins will tell us
Eileen McNaughton [Mon, 3 Jul 2023 19:52:16 +0000 (07:52 +1200)]
Add weight to Group Links
colemanw [Mon, 3 Jul 2023 19:46:30 +0000 (12:46 -0700)]
Merge pull request #26505 from larssandergreen/PHP-warning-on-Contribution
Reduce PHP warnings with paymentBlock
colemanw [Sat, 24 Jun 2023 19:42:40 +0000 (12:42 -0700)]
Drop unused table civicrm_action_mapping
In 2015 this table was made obsolete by the new MappingInterface
and has not been used for anything since then.
colemanw [Mon, 3 Jul 2023 19:31:58 +0000 (12:31 -0700)]
Merge pull request #26709 from eileenmcnaughton/price_fee
Fix ChangeFeeSelectionTest to use eventCreatePaid
Eileen McNaughton [Mon, 3 Jul 2023 19:31:25 +0000 (12:31 -0700)]
Merge pull request #26710 from colemanw/customType
APIv4 - Add more metadata to CustomValue entities; use AutoService
Eileen McNaughton [Mon, 3 Jul 2023 19:30:21 +0000 (12:30 -0700)]
Merge pull request #26714 from colemanw/codeFixes
[REF] Code cleanup; remove unused vars and remove CRM_Utils_Array::value
Eileen McNaughton [Mon, 3 Jul 2023 19:25:03 +0000 (12:25 -0700)]
Merge pull request #26712 from larssandergreen/Install-SK-on-headless-tests
Install SK as part of headless test baseline
colemanw [Mon, 3 Jul 2023 19:22:09 +0000 (15:22 -0400)]
SearchKit - Provide context information to subscribers
colemanw [Mon, 3 Jul 2023 18:34:29 +0000 (14:34 -0400)]
Code cleanup; remove unused vars and remove CRM_Utils_Array::value
larssandergreen [Mon, 3 Jul 2023 18:14:54 +0000 (12:14 -0600)]
Install SK as part of headless test baseline
demeritcowboy [Mon, 3 Jul 2023 17:43:27 +0000 (13:43 -0400)]
Merge pull request #26696 from mlutfy/cleanupTmpTables
clearTempTables: fix condition for user_job check
colemanw [Mon, 3 Jul 2023 17:10:44 +0000 (10:10 -0700)]
Merge pull request #26713 from reflexive-communications/unsubscribe-properties
CRM_Mailing_Form_Optout, CRM_Mailing_Form_Unsubscribe: change properties to protected from private
colemanw [Mon, 3 Jul 2023 15:38:36 +0000 (08:38 -0700)]
Merge pull request #26711 from larssandergreen/Don't-show-SQL-text-in-SK-if-the-user-doesn't-have-permission
Don't show SQL text in SK if user does not have view debug permission
colemanw [Mon, 3 Jul 2023 02:05:56 +0000 (22:05 -0400)]
Render Email input as type="email"
Fixes dev/core#4300
colemanw [Mon, 3 Jul 2023 13:53:05 +0000 (09:53 -0400)]
APIv4 - Add more metadata to CustomValue entities; use AutoService
There are several places in SearchKit code that check an entity 'type' to see if it contains 'DAOEntity'; they all seem designed
to test if the query will go through (so does it support joins, etc?) and custom entities were getting overlooked.
While I was at it I switch to our new standard 'AutoService' style of event listener
Sandor Semsey [Mon, 3 Jul 2023 14:33:02 +0000 (16:33 +0200)]
make properties protected to get accessed by CRM_Core_Form::getVar()
Aidan Saunders [Mon, 3 Jul 2023 10:18:43 +0000 (11:18 +0100)]
Merge pull request #26698 from colemanw/customJoin
SearchKit - Allow custom fields in join conditions
Eileen McNaughton [Mon, 3 Jul 2023 06:53:12 +0000 (18:53 +1200)]
Fix ChangeFeeSelectionTest to use eventCreatePaid
Seamus Lee [Mon, 3 Jul 2023 05:40:38 +0000 (01:40 -0400)]
Merge pull request #26708 from eileenmcnaughton/part_create
Use eventCreateUnpaid in participantCreate
Eileen McNaughton [Mon, 3 Jul 2023 04:11:35 +0000 (16:11 +1200)]
Use eventCreateUnpaid in participantCreate
Eileen McNaughton [Mon, 3 Jul 2023 04:51:39 +0000 (21:51 -0700)]
Merge pull request #26707 from eileenmcnaughton/event_change
Fix ACLPermissionTrait to use EventTest create function
larssandergreen [Mon, 3 Jul 2023 04:41:36 +0000 (22:41 -0600)]
Don't show SQL text in SK if user does not have view debug permission
Eileen McNaughton [Mon, 3 Jul 2023 03:40:24 +0000 (15:40 +1200)]
Fix ACLPermissionTrait to use EventTest create function
Cleanup in related classes
Seamus Lee [Mon, 3 Jul 2023 03:42:40 +0000 (23:42 -0400)]
Merge pull request #26706 from civicrm/5.63
5.63
Seamus Lee [Mon, 3 Jul 2023 03:01:34 +0000 (23:01 -0400)]
Merge pull request #26695 from alifrumin/rn5.63
[NFC] First pass at 5.63 release notes
Seamus Lee [Mon, 3 Jul 2023 02:59:30 +0000 (22:59 -0400)]
Merge pull request #26703 from larssandergreen/Give-webtest-user-permission-to-view-debug
Allow Drupal webstest user to view debug output
Seamus Lee [Mon, 3 Jul 2023 02:59:12 +0000 (22:59 -0400)]
Merge pull request #26702 from larssandergreen/Fix-debug-permissions-issue-in-API4
Fix debug permissions for API 4 Explorer debug
Eileen McNaughton [Mon, 3 Jul 2023 02:57:53 +0000 (19:57 -0700)]
Merge pull request #26704 from eileenmcnaughton/event_t
Test cleanup in BAO_ParticipantTest
Eileen McNaughton [Mon, 3 Jul 2023 02:05:39 +0000 (14:05 +1200)]
Test cleanup in BAO_ParticipantTest
Fixes to use the trait. Also simplifies the fixEventLevel test
- the fixEventLevel function has a lot of set up with
some legacy function calls. However, the set up is not
relevent the the string-processing function being tested
larssandergreen [Mon, 3 Jul 2023 01:45:41 +0000 (19:45 -0600)]
Fix debug permissions for API 4 Explorer debug
larssandergreen [Mon, 3 Jul 2023 01:40:11 +0000 (19:40 -0600)]
Allow Drupal webstest user to view debug output
Eileen McNaughton [Mon, 3 Jul 2023 01:34:10 +0000 (18:34 -0700)]
Merge pull request #26701 from eileenmcnaughton/event
[Tests] Fix a few more places to use eventTrait & remove `legacyEventCreate`
Eileen McNaughton [Mon, 3 Jul 2023 00:20:34 +0000 (12:20 +1200)]
Fix a few more places to use eventTrait & remove legacyEventCreate
Tim Otten [Sun, 2 Jul 2023 21:26:45 +0000 (14:26 -0700)]
Merge pull request #26672 from totten/master-standalone-obj
Standalone - Track logged-in user object
colemanw [Sun, 2 Jul 2023 20:27:54 +0000 (13:27 -0700)]
Merge pull request #26697 from larssandergreen/Re-order-SearchDisplay-Links-options
Put link first in SearchDisplay Links options
larssandergreen [Sun, 2 Jul 2023 19:21:31 +0000 (13:21 -0600)]
Fix Joomla permissions warning
colemanw [Sun, 2 Jul 2023 17:39:34 +0000 (13:39 -0400)]
SearchKit - Allow custom fields in join conditions
Mathieu Lutfy [Sun, 2 Jul 2023 03:25:32 +0000 (23:25 -0400)]
clearTempTables: fix condition for user_job check, move check inside the loop
larssandergreen [Sun, 2 Jul 2023 15:51:55 +0000 (09:51 -0600)]
Put link first in SearchDisplay Links options
demeritcowboy [Sun, 2 Jul 2023 13:49:02 +0000 (09:49 -0400)]
Merge pull request #25224 from braders/casecreation-medium-options-suffixes
APIv4, Case API, configure options and suffixes for medium_id field
Alice Frumin [Mon, 26 Jun 2023 17:29:44 +0000 (13:29 -0400)]
[NFC] 5.63 release notes
colemanw [Sat, 1 Jul 2023 21:24:16 +0000 (14:24 -0700)]
Merge pull request #26694 from larssandergreen/Add-unsub-and-optout-combined-to-mailing-stats
Add calculated optout & unsub mailing stats to API 4
larssandergreen [Sat, 1 Jul 2023 20:48:10 +0000 (14:48 -0600)]
Add calculated optout & unsub mailing stats to API 4
colemanw [Sat, 1 Jul 2023 20:05:44 +0000 (13:05 -0700)]
Merge pull request #26689 from larssandergreen/Calculated-field-for-mailing-successful-deliveries
Add calculated fields to API 4 for total mailing stats
demeritcowboy [Sat, 1 Jul 2023 18:27:12 +0000 (14:27 -0400)]
Merge pull request #26693 from larssandergreen/Remove-PHP5-check
Don't check for PHP 5 on Mapping Settings
larssandergreen [Sat, 1 Jul 2023 17:31:31 +0000 (11:31 -0600)]
Add calculated fields to API 4 for overall mailing stats
larssandergreen [Sat, 1 Jul 2023 16:50:56 +0000 (10:50 -0600)]
Don't check for PHP 5
Eileen McNaughton [Sat, 1 Jul 2023 03:45:38 +0000 (20:45 -0700)]
Merge pull request #26692 from larssandergreen/Correct-type-in-API-mailing-events
Typo correct for MailingEventReply.php
larssandergreen [Fri, 30 Jun 2023 23:41:25 +0000 (17:41 -0600)]
Typo correct for MailingEventReply.php
Bradley Taylor [Tue, 27 Dec 2022 11:37:32 +0000 (11:37 +0000)]
APIv4, Case API, configure options and suffixes for medium_id field
Eileen McNaughton [Fri, 30 Jun 2023 20:19:12 +0000 (13:19 -0700)]
Merge pull request #26691 from MegaphoneJon/replace-deprecated-event-fee-quickform
replace deprecated functions in event fee form
Jon Goldberg [Fri, 30 Jun 2023 19:46:05 +0000 (15:46 -0400)]
replace deprecated functions in event fee form
Eileen McNaughton [Fri, 30 Jun 2023 19:24:54 +0000 (12:24 -0700)]
Merge pull request #26686 from mlutfy/noteEntityId
Note Form: use EntityFormTrait and setEntityId for postProcess hooks
Tim Otten [Fri, 30 Jun 2023 18:57:21 +0000 (11:57 -0700)]
Standalone - Drop extra lookup
Tim Otten [Thu, 29 Jun 2023 23:19:20 +0000 (16:19 -0700)]
Standalone - Fix reference to session-variable
Tim Otten [Tue, 27 Jun 2023 21:36:23 +0000 (14:36 -0700)]
(REF) Invert relation between login functions. Prepare to reduce loads.
Before:
* Civi\Standalone\Security::loginAuthenticatedUserRecord() calls
Civix\Authx\Standalone::loginStateless() and Civix\Authx\Standalone::loginStateful()
* The logged-in user may be loaded twice - e.g. for workflows that
hit `loginAuthenticatedUserRecord()`
After
* Civix\Authx\Standalone::loginStateless() and Civix\Authx\Standalone::loginStateful()
call Civi\Standalone\Security::loginAuthenticatedUserRecord()
* The logged-in user is still loaded twice... but it'll small fix to load only once.
Comments
* The redundancy arose because `loginAuthenticatedUserRecord()` had the full-record,
and it called to `loginStateless()` (etc) with just ID or name - which then loaded
the full-record again.
* One might ask: "Is one orientation conceptually or philosophically better
than the other?" I don't have a good answer to that, but... I think this
patch makes for a nicer symmetry between `Civi\Authx\Standalone` and
`Civi\Authx\{Drupal,WordPress,etc}`. In all cases, they take the
userID/username and then perform a 1-4 SLOC incantation that
populates the global user-record.
Eileen McNaughton [Fri, 30 Jun 2023 17:42:46 +0000 (10:42 -0700)]
Merge pull request #26687 from colemanw/grantAutocomplete
CiviGrant - Support APIv4 autocompletes
Eileen McNaughton [Fri, 30 Jun 2023 17:41:29 +0000 (10:41 -0700)]
Merge pull request #26683 from larssandergreen/Add-Mailing-delivered-to-API4
Add missing Mailing Events to API4: Delivered, Forward, Reply
Eileen McNaughton [Fri, 30 Jun 2023 17:40:30 +0000 (10:40 -0700)]
Merge pull request #26681 from colemanw/isPrettyMuchEqual
crmAutocomplete - Fix endless loop (again)
colemanw [Thu, 29 Jun 2023 17:07:19 +0000 (13:07 -0400)]
crmAutocomplete - Fix endless loop (again)
This regressed in
65a6ae6b9228ad945b0f2dc9b80886468098555f because the comparison
needs to equivocate numbers and numeric strings.
Update ang/crmUi.js
Co-authored-by: Rich Lott <artfulrobot@users.noreply.github.com>
colemanw [Fri, 30 Jun 2023 16:08:00 +0000 (09:08 -0700)]
Merge pull request #26685 from artfulrobot/artfulrobot-add-port-to-FB-redirect
Fix ommitted port when constructing redirect URL
Mathieu Lu [Fri, 30 Jun 2023 15:16:22 +0000 (11:16 -0400)]
Note Form: use EntityFormTrait and setEntityId for postProcess hooks
Rich Lott / Artful Robot [Fri, 30 Jun 2023 15:03:00 +0000 (16:03 +0100)]
Fix ommitted port when constructing redirect URL
Form Builder can be configured to send a redirect after a submission
form has submitted. Before this change it rebuilt URLs with all the
parts except the port, causing failures on sites that use a non standard
port. After this change, a port is used if there is one.
larssandergreen [Fri, 30 Jun 2023 00:25:41 +0000 (18:25 -0600)]
Add missing Mailing Events to API4: Delivered, Forward, Reply
colemanw [Fri, 30 Jun 2023 00:10:48 +0000 (17:10 -0700)]
Merge pull request #26682 from samuelsov/dev/core#4396
dev/core#4396 AdminUI Find contact using sort_name
Tim Otten [Tue, 27 Jun 2023 08:49:36 +0000 (01:49 -0700)]
Standalone - Track logged-in user object
Overview
--------
This is a partial solution for running `E2E_Extern_CliRunnerTest::testPermissionLookup()` on Standalone.
Technical Details
-----------------
The test calls:
```
cv ev --user='admin' 'echo json_encode(CRM_Core_Config::singleton()->userPermissionClass->check("administer CiviCRM", 0));'
```
Internally, this command relies on `CRM_Core_BAO_UFMatch::synchronize()` by way of:
https://github.com/civicrm/cv/blob/
59efd9ffefde8dc500643e048d37db90e0de11b7/src/Util/BootTrait.php#L213-L235
Calls to `UFMatch::synchronize($user)` are expected to pass in a user-record.
Before
------
Standalone logins record the active user-ID.
After
------
Standalone logins record the active user-ID and active user-record (which can be supplied to `UFMatch::synchronize()`).
Samuel Vanhove [Thu, 29 Jun 2023 20:12:03 +0000 (16:12 -0400)]
dev/core#4396
Eileen McNaughton [Thu, 29 Jun 2023 20:10:19 +0000 (13:10 -0700)]
Merge pull request #26680 from demeritcowboy/codegen-php8
[PHP8] Codegen - Don't generate invalid secondary emails
Samuel Vanhove [Thu, 29 Jun 2023 19:32:22 +0000 (15:32 -0400)]
Upgrader for menu instead of a managed
colemanw [Thu, 29 Jun 2023 18:10:01 +0000 (14:10 -0400)]
CiviGrant - Support APIv4 autocompletes
demeritcowboy [Thu, 29 Jun 2023 14:39:15 +0000 (10:39 -0400)]
Merge pull request #26673 from larssandergreen/Rename-dedupe-rules
Clarify dedupe rules as "Name or Email"