Jon Goldberg [Wed, 30 Aug 2023 18:57:39 +0000 (14:57 -0400)]
fix sort groups on PHP8
colemanw [Wed, 30 Aug 2023 18:32:23 +0000 (14:32 -0400)]
Merge pull request #27208 from eileenmcnaughton/stop_testing_the_test
Remove old tests that only test test functions
Mathieu Lu [Wed, 30 Aug 2023 14:52:23 +0000 (10:52 -0400)]
Merge pull request #27194 from larssandergreen/SMS-error-message
Update SMS cannot send message to specify that a mobile phone number is required
demeritcowboy [Wed, 30 Aug 2023 12:48:30 +0000 (08:48 -0400)]
Merge pull request #27205 from eileenmcnaughton/test_easy
Simplify test
Eileen McNaughton [Wed, 30 Aug 2023 05:34:47 +0000 (17:34 +1200)]
Merge pull request #27207 from eileenmcnaughton/multi
Move smarty assign to be always assigned (notices)
Eileen McNaughton [Wed, 30 Aug 2023 04:55:39 +0000 (16:55 +1200)]
Remove old tests that only test test functions
These tests are calling the test functions to create & delete contacts- but these are not 'real'
functions - ideally we wouldn't even call them in tests. We have lots of cover for the
actual functions - so just removing
Seamus Lee [Wed, 30 Aug 2023 04:45:27 +0000 (00:45 -0400)]
Merge pull request #27206 from eileenmcnaughton/delete_test
Remove never called testCleanUp function
Eileen McNaughton [Wed, 30 Aug 2023 04:40:38 +0000 (16:40 +1200)]
Move smarty assign to be always assigned (notices)
Eileen McNaughton [Wed, 30 Aug 2023 03:28:46 +0000 (15:28 +1200)]
Remove never called testCleanUp function
deleteTestObjects is not called, except by itself, which is not called. Without
that function there is no need to 'register' the test entities either...
Eileen McNaughton [Wed, 30 Aug 2023 02:01:24 +0000 (14:01 +1200)]
Simplify test
Tim Otten [Tue, 29 Aug 2023 23:17:24 +0000 (16:17 -0700)]
Merge pull request #27138 from artfulrobot/artfulrobot-improve-initialization-crash-message
Improve initialization crash message
Eileen McNaughton [Tue, 29 Aug 2023 18:59:29 +0000 (06:59 +1200)]
Merge pull request #27198 from larssandergreen/Fix-membership-renewal-leap-year-bug
dev/core#4541 Fix membership leap year bug that causes test failure
larssandergreen [Tue, 29 Aug 2023 18:33:59 +0000 (12:33 -0600)]
Fix membership leap year bug
Rich Lott / Artful Robot [Tue, 29 Aug 2023 11:30:24 +0000 (12:30 +0100)]
Improve debug() function
larssandergreen [Tue, 29 Aug 2023 05:38:40 +0000 (23:38 -0600)]
Update SMS cannot send message to specify that a mobile phone number is required
Eileen McNaughton [Tue, 29 Aug 2023 04:22:09 +0000 (16:22 +1200)]
Merge pull request #27192 from eileenmcnaughton/hidden
[REF] Remove unreachable handling
Eileen McNaughton [Tue, 29 Aug 2023 02:39:54 +0000 (14:39 +1200)]
Merge pull request #27193 from eileenmcnaughton/hidden_2
Remove always-true empty check
Eileen McNaughton [Tue, 29 Aug 2023 02:02:24 +0000 (14:02 +1200)]
Remove always-true empty check
Per https://github.com/civicrm/civicrm-core/pull/27192
hidden_CreditCard is always empty so the check is meaningless.
The newer boolean token check is safer than the quoted string check
Eileen McNaughton [Tue, 29 Aug 2023 01:59:22 +0000 (13:59 +1200)]
Remove unreachable handling
generatePane is only called from one function & those calls have either AdditionalDetail
or Premium as the type - the rest of the handling in the function
apparently relates to before we used the payment form load method (a long time ago)
Eileen McNaughton [Tue, 29 Aug 2023 01:04:07 +0000 (13:04 +1200)]
Merge pull request #27183 from colemanw/relationshipAcls
APIv4 - Proper ACLs for relationship entity
Eileen McNaughton [Mon, 28 Aug 2023 22:41:45 +0000 (10:41 +1200)]
Merge pull request #27191 from colemanw/removeDateFields
CRM_Core_Form - Remove unused protected properties
Seamus Lee [Mon, 28 Aug 2023 22:19:05 +0000 (18:19 -0400)]
Merge pull request #27113 from eileenmcnaughton/redis_flush
Flush Redis `prevnext` cache when clearing `civicrm_cache`
Seamus Lee [Mon, 28 Aug 2023 22:18:06 +0000 (18:18 -0400)]
Merge pull request #27172 from colemanw/suffixes
[REF] Add pseudoconstant suffixes to xml/dao
Seamus Lee [Mon, 28 Aug 2023 22:15:24 +0000 (18:15 -0400)]
Merge pull request #27187 from colemanw/utilsArrayX
[REF] 🏌️ CRM_Utils_Array cleanup
Seamus Lee [Mon, 28 Aug 2023 22:13:43 +0000 (18:13 -0400)]
Merge pull request #27186 from colemanw/void
[NFC] Test - Add return type hints to test functions
Seamus Lee [Mon, 28 Aug 2023 22:13:07 +0000 (18:13 -0400)]
Merge pull request #27190 from eileenmcnaughton/domain_email_2
Fix Domain Organization form for notices & php8 compliance
Seamus Lee [Mon, 28 Aug 2023 22:12:56 +0000 (18:12 -0400)]
Merge pull request #27189 from eileenmcnaughton/domain_email
Fix notices on domain.tpl by just adding what we need
colemanw [Mon, 28 Aug 2023 21:55:44 +0000 (17:55 -0400)]
CRM_Core_Form - Remove unused var _is_pay_later_enabled
This field was added in
cbcb5b49 but was never used for anything.
colemanw [Mon, 28 Aug 2023 21:53:34 +0000 (17:53 -0400)]
CRM_Core_Form - Remove unused var _dateFields
This field was added in
5d86176 for the sake of the convertDateFieldsToMySQL() function which has since been deleted.
Tim Otten [Mon, 28 Aug 2023 21:52:12 +0000 (14:52 -0700)]
Merge pull request #27104 from mlutfy/distmakerStandalone
Distmaker: add CiviCRM Standalone support
Tim Otten [Mon, 28 Aug 2023 21:41:25 +0000 (14:41 -0700)]
Merge pull request #27181 from colemanw/api3UnusedCode
APIv3 Explorer - Delete unused code
colemanw [Mon, 28 Aug 2023 15:52:04 +0000 (11:52 -0400)]
Test - Add return type hints to test functions
Tim Otten [Mon, 28 Aug 2023 21:23:34 +0000 (14:23 -0700)]
Merge pull request #27180 from colemanw/deprecateApiWrapper
API - Soft-deprecate civicrm_api() wrapper
Eileen McNaughton [Mon, 28 Aug 2023 21:12:26 +0000 (09:12 +1200)]
Fix remaining undefined properties by no longer calling unrelated preProcess
Eileen McNaughton [Mon, 28 Aug 2023 20:50:50 +0000 (08:50 +1200)]
Fix notices on domain.tpl by just adding what we need
Eileen McNaughton [Mon, 28 Aug 2023 21:08:24 +0000 (09:08 +1200)]
Merge pull request #27188 from eileenmcnaughton/notice_1
E-notice fix - switch order of and params check around
Eileen McNaughton [Mon, 28 Aug 2023 20:50:50 +0000 (08:50 +1200)]
Fix notices on domain.tpl by just adding what we need
Eileen McNaughton [Mon, 28 Aug 2023 20:17:10 +0000 (08:17 +1200)]
E-notice fix - switch order of and params check around
colemanw [Mon, 28 Aug 2023 16:23:02 +0000 (12:23 -0400)]
CRM/Report - Cleanup bitwise conditionals using CRM_Utils_Array
colemanw [Mon, 28 Aug 2023 16:12:29 +0000 (12:12 -0400)]
CRM - Cleanup verbose array conditionals
colemanw [Sat, 26 Aug 2023 03:37:45 +0000 (23:37 -0400)]
API - Soft-deprecate civicrm_api() wrapper, cleanup code comments, remove unused vars
demeritcowboy [Mon, 28 Aug 2023 14:50:08 +0000 (10:50 -0400)]
Merge pull request #27185 from seamuslee001/better_reporting_invalid_instance
[REF] Improve cron job handling when there is an invalid report insta…
demeritcowboy [Mon, 28 Aug 2023 14:44:13 +0000 (10:44 -0400)]
Merge pull request #27184 from seamuslee001/infinite_loop_report
[REF] Fix infinite loop when trying to load a report instance with an…
colemanw [Fri, 25 Aug 2023 20:04:38 +0000 (16:04 -0400)]
Add pseudoconstant suffixes to xml/dao
This makes suffixes more available outside APIv4, and reduces the necessity of one-off SpecProvider classes
Seamus Lee [Mon, 28 Aug 2023 04:52:56 +0000 (14:52 +1000)]
[REF] Improve cron job handling when there is an invalid report instance id passed to mail_report job
Seamus Lee [Mon, 28 Aug 2023 04:43:15 +0000 (14:43 +1000)]
[REF] Fix infinite loop when trying to load a report instance with an id that does not exist
colemanw [Mon, 28 Aug 2023 02:09:19 +0000 (22:09 -0400)]
APIv4 - Proper ACLs for relationship entity
Before: APIv3 and v4 require 'edit all contacts' to create/update/delete relationships
After: APIv3 unchanged, but v4 uses ACLs instead so the permission is no longer needed.
Seamus Lee [Sun, 27 Aug 2023 23:50:14 +0000 (19:50 -0400)]
Merge pull request #27182 from civicrm/5.65
5.65
Seamus Lee [Sun, 27 Aug 2023 23:21:47 +0000 (19:21 -0400)]
Merge pull request #27170 from agh1/5.65.0-releasenotes-initial
5.65.0 release notes initial run
Seamus Lee [Sun, 27 Aug 2023 23:21:23 +0000 (19:21 -0400)]
Merge pull request #27179 from totten/master-phpstorm-setting
PhpStorm - Add a corybantic avalanche of type-hints
colemanw [Sun, 27 Aug 2023 02:52:38 +0000 (22:52 -0400)]
Merge pull request #27161 from eileenmcnaughton/discount
Add test & fix for getOptions on options with a domain id
Tim Otten [Sat, 26 Aug 2023 02:59:34 +0000 (19:59 -0700)]
phpstorm - Generate event hints for "hook_civicrm_pre::Entity" (and similar)
colemanw [Sat, 26 Aug 2023 02:47:52 +0000 (22:47 -0400)]
APIv3 Explorer - Delete unused code
Delete code no longer needed now that examples have been deleted in
44def67
Tim Otten [Sat, 26 Aug 2023 02:44:59 +0000 (19:44 -0700)]
phpstorm - Generate hints about Civi::dispatcher()
Tim Otten [Sat, 26 Aug 2023 02:29:20 +0000 (19:29 -0700)]
phpstorm - Generate hints about civicrm_api3()
Coleman Watts [Sat, 26 Aug 2023 02:14:23 +0000 (19:14 -0700)]
phpstorm - Generate hints about civicrm_api4()
colemanw [Sat, 26 Aug 2023 02:19:46 +0000 (22:19 -0400)]
Merge pull request #27112 from colemanw/sortName
SearchKit - Use Contact.sort_name instead of display_name for searches and Autocompletes
Tim Otten [Sat, 26 Aug 2023 00:43:18 +0000 (17:43 -0700)]
phpstorm - Generate hints about CiviCRM settings
Tim Otten [Sat, 26 Aug 2023 00:41:58 +0000 (17:41 -0700)]
PhpStormMetadata - Define registerArgumentsSet() and addExpectedArguments()
Tim Otten [Sat, 26 Aug 2023 01:52:05 +0000 (18:52 -0700)]
(NFC) phpstorm.php
Tim Otten [Sat, 26 Aug 2023 01:57:32 +0000 (18:57 -0700)]
Use `hook_managed` to implement `civi.phpstorm.flush`
Tim Otten [Fri, 25 Aug 2023 23:57:27 +0000 (16:57 -0700)]
phpstorm - Enable 'scan-classes'
Tim Otten [Sat, 26 Aug 2023 00:27:42 +0000 (17:27 -0700)]
Merge pull request #27175 from totten/master-phpstorm-redux
phpstorm - Multiple updates
Tim Otten [Sat, 26 Aug 2023 00:27:33 +0000 (17:27 -0700)]
Merge pull request #27177 from colemanw/api4EntityNames
[REF] APIv4 - Simplify entity name gathering
Tim Otten [Sat, 26 Aug 2023 00:16:11 +0000 (17:16 -0700)]
Merge pull request #27178 from colemanw/phpStormStatic
PHPStorm - Add static metadata file
demeritcowboy [Sat, 26 Aug 2023 00:10:48 +0000 (20:10 -0400)]
Merge pull request #27176 from colemanw/api3ExampleCleanup
Test Cleanup - Refactor out uses of deprecated `callAPIAndDocument()`
demeritcowboy [Sat, 26 Aug 2023 00:09:38 +0000 (20:09 -0400)]
Merge pull request #27166 from eileenmcnaughton/test_fix
Remove some unused parameters in test class
colemanw [Sat, 26 Aug 2023 00:09:03 +0000 (20:09 -0400)]
PHPStorm - Add static metadata file
colemanw [Fri, 25 Aug 2023 16:26:57 +0000 (12:26 -0400)]
APIv4 - Simplify entity name gathering
Before: Getting entity names was hard and the conformanceTest struggled
After: It's easier, as every entity class has a public getEntityName method
colemanw [Fri, 25 Aug 2023 23:00:56 +0000 (19:00 -0400)]
Test Cleanup - Refactor out uses of deprecated `callAPIAndDocument()`
Tim Otten [Fri, 25 Aug 2023 23:33:49 +0000 (16:33 -0700)]
Fix type-hints for boot services
Tim Otten [Fri, 25 Aug 2023 23:16:28 +0000 (16:16 -0700)]
PhpStormCompilePass - Generate hints for `Civi::cache()`
The `cache()` method just returns objects from the container, so it can come from the same metadata.
Tim Otten [Fri, 25 Aug 2023 22:58:48 +0000 (15:58 -0700)]
Add README.md
Tim Otten [Fri, 25 Aug 2023 22:58:25 +0000 (15:58 -0700)]
phpstorm - Re-enable standard civix bits
Tim Otten [Fri, 25 Aug 2023 22:56:28 +0000 (15:56 -0700)]
phpstorm - Cleanup on uninstall
Tim Otten [Fri, 25 Aug 2023 22:52:00 +0000 (15:52 -0700)]
(REF) Extract helper PhpStormMetadata
demeritcowboy [Fri, 25 Aug 2023 22:46:44 +0000 (18:46 -0400)]
Merge pull request #27174 from colemanw/examples
APIv3 - Delete api examples
Tim Otten [Fri, 25 Aug 2023 22:03:12 +0000 (15:03 -0700)]
phpstorm - Convert "Generator" to "PhpStormCompilePass"
colemanw [Fri, 25 Aug 2023 20:23:16 +0000 (16:23 -0400)]
APIv3 - Delete api examples
Andie Hunt [Fri, 25 Aug 2023 15:51:17 +0000 (11:51 -0400)]
5.65.0 release notes: added boilerplate
Andie Hunt [Fri, 25 Aug 2023 15:40:12 +0000 (11:40 -0400)]
5.65.0 release notes: raw from script
colemanw [Fri, 25 Aug 2023 12:51:04 +0000 (08:51 -0400)]
Merge pull request #27169 from yashodha/report_improvement
(dev/core#4536) Fix 'Primary Membership' filter options in Membership…
colemanw [Fri, 25 Aug 2023 12:46:33 +0000 (08:46 -0400)]
Merge pull request #27168 from totten/master-phpstorm
Add "phpstorm" extension
yashodha [Fri, 25 Aug 2023 12:14:30 +0000 (17:44 +0530)]
(dev/core#4536) Fix 'Primary Membership' filter options in Membership Details report
Tim Otten [Fri, 25 Aug 2023 12:03:02 +0000 (05:03 -0700)]
phpstorm - Move listener to the end of the hook
Tim Otten [Fri, 25 Aug 2023 11:37:21 +0000 (04:37 -0700)]
Add extension "phpstorm"
colemanw [Fri, 25 Aug 2023 10:56:00 +0000 (06:56 -0400)]
Merge pull request #27157 from eileenmcnaughton/execute
Fix deprecation notice on ExecuteJob screen
colemanw [Fri, 25 Aug 2023 10:42:52 +0000 (06:42 -0400)]
Merge pull request #27154 from eileenmcnaughton/notice_reminders
Notice fix - schedule reminders
colemanw [Fri, 25 Aug 2023 10:38:51 +0000 (06:38 -0400)]
Merge pull request #27163 from eileenmcnaughton/broken
Remove broken deprecated function
Eileen McNaughton [Fri, 25 Aug 2023 08:53:19 +0000 (20:53 +1200)]
Merge pull request #27160 from larssandergreen/Also-add-event-confirm-text-as-default-receipt_text-for-edit-Participant
Also add event confirm text as default receipt_text for edit Participant
Eileen McNaughton [Fri, 25 Aug 2023 08:49:47 +0000 (20:49 +1200)]
Merge pull request #27137 from artfulrobot/artfulrobot-php81-table-tpl
Fix PHP8.1 repeated notice errors in Table.tpl
Seamus Lee [Fri, 25 Aug 2023 07:50:27 +0000 (03:50 -0400)]
Merge pull request #27164 from seamuslee001/acl_notice_error
[REF] Fix Notice Errors on ACL listing page by assigning fields consi…
Rich Lott / Artful Robot [Thu, 24 Aug 2023 15:00:24 +0000 (16:00 +0100)]
Fix PHP8.1 repeated notice errors in Table.tpl
Rich Lott / Artful Robot [Thu, 24 Aug 2023 15:17:12 +0000 (16:17 +0100)]
Improve browser output in case of an initialization error
Eileen McNaughton [Fri, 25 Aug 2023 06:12:52 +0000 (18:12 +1200)]
Remove some unused parameters
Seamus Lee [Fri, 25 Aug 2023 06:04:17 +0000 (16:04 +1000)]
[REF] Fix Notice Errors on ACL listing page by assigning fields consistently
Eileen McNaughton [Fri, 25 Aug 2023 05:52:29 +0000 (17:52 +1200)]
Remove broken deprecated function
The function this calls was made private in Feb & no-one has noticed. It's deprecated
& I can't find any calls to it so I guess it has been unused-long-time
Eileen McNaughton [Fri, 25 Aug 2023 05:23:48 +0000 (17:23 +1200)]
Add test & fix for getOptions
Yashodha Chaku [Fri, 25 Aug 2023 05:31:52 +0000 (11:01 +0530)]
Merge pull request #27148 from eileenmcnaughton/fee_block
Undefined property fix
Eileen McNaughton [Fri, 25 Aug 2023 05:24:56 +0000 (17:24 +1200)]
Merge pull request #27122 from eileenmcnaughton/discount
Add api-v4 discount api