civicrm-core.git
2 years agoCivi::pipe - Define option `apiError`
Tim Otten [Wed, 15 Dec 2021 01:53:09 +0000 (17:53 -0800)]
Civi::pipe - Define option `apiError`

This option balances two interests:

- For generic plumbing code, it's easier to keep the API errors in their canonical format.
- For bespoke JSON-RPC client code, it's easier to bind errors into JSON-RPC errors. This way
  downstream clients can adapt the errors to their own convention (PHP exceptions, JS exceptions,
  promise-failures, ad nauseum)

2 years agoCivi::pipe - Add top-level facade. Add E2E test.
Tim Otten [Wed, 15 Dec 2021 00:38:00 +0000 (16:38 -0800)]
Civi::pipe - Add top-level facade. Add E2E test.

2 years agoCivi::pipe - JSON-RPC 2.0 session
Tim Otten [Wed, 15 Dec 2021 00:39:01 +0000 (16:39 -0800)]
Civi::pipe - JSON-RPC 2.0 session

2 years agoCivi::pipe - Basic JSON session
Tim Otten [Wed, 15 Dec 2021 00:37:38 +0000 (16:37 -0800)]
Civi::pipe - Basic JSON session

2 years agoCivi::pipe - Add some initial utilities
Tim Otten [Wed, 15 Dec 2021 00:34:56 +0000 (16:34 -0800)]
Civi::pipe - Add some initial utilities

2 years agoMerge pull request #22496 from civicrm/5.46
Eileen McNaughton [Thu, 13 Jan 2022 05:29:37 +0000 (18:29 +1300)]
Merge pull request #22496 from civicrm/5.46

5.46

2 years agoMerge pull request #22443 from eileenmcnaughton/download
colemanw [Thu, 13 Jan 2022 03:27:14 +0000 (22:27 -0500)]
Merge pull request #22443 from eileenmcnaughton/download

Remove support for deprecated key

2 years agoMerge pull request #22485 from eileenmcnaughton/ab
colemanw [Thu, 13 Jan 2022 03:25:39 +0000 (22:25 -0500)]
Merge pull request #22485 from eileenmcnaughton/ab

Fully remove contactAB function

2 years agoMerge pull request #22498 from eileenmcnaughton/mem_act
colemanw [Thu, 13 Jan 2022 03:24:55 +0000 (22:24 -0500)]
Merge pull request #22498 from eileenmcnaughton/mem_act

Don't default membership type create to inactive

2 years agoMerge pull request #22464 from colemanw/extRequirementCheck
Eileen McNaughton [Thu, 13 Jan 2022 02:08:56 +0000 (15:08 +1300)]
Merge pull request #22464 from colemanw/extRequirementCheck

Extensions - Add dependency status check

2 years agoDon't default membership type create to inactive
Eileen McNaughton [Thu, 13 Jan 2022 01:55:38 +0000 (14:55 +1300)]
Don't default membership type create to inactive

We don't do this for any other entity...

2 years agoMerge pull request #22494 from eileenmcnaughton/fin
Eileen McNaughton [Thu, 13 Jan 2022 01:53:59 +0000 (14:53 +1300)]
Merge pull request #22494 from eileenmcnaughton/fin

Remove handling for impossible array

2 years agoMerge pull request #22490 from colemanw/refreshButton
Seamus Lee [Thu, 13 Jan 2022 01:48:29 +0000 (12:48 +1100)]
Merge pull request #22490 from colemanw/refreshButton

SearchKit - Facilitate popup forms

2 years agoMerge pull request #22403 from colemanw/api4WriteRecords
Eileen McNaughton [Thu, 13 Jan 2022 00:57:36 +0000 (13:57 +1300)]
Merge pull request #22403 from colemanw/api4WriteRecords

[REF] Improve APIv4 save functions

2 years agoMerge pull request #22493 from eileenmcnaughton/546
Eileen McNaughton [Thu, 13 Jan 2022 00:45:02 +0000 (13:45 +1300)]
Merge pull request #22493 from eileenmcnaughton/546

Cleanup test class

2 years agoMerge pull request #22467 from colemanw/civigrantSearchKitTab
Eileen McNaughton [Thu, 13 Jan 2022 00:42:19 +0000 (13:42 +1300)]
Merge pull request #22467 from colemanw/civigrantSearchKitTab

CiviGrant - Use SearchKit for contact summary tab

2 years agoMerge pull request #22492 from braders/system-utils-docblock
colemanw [Thu, 13 Jan 2022 00:31:56 +0000 (19:31 -0500)]
Merge pull request #22492 from braders/system-utils-docblock

Improve method phpdoc for CRM_Utils_System

2 years agoRemove handling for impossible array
Eileen McNaughton [Thu, 13 Jan 2022 00:11:24 +0000 (13:11 +1300)]
Remove handling for impossible array

CRM_Financial_BAO_FinancialType::buildPermissionedClause is only called from one place
outside of tests. That place passes in this->_whereClause which is the result of calling
this->whereClause() a few lines earlier. As that function always returns a string
we know that it cannot be an array & can remove the handling

2 years agoCleanup test class
Eileen McNaughton [Wed, 5 Jan 2022 22:04:10 +0000 (11:04 +1300)]
Cleanup test class

2 years agocrmDialog - Add convenience binding to automatically launch a dialog when clicking...
Coleman Watts [Wed, 12 Jan 2022 21:07:49 +0000 (16:07 -0500)]
crmDialog - Add convenience binding to automatically launch a dialog when clicking an element

2 years agoSearchKit - Auto-refresh search when popup forms submit
Coleman Watts [Wed, 12 Jan 2022 21:06:33 +0000 (16:06 -0500)]
SearchKit - Auto-refresh search when popup forms submit

This expands the listener to the entire surrounding <form> element,
in case there are related popups on the Afform.

2 years agoImprove method phpdoc for CRM_Utils_System
Bradley Taylor [Wed, 12 Jan 2022 22:37:43 +0000 (22:37 +0000)]
Improve method phpdoc for CRM_Utils_System

2 years agoCiviGrant - Ensure dependencies are installed before running tests
Coleman Watts [Wed, 12 Jan 2022 22:33:08 +0000 (17:33 -0500)]
CiviGrant - Ensure dependencies are installed before running tests

2 years agoMerge pull request #22486 from eileenmcnaughton/rel_check
colemanw [Wed, 12 Jan 2022 21:02:58 +0000 (16:02 -0500)]
Merge pull request #22486 from eileenmcnaughton/rel_check

Remove always-true-if

2 years agoRemove always-true-if
Eileen McNaughton [Wed, 12 Jan 2022 05:06:56 +0000 (18:06 +1300)]
Remove always-true-if

We just ensured organization is numeric so .. it is

2 years agoFully remove contactAB function
Eileen McNaughton [Wed, 12 Jan 2022 05:01:36 +0000 (18:01 +1300)]
Fully remove contactAB function

The function was a really long winded way of doing what the 3 lines do.

Universe search did not reveal other usages and it is not the
sort of function we would expect to be used by extensions so
I'm straight removing it

2 years agoMerge pull request #22468 from eileenmcnaughton/ab
Seamus Lee [Wed, 12 Jan 2022 04:49:34 +0000 (15:49 +1100)]
Merge pull request #22468 from eileenmcnaughton/ab

Stop calling confusing function that doesn't do much .....

2 years agoMerge pull request #22484 from civicrm/5.46
Eileen McNaughton [Wed, 12 Jan 2022 04:39:00 +0000 (17:39 +1300)]
Merge pull request #22484 from civicrm/5.46

5.46 to master

2 years agoMerge pull request #22479 from demeritcowboy/fulltext-quickfix-546
Eileen McNaughton [Wed, 12 Jan 2022 04:38:33 +0000 (17:38 +1300)]
Merge pull request #22479 from demeritcowboy/fulltext-quickfix-546

dev/core#3026 - 5.46 version of 22478

2 years agoquickfix for fulltext search drupal block
demeritcowboy [Wed, 12 Jan 2022 02:35:33 +0000 (21:35 -0500)]
quickfix for fulltext search drupal block

2 years agoMerge pull request #22469 from eileenmcnaughton/help
demeritcowboy [Wed, 12 Jan 2022 00:33:33 +0000 (19:33 -0500)]
Merge pull request #22469 from eileenmcnaughton/help

Remove seemingly unreachable help text

2 years agoMerge pull request #22472 from eileenmcnaughton/import
demeritcowboy [Wed, 12 Jan 2022 00:18:31 +0000 (19:18 -0500)]
Merge pull request #22472 from eileenmcnaughton/import

Move function to the class that 'owns' it

2 years agoMerge pull request #22451 from MegaphoneJon/member-count-fix
Eileen McNaughton [Tue, 11 Jan 2022 23:05:33 +0000 (12:05 +1300)]
Merge pull request #22451 from MegaphoneJon/member-count-fix

Crash when adding a relationship when CiviMember is disabled

2 years agoMerge pull request #22474 from braders/incoming-mail-broken-fn-reference
Eileen McNaughton [Tue, 11 Jan 2022 20:36:19 +0000 (09:36 +1300)]
Merge pull request #22474 from braders/incoming-mail-broken-fn-reference

Fix broken function reference

2 years agofix accessing member/contribution count when not enabled
Jon Goldberg [Mon, 10 Jan 2022 18:11:57 +0000 (13:11 -0500)]
fix accessing member/contribution count when not enabled

2 years agoMove function to the class that 'owns' it
Eileen McNaughton [Tue, 11 Jan 2022 11:50:11 +0000 (00:50 +1300)]
Move function to the class that 'owns' it

Following https://github.com/civicrm/civicrm-core/commit/f54e87d9cf1e216036adf92f744cdbac3c1fe79e#diff-5864d6a1d03dffb7699b930837c1c222b41fba16dad7d0a5f73b4923ac53dd42R198
neither of these functions are called from outside their class (I did a universe search)
so making them private (& in one case moving off the parent) means a universe seach won't be needed
next time

2 years agoMerge pull request #22473 from eileenmcnaughton/script
Eileen McNaughton [Tue, 11 Jan 2022 18:43:00 +0000 (07:43 +1300)]
Merge pull request #22473 from eileenmcnaughton/script

Remove broken script

2 years agoFix broken function reference
Bradley Taylor [Tue, 11 Jan 2022 18:22:38 +0000 (18:22 +0000)]
Fix broken function reference

2 years agoMerge pull request #22459 from mlutfy/core983acl
colemanw [Tue, 11 Jan 2022 17:07:52 +0000 (12:07 -0500)]
Merge pull request #22459 from mlutfy/core983acl

dev/core#983 Fix Access CiviCampaign permissions (instead of admin)

2 years agoRemove broken script
Eileen McNaughton [Tue, 11 Jan 2022 12:04:37 +0000 (01:04 +1300)]
Remove broken script

2 years agoRemove seemingly unreachable help text
Eileen McNaughton [Tue, 11 Jan 2022 10:42:19 +0000 (23:42 +1300)]
Remove seemingly unreachable help text

This text is e-notice causing (with default modifiers on). I could not find the tpl file
or the potentially corresponding php file & concluded they were likely long-gone

(If I'm wrong some possibly-outdated help text disappears but I couldnt find it)

2 years agoStop calling confusing function that doesn't do much .....
Eileen McNaughton [Tue, 11 Jan 2022 01:15:09 +0000 (14:15 +1300)]
Stop calling confusing function that doesn't do much .....

2 years agoMerge pull request #22448 from mattwire/recurid
Seamus Lee [Tue, 11 Jan 2022 06:11:47 +0000 (17:11 +1100)]
Merge pull request #22448 from mattwire/recurid

Simplify getting contact_id from recurring contribution when generating subscription URLs

2 years agoMerge pull request #22456 from eileenmcnaughton/legt
Seamus Lee [Tue, 11 Jan 2022 04:54:14 +0000 (15:54 +1100)]
Merge pull request #22456 from eileenmcnaughton/legt

Remove & deprecate silly function

2 years agoCiviGrant - Use SearchKit for contact summary tab
Coleman Watts [Mon, 10 Jan 2022 01:24:12 +0000 (20:24 -0500)]
CiviGrant - Use SearchKit for contact summary tab

2 years agoMerge pull request #22064 from colemanw/civigrant
Eileen McNaughton [Tue, 11 Jan 2022 02:09:27 +0000 (15:09 +1300)]
Merge pull request #22064 from colemanw/civigrant

Migrate CiviGrant component to an extension

2 years agoMerge pull request #22264 from sunilpawar/dev_recurring_error
Eileen McNaughton [Tue, 11 Jan 2022 01:40:45 +0000 (14:40 +1300)]
Merge pull request #22264 from sunilpawar/dev_recurring_error

Fix Fatal Error on contribution tab and user dashboard when recurring payment generated using extension get disabled

2 years agoMerge pull request #22462 from eileenmcnaughton/inv2
Seamus Lee [Tue, 11 Jan 2022 01:38:57 +0000 (12:38 +1100)]
Merge pull request #22462 from eileenmcnaughton/inv2

Remove unused variable

2 years agoRemove & deprecate silly function
Eileen McNaughton [Mon, 10 Jan 2022 19:33:14 +0000 (08:33 +1300)]
Remove & deprecate silly function

This function just calls another function & it's slightly MORE complicted to call that then the function
it calls - deprecate it....

2 years agoMerge pull request #22455 from eileenmcnaughton/legg
Eileen McNaughton [Tue, 11 Jan 2022 01:08:02 +0000 (14:08 +1300)]
Merge pull request #22455 from eileenmcnaughton/legg

Remove IF that only loops through one value

2 years agoMerge pull request #22421 from eileenmcnaughton/tax
colemanw [Tue, 11 Jan 2022 00:38:10 +0000 (19:38 -0500)]
Merge pull request #22421 from eileenmcnaughton/tax

Replace all isset checks on line.tax_rate

2 years agoMerge pull request #22453 from braders/autorespond-failure
Eileen McNaughton [Tue, 11 Jan 2022 00:15:06 +0000 (13:15 +1300)]
Merge pull request #22453 from braders/autorespond-failure

Fix syntax error in CRM_Mailing_Event_BAO_Reply

2 years agoMerge pull request #22313 from mlutfy/eventDefaultUrlValues
Seamus Lee [Mon, 10 Jan 2022 23:14:48 +0000 (10:14 +1100)]
Merge pull request #22313 from mlutfy/eventDefaultUrlValues

Event Registration: allow default Price Set values from the URL

2 years agoExtensions - Add dependency status check
Coleman Watts [Mon, 10 Jan 2022 22:48:03 +0000 (17:48 -0500)]
Extensions - Add dependency status check

Adds a system status check to ensure extension dependencies are met

2 years agoMerge pull request #22457 from eileenmcnaughton/label
colemanw [Mon, 10 Jan 2022 21:34:50 +0000 (16:34 -0500)]
Merge pull request #22457 from eileenmcnaughton/label

Mark function as private

2 years agoRemove unused variable
Eileen McNaughton [Mon, 10 Jan 2022 21:32:56 +0000 (10:32 +1300)]
Remove unused variable

2 years agoMerge pull request #22460 from civicrm/5.46
Eileen McNaughton [Mon, 10 Jan 2022 21:29:39 +0000 (10:29 +1300)]
Merge pull request #22460 from civicrm/5.46

5.46

2 years agoMerge pull request #22445 from eileenmcnaughton/546
Seamus Lee [Mon, 10 Jan 2022 21:24:00 +0000 (08:24 +1100)]
Merge pull request #22445 from eileenmcnaughton/546

Use field value function to get html signature

2 years agoAPIv4 - Refactor writeObjects to choose BAO function based on annotations
Coleman Watts [Thu, 6 Jan 2022 22:46:10 +0000 (17:46 -0500)]
APIv4 - Refactor writeObjects to choose BAO function based on annotations

Instead of using a hardcoded list of BAO functions to call, with extra
hardcoded params to e.g. the Contact & Address BAOs, this switches
to picking the BAO's create/add only if it's not `@deprecated`,
and falling back to WriteRecords.

Also refactors the large `writeObjects` function into two smaller
functions so individual action classes can more easily override them.

2 years agoMerge pull request #22454 from braders/phpdoc-types
Eileen McNaughton [Mon, 10 Jan 2022 21:14:47 +0000 (10:14 +1300)]
Merge pull request #22454 from braders/phpdoc-types

A whole bunch of phpdoc fixes

2 years agodev/core#983 Fix Access CiviCampaign permissions (instead of admin)
Mathieu Lutfy [Mon, 10 Jan 2022 21:06:33 +0000 (16:06 -0500)]
dev/core#983 Fix Access CiviCampaign permissions (instead of admin)

2 years agoEnsure tax is set when it comes form Order BAO
Eileen McNaughton [Sat, 8 Jan 2022 07:50:21 +0000 (20:50 +1300)]
Ensure tax is set when it comes form Order BAO

2 years agoReplace all isset checks on line.tax_rate
Eileen McNaughton [Sat, 8 Jan 2022 03:53:00 +0000 (16:53 +1300)]
Replace all isset checks on line.tax_rate

It is actually always set here
https://github.com/civicrm/civicrm-core/blob/64f4eebe75dbaeb429abcaa4dfca90094ce8be20/CRM/Price/BAO/LineItem.php#L246-L253

2 years agoRemove IF that only loops through one value
Eileen McNaughton [Mon, 10 Jan 2022 19:22:14 +0000 (08:22 +1300)]
Remove IF that only loops through one value

2 years agoMark function as private
Eileen McNaughton [Mon, 10 Jan 2022 19:47:38 +0000 (08:47 +1300)]
Mark function as private

I did a universe search & this is not called outside this class (the
one on the LabelCommon class is called from one place outside that class

2 years agoA whole bunch of phpdoc fixes
Bradley Taylor [Mon, 10 Jan 2022 19:13:26 +0000 (19:13 +0000)]
A whole bunch of phpdoc fixes

2 years agoFix syntax error in CRM_Mailing_Event_BAO_Reply
Bradley Taylor [Mon, 10 Jan 2022 18:29:24 +0000 (18:29 +0000)]
Fix syntax error in CRM_Mailing_Event_BAO_Reply

2 years agoCiviGrant - Regenerate SQL
Coleman Watts [Fri, 7 Jan 2022 20:37:07 +0000 (15:37 -0500)]
CiviGrant - Regenerate SQL

2 years agoCiviGrant - Install extension + managed entities during upgrade
Coleman Watts [Mon, 15 Nov 2021 17:09:12 +0000 (12:09 -0500)]
CiviGrant - Install extension + managed entities during upgrade

Disable & delete component, install extension as either "enabled" or "disabled" depending on the status of the component.
Migrate option values to managed entities
Migrate navigation menu to extension managed entities

2 years agoCiviGrant - Migrate legacy search query code
Coleman Watts [Thu, 18 Nov 2021 21:56:18 +0000 (16:56 -0500)]
CiviGrant - Migrate legacy search query code

This fixes up the `CRM_Contact_BAO_Query_Interface` class which had incorrectly
omitted `static` from some static functions.

Adds defaultReurnProperties to search hook interface.

2 years agoCiviGrant - Remove or mitigate hardcoded references to civicrm_grant table in core
Coleman Watts [Thu, 18 Nov 2021 21:54:17 +0000 (16:54 -0500)]
CiviGrant - Remove or mitigate hardcoded references to civicrm_grant table in core

Removes CiviGrant from hardcoded lists when possible, or at least puts up
guards to check that it's available before attempting to use it.

2 years agoCiviGrant - Move unit tests
Coleman Watts [Thu, 18 Nov 2021 00:35:55 +0000 (19:35 -0500)]
CiviGrant - Move unit tests

2 years agoCiviGrant - Move report files
Coleman Watts [Fri, 12 Nov 2021 20:27:26 +0000 (15:27 -0500)]
CiviGrant - Move report files

2 years agoCiviGrant - Migrate schema files
Coleman Watts [Fri, 12 Nov 2021 19:45:16 +0000 (14:45 -0500)]
CiviGrant - Migrate schema files

Insert and then delete CiviGrant to avoid messing up legacy code with expectations of component IDs.

2 years agoCiviGrant - Migrate component functions to hooks
Coleman Watts [Fri, 12 Nov 2021 14:44:26 +0000 (09:44 -0500)]
CiviGrant - Migrate component functions to hooks

2 years agoCiviGrant - Move CRM & API code from core to extension
Coleman Watts [Fri, 12 Nov 2021 14:30:29 +0000 (09:30 -0500)]
CiviGrant - Move CRM & API code from core to extension

2 years agoGenerate CiviGrant extension
Coleman Watts [Fri, 12 Nov 2021 14:22:57 +0000 (09:22 -0500)]
Generate CiviGrant extension

2 years agoMerge pull request #22439 from eileenmcnaughton/legt
colemanw [Mon, 10 Jan 2022 13:28:40 +0000 (08:28 -0500)]
Merge pull request #22439 from eileenmcnaughton/legt

Simplify variables pass in & out of function

2 years agoMerge pull request #22447 from eileenmcnaughton/legg
colemanw [Mon, 10 Jan 2022 13:26:20 +0000 (08:26 -0500)]
Merge pull request #22447 from eileenmcnaughton/legg

Remove if & foreach that no longer do anything

2 years agoMerge pull request #22446 from eileenmcnaughton/php4
colemanw [Mon, 10 Jan 2022 13:24:22 +0000 (08:24 -0500)]
Merge pull request #22446 from eileenmcnaughton/php4

Remove call to php 4 function

2 years agoSimplify getting contact_id from recurring contribution
Matthew Wire [Mon, 10 Jan 2022 12:43:08 +0000 (12:43 +0000)]
Simplify getting contact_id from recurring contribution

2 years agoSimplify variables pass in & out of function
Eileen McNaughton [Sun, 9 Jan 2022 23:52:45 +0000 (12:52 +1300)]
Simplify variables pass in & out of function

Rather than compiling an array, pass in the 3 values. Also
its now obvious that there is only a max of 1 contact_check in the function
so just return rather than 'continuing' (allowing us to de-loop in a more
whitespacey follow up)

2 years agoRemove if & foreach that no longer do anything
Eileen McNaughton [Mon, 10 Jan 2022 03:21:41 +0000 (16:21 +1300)]
Remove if & foreach that no longer do anything

2 years agoRemove call to php 4 function
Eileen McNaughton [Mon, 10 Jan 2022 03:14:50 +0000 (16:14 +1300)]
Remove call to php 4 function

This CRM-2122 seems to be php4 thing - it won't exist anymore

https://php.uz/manual/en/function.fribidi-log2vis.php

2 years agoUse field value function to get html signature
Eileen McNaughton [Mon, 10 Jan 2022 02:37:23 +0000 (15:37 +1300)]
Use field value function to get html signature

The  function is used for all other tokens on the contact object and will better access
the right value and return an empty string rather NULL if not set.

I hit this as an enotice writing a test - but it is possibly the cause of this issue
https://github.com/eileenmcnaughton/nz.co.fuzion.civitoken/issues/58#issuecomment-966611004

hence targetting the rc

The tokens() function does weird things if you pass it NULL

2 years agoMerge pull request #22440 from eileenmcnaughton/legg
Seamus Lee [Mon, 10 Jan 2022 02:30:52 +0000 (13:30 +1100)]
Merge pull request #22440 from eileenmcnaughton/legg

Clean up input and outputs

2 years agoMerge pull request #22441 from civicrm/5.46
colemanw [Mon, 10 Jan 2022 01:56:55 +0000 (20:56 -0500)]
Merge pull request #22441 from civicrm/5.46

5.46

2 years agoRemove support for deprecated key
Eileen McNaughton [Mon, 10 Jan 2022 01:27:28 +0000 (14:27 +1300)]
Remove support for deprecated key

downloadUrl causes notices when default modifier is on.

It turns out is was deprecated approximately 2 forevers ago

https://docs.civicrm.org/dev/en/latest/extensions/info-xml/#downloadUrl

2 years agoMerge pull request #22435 from colemanw/subscriptionHistory
colemanw [Mon, 10 Jan 2022 00:40:09 +0000 (19:40 -0500)]
Merge pull request #22435 from colemanw/subscriptionHistory

APIv4 - Add SubscriptionHistory entity

2 years agoMerge pull request #22436 from eileenmcnaughton/noticeme
colemanw [Mon, 10 Jan 2022 00:39:19 +0000 (19:39 -0500)]
Merge pull request #22436 from eileenmcnaughton/noticeme

Enotice fix

2 years agoMerge pull request #22437 from MegaphoneJon/broken-search-urls
Eileen McNaughton [Mon, 10 Jan 2022 00:25:54 +0000 (13:25 +1300)]
Merge pull request #22437 from MegaphoneJon/broken-search-urls

fixes report#93: SearchKit shows broken external URLs

2 years agoMerge pull request #22429 from colemanw/fixMoneyType2
demeritcowboy [Mon, 10 Jan 2022 00:02:40 +0000 (19:02 -0500)]
Merge pull request #22429 from colemanw/fixMoneyType2

Fix input type for smarty number formatting (more forgiving)

2 years agoClean up input and outputs
Eileen McNaughton [Mon, 10 Jan 2022 00:01:30 +0000 (13:01 +1300)]
Clean up input and outputs

By grepping universe we can see that params['contact_check'] only ever has one value when called
from the supported core place and the unsupported jma grant application extension place.

By clarifying that here we can do further cleanup without having to re-search universe...

2 years agoMerge pull request #22428 from civicrm/5.46
Eileen McNaughton [Sun, 9 Jan 2022 23:43:55 +0000 (12:43 +1300)]
Merge pull request #22428 from civicrm/5.46

5.46

2 years agoMerge pull request #20884 from MegaphoneJon/financial-89
Eileen McNaughton [Sun, 9 Jan 2022 23:30:00 +0000 (12:30 +1300)]
Merge pull request #20884 from MegaphoneJon/financial-89

don't allow multiple currencies in a batch

2 years agoMerge pull request #22431 from eileenmcnaughton/leg
Seamus Lee [Sun, 9 Jan 2022 23:06:12 +0000 (10:06 +1100)]
Merge pull request #22431 from eileenmcnaughton/leg

[REF] Rename variable to be meaningful

2 years agofixes report#93: SearchKit shows broken external URLs
Jon Goldberg [Sun, 9 Jan 2022 22:48:33 +0000 (17:48 -0500)]
fixes report#93: SearchKit shows broken external URLs

2 years agoEnotice fix
Eileen McNaughton [Sun, 9 Jan 2022 22:39:58 +0000 (11:39 +1300)]
Enotice fix

2 years agoAPIv4 - Add SubscriptionHistory entity
Coleman Watts [Sun, 9 Jan 2022 22:27:33 +0000 (17:27 -0500)]
APIv4 - Add SubscriptionHistory entity

2 years agoFix input type for smarty number formatting
Coleman Watts [Sat, 8 Jan 2022 22:10:02 +0000 (17:10 -0500)]
Fix input type for smarty number formatting

Some smarty templates pass NULL to crmMoney, so it needs to handle that possibilty