colemanw [Mon, 28 Aug 2023 16:12:29 +0000 (12:12 -0400)]
CRM - Cleanup verbose array conditionals
demeritcowboy [Mon, 28 Aug 2023 14:50:08 +0000 (10:50 -0400)]
Merge pull request #27185 from seamuslee001/better_reporting_invalid_instance
[REF] Improve cron job handling when there is an invalid report insta…
demeritcowboy [Mon, 28 Aug 2023 14:44:13 +0000 (10:44 -0400)]
Merge pull request #27184 from seamuslee001/infinite_loop_report
[REF] Fix infinite loop when trying to load a report instance with an…
Seamus Lee [Mon, 28 Aug 2023 04:52:56 +0000 (14:52 +1000)]
[REF] Improve cron job handling when there is an invalid report instance id passed to mail_report job
Seamus Lee [Mon, 28 Aug 2023 04:43:15 +0000 (14:43 +1000)]
[REF] Fix infinite loop when trying to load a report instance with an id that does not exist
Seamus Lee [Sun, 27 Aug 2023 23:50:14 +0000 (19:50 -0400)]
Merge pull request #27182 from civicrm/5.65
5.65
Seamus Lee [Sun, 27 Aug 2023 23:21:47 +0000 (19:21 -0400)]
Merge pull request #27170 from agh1/5.65.0-releasenotes-initial
5.65.0 release notes initial run
Seamus Lee [Sun, 27 Aug 2023 23:21:23 +0000 (19:21 -0400)]
Merge pull request #27179 from totten/master-phpstorm-setting
PhpStorm - Add a corybantic avalanche of type-hints
colemanw [Sun, 27 Aug 2023 02:52:38 +0000 (22:52 -0400)]
Merge pull request #27161 from eileenmcnaughton/discount
Add test & fix for getOptions on options with a domain id
Tim Otten [Sat, 26 Aug 2023 02:59:34 +0000 (19:59 -0700)]
phpstorm - Generate event hints for "hook_civicrm_pre::Entity" (and similar)
Tim Otten [Sat, 26 Aug 2023 02:44:59 +0000 (19:44 -0700)]
phpstorm - Generate hints about Civi::dispatcher()
Tim Otten [Sat, 26 Aug 2023 02:29:20 +0000 (19:29 -0700)]
phpstorm - Generate hints about civicrm_api3()
Coleman Watts [Sat, 26 Aug 2023 02:14:23 +0000 (19:14 -0700)]
phpstorm - Generate hints about civicrm_api4()
colemanw [Sat, 26 Aug 2023 02:19:46 +0000 (22:19 -0400)]
Merge pull request #27112 from colemanw/sortName
SearchKit - Use Contact.sort_name instead of display_name for searches and Autocompletes
Tim Otten [Sat, 26 Aug 2023 00:43:18 +0000 (17:43 -0700)]
phpstorm - Generate hints about CiviCRM settings
Tim Otten [Sat, 26 Aug 2023 00:41:58 +0000 (17:41 -0700)]
PhpStormMetadata - Define registerArgumentsSet() and addExpectedArguments()
Tim Otten [Sat, 26 Aug 2023 01:52:05 +0000 (18:52 -0700)]
(NFC) phpstorm.php
Tim Otten [Sat, 26 Aug 2023 01:57:32 +0000 (18:57 -0700)]
Use `hook_managed` to implement `civi.phpstorm.flush`
Tim Otten [Fri, 25 Aug 2023 23:57:27 +0000 (16:57 -0700)]
phpstorm - Enable 'scan-classes'
Tim Otten [Sat, 26 Aug 2023 00:27:42 +0000 (17:27 -0700)]
Merge pull request #27175 from totten/master-phpstorm-redux
phpstorm - Multiple updates
Tim Otten [Sat, 26 Aug 2023 00:27:33 +0000 (17:27 -0700)]
Merge pull request #27177 from colemanw/api4EntityNames
[REF] APIv4 - Simplify entity name gathering
Tim Otten [Sat, 26 Aug 2023 00:16:11 +0000 (17:16 -0700)]
Merge pull request #27178 from colemanw/phpStormStatic
PHPStorm - Add static metadata file
demeritcowboy [Sat, 26 Aug 2023 00:10:48 +0000 (20:10 -0400)]
Merge pull request #27176 from colemanw/api3ExampleCleanup
Test Cleanup - Refactor out uses of deprecated `callAPIAndDocument()`
demeritcowboy [Sat, 26 Aug 2023 00:09:38 +0000 (20:09 -0400)]
Merge pull request #27166 from eileenmcnaughton/test_fix
Remove some unused parameters in test class
colemanw [Sat, 26 Aug 2023 00:09:03 +0000 (20:09 -0400)]
PHPStorm - Add static metadata file
colemanw [Fri, 25 Aug 2023 16:26:57 +0000 (12:26 -0400)]
APIv4 - Simplify entity name gathering
Before: Getting entity names was hard and the conformanceTest struggled
After: It's easier, as every entity class has a public getEntityName method
colemanw [Fri, 25 Aug 2023 23:00:56 +0000 (19:00 -0400)]
Test Cleanup - Refactor out uses of deprecated `callAPIAndDocument()`
Tim Otten [Fri, 25 Aug 2023 23:33:49 +0000 (16:33 -0700)]
Fix type-hints for boot services
Tim Otten [Fri, 25 Aug 2023 23:16:28 +0000 (16:16 -0700)]
PhpStormCompilePass - Generate hints for `Civi::cache()`
The `cache()` method just returns objects from the container, so it can come from the same metadata.
Tim Otten [Fri, 25 Aug 2023 22:58:48 +0000 (15:58 -0700)]
Add README.md
Tim Otten [Fri, 25 Aug 2023 22:58:25 +0000 (15:58 -0700)]
phpstorm - Re-enable standard civix bits
Tim Otten [Fri, 25 Aug 2023 22:56:28 +0000 (15:56 -0700)]
phpstorm - Cleanup on uninstall
Tim Otten [Fri, 25 Aug 2023 22:52:00 +0000 (15:52 -0700)]
(REF) Extract helper PhpStormMetadata
demeritcowboy [Fri, 25 Aug 2023 22:46:44 +0000 (18:46 -0400)]
Merge pull request #27174 from colemanw/examples
APIv3 - Delete api examples
Tim Otten [Fri, 25 Aug 2023 22:03:12 +0000 (15:03 -0700)]
phpstorm - Convert "Generator" to "PhpStormCompilePass"
colemanw [Fri, 25 Aug 2023 20:23:16 +0000 (16:23 -0400)]
APIv3 - Delete api examples
Andie Hunt [Fri, 25 Aug 2023 15:51:17 +0000 (11:51 -0400)]
5.65.0 release notes: added boilerplate
Andie Hunt [Fri, 25 Aug 2023 15:40:12 +0000 (11:40 -0400)]
5.65.0 release notes: raw from script
colemanw [Fri, 25 Aug 2023 12:51:04 +0000 (08:51 -0400)]
Merge pull request #27169 from yashodha/report_improvement
(dev/core#4536) Fix 'Primary Membership' filter options in Membership…
colemanw [Fri, 25 Aug 2023 12:46:33 +0000 (08:46 -0400)]
Merge pull request #27168 from totten/master-phpstorm
Add "phpstorm" extension
yashodha [Fri, 25 Aug 2023 12:14:30 +0000 (17:44 +0530)]
(dev/core#4536) Fix 'Primary Membership' filter options in Membership Details report
Tim Otten [Fri, 25 Aug 2023 12:03:02 +0000 (05:03 -0700)]
phpstorm - Move listener to the end of the hook
Tim Otten [Fri, 25 Aug 2023 11:37:21 +0000 (04:37 -0700)]
Add extension "phpstorm"
colemanw [Fri, 25 Aug 2023 10:56:00 +0000 (06:56 -0400)]
Merge pull request #27157 from eileenmcnaughton/execute
Fix deprecation notice on ExecuteJob screen
colemanw [Fri, 25 Aug 2023 10:42:52 +0000 (06:42 -0400)]
Merge pull request #27154 from eileenmcnaughton/notice_reminders
Notice fix - schedule reminders
colemanw [Fri, 25 Aug 2023 10:38:51 +0000 (06:38 -0400)]
Merge pull request #27163 from eileenmcnaughton/broken
Remove broken deprecated function
Eileen McNaughton [Fri, 25 Aug 2023 08:53:19 +0000 (20:53 +1200)]
Merge pull request #27160 from larssandergreen/Also-add-event-confirm-text-as-default-receipt_text-for-edit-Participant
Also add event confirm text as default receipt_text for edit Participant
Eileen McNaughton [Fri, 25 Aug 2023 08:49:47 +0000 (20:49 +1200)]
Merge pull request #27137 from artfulrobot/artfulrobot-php81-table-tpl
Fix PHP8.1 repeated notice errors in Table.tpl
Seamus Lee [Fri, 25 Aug 2023 07:50:27 +0000 (03:50 -0400)]
Merge pull request #27164 from seamuslee001/acl_notice_error
[REF] Fix Notice Errors on ACL listing page by assigning fields consi…
Rich Lott / Artful Robot [Thu, 24 Aug 2023 15:00:24 +0000 (16:00 +0100)]
Fix PHP8.1 repeated notice errors in Table.tpl
Eileen McNaughton [Fri, 25 Aug 2023 06:12:52 +0000 (18:12 +1200)]
Remove some unused parameters
Seamus Lee [Fri, 25 Aug 2023 06:04:17 +0000 (16:04 +1000)]
[REF] Fix Notice Errors on ACL listing page by assigning fields consistently
Eileen McNaughton [Fri, 25 Aug 2023 05:52:29 +0000 (17:52 +1200)]
Remove broken deprecated function
The function this calls was made private in Feb & no-one has noticed. It's deprecated
& I can't find any calls to it so I guess it has been unused-long-time
Eileen McNaughton [Fri, 25 Aug 2023 05:23:48 +0000 (17:23 +1200)]
Add test & fix for getOptions
Yashodha Chaku [Fri, 25 Aug 2023 05:31:52 +0000 (11:01 +0530)]
Merge pull request #27148 from eileenmcnaughton/fee_block
Undefined property fix
Eileen McNaughton [Fri, 25 Aug 2023 05:24:56 +0000 (17:24 +1200)]
Merge pull request #27122 from eileenmcnaughton/discount
Add api-v4 discount api
larssandergreen [Fri, 25 Aug 2023 05:16:45 +0000 (23:16 -0600)]
Also add event confirm text as default receipt_text for edit Participant
Eileen McNaughton [Fri, 25 Aug 2023 03:58:10 +0000 (15:58 +1200)]
Merge pull request #27130 from colemanw/emailType
dev/core#4530 - Change email fields to text in search mode
Eileen McNaughton [Fri, 25 Aug 2023 02:07:57 +0000 (14:07 +1200)]
Fix deprecation notice on ExecuteJob screen
Seamus Lee [Fri, 25 Aug 2023 02:19:03 +0000 (22:19 -0400)]
Merge pull request #27153 from eileenmcnaughton/notice_contact_type
Notice fix on contact types browse
Seamus Lee [Fri, 25 Aug 2023 02:18:51 +0000 (22:18 -0400)]
Merge pull request #27152 from eileenmcnaughton/notice_sched
Fix e-notice by removing conditionality
Eileen McNaughton [Fri, 25 Aug 2023 01:36:35 +0000 (13:36 +1200)]
Notice fix - schedule reminders
Eileen McNaughton [Fri, 25 Aug 2023 01:28:45 +0000 (13:28 +1200)]
Notice fix on contact types browse
Eileen McNaughton [Fri, 25 Aug 2023 01:25:52 +0000 (13:25 +1200)]
Also fix the isRepeatingEvent one
Eileen McNaughton [Fri, 25 Aug 2023 01:20:09 +0000 (13:20 +1200)]
Fix e-notice by removing conditionality
colemanw [Wed, 23 Aug 2023 22:25:55 +0000 (18:25 -0400)]
SearchKit - Use correct action for getFields for in-place edit
Adds some caching to that function since it's called for every row
colemanw [Wed, 23 Aug 2023 20:39:27 +0000 (16:39 -0400)]
dev/core#4530 - Change email fields to text in search mode
colemanw [Thu, 24 Aug 2023 23:58:02 +0000 (19:58 -0400)]
Merge pull request #27145 from eileenmcnaughton/init
Fold private function back into calling function
Eileen McNaughton [Thu, 24 Aug 2023 23:43:58 +0000 (11:43 +1200)]
Undefined property fix
This removes interaction with an undefined property which actually only
tells us if eventId is in the url. The property is only accessed
in preProcess, buildForm & setDefaultValues - ie when the GET is
populated because this overload use case is only for ajax
loading of fees - so we can just keep checking _GET and
not set a property
demeritcowboy [Thu, 24 Aug 2023 23:42:13 +0000 (19:42 -0400)]
Merge pull request #27142 from civicrm/5.65
5.65
Eileen McNaughton [Thu, 24 Aug 2023 21:28:39 +0000 (09:28 +1200)]
Fold private function back into calling function
This function is not logically separated from the calling function - it used
to be shared code but now is private & called from one place.
This moves the code back into the calling function. All the variables have the same name
in both places
colemanw [Thu, 24 Aug 2023 21:07:58 +0000 (17:07 -0400)]
Merge pull request #27129 from larssandergreen/Fix-adding-onclick-for-other_amount-in-pricesets
Fix adding onclick for other_amount in pricesets
Seamus Lee [Thu, 24 Aug 2023 20:28:41 +0000 (16:28 -0400)]
Merge pull request #27136 from colemanw/revertSurvey
Revert "Add apiv4 Survey entity" (already exists in civi_campaign ext)
Seamus Lee [Thu, 24 Aug 2023 20:28:19 +0000 (16:28 -0400)]
Merge pull request #27119 from mlutfy/standaloneACLNav
Standalone: Fix ACL help/links, tweak Users and Permissions menu
Seamus Lee [Thu, 24 Aug 2023 20:28:02 +0000 (16:28 -0400)]
Merge pull request #27134 from totten/5.65-aff-hook
(dev/core#4531) Afform Mail Tokens - Fix rendering for localized/individual email
demeritcowboy [Thu, 24 Aug 2023 19:54:05 +0000 (15:54 -0400)]
Merge pull request #27133 from totten/master-phpunit-xml
phpunit.xml.dist - Update extensions to use phpunit9 format
demeritcowboy [Thu, 24 Aug 2023 19:50:50 +0000 (15:50 -0400)]
Merge pull request #27132 from larssandergreen/Fix-checkbox-regressions-for-import-and-new-message-template
Fix checkbox JS regression for import data selection and email new te…
colemanw [Thu, 24 Aug 2023 19:43:56 +0000 (15:43 -0400)]
Merge pull request #27139 from larssandergreen/Update-for-PHP9
Replace deprecated RegExp PHPUnit functions for v9
demeritcowboy [Thu, 24 Aug 2023 19:36:14 +0000 (15:36 -0400)]
Merge pull request #27141 from colemanw/elvis
REF - Simplify inline conditionals with Elvis
colemanw [Thu, 24 Aug 2023 17:50:01 +0000 (13:50 -0400)]
REF/tests - Simplify inline conditionals with Elvis
colemanw [Thu, 24 Aug 2023 17:47:42 +0000 (13:47 -0400)]
REF/ext - Simplify inline conditionals with Elvis
colemanw [Thu, 24 Aug 2023 17:46:54 +0000 (13:46 -0400)]
REF/Civi+api - Simplify inline conditionals with Elvis
colemanw [Thu, 24 Aug 2023 17:42:03 +0000 (13:42 -0400)]
REF/CRM - Simplify inline conditionals with Elvis
colemanw [Thu, 24 Aug 2023 18:11:43 +0000 (14:11 -0400)]
Merge pull request #26879 from colemanw/scheduledJobForm
ScheduledJob - Clean up form code & improve validation
larssandergreen [Thu, 24 Aug 2023 17:10:12 +0000 (11:10 -0600)]
PHPUnit9 for mixins too
larssandergreen [Thu, 24 Aug 2023 16:31:03 +0000 (10:31 -0600)]
Replace deprecated RegExp PHPUnit functions
Mathieu Lu [Tue, 22 Aug 2023 13:58:40 +0000 (09:58 -0400)]
Standalone: Fix ACL help/links, tweak Users and Permissions menu
colemanw [Thu, 24 Aug 2023 16:09:33 +0000 (12:09 -0400)]
Fix petition test
demeritcowboy [Thu, 24 Aug 2023 15:16:50 +0000 (11:16 -0400)]
Merge pull request #27135 from yashodha/dev-4532
(dev/core#4532) Add sort for country/state fields in reports
colemanw [Thu, 24 Aug 2023 12:49:36 +0000 (08:49 -0400)]
Revert "Add apiv4 Survey entity" (already exists in the civi_campaign extension)
This reverts commit
92eea77386417a5d29538320d06d99e94bc2b2c2.
yashodha [Thu, 24 Aug 2023 12:18:12 +0000 (17:48 +0530)]
(dev/core#4532) Add sort for country/state fields in reports
Tim Otten [Thu, 24 Aug 2023 07:48:10 +0000 (00:48 -0700)]
(dev/core#4531) Afform Mail Tokens - Fix rendering for localized/individual email
While sending the localized email, some UF's may reboot the container
mid-execution. This change ensures that the listeners will be re-registered.
It also makes the code prettier.
Eileen McNaughton [Thu, 24 Aug 2023 05:34:47 +0000 (17:34 +1200)]
Merge pull request #27131 from civicrm/5.65
5.65
Tim Otten [Thu, 24 Aug 2023 04:08:40 +0000 (21:08 -0700)]
phpunit.xml.dist - Run migration script
larssandergreen [Thu, 24 Aug 2023 03:59:02 +0000 (21:59 -0600)]
Fix checkbox JS regression for import data selection and email new template
Tim Otten [Thu, 24 Aug 2023 03:58:02 +0000 (20:58 -0700)]
(NFC) phpunit.xml.dist - Reformat
This makes the phpunit.xml for the ext's match style of the main one.
This makes it easier to see future changes in a diff.
Eileen McNaughton [Thu, 24 Aug 2023 02:48:31 +0000 (14:48 +1200)]
Merge pull request #27123 from colemanw/searchKitKey
dev/core#4519 SearchKit - Fix tasks when ID column is not present
Tim Otten [Thu, 24 Aug 2023 02:43:17 +0000 (19:43 -0700)]
Merge pull request #27115 from eileenmcnaughton/redis_ttl
dev/core#4501 Redis - fix ttl on prev-next cache
Seamus Lee [Thu, 24 Aug 2023 02:15:13 +0000 (22:15 -0400)]
Merge pull request #27121 from colemanw/afformPrefill
Afform - Fix broken prefill functionality
Seamus Lee [Wed, 23 Aug 2023 22:14:30 +0000 (18:14 -0400)]
Merge pull request #27127 from colemanw/pcpBao
[REF] PCP - Update BAO to use writeRecord/deleteRecord