civicrm-core.git
4 years agoRemove deprecated function CRM_Contact_BAO_GroupContactCache::remove
Coleman Watts [Wed, 4 Mar 2020 17:10:12 +0000 (12:10 -0500)]
Remove deprecated function CRM_Contact_BAO_GroupContactCache::remove

4 years agoMerge pull request #16675 from christianwach/lab-1628
Matthew Wire [Wed, 4 Mar 2020 14:52:43 +0000 (14:52 +0000)]
Merge pull request #16675 from christianwach/lab-1628

Fix display of administrator permissions in WordPress Multisite

4 years agoFix display of administrator permissions in WordPress Multisite
Christian Wach [Wed, 4 Mar 2020 10:23:01 +0000 (10:23 +0000)]
Fix display of administrator permissions in WordPress Multisite

4 years agoMerge pull request #16676 from christianwach/lab-1629
Eileen McNaughton [Wed, 4 Mar 2020 07:23:44 +0000 (20:23 +1300)]
Merge pull request #16676 from christianwach/lab-1629

Fix synchronisation of Users to Contacts in WordPress Multisite

4 years agoMerge pull request #16679 from pradpnayak/priceSetSchema
Seamus Lee [Wed, 4 Mar 2020 06:31:00 +0000 (17:31 +1100)]
Merge pull request #16679 from pradpnayak/priceSetSchema

added sudo constant for sms api type

4 years agoadded sudo constant for sms api type
Pradeep Nayak [Wed, 4 Mar 2020 01:35:48 +0000 (01:35 +0000)]
added sudo constant for sms api type

4 years agoFix synchronisation of Users to Contacts in WordPress Multisite
Christian Wach [Tue, 3 Mar 2020 12:04:25 +0000 (12:04 +0000)]
Fix synchronisation of Users to Contacts in WordPress Multisite

4 years agoMerge pull request #16672 from MegaphoneJon/core-1627
Seamus Lee [Tue, 3 Mar 2020 02:59:34 +0000 (13:59 +1100)]
Merge pull request #16672 from MegaphoneJon/core-1627

Activity Details report: fix filtering by is null/is not null

4 years agoActivity Details report: fix filtering by is null/is not null
Jon Goldberg [Mon, 2 Mar 2020 23:43:09 +0000 (18:43 -0500)]
Activity Details report: fix filtering by is null/is not null

4 years agoMerge pull request #16667 from eileenmcnaughton/acl
colemanw [Mon, 2 Mar 2020 17:30:34 +0000 (12:30 -0500)]
Merge pull request #16667 from eileenmcnaughton/acl

[REF] Only call getACLs when contact_id is present, remove handling

4 years agoMerge pull request #16566 from eileenmcnaughton/setting_fix
colemanw [Mon, 2 Mar 2020 16:18:26 +0000 (11:18 -0500)]
Merge pull request #16566 from eileenmcnaughton/setting_fix

Remove helper function now that contribution settings is not weirdly stored

4 years agoMerge pull request #16647 from JMAConsulting/core-1623
colemanw [Mon, 2 Mar 2020 16:13:30 +0000 (11:13 -0500)]
Merge pull request #16647 from JMAConsulting/core-1623

core#1623: My Case dashlet doesn't sort by name but contact_id instead

4 years agoMerge pull request #16669 from demeritcowboy/audit-tpl-2
colemanw [Mon, 2 Mar 2020 16:11:21 +0000 (11:11 -0500)]
Merge pull request #16669 from demeritcowboy/audit-tpl-2

dev/core#1366 - CRM_Case_XMLProcessor_Report::run() is never called anymore

4 years agoMerge pull request #16668 from eileenmcnaughton/php
colemanw [Mon, 2 Mar 2020 16:10:14 +0000 (11:10 -0500)]
Merge pull request #16668 from eileenmcnaughton/php

Increase php min recommended version

4 years agoremove unused function
demeritcowboy [Mon, 2 Mar 2020 06:33:25 +0000 (01:33 -0500)]
remove unused function

4 years agocore#1623: My Case dashlet doesn't sort by name but contact_id instead
Monish Deb [Fri, 28 Feb 2020 09:17:29 +0000 (14:47 +0530)]
core#1623: My Case dashlet doesn't sort by name but contact_id instead

4 years agoIncrease php min recommended version
eileen [Mon, 2 Mar 2020 04:01:39 +0000 (17:01 +1300)]
Increase php min recommended version

We seem to not be doing a good job of communicating about dropping php 7.0
but given php 7.1 is now out of support https://www.php.net/supported-versions.php
it seems pretty clear it meets no longer meets the criteria for 'minimum recommended'

https://www.php.net/supported-versions.php

4 years ago[REF] Only call getACLs when contact_id is present, remove handling
eileen [Sun, 1 Mar 2020 22:50:22 +0000 (11:50 +1300)]
[REF] Only call getACLs when contact_id is present, remove handling

getACLs is called from one place in the code. Within the function there are 2 places that
handle the possibility it might be null - this moves it to the calling function
& requires contact id to be an int

4 years agoMerge pull request #16665 from pradpnayak/priceSetSchema
Seamus Lee [Mon, 2 Mar 2020 01:53:01 +0000 (12:53 +1100)]
Merge pull request #16665 from pradpnayak/priceSetSchema

Add pseudoconstant for priceset

4 years agoMerge pull request #16664 from totten/master-ext-hidden
Eileen McNaughton [Mon, 2 Mar 2020 01:23:56 +0000 (14:23 +1300)]
Merge pull request #16664 from totten/master-ext-hidden

Extensions - Change new tag "hidden" to "mgmt:hidden"

4 years agoMerge pull request #16624 from mattwire/tokencompatsubscriber
Eileen McNaughton [Mon, 2 Mar 2020 01:23:03 +0000 (14:23 +1300)]
Merge pull request #16624 from mattwire/tokencompatsubscriber

TokenProcessor - fix greetings tokens

4 years agoAdd pseudoconstant for priceset
Pradeep Nayak [Mon, 2 Mar 2020 00:23:15 +0000 (00:23 +0000)]
Add pseudoconstant for priceset

4 years agoExtensions - Change new tag "hidden" to "mgmt:hidden"
Tim Otten [Mon, 2 Mar 2020 00:04:19 +0000 (16:04 -0800)]
Extensions - Change new tag "hidden" to "mgmt:hidden"

Overview
--------

This is follow-up from the discussion about how to name extension tags

https://github.com/civicrm/civicrm-dev-docs/pull/761

It's a follow-up #16531 (dev/financial#84) within the same 5.24.alpha1 dev cycle.

Before
------

The `sequentialcreditnotes` extension is tagged `hidden` and omitted
from display in the web UI.

After
-----

The `sequentialcreditnotes` extension is tagged `mgmt:hidden` and omitted
from display in the web UI.

4 years agoMerge pull request #16662 from seamuslee001/tcpdf_depreaction
Seamus Lee [Sun, 1 Mar 2020 23:44:00 +0000 (10:44 +1100)]
Merge pull request #16662 from seamuslee001/tcpdf_depreaction

[REF] Deprecate _html2pdf_tcpdf function in favour of _html2pdf_dompdf

4 years agoMerge pull request #16663 from eileenmcnaughton/acl
Seamus Lee [Sun, 1 Mar 2020 23:43:54 +0000 (10:43 +1100)]
Merge pull request #16663 from eileenmcnaughton/acl

[REF] Removed unused function

4 years agoMerge pull request #16655 from seamuslee001/hook_uf_fields
Seamus Lee [Sun, 1 Mar 2020 23:43:37 +0000 (10:43 +1100)]
Merge pull request #16655 from seamuslee001/hook_uf_fields

[Feature] Add in new hook alterUFFields to allow extensions to modify…

4 years agoAdd in code doucmentation of the format of the fields array and add in a unit test
Seamus Lee [Sun, 1 Mar 2020 22:33:59 +0000 (09:33 +1100)]
Add in code doucmentation of the format of the fields array and add in a unit test

4 years ago[REF] Removed unused function
eileen [Sun, 1 Mar 2020 22:32:31 +0000 (11:32 +1300)]
[REF] Removed unused function

I did some searches - this isn't called

4 years agoMerge pull request #16660 from demeritcowboy/audit-tpl
Eileen McNaughton [Sun, 1 Mar 2020 21:45:45 +0000 (10:45 +1300)]
Merge pull request #16660 from demeritcowboy/audit-tpl

dev/core#1366 - Case Audit.tpl file no longer used

4 years ago[REF] Deprecate _html2pdf_tcpdf function in favour of _html2pdf_dompdf
Seamus Lee [Sun, 1 Mar 2020 21:39:39 +0000 (08:39 +1100)]
[REF] Deprecate _html2pdf_tcpdf function in favour of _html2pdf_dompdf

4 years agoMerge pull request #15964 from mlutfy/financial109
Eileen McNaughton [Sun, 1 Mar 2020 20:10:14 +0000 (09:10 +1300)]
Merge pull request #15964 from mlutfy/financial109

dev/financial#109 Fix country/province assignation in the contribution invoice

4 years agoMerge pull request #16648 from pradpnayak/priceSetSchema
Seamus Lee [Sun, 1 Mar 2020 03:51:14 +0000 (14:51 +1100)]
Merge pull request #16648 from pradpnayak/priceSetSchema

Add pseudoconstant for priceset

4 years agoMerge pull request #16661 from seamuslee001/typo_fix
Seamus Lee [Sun, 1 Mar 2020 03:50:53 +0000 (14:50 +1100)]
Merge pull request #16661 from seamuslee001/typo_fix

Fix unreleaesd typo error

4 years agoFix unreleaesd typo error
Seamus Lee [Sat, 29 Feb 2020 23:59:37 +0000 (10:59 +1100)]
Fix unreleaesd typo error

4 years agoMerge pull request #16658 from mattwire/fixtypo
Seamus Lee [Sat, 29 Feb 2020 23:57:41 +0000 (10:57 +1100)]
Merge pull request #16658 from mattwire/fixtypo

Fix typo (unrelease regression)

4 years agoAdd pseudoconstant for priceset
Pradeep Nayak [Fri, 28 Feb 2020 12:14:53 +0000 (12:14 +0000)]
Add pseudoconstant for priceset

4 years agodev/financial#109 Fix country/province assignation in the contribution invoice
Mathieu Lutfy [Tue, 26 Nov 2019 15:26:34 +0000 (10:26 -0500)]
dev/financial#109 Fix country/province assignation in the contribution invoice

4 years agoremove files no longer used
demeritcowboy [Sat, 29 Feb 2020 15:45:15 +0000 (10:45 -0500)]
remove files no longer used

4 years agoFix typo (unrelease regression)
Matthew Wire [Sat, 29 Feb 2020 14:15:55 +0000 (14:15 +0000)]
Fix typo (unrelease regression)

4 years agoMerge pull request #16657 from mattwire/fixcomment
colemanw [Sat, 29 Feb 2020 13:02:12 +0000 (08:02 -0500)]
Merge pull request #16657 from mattwire/fixcomment

Fix mistake in comment

4 years agoFix mistake in comment
Matthew Wire [Sat, 29 Feb 2020 11:09:33 +0000 (11:09 +0000)]
Fix mistake in comment

4 years ago[Feature] Add in new hook alterUFFields to allow extensions to modify which fields...
Seamus Lee [Fri, 28 Feb 2020 23:12:05 +0000 (10:12 +1100)]
[Feature] Add in new hook alterUFFields to allow extensions to modify which fields can be added to a profile

4 years agoMerge pull request #16652 from UshaMakoa/patch-2
Seamus Lee [Fri, 28 Feb 2020 23:07:37 +0000 (10:07 +1100)]
Merge pull request #16652 from UshaMakoa/patch-2

Update contributor-key.yml

4 years agoMerge pull request #16653 from seamuslee001/hook_pre_post_uf_field
Seamus Lee [Fri, 28 Feb 2020 23:07:18 +0000 (10:07 +1100)]
Merge pull request #16653 from seamuslee001/hook_pre_post_uf_field

[REF] Add in pre and post hooks to UFField Entity

4 years agoUpdate TokenTest.php
Tim Otten [Fri, 28 Feb 2020 22:45:04 +0000 (14:45 -0800)]
Update TokenTest.php

4 years agoMerge pull request #16644 from seamuslee001/extension_notices
Eileen McNaughton [Fri, 28 Feb 2020 22:16:03 +0000 (11:16 +1300)]
Merge pull request #16644 from seamuslee001/extension_notices

[NFC] Use insert ignore for inserts into civicrm_extension to stop warnings on duplicate entry for sequential credit notes extension

4 years ago[REF] Add in pre and post hooks to UFField Entity
Seamus Lee [Fri, 28 Feb 2020 21:47:22 +0000 (08:47 +1100)]
[REF] Add in pre and post hooks to UFField Entity

4 years agoUpdate contributor-key.yml
Usha Matisson [Fri, 28 Feb 2020 21:11:43 +0000 (22:11 +0100)]
Update contributor-key.yml

4 years agoMerge pull request #16632 from colemanw/dash
colemanw [Fri, 28 Feb 2020 14:58:31 +0000 (09:58 -0500)]
Merge pull request #16632 from colemanw/dash

News dashboard - Code cleanup to update js & css

4 years agoMerge pull request #16645 from colemanw/null
colemanw [Fri, 28 Feb 2020 14:51:38 +0000 (09:51 -0500)]
Merge pull request #16645 from colemanw/null

APIv4 - Correctly return null values from DAO save actions

4 years agoAdd basic test for TokenCompatSubscriber
Matthew Wire [Fri, 28 Feb 2020 11:14:01 +0000 (11:14 +0000)]
Add basic test for TokenCompatSubscriber

4 years agoAPIv4 - Correctly return null values from DAO save actions
Coleman Watts [Fri, 28 Feb 2020 00:45:22 +0000 (19:45 -0500)]
APIv4 - Correctly return null values from DAO save actions

Make sure the value "null" is not returned as a string
Don't return null values from saved DAO objects unless it is in params or reload is set to true

4 years ago[NFC] Use insert ignore for inserts into civicrm_extension to stop warnings on duplic...
Seamus Lee [Thu, 27 Feb 2020 23:26:27 +0000 (10:26 +1100)]
[NFC] Use insert ignore for inserts into civicrm_extension to stop warnings on duplicate entry for sequential credit notes extension

4 years agoMerge pull request #16615 from MegaphoneJon/selfsfc-refactor
Seamus Lee [Thu, 27 Feb 2020 23:34:40 +0000 (10:34 +1100)]
Merge pull request #16615 from MegaphoneJon/selfsfc-refactor

[REF] Extract self-service eligibility code into its own function

4 years agoMerge pull request #16627 from seamuslee001/aug_custom_fields_fix
Eileen McNaughton [Thu, 27 Feb 2020 22:41:49 +0000 (11:41 +1300)]
Merge pull request #16627 from seamuslee001/aug_custom_fields_fix

[REF] Apply fix for CRM-607 for when building the select section of t…

4 years agoMerge pull request #16638 from UshaMakoa/patch-1
colemanw [Thu, 27 Feb 2020 22:34:05 +0000 (17:34 -0500)]
Merge pull request #16638 from UshaMakoa/patch-1

Contact Type Values with Cap in order to be well translated with ts()

4 years agoMerge pull request #16643 from demeritcowboy/activity-summary-groupby
colemanw [Thu, 27 Feb 2020 22:33:47 +0000 (17:33 -0500)]
Merge pull request #16643 from demeritcowboy/activity-summary-groupby

dev/core#1619 - Fatal error when grouping Activity Summary report by activity date

4 years agoMerge pull request #16642 from eileenmcnaughton/ss2
colemanw [Thu, 27 Feb 2020 22:33:26 +0000 (17:33 -0500)]
Merge pull request #16642 from eileenmcnaughton/ss2

[REF] simple function extraction

4 years agoMerge pull request #16595 from seamuslee001/refactor_payment_processor_radio
Eileen McNaughton [Thu, 27 Feb 2020 21:53:32 +0000 (10:53 +1300)]
Merge pull request #16595 from seamuslee001/refactor_payment_processor_radio

[REF] Refactor adding payment processor radio section onto register a…

4 years agoMerge pull request #16637 from eileenmcnaughton/ss
Eileen McNaughton [Thu, 27 Feb 2020 21:46:54 +0000 (10:46 +1300)]
Merge pull request #16637 from eileenmcnaughton/ss

Remove unused columns from civicrm_saved_search

4 years agoMerge pull request #16639 from seamuslee001/dev_core_1621
Eileen McNaughton [Thu, 27 Feb 2020 21:10:12 +0000 (10:10 +1300)]
Merge pull request #16639 from seamuslee001/dev_core_1621

[NFC] dev/core#1621 Extend unit tests to ensure that entity financial account is co…

4 years agoMerge pull request #16640 from JMAConsulting/dev-core-1158
Eileen McNaughton [Thu, 27 Feb 2020 21:09:01 +0000 (10:09 +1300)]
Merge pull request #16640 from JMAConsulting/dev-core-1158

core#1158: Unit Test to ensure primary addresses are printed on mailing label if searchPrimaryDetailsOnly is disabled

4 years agoMerge pull request #16641 from colemanw/apiError
Eileen McNaughton [Thu, 27 Feb 2020 21:05:48 +0000 (10:05 +1300)]
Merge pull request #16641 from colemanw/apiError

Api4 - Display sql errors in explorer

4 years ago[REF] simple funnction extraction
eileen [Thu, 27 Feb 2020 20:49:18 +0000 (09:49 +1300)]
[REF] simple funnction extraction

4 years ago[REF] Extract self-service eligibility code into its own function
Jon Goldberg [Fri, 21 Feb 2020 23:17:23 +0000 (18:17 -0500)]
[REF] Extract self-service eligibility code into its own function

4 years agofatal error when grouping by activity date
demeritcowboy [Thu, 27 Feb 2020 20:50:27 +0000 (15:50 -0500)]
fatal error when grouping by activity date

4 years agoRemove unused columns from civicrm_saved_search
eileen [Thu, 27 Feb 2020 01:51:13 +0000 (14:51 +1300)]
Remove unused columns from civicrm_saved_search

We identified these as unused in 5.20 & removed the places still saving to them -
https://github.com/civicrm/civicrm-core/pull/14891

This removes the actual columns. A couple of other tables still have similar columns, not sure
if they are required still

4 years agoMerge pull request #16634 from seamuslee001/lab_core_1612
Eileen McNaughton [Thu, 27 Feb 2020 20:21:10 +0000 (09:21 +1300)]
Merge pull request #16634 from seamuslee001/lab_core_1612

dev/core#1622 Fix unsubscribe when loading the unsubscribe form on a …

4 years agoApi4 - Display sql errors in explorer
Coleman Watts [Thu, 27 Feb 2020 13:05:38 +0000 (08:05 -0500)]
Api4 - Display sql errors in explorer

4 years agoApi code minor cleanup
Coleman Watts [Thu, 27 Feb 2020 13:05:02 +0000 (08:05 -0500)]
Api code minor cleanup

4 years agocore#1158: Unit Test to ensure primary addresses are printed on mailing label if...
Monish Deb [Thu, 27 Feb 2020 08:53:23 +0000 (14:23 +0530)]
core#1158: Unit Test to ensure primary addresses are printed on mailing label if searchPrimaryDetailsOnly is disabled

4 years ago[NFC] Extend unit tests to ensure that entity financial account is correctly deleted...
Seamus Lee [Thu, 27 Feb 2020 06:51:29 +0000 (17:51 +1100)]
[NFC] Extend unit tests to ensure that entity financial account is correctly deleted when financial type is deleted

4 years agodev/core#1622 Fix unsubscribe when loading the unsubscribe form on a different locale...
Seamus Lee [Wed, 26 Feb 2020 21:00:57 +0000 (08:00 +1100)]
dev/core#1622 Fix unsubscribe when loading the unsubscribe form on a different locale to the one the mailing was sent from

Add in comments as per request from Eileen

4 years agoMerge pull request #16636 from totten/master-settings-tpl
Seamus Lee [Thu, 27 Feb 2020 05:57:02 +0000 (16:57 +1100)]
Merge pull request #16636 from totten/master-settings-tpl

civicrm.settings.php.template - Simplify examples of `$civicrm_setting`

4 years agoContact Type Values with Cap in order to be well translated with ts()
Usha Matisson [Thu, 27 Feb 2020 05:39:34 +0000 (06:39 +0100)]
Contact Type Values with Cap in order to be well translated with ts()

4 years agoMerge pull request #16635 from seamuslee001/dev_core_1615_distmaker
Seamus Lee [Thu, 27 Feb 2020 04:32:15 +0000 (15:32 +1100)]
Merge pull request #16635 from seamuslee001/dev_core_1615_distmaker

dev/core#1615 Update distmaker to handle the fact civicrm-setup is no…

4 years agodev/financial#84 - Update distmaker to include sequentialcreditnotes
Tim Otten [Thu, 27 Feb 2020 02:01:08 +0000 (18:01 -0800)]
dev/financial#84 - Update distmaker to include sequentialcreditnotes

4 years agocivicrm.settings.php.template - Simplify examples of `$civicrm_setting`
Tim Otten [Thu, 27 Feb 2020 00:12:10 +0000 (16:12 -0800)]
civicrm.settings.php.template - Simplify examples of `$civicrm_setting`

Overview
--------

This simplifies the examples in `civicrm.settings.php.template`.

Before
------

Every reference to `$civicrm_setting` uses an English-looking group-name like

``php
$civicrm_setting['URL Preferences']['imageUploadURL'] = 'http://example.com/example-image-upload-url';
```

After
-----

The varying group names are just `domain`.

```php
$civicrm_setting['domain']['imageUploadURL'] = 'http://example.com/example-image-upload-url';.
```

Comments
--------

Since CiviCRM v4.7, expessions like `$civicrm_setting['URL Preferences']` have been aliases
for `$civicrm_setting['domain']`.  (See `SettingsManager::parseMandatorySettings()`.)

These examples were initially kept in the verbose 4.6 format so that users of 4.6 and 4.7
could continue to exchange examples with each other.  But 4.6 and 4.7 are pretty old, so I
don't think that's an issue anymore. We're now firmly in the 5.x world.

What does still matter is intuition - if the examples set an expectation that you should put
things under buckets like `URL Preferences`, then it implies that you should be thinking about
those buckets.  (Does the `extensionsURL` belong under `URL Preferences` or `Extension
Preferences`?  Should a search-related setting defined by an extension go under `Search
Preferences` or `Extension Preferences`?  Can I make up new groups?  If I know the name used
by the Setting API, then how do I figure out the group-name used for the `$civicrm_setting`
override?  ...  The answer to all of these questions is that it doesn't matter because they're
really the same group.)

4 years agoMerge pull request #16597 from colemanw/drilldown
Eileen McNaughton [Wed, 26 Feb 2020 22:23:38 +0000 (11:23 +1300)]
Merge pull request #16597 from colemanw/drilldown

Menubar - Add "find menu item" search feature

4 years agodev/core#1615 Update distmaker to handle the fact civicrm-setup is now in core
Seamus Lee [Wed, 26 Feb 2020 21:55:14 +0000 (08:55 +1100)]
dev/core#1615 Update distmaker to handle the fact civicrm-setup is now in core

4 years agoMerge pull request #16631 from kartik1000/Fix_Invalid_parameter_doc
Seamus Lee [Wed, 26 Feb 2020 21:25:06 +0000 (08:25 +1100)]
Merge pull request #16631 from kartik1000/Fix_Invalid_parameter_doc

Removed Invalid Paramter from function doc

4 years agoMerge pull request #16630 from breheret/master
Seamus Lee [Wed, 26 Feb 2020 21:18:18 +0000 (08:18 +1100)]
Merge pull request #16630 from breheret/master

Add ts() for a sentence 'Add to case as role'

4 years agoNews dashboard - Code cleanup to update js & css
Coleman Watts [Wed, 26 Feb 2020 19:25:23 +0000 (14:25 -0500)]
News dashboard - Code cleanup to update js & css

- Use css class instead of inline style for unread items
- Use `CRM.cache` instead of `window.localStorage`
- Longer preview snippet for wide screens

4 years agoMerge pull request #16633 from alexymik/patch-1
colemanw [Wed, 26 Feb 2020 19:23:59 +0000 (14:23 -0500)]
Merge pull request #16633 from alexymik/patch-1

CommunicationPreferences 'loclize' -> 'localize'

4 years ago'loclize' -> 'localize'
Alexy Mikhailichenko [Wed, 26 Feb 2020 17:43:12 +0000 (09:43 -0800)]
'loclize' -> 'localize'

4 years agoRemoved Invalid Paramter from function doc
Kartik Kathuria [Wed, 26 Feb 2020 15:52:29 +0000 (21:22 +0530)]
Removed Invalid Paramter from function doc

Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
4 years agoAdd ts() for a sentence 'Add To case role'
breheret [Wed, 26 Feb 2020 15:13:35 +0000 (16:13 +0100)]
Add ts() for a sentence 'Add To case role'

4 years agoMerge pull request #16628 from totten/master-setup-action
Seamus Lee [Wed, 26 Feb 2020 07:15:49 +0000 (18:15 +1100)]
Merge pull request #16628 from totten/master-setup-action

dev/drupal#4 - Add Civi\Setup::getPendingAction() helper

4 years agodev/drupal#4 - Add Civi\Setup::getPendingAction() helper
Tim Otten [Wed, 26 Feb 2020 03:42:47 +0000 (19:42 -0800)]
dev/drupal#4 - Add Civi\Setup::getPendingAction() helper

Overview
--------

This exposes a new piece of information for downstream consumers of the `civicrm-setup` API.

It doesn't change any behaviors or expectations - it merely tracks an extra piece of info.

Before
------

The `Civi\Setup` interface does not give any reporting about what's going on.

After
-----

The `Civi\Setup` interface has a method, `getPendingAction()`, which reports the pending action.

Technical Details
-----------------

(1) The pending action is strictly singular - it would not be sensible, for example, to have the
`installFiles` and `uninstallFiles` actions running at the same time. Thus, the guards within
each function.

(2) The basic gist of the change - in each of the functions
(`{install,uninstall}{Files,Database}`), set the `pendingAction` at the start and unset
it at the end.  The change looks slightly bigger than it should - because it wraps the
existing code within the `try ...  finally ...` block.

(3) This facilitates dev/drupal#4 and https://github.com/civicrm/civicrm-drupal-8/pull/37
- there were some use-cases in which the auto-install behaviors of `civicrm_install()`
and `FlushDrupal8.civi-setup.php` would provoke each other (causing a sort of
installer-loop).  This change makes it possible to avoid the loop without changing the
contracts.

4 years ago[REF] Apply fix for CRM-607 for when building the select section of the query as...
Seamus Lee [Wed, 26 Feb 2020 02:02:04 +0000 (13:02 +1100)]
[REF] Apply fix for CRM-607 for when building the select section of the query as well as in where

4 years agoMerge pull request #16560 from eileenmcnaughton/fgbvar
Eileen McNaughton [Tue, 25 Feb 2020 20:05:19 +0000 (09:05 +1300)]
Merge pull request #16560 from eileenmcnaughton/fgbvar

dev/core#1596 fix (unreleased) regression on contribution summary

4 years agodev/core#1596 fix (unreleased) regression on contribution summary
eileen [Sun, 16 Feb 2020 23:48:23 +0000 (12:48 +1300)]
dev/core#1596 fix (unreleased) regression on contribution summary

https://lab.civicrm.org/dev/core/issues/1596

Makes more use of parent function to fix (in general we've done fixes/ improvements to the report
generic functions that have not filtered down to reports that override them

4 years agoMerge pull request #16503 from aydun/dev_core_1584
Eileen McNaughton [Mon, 24 Feb 2020 21:24:29 +0000 (10:24 +1300)]
Merge pull request #16503 from aydun/dev_core_1584

dev/core#1584 Add function to specify whether payment processor requires email address

4 years agoMerge pull request #16338 from mattwire/note_timestamp
Eileen McNaughton [Mon, 24 Feb 2020 21:18:57 +0000 (10:18 +1300)]
Merge pull request #16338 from mattwire/note_timestamp

Convert civicrm_note.modified_date to timestamp

4 years agoMerge pull request #16598 from eileenmcnaughton/setup
Tim Otten [Mon, 24 Feb 2020 20:49:53 +0000 (12:49 -0800)]
Merge pull request #16598 from eileenmcnaughton/setup

Enable the "sequentialcreditnotes" extension on new installations

4 years agoreplaceGreetingsTokens must be called before replaceContactTokens because replaceCont...
Matthew Wire [Mon, 24 Feb 2020 19:08:23 +0000 (19:08 +0000)]
replaceGreetingsTokens must be called before replaceContactTokens because replaceContactTokens removes all 'invalid' tokens

4 years agoMerge pull request #16621 from totten/master-setup-autoload
colemanw [Mon, 24 Feb 2020 11:30:20 +0000 (06:30 -0500)]
Merge pull request #16621 from totten/master-setup-autoload

dev/core#1615 - Fix for recently migrated civicrm-setup

4 years agoMerge pull request #16622 from seamuslee001/test_dev_core_1386
Eileen McNaughton [Mon, 24 Feb 2020 05:27:08 +0000 (18:27 +1300)]
Merge pull request #16622 from seamuslee001/test_dev_core_1386

dev/core#1386 Add in unit test for #15834

4 years agodev/core#1386 Add in unit test for #15834
Seamus Lee [Mon, 24 Feb 2020 03:35:52 +0000 (14:35 +1100)]
dev/core#1386 Add in unit test for #15834

4 years agodev/core#1615 - Fix for recently migrated civicrm-setup
Tim Otten [Mon, 24 Feb 2020 00:37:10 +0000 (16:37 -0800)]
dev/core#1615 - Fix for recently migrated civicrm-setup

Overview
--------

Fix a recent (intra-alpha) regression from https://github.com/civicrm/civicrm-core/pull/16618

The search for `civicrm-setup` goes slightly awry because the migrated copy of civicrm-setup uses
the core's classloader rather than its own classloader.

Steps to Reproduce
------------------

* Create a site with WP and Civi(master).
* Ensure Civi is uninstalled. (ex: `cv core:uninstall -f`)
* In `wp-content/plugins/civicrm/civicrm`, touch the file `.use-civicrm-setup`.
  (*This is supposed to activate the new UI.*)
* Go to the WP admin console. In the left navbar, choose "CiviCRM Installer".

Before
------

It fails to load the new UI -- the search finds `.use-civicrm-setup` but does not
find `civicrm-setup-autoload.php`. It falls back to the old UI.

After
-----

It opens the new UI.