Mathieu Lu [Tue, 6 Jun 2023 18:53:25 +0000 (14:53 -0400)]
Merge pull request #26397 from larssandergreen/Remove-unneeded-text-on-Campaign,-Pledge-etc
Remove unneeded description text on Campaign, Pledge, Tell a Friend, etc
Mathieu Lu [Tue, 6 Jun 2023 18:50:18 +0000 (14:50 -0400)]
Merge pull request #26396 from larssandergreen/Remove-unneeded-descriptions-on-Membership
Remove unneeded description text on Memberships
Mathieu Lu [Tue, 6 Jun 2023 18:42:08 +0000 (14:42 -0400)]
Merge pull request #26415 from larssandergreen/options_per_line-for-customs-fields
dev/core#3815 Set options_per_line to zero when changing Custom Field html_type
demeritcowboy [Tue, 6 Jun 2023 18:04:21 +0000 (14:04 -0400)]
Merge pull request #26442 from eileenmcnaughton/no_ref
Remove pass-by-ref
Seamus Lee [Tue, 6 Jun 2023 04:21:16 +0000 (14:21 +1000)]
Merge pull request #26454 from eileenmcnaughton/event_test
Superficial Cleanup in test class
Eileen McNaughton [Tue, 6 Jun 2023 02:50:53 +0000 (14:50 +1200)]
Cleanup in event class
colemanw [Tue, 6 Jun 2023 01:32:45 +0000 (21:32 -0400)]
Merge pull request #26441 from eileenmcnaughton/price_
PriceSet forms - remove reference to undeclared _contributionAmount property
Seamus Lee [Tue, 6 Jun 2023 01:13:07 +0000 (11:13 +1000)]
Merge pull request #26450 from eileenmcnaughton/leg_event_paid
[Test] Rename version of eventCreatePaid that is being replaced
Seamus Lee [Tue, 6 Jun 2023 01:12:33 +0000 (11:12 +1000)]
Merge pull request #26453 from seamuslee001/master
5.62
Seamus Lee [Tue, 6 Jun 2023 01:11:09 +0000 (11:11 +1000)]
Merge branch '5.62'
Eileen McNaughton [Tue, 6 Jun 2023 00:57:04 +0000 (12:57 +1200)]
Merge pull request #26451 from demeritcowboy/translate-petition
Use already translated string (followup to 26446)
Eileen McNaughton [Mon, 5 Jun 2023 22:32:20 +0000 (10:32 +1200)]
Use same key as new function for easier transition
demeritcowboy [Mon, 5 Jun 2023 22:50:29 +0000 (18:50 -0400)]
use already translated string
demeritcowboy [Mon, 5 Jun 2023 22:47:11 +0000 (18:47 -0400)]
Merge pull request #26449 from eileenmcnaughton/profile
Stop truncating UFGroup on tearDown
demeritcowboy [Mon, 5 Jun 2023 22:44:01 +0000 (18:44 -0400)]
Merge pull request #26446 from jmcclelland/petition-error-take-two
present friendlier error message if petition cannot be displayed.
Eileen McNaughton [Mon, 5 Jun 2023 22:14:49 +0000 (10:14 +1200)]
Switch PaymentFormsTest to new version
Eileen McNaughton [Mon, 5 Jun 2023 22:04:45 +0000 (10:04 +1200)]
Rename the test function I am replacing
The eventTrait has a new version of eventCreatePaid but
it can't be called because these tests still rely on an older variant
(which creates invalid financial records) - this moves that function
out of the way to allow me to work through migrating over
Eileen McNaughton [Mon, 5 Jun 2023 21:38:27 +0000 (09:38 +1200)]
Stop truncating UFGroup on tearDown
Eileen McNaughton [Mon, 5 Jun 2023 20:34:59 +0000 (08:34 +1200)]
Merge pull request #26443 from reflexive-communications/log-filename
Use dot to delimit log filename for domain ID
colemanw [Mon, 5 Jun 2023 20:10:16 +0000 (16:10 -0400)]
Merge pull request #26420 from eileenmcnaughton/user_dash
[Test] Switch some unpaid event test setup to use createUnPaidEvent
colemanw [Mon, 5 Jun 2023 20:09:00 +0000 (16:09 -0400)]
Merge pull request #26434 from eileenmcnaughton/uf_group_cleanup
[TEST] Further minor fixes on UFGroup Cleanup
Jamie McClelland [Mon, 5 Jun 2023 16:50:57 +0000 (12:50 -0400)]
present friendlier error message if petition cannot be displayed.
Aidan Saunders [Mon, 5 Jun 2023 16:39:00 +0000 (17:39 +0100)]
Merge pull request #26436 from larssandergreen/Order-select-mailing-id-DESC
Order mailings for selects in search and reports by id DESC
Aidan Saunders [Mon, 5 Jun 2023 16:29:46 +0000 (17:29 +0100)]
Merge pull request #26231 from colemanw/campaignIndexes
REF - Fix Campaign index names, add default value for created_date
Aidan Saunders [Mon, 5 Jun 2023 16:26:24 +0000 (17:26 +0100)]
Merge pull request #26345 from colemanw/sampleData
Installer - Clarify the function and purpose of sample data
Aidan Saunders [Mon, 5 Jun 2023 16:05:36 +0000 (17:05 +0100)]
Merge pull request #26437 from colemanw/api4FixOrderBy
dev/core#4330 - Fix APIv4 orderBy to resolve ambiguous column names
colemanw [Mon, 5 Jun 2023 00:29:17 +0000 (20:29 -0400)]
dev/core#4330 - Fix APIv4 orderBy to resolve ambiguous column names
See https://lab.civicrm.org/dev/core/-/issues/4330
This regressed from
ff2a73c, the fix is to only use names from the select
clause if they are actual aliases.
colemanw [Mon, 5 Jun 2023 13:53:57 +0000 (09:53 -0400)]
Merge pull request #26440 from eileenmcnaughton/perm
Use PriceSet permissions for related entities
Sandor Semsey [Mon, 5 Jun 2023 12:37:04 +0000 (14:37 +0200)]
use dot to delimit log filename
Eileen McNaughton [Mon, 5 Jun 2023 07:58:30 +0000 (19:58 +1200)]
Remove pass-by-ref
Eileen McNaughton [Mon, 5 Jun 2023 07:52:49 +0000 (19:52 +1200)]
PriceSet forms - remove reference to undeclared _contributionAmount property
I don't find this value anywhere in our universe outside this
function - which implies it should be not be a property - especially for
php 8,x reasons. In fact it really just is a case of checking if field_name
is contribution_amount at the right places. I didn't include it in the place where
it would read if field_name = x AND field_name <> y....
Eileen McNaughton [Mon, 5 Jun 2023 07:44:42 +0000 (19:44 +1200)]
Merge pull request #26375 from larssandergreen/Refactor-price-sets
[REF] Move repeated code for Price Field labels into separate function
Eileen McNaughton [Mon, 5 Jun 2023 07:23:17 +0000 (19:23 +1200)]
Merge pull request #26374 from colemanw/activityVirtualFields
APIv4 - Fix Activity contact virtual fields to work across joins
Eileen McNaughton [Sun, 4 Jun 2023 21:20:50 +0000 (09:20 +1200)]
[TEST] Further minor fixes on UFGroup Cleanup
Eileen McNaughton [Mon, 5 Jun 2023 04:52:26 +0000 (16:52 +1200)]
Merge pull request #26373 from mattwire/noidsmembership
Stop passing $ids to membership::create
Yashodha Chaku [Mon, 5 Jun 2023 04:48:00 +0000 (10:18 +0530)]
Merge pull request #26439 from eileenmcnaughton/price_search
Cleanup on PriceSetCustom search
Eileen McNaughton [Mon, 5 Jun 2023 01:38:12 +0000 (13:38 +1200)]
Remove handling for required field to be empty
Eileen McNaughton [Mon, 5 Jun 2023 01:32:03 +0000 (13:32 +1200)]
Cleanup on PriceSetCustom search
Having fixed up the test on this I also fixed a couple of bits of red and
also replaced calls to internal Core CiviCRM functions
with api calls
Eileen McNaughton [Sun, 4 Jun 2023 23:27:20 +0000 (11:27 +1200)]
Move legacy prices set search test to extension
Eileen McNaughton [Mon, 5 Jun 2023 01:41:55 +0000 (13:41 +1200)]
Use PriceSet permissions for related entities
This addresses a situation where price set permissions are looser than the
associated fields, values & linkages to events & contribution pages
larssandergreen [Sun, 4 Jun 2023 23:22:11 +0000 (17:22 -0600)]
Order select for mailings by id DESC
colemanw [Sun, 4 Jun 2023 23:30:17 +0000 (19:30 -0400)]
Merge pull request #26427 from larssandergreen/Don't-show-current-mailing-in-include/exclude-mailings
dev/core#3570: Don't show current mailing in include/exclude previous mailings
Eileen McNaughton [Sun, 4 Jun 2023 23:24:28 +0000 (11:24 +1200)]
Merge pull request #26419 from larssandergreen/Remove-URL-from-event-template
Don't show event URL on Manage Event Template
colemanw [Sun, 4 Jun 2023 23:20:32 +0000 (19:20 -0400)]
Merge pull request #26395 from larssandergreen/No-pager-in-Afform-when-not-needed
SearchKit: Don't show the pager unless it is needed
Eileen McNaughton [Sun, 4 Jun 2023 21:01:22 +0000 (09:01 +1200)]
Merge pull request #26433 from braders/php8.2-CRM_Member_Page_DashBoard
[REF][PHP8.2] Remove unused dynamic property showMembershipSummary
Matthew Wire [Sun, 4 Jun 2023 20:29:53 +0000 (21:29 +0100)]
Merge pull request #26431 from larssandergreen/Show-fee-info-above-payment-info-on-Event-confirmation-and-thank-you
Show Event Info at bottom of Registration Confirm & Fee Info above Payment
Matthew Wire [Sun, 4 Jun 2023 20:27:17 +0000 (21:27 +0100)]
Merge pull request #26430 from larssandergreen/Fix-payment-validation-for-show-payment-on-confirm
Fix payment validation for Payment on Confirm
Bradley Taylor [Sun, 4 Jun 2023 19:10:26 +0000 (20:10 +0100)]
[REF][PHP8.2] Remove unused dynamic property showMembershipSummary
demeritcowboy [Sun, 4 Jun 2023 17:21:48 +0000 (13:21 -0400)]
Merge pull request #26429 from larssandergreen/Fix-whitespace-around-date-through-in-EventInfoBlock
[NFC] Remove extra whitespace around date through in EventInfoBlock
larssandergreen [Sun, 4 Jun 2023 16:55:40 +0000 (10:55 -0600)]
Show Event Info at bottom Registration confirm and show Fee Info above Payment
larssandergreen [Sun, 4 Jun 2023 16:15:54 +0000 (10:15 -0600)]
Fix payment validation for payment on confirm
larssandergreen [Sun, 4 Jun 2023 15:47:06 +0000 (09:47 -0600)]
Remove extra whitespace around date through in EventInfoBlock
demeritcowboy [Sun, 4 Jun 2023 15:13:56 +0000 (11:13 -0400)]
Merge pull request #26409 from ahed-compucorp/dev/core#4333
dev/core#4333 Set default created_id for case and activity Attachments
demeritcowboy [Sun, 4 Jun 2023 14:41:37 +0000 (10:41 -0400)]
Merge pull request #26421 from eileenmcnaughton/cleanup2
[Test] Fix UFGroup cleanup in ReportTemplateTest
demeritcowboy [Sun, 4 Jun 2023 14:35:14 +0000 (10:35 -0400)]
Merge pull request #26422 from eileenmcnaughton/cleanup
[Test] More test UFGroup cleanup
demeritcowboy [Sun, 4 Jun 2023 14:30:26 +0000 (10:30 -0400)]
Merge pull request #26423 from braders/php8.2-CRM_Report_Form_Contact_Log
[REF][PHP8.2] Declare property in CRM_Report_Form_Contact_Log
demeritcowboy [Sun, 4 Jun 2023 14:29:31 +0000 (10:29 -0400)]
Merge pull request #26424 from braders/php8.2-CRM_Report_Form_Contribute_OrganizationSummary
[REF][PHP8.2] Declare properties on OrganizationSummary report
demeritcowboy [Sun, 4 Jun 2023 14:23:34 +0000 (10:23 -0400)]
Merge pull request #26428 from braders/class-case
[NFC] Fix capitalization of class names
larssandergreen [Sun, 4 Jun 2023 13:22:41 +0000 (07:22 -0600)]
Don't show current mailing in include/exclude options
Bradley Taylor [Sun, 4 Jun 2023 08:25:42 +0000 (09:25 +0100)]
[NFC] Fix capitalization of class names
Bradley Taylor [Sat, 3 Jun 2023 17:24:49 +0000 (18:24 +0100)]
[REF][PHP8.2] Declare properties on OrganizationSummary report
Bradley Taylor [Sat, 3 Jun 2023 17:06:29 +0000 (18:06 +0100)]
[REF][PHP8.2] Declare property in CRM_Report_Form_Contact_Log
Ahed [Fri, 2 Jun 2023 08:47:27 +0000 (11:47 +0300)]
dev/core#4333 Set default created_id for case and activity Attachments
Eileen McNaughton [Sat, 3 Jun 2023 00:06:00 +0000 (12:06 +1200)]
More test UFGroup cleanup
Fixes a couple more tests to appropriate UFGroup cleanup
Eileen McNaughton [Sat, 3 Jun 2023 00:00:41 +0000 (12:00 +1200)]
Fix UFGroup cleanup in SelectorTest
Eileen McNaughton [Fri, 2 Jun 2023 06:55:02 +0000 (18:55 +1200)]
Fix UFGroup cleanup in ReportTemplateTest
Eileen McNaughton [Fri, 2 Jun 2023 22:07:03 +0000 (10:07 +1200)]
Switch some unpaid event test setup to use createUnPaidEvent
This resolves some of the ambiguity
Spin off from https://github.com/civicrm/civicrm-core/pull/26348
larssandergreen [Fri, 2 Jun 2023 22:02:56 +0000 (16:02 -0600)]
Hide pager if single page on all Admin UI
Aidan Saunders [Fri, 2 Jun 2023 21:47:25 +0000 (22:47 +0100)]
Merge pull request #26417 from colemanw/htmlType
Metadata - Add missing html types/labels to the schema
Aidan Saunders [Fri, 2 Jun 2023 21:43:09 +0000 (22:43 +0100)]
Merge pull request #26418 from SolidCharity/TP-202306-contributor_key
Added tpokorra to contributor-key.yml
larssandergreen [Fri, 2 Jun 2023 20:57:38 +0000 (14:57 -0600)]
Don't show event URL on Manage Event Template
Timotheus Pokorra [Fri, 2 Jun 2023 20:03:11 +0000 (22:03 +0200)]
Added tpokorra to contributor-key.yml
colemanw [Fri, 2 Jun 2023 19:58:23 +0000 (15:58 -0400)]
CiviGrant - Add missing html type metadata and upgrade civix
colemanw [Fri, 2 Jun 2023 19:56:36 +0000 (15:56 -0400)]
Metadata - Add missing html types/labels to the schema
Aidan Saunders [Fri, 2 Jun 2023 19:44:46 +0000 (20:44 +0100)]
Merge pull request #26392 from SolidCharity/TP-202306-notes-author-only
description is wrong for permission to view notes that are marked for author only
larssandergreen [Fri, 2 Jun 2023 19:28:49 +0000 (13:28 -0600)]
Add hide pager if one page option to Displays
larssandergreen [Fri, 2 Jun 2023 18:47:40 +0000 (12:47 -0600)]
Set options_per_line to zero when changing Custom Field html_type
colemanw [Fri, 2 Jun 2023 18:16:12 +0000 (14:16 -0400)]
Merge pull request #26408 from eileenmcnaughton/cleanup3
Improve `UFGroup` cleanup in the `ProcessorFormTest`
colemanw [Fri, 2 Jun 2023 18:12:07 +0000 (14:12 -0400)]
Merge pull request #26414 from braders/php8.2-ReportTemplateTest
[REF][PHP8.2] Sort out dynamic properties in api_v3_ReportTemplateTest
colemanw [Fri, 2 Jun 2023 18:10:51 +0000 (14:10 -0400)]
Merge pull request #26413 from demeritcowboy/regen-serbia
Regen after #26328
colemanw [Fri, 2 Jun 2023 18:10:31 +0000 (14:10 -0400)]
Merge pull request #26412 from braders/php-8.2-report-summary
[REF][PHP8.2] Avoid dynamic properties in report summary
colemanw [Fri, 2 Jun 2023 18:08:59 +0000 (14:08 -0400)]
Merge pull request #26411 from braders/php8.2-report-sybunt
[REF][PHP8.2] Declare property in CRM_Report_Form_Contribute_Sybunt
colemanw [Fri, 2 Jun 2023 18:05:53 +0000 (14:05 -0400)]
Merge pull request #26406 from eileenmcnaughton/cleanup
Fix UFGroupTest to cleanup it's UFGroups
colemanw [Fri, 2 Jun 2023 17:37:18 +0000 (13:37 -0400)]
Merge pull request #26259 from eileenmcnaughton/frontend_contribution_page
dev/core#4213 Make contribution_page.frontend_title required
Bradley Taylor [Fri, 2 Jun 2023 16:50:59 +0000 (17:50 +0100)]
[REF][PHP8.2] Sort out dynamic properties in api_v3_ReportTemplateTest
Aidan Saunders [Fri, 2 Jun 2023 16:46:13 +0000 (17:46 +0100)]
Merge pull request #24781 from mattwire/eventmultiplepaymentend
Move event payment to the confirmation page
demeritcowboy [Fri, 2 Jun 2023 16:44:58 +0000 (12:44 -0400)]
regen after #26328
Bradley Taylor [Fri, 2 Jun 2023 16:39:30 +0000 (17:39 +0100)]
[REF][PHP8.2] Avoid dynamic properties in report summary
demeritcowboy [Fri, 2 Jun 2023 16:38:06 +0000 (12:38 -0400)]
Merge pull request #26328 from quimgil/quimgil-patch-1
Removes obsolete "Serbia and Montenegro" on civicrm_country.tpl
Bradley Taylor [Fri, 2 Jun 2023 16:31:52 +0000 (17:31 +0100)]
[REF][PHP8.2] Declare property in CRM_Report_Form_Contribute_Sybunt
Yashodha Chaku [Fri, 2 Jun 2023 09:32:17 +0000 (15:02 +0530)]
Merge pull request #26405 from eileenmcnaughton/test_trait
Add Event test trait
Eileen McNaughton [Fri, 2 Jun 2023 06:19:07 +0000 (18:19 +1200)]
Add Event test trait
Eileen McNaughton [Fri, 2 Jun 2023 07:14:33 +0000 (19:14 +1200)]
Improve UFGroup cleanup in the ProcessorFormTest
Eileen McNaughton [Fri, 2 Jun 2023 06:44:28 +0000 (18:44 +1200)]
Fix UFGroupTest to cleanup it's UFGroups
Eileen McNaughton [Fri, 2 Jun 2023 06:05:26 +0000 (18:05 +1200)]
Merge pull request #26403 from eileenmcnaughton/event_test_small
Test cleanup - improve cleanup of `UFGroup`
Eileen McNaughton [Fri, 2 Jun 2023 05:33:51 +0000 (17:33 +1200)]
Test cleanup - improve cleanup of UFGroup
Eileen McNaughton [Fri, 2 Jun 2023 04:56:06 +0000 (16:56 +1200)]
Merge pull request #26399 from eileenmcnaughton/perm
Use Permission=FALSE when retrieving price sets in examples
Eileen McNaughton [Thu, 1 Jun 2023 21:55:45 +0000 (09:55 +1200)]
Use Permission=FALSE when retrieving price sets in examples
Doing a check causes the whole example to fail -
and this feels like fairly public info
demeritcowboy [Fri, 2 Jun 2023 01:03:30 +0000 (21:03 -0400)]
Merge pull request #26402 from eileenmcnaughton/dep
Add deprecation notes to `processMembership` function deprecated in 2021
demeritcowboy [Fri, 2 Jun 2023 01:00:54 +0000 (21:00 -0400)]
Merge pull request #26179 from eileenmcnaughton/token_get
Fix locale leaking into tokens