civicrm-core.git
23 months agoFind DAO by ID instead of just calling the constructor and setting the ID
Jens Schuppe [Fri, 29 Jul 2022 13:47:28 +0000 (15:47 +0200)]
Find DAO by ID instead of just calling the constructor and setting the ID

Otherwise, finding references might fail because of missing entity values when comparing, e.g. `option_group_id` for OptionVaue BAOs.

23 months agoMerge pull request #24084 from michaelmcandrew/dev/core#3764
Seamus Lee [Fri, 29 Jul 2022 02:18:09 +0000 (12:18 +1000)]
Merge pull request #24084 from michaelmcandrew/dev/core#3764

fix broken url for wordpress in example code

23 months agoMerge pull request #24008 from seamuslee001/php8_1_message_templates
Seamus Lee [Fri, 29 Jul 2022 00:27:43 +0000 (10:27 +1000)]
Merge pull request #24008 from seamuslee001/php8_1_message_templates

[REF][PHP8.1] Replace usage of the date_format modifer with crmDate t…

23 months agofix broken url for wordpress in example code
Michael McAndrew [Thu, 28 Jul 2022 23:54:30 +0000 (00:54 +0100)]
fix broken url for wordpress in example code

23 months agoMerge pull request #24077 from demeritcowboy/percent-a
Seamus Lee [Thu, 28 Jul 2022 23:30:13 +0000 (09:30 +1000)]
Merge pull request #24077 from demeritcowboy/percent-a

Upgrade task to handle %A date format specifier change

23 months agoMerge pull request #24059 from eileenmcnaughton/pledged
Seamus Lee [Thu, 28 Jul 2022 23:20:27 +0000 (09:20 +1000)]
Merge pull request #24059 from eileenmcnaughton/pledged

dev/core#3749 Fix process pledges to throw exception when civiPledge disabled

23 months agoMerge pull request #23413 from colemanw/radioSilence
colemanw [Thu, 28 Jul 2022 21:52:19 +0000 (17:52 -0400)]
Merge pull request #23413 from colemanw/radioSilence

Afform - Add "clear" button to non-required radios

23 months ago[REF][PHP8.1] Replace usage of the date_format modifer with crmDate to resolve issues...
Seamus Lee [Mon, 18 Jul 2022 02:25:28 +0000 (12:25 +1000)]
[REF][PHP8.1] Replace usage of the date_format modifer with crmDate to resolve issues with strftime

Add in handling for %D and %Z

pick up timezone based on date

23 months agoMerge pull request #24078 from vitius1/patch-2
demeritcowboy [Thu, 28 Jul 2022 20:12:45 +0000 (16:12 -0400)]
Merge pull request #24078 from vitius1/patch-2

Update contributor-key.yml

23 months agoUpdate contributor-key.yml
vitius1 [Thu, 28 Jul 2022 20:05:35 +0000 (22:05 +0200)]
Update contributor-key.yml

Adding yourself to contributors.

23 months agoMerge pull request #24072 from vitius1/patch-1
demeritcowboy [Thu, 28 Jul 2022 19:40:21 +0000 (15:40 -0400)]
Merge pull request #24072 from vitius1/patch-1

Case custom field with clickable contact reference

23 months agoupgrade task to handle %A change
demeritcowboy [Thu, 28 Jul 2022 19:17:49 +0000 (15:17 -0400)]
upgrade task to handle %A change

23 months agoAfform - Add "clear" button to non-required radios
Coleman Watts [Mon, 9 May 2022 16:17:13 +0000 (12:17 -0400)]
Afform - Add "clear" button to non-required radios

Fixes dev/core#3450
Allows the value of radio buttons to be unset if the field is not required,
consistent with the rest of the CiviCRM UI.

23 months agoMerge pull request #24073 from kurund/formbuilder-icon-fixes
colemanw [Thu, 28 Jul 2022 17:52:57 +0000 (13:52 -0400)]
Merge pull request #24073 from kurund/formbuilder-icon-fixes

Afform - show icon on button only if icon is selected

23 months agoMerge pull request #24074 from civicrm/5.52
Eileen McNaughton [Thu, 28 Jul 2022 16:35:30 +0000 (17:35 +0100)]
Merge pull request #24074 from civicrm/5.52

5.52 to master

23 months agoMerge pull request #24066 from alifrumin/rn5.52
Eileen McNaughton [Thu, 28 Jul 2022 16:35:07 +0000 (17:35 +0100)]
Merge pull request #24066 from alifrumin/rn5.52

[NFC] 5.52 Release notes first pass

23 months agoshow icon on button only if icon is selected
Kurund Jalmi [Thu, 28 Jul 2022 14:56:03 +0000 (15:56 +0100)]
show icon on button only if icon is selected

23 months agoMerge pull request #23870 from eileenmcnaughton/offline
demeritcowboy [Thu, 28 Jul 2022 14:02:37 +0000 (10:02 -0400)]
Merge pull request #23870 from eileenmcnaughton/offline

dev/core#3694 - get preview working & tested for offline-contribution receipt

23 months agoMerge pull request #24064 from eileenmcnaughton/dep_err
demeritcowboy [Thu, 28 Jul 2022 11:20:13 +0000 (07:20 -0400)]
Merge pull request #24064 from eileenmcnaughton/dep_err

Log a bit more deprecation info

23 months agoCustomDataView.tpl clickable contact reference
vitius1 [Thu, 28 Jul 2022 09:21:42 +0000 (11:21 +0200)]
CustomDataView.tpl clickable contact reference

In manage case if we have custom field as contact reference we cant click on this contact. I used same condition as CRM/Custom/Page/CustomDataView.tpl, which create clickable contact reference.

23 months agoUpdate CRM/Core/Error.php
Eileen McNaughton [Thu, 28 Jul 2022 08:56:03 +0000 (09:56 +0100)]
Update CRM/Core/Error.php

Co-authored-by: demeritcowboy <demeritcowboy@hotmail.com>
23 months agoUpdate CRM/Core/Error.php
Eileen McNaughton [Thu, 28 Jul 2022 08:55:53 +0000 (09:55 +0100)]
Update CRM/Core/Error.php

Co-authored-by: demeritcowboy <demeritcowboy@hotmail.com>
23 months agoMerge pull request #24032 from seamuslee001/remove_dependency_strftime
demeritcowboy [Thu, 28 Jul 2022 04:39:39 +0000 (00:39 -0400)]
Merge pull request #24032 from seamuslee001/remove_dependency_strftime

[REF][PHP8.1][INTL] Remove dependency on strftime function by using t…

23 months agoMerge pull request #24065 from eileenmcnaughton/pdf_inv
Monish Deb [Thu, 28 Jul 2022 04:21:10 +0000 (09:51 +0530)]
Merge pull request #24065 from eileenmcnaughton/pdf_inv

Avoid sending blank invoices

23 months agoMerge pull request #24050 from eileenmcnaughton/pledge
Seamus Lee [Thu, 28 Jul 2022 04:14:50 +0000 (14:14 +1000)]
Merge pull request #24050 from eileenmcnaughton/pledge

dev/financial#201 Fix PaypalPro IPN to refer to correct option group

23 months agoUpdate to use INTL Date formatter instead
Seamus Lee [Thu, 28 Jul 2022 00:31:13 +0000 (10:31 +1000)]
Update to use INTL Date formatter instead

23 months ago[REF][PHP8.1][INTL] Remove dependency on strftime function by using ts to generate...
Seamus Lee [Thu, 21 Jul 2022 06:15:02 +0000 (16:15 +1000)]
[REF][PHP8.1][INTL] Remove dependency on strftime function by using ts to generate day full names and abbreviations and month abbreviations

Fix array order and add unit test to lock in fix

23 months agoMerge pull request #24068 from totten/master-552
Tim Otten [Thu, 28 Jul 2022 00:05:40 +0000 (17:05 -0700)]
Merge pull request #24068 from totten/master-552

Merge forward 5.52-rc => master

23 months ago(dev/core#3490) Upgrader - 5.52's #24040 is obsoleted by 5.53's #24030
Tim Otten [Wed, 27 Jul 2022 23:43:55 +0000 (16:43 -0700)]
(dev/core#3490) Upgrader - 5.52's #24040 is obsoleted by 5.53's #24030

5.53's #24030 is the longer term fix for dev/core#3490.

5.52's #24040 was a short term mitigation and is not needed going forward.

23 months agoMerge remote-tracking branch 'origin/5.52' into master-552
Tim Otten [Wed, 27 Jul 2022 23:39:17 +0000 (16:39 -0700)]
Merge remote-tracking branch 'origin/5.52' into master-552

23 months ago[NFC] 5.52 Release Notes first pass
Alice Frumin [Wed, 27 Jul 2022 15:02:13 +0000 (11:02 -0400)]
[NFC] 5.52 Release Notes first pass

23 months agoAvoid sending blank invoices
Eileen McNaughton [Wed, 27 Jul 2022 16:23:18 +0000 (17:23 +0100)]
Avoid sending blank invoices

Alternative to https://github.com/civicrm/civicrm-core/pull/24029

23 months agoLog a bit more deprecation info
Eileen McNaughton [Wed, 27 Jul 2022 16:10:47 +0000 (17:10 +0100)]
Log a bit more deprecation info

23 months agodev/core#3749 Fix process pledges to throw exception when civiPledge disabled
Eileen McNaughton [Wed, 27 Jul 2022 11:17:30 +0000 (12:17 +0100)]
dev/core#3749 Fix process pledges to throw exception when civiPledge disabled

Per the issue - it's fine for the job to not work if disabled,
but the error should be logical.

updatePledgeStatus is only called from one place so made the return
handling flatter for success, and exception on error

23 months agoMerge pull request #24053 from agh1/5.52.0-releasenotes-initial
Eileen McNaughton [Wed, 27 Jul 2022 13:03:22 +0000 (14:03 +0100)]
Merge pull request #24053 from agh1/5.52.0-releasenotes-initial

5.52.0 release notes initial run

23 months agoMerge pull request #24057 from alexymik/patch-4
Seamus Lee [Wed, 27 Jul 2022 04:58:58 +0000 (14:58 +1000)]
Merge pull request #24057 from alexymik/patch-4

Add whitespace to exception message

23 months agoAdd whitespace to exception message
Alexy Mikhailichenko [Tue, 26 Jul 2022 23:06:52 +0000 (16:06 -0700)]
Add whitespace to exception message

"Entity not loadedGrant" -> "Entity not loaded: Grant"

23 months agoMerge pull request #24055 from eileenmcnaughton/nfc
Tim Otten [Tue, 26 Jul 2022 21:53:23 +0000 (14:53 -0700)]
Merge pull request #24055 from eileenmcnaughton/nfc

(NFC) HookStyleListener - Comments

23 months agoMerge pull request #24052 from colemanw/fixChainDollarSignBug
colemanw [Tue, 26 Jul 2022 20:34:21 +0000 (16:34 -0400)]
Merge pull request #24052 from colemanw/fixChainDollarSignBug

APIv4 - Allow values to start with a dollar sign in chaining

23 months ago(NFC) HookStyleListener - Comments
Eileen McNaughton [Tue, 28 Jun 2022 04:31:11 +0000 (21:31 -0700)]
(NFC) HookStyleListener - Comments

23 months agoMerge pull request #24047 from kurund/export-fixes
Eileen McNaughton [Tue, 26 Jul 2022 19:10:22 +0000 (20:10 +0100)]
Merge pull request #24047 from kurund/export-fixes

dev/core#3751 - export error fixes for multi-select contact reference custom field

23 months ago5.52.0 release notes: added boilerplate
Andie Hunt [Tue, 26 Jul 2022 17:50:07 +0000 (13:50 -0400)]
5.52.0 release notes: added boilerplate

23 months ago5.51.0 release notes: fix a couple small things
Andie Hunt [Tue, 26 Jul 2022 17:49:50 +0000 (13:49 -0400)]
5.51.0 release notes: fix a couple small things

23 months ago5.52.0 release notes: raw from script
Andie Hunt [Tue, 26 Jul 2022 17:43:06 +0000 (13:43 -0400)]
5.52.0 release notes: raw from script

23 months agoAPIv4 - Allow values to start with a dollar sign in chaining
Coleman Watts [Tue, 26 Jul 2022 16:42:52 +0000 (12:42 -0400)]
APIv4 - Allow values to start with a dollar sign in chaining

Fixes dev/core#3754

23 months agoFix PaypalPro IPN to refer to correct option group
Eileen McNaughton [Tue, 26 Jul 2022 14:39:04 +0000 (15:39 +0100)]
Fix PaypalPro IPN to refer to correct option group

23 months agoMerge pull request #24036 from colemanw/v3Custom
Eileen McNaughton [Tue, 26 Jul 2022 14:04:07 +0000 (15:04 +0100)]
Merge pull request #24036 from colemanw/v3Custom

API - Consistently save custom data for v3 & v4

23 months agoMerge pull request #24048 from yashodha/reports_improvements
demeritcowboy [Tue, 26 Jul 2022 13:07:31 +0000 (09:07 -0400)]
Merge pull request #24048 from yashodha/reports_improvements

remove start/end date as mandatory in Demographics report

23 months agoremove start/end date as mandatory in Demographics report
yashodha [Tue, 26 Jul 2022 05:03:53 +0000 (10:33 +0530)]
remove start/end date as mandatory in Demographics report

23 months agoexport error fixes for multi-select contact reference custom field
Kurund Jalmi [Mon, 25 Jul 2022 16:19:17 +0000 (17:19 +0100)]
export error fixes for multi-select contact reference custom field

23 months agoMerge pull request #24039 from totten/5.52-snap
Eileen McNaughton [Mon, 25 Jul 2022 10:24:46 +0000 (11:24 +0100)]
Merge pull request #24039 from totten/5.52-snap

Upgrader - Add snapshots for 5.52's data modifications

23 months agoMerge pull request #24040 from totten/5.52-postup
Eileen McNaughton [Mon, 25 Jul 2022 10:23:31 +0000 (11:23 +0100)]
Merge pull request #24040 from totten/5.52-postup

dev/core#3490 - Upgrader - Show additional notice about running extension upgrades

23 months agoMerge pull request #24010 from eileenmcnaughton/task_notice
Eileen McNaughton [Mon, 25 Jul 2022 09:54:19 +0000 (10:54 +0100)]
Merge pull request #24010 from eileenmcnaughton/task_notice

dev/core#3737 ensure tasks are loaded (notice fix)

23 months agoMerge pull request #24046 from seamuslee001/league_csv_php81
Eileen McNaughton [Mon, 25 Jul 2022 09:39:21 +0000 (10:39 +0100)]
Merge pull request #24046 from seamuslee001/league_csv_php81

[REF][PHP8.1] Apply patches from upstream to ensure league/csv can work on php8.1

23 months ago[REF][PHP8.1] Apply patches from upstream to ensure league/csv can work on php8.1
Seamus Lee [Sun, 24 Jul 2022 22:48:37 +0000 (08:48 +1000)]
[REF][PHP8.1] Apply patches from upstream to ensure league/csv can work on php8.1

23 months agoAdd in patch for league CSV to fix fputcsv in php8.1
Seamus Lee [Sun, 24 Jul 2022 22:42:16 +0000 (08:42 +1000)]
Add in patch for league CSV to fix fputcsv in php8.1

23 months agoMerge pull request #24045 from seamuslee001/package_update_2_php81
demeritcowboy [Mon, 25 Jul 2022 03:10:16 +0000 (23:10 -0400)]
Merge pull request #24045 from seamuslee001/package_update_2_php81

[REF][PHP8.1] Update phpoffice/phpword and tecnickcom/tcpdf  packages…

23 months ago[REF][PHP8.1] Update phpoffice/phpword and tecnickcom/tcpdf packages for php8.1...
Seamus Lee [Sun, 24 Jul 2022 22:18:29 +0000 (08:18 +1000)]
[REF][PHP8.1] Update phpoffice/phpword and tecnickcom/tcpdf  packages for php8.1 compatability

23 months agoMerge pull request #23875 from alexymik/patch-3
demeritcowboy [Sat, 23 Jul 2022 14:53:48 +0000 (10:53 -0400)]
Merge pull request #23875 from alexymik/patch-3

Set target="_blank" on external footer links

23 months agoSet target="_blank" on external footer links
Alexy Mikhailichenko [Thu, 23 Jun 2022 23:39:30 +0000 (16:39 -0700)]
Set target="_blank" on external footer links

23 months agoMerge pull request #24043 from totten/master-nfc-perm
demeritcowboy [Fri, 22 Jul 2022 14:46:32 +0000 (10:46 -0400)]
Merge pull request #24043 from totten/master-nfc-perm

(NFC) CRM_Core_Permission - More docblocks

23 months agoMerge pull request #24044 from totten/master-scss
demeritcowboy [Fri, 22 Jul 2022 14:44:12 +0000 (10:44 -0400)]
Merge pull request #24044 from totten/master-scss

composer.json - Update scssphp and related libraries (for PHP 8.1)

23 months agocomposer.json - Update scssphp and related libraries (for PHP 8.1)
Tim Otten [Fri, 22 Jul 2022 09:52:42 +0000 (02:52 -0700)]
composer.json - Update scssphp and related libraries (for PHP 8.1)

Overview
--------

Update scssphp/scssphp, civicrm/composer-compile-plugin, and civicrm/composer-compile-lib.

Before
-------

Large number of warnings are generated in scssphp / php81, leading to an overflow

```
Compiling additional files (For full details, use verbose "-v" mode.)
Compile: Generate CCL wrapper functions
Compile: Greenwich CSS (dist/bootstrap3.css)

Fatal error: Allowed memory size of 1610612736 bytes exhausted (tried to allocate 36864 bytes) in phar:///Users/totten/bknix/bin/composer/vendor/symfony/process/Pipes/UnixPipes.php on line 132

Check https://getcomposer.org/doc/articles/troubleshooting.md#memory-limit-errors for more info on how to handle out of memory errors.Subcommand @composer compile  returned with error code 255

In ComposerPassthru.php line 72:

  Subcommand @composer compile  returned with error code 255

install [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-suggest] [--no-dev] [--no-autoloader] [--no-progress] [--no-install] [--audit] [--audit-format AUDIT-FORMAT] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--] [<packages>...]
```

After
-----

Compilation works

Comments
--------

Generated via: `composer update civicrm/composer-compile-lib scssphp/scssphp civicrm/composer-compile-plugin`

23 months ago(NFC) CRM_Core_Permission - More docblocks
Tim Otten [Fri, 22 Jul 2022 06:51:29 +0000 (23:51 -0700)]
(NFC) CRM_Core_Permission - More docblocks

23 months agoMerge pull request #24042 from seamuslee001/master
Seamus Lee [Fri, 22 Jul 2022 04:58:39 +0000 (14:58 +1000)]
Merge pull request #24042 from seamuslee001/master

5.52

23 months agoMerge branch '5.52'
Seamus Lee [Fri, 22 Jul 2022 04:57:39 +0000 (14:57 +1000)]
Merge branch '5.52'

23 months agoMerge pull request #24038 from seamuslee001/5.52
Tim Otten [Fri, 22 Jul 2022 03:49:03 +0000 (20:49 -0700)]
Merge pull request #24038 from seamuslee001/5.52

[REF] Upgrade DOMPDF to 2.x branch

23 months agoMerge pull request #23896 from colemanw/afformManaged
Tim Otten [Fri, 22 Jul 2022 03:44:42 +0000 (20:44 -0700)]
Merge pull request #23896 from colemanw/afformManaged

Afform - Switch to APIv4 for managed afform_type option group

23 months agoUpgrader - Show additional notice about running extension upgrades
Tim Otten [Thu, 21 Jul 2022 23:54:55 +0000 (16:54 -0700)]
Upgrader - Show additional notice about running extension upgrades

23 months agoMerge pull request #24030 from totten/master-run-ext-upgrades
colemanw [Thu, 21 Jul 2022 23:27:40 +0000 (19:27 -0400)]
Merge pull request #24030 from totten/master-run-ext-upgrades

dev/core#3490 - Apply extension updates after core updates

23 months agoMerge pull request #24016 from colemanw/afformTokens
colemanw [Thu, 21 Jul 2022 23:26:00 +0000 (19:26 -0400)]
Merge pull request #24016 from colemanw/afformTokens

Afform - Post-submit redirect tokens

23 months agoFiveFiftyTwo - Add snapshots for modified data structures
Tim Otten [Thu, 21 Jul 2022 22:44:16 +0000 (15:44 -0700)]
FiveFiftyTwo - Add snapshots for modified data structures

23 months agowhitespace fix
demeritcowboy [Sun, 10 Jul 2022 15:09:46 +0000 (11:09 -0400)]
whitespace fix

23 months agoFix installed-fonts cache
Seamus Lee [Wed, 6 Jul 2022 02:28:10 +0000 (12:28 +1000)]
Fix installed-fonts cache

23 months ago[REF] Upgrade DOMPDF to 2.x branch
Seamus Lee [Tue, 5 Jul 2022 22:32:40 +0000 (08:32 +1000)]
[REF] Upgrade DOMPDF to 2.x branch

23 months agoMerge pull request #23970 from MegaphoneJon/false-not-zero
Seamus Lee [Thu, 21 Jul 2022 21:26:22 +0000 (07:26 +1000)]
Merge pull request #23970 from MegaphoneJon/false-not-zero

APIv4 - Fix mishandling of boolean custom values

23 months agoMerge pull request #23895 from colemanw/searchKitManaged
Seamus Lee [Thu, 21 Jul 2022 21:23:31 +0000 (07:23 +1000)]
Merge pull request #23895 from colemanw/searchKitManaged

SearchKit - Switch to APIv4 for managed entities

23 months agoAfform - Switch to APIv4 for managed afform_type option group
Coleman Watts [Tue, 28 Jun 2022 15:59:45 +0000 (11:59 -0400)]
Afform - Switch to APIv4 for managed afform_type option group

23 months agoMerge pull request #24035 from colemanw/actionLogFix
Seamus Lee [Thu, 21 Jul 2022 21:06:11 +0000 (07:06 +1000)]
Merge pull request #24035 from colemanw/actionLogFix

Fix ActionLog BAO to not overwrite existing data

23 months agoAPIv3 - Don't handle custom data already handled by BAO
Coleman Watts [Thu, 21 Jul 2022 14:36:06 +0000 (10:36 -0400)]
APIv3 - Don't handle custom data already handled by BAO

Fixes dev/core#3747
It's confusing to handle saving custom data in the APIv3 layer,
because APIv4 expects the BAO to handle it.

Until every BAO consistently uses WriteRecord this will continue to be a pain point.

23 months agoFix ActionLog BAO to not overwrite existing data
Coleman Watts [Thu, 21 Jul 2022 14:06:04 +0000 (10:06 -0400)]
Fix ActionLog BAO to not overwrite existing data

23 months agoMerge pull request #24027 from totten/master552-status-footer-skipsort
demeritcowboy [Thu, 21 Jul 2022 12:06:22 +0000 (08:06 -0400)]
Merge pull request #24027 from totten/master552-status-footer-skipsort

Status Check - Report the overall status (accurately)

23 months agoMerge pull request #24031 from yashodha/reports_improvements
demeritcowboy [Thu, 21 Jul 2022 10:58:16 +0000 (06:58 -0400)]
Merge pull request #24031 from yashodha/reports_improvements

Fix 'Pledge Made Date' display to show date and not time

23 months agoMerge pull request #24025 from demeritcowboy/batch-remove-2
Eileen McNaughton [Thu, 21 Jul 2022 07:58:39 +0000 (08:58 +0100)]
Merge pull request #24025 from demeritcowboy/batch-remove-2

dev/core#3050 - (Alternate) Fix crash removing an entry from a batch

23 months agofix 'Pledge Made Date' to show date and not time
yashodha [Thu, 21 Jul 2022 05:00:53 +0000 (10:30 +0530)]
fix 'Pledge Made Date' to show date and not time

23 months agoMerge pull request #24018 from seamuslee001/php8_1_null_batch_4
demeritcowboy [Thu, 21 Jul 2022 00:48:31 +0000 (20:48 -0400)]
Merge pull request #24018 from seamuslee001/php8_1_null_batch_4

[REF][PHP8.1] Batch 4 of fixing issues found in unit tests where pass…

23 months ago[REF][PHP8.1] Batch 4 of fixing issues found in unit tests where passing NULL values...
Seamus Lee [Tue, 19 Jul 2022 01:46:56 +0000 (11:46 +1000)]
[REF][PHP8.1] Batch 4 of fixing issues found in unit tests where passing NULL values triggers deprecations

Apply fixes as per Demeritcowboy

23 months agoMerge pull request #23767 from colemanw/afformRequireAuthx
Tim Otten [Wed, 20 Jul 2022 21:34:02 +0000 (14:34 -0700)]
Merge pull request #23767 from colemanw/afformRequireAuthx

Afform - Require Authx

23 months agoUpdate CRM/Utils/Check.php
Tim Otten [Wed, 20 Jul 2022 21:01:19 +0000 (14:01 -0700)]
Update CRM/Utils/Check.php

Co-authored-by: demeritcowboy <demeritcowboy@hotmail.com>
23 months agoUpgrader - Enqueue extension upgrade tasks
Tim Otten [Wed, 1 Jun 2022 21:10:22 +0000 (14:10 -0700)]
Upgrader - Enqueue extension upgrade tasks

23 months agoUpgrader - Re-assess dispatch policy at the start of every upgrade task
Tim Otten [Wed, 20 Jul 2022 08:11:22 +0000 (01:11 -0700)]
Upgrader - Re-assess dispatch policy at the start of every upgrade task

The practical effect should be this:

* All tasks before `doCoreFinish()` run with the `upgrade.main` policy
* All tasks after `doCoreFinish()` run with the `upgrade.finish` policy

Framing this change is a bit delicate because tasks can run in different
ways (eg AJAX queue runner; headless queue-runner; cv queue-runner).  This
should have the same consequence in all runners.

23 months agoMerge pull request #24028 from yashodha/reports_improvements
demeritcowboy [Wed, 20 Jul 2022 19:54:20 +0000 (15:54 -0400)]
Merge pull request #24028 from yashodha/reports_improvements

remove pledge status as mandatory in Pledge report

23 months agoMerge pull request #24023 from colemanw/searchKitHtml
Matthew Wire [Wed, 20 Jul 2022 14:13:29 +0000 (15:13 +0100)]
Merge pull request #24023 from colemanw/searchKitHtml

SearchKit - Allow html in columns

23 months agoremove pledge status as mandatory in Pledge report
yashodha [Wed, 20 Jul 2022 04:57:44 +0000 (10:27 +0530)]
remove pledge status as mandatory in Pledge report

23 months agoUpgrader - Pick initial dispatch policy based on how far we've progressed in upgrade
Tim Otten [Wed, 20 Jul 2022 07:32:37 +0000 (00:32 -0700)]
Upgrader - Pick initial dispatch policy based on how far we've progressed in upgrade

23 months ago(REF) Extract method \CRM_Upgrade_DispatchPolicy::useTemporarily()
Tim Otten [Wed, 1 Jun 2022 21:07:15 +0000 (14:07 -0700)]
(REF) Extract method \CRM_Upgrade_DispatchPolicy::useTemporarily()

23 months ago(REF) Extensions - Extract method to build upgrade queue
Tim Otten [Wed, 1 Jun 2022 20:51:06 +0000 (13:51 -0700)]
(REF) Extensions - Extract method to build upgrade queue

I was slightly concerned that building a queue under a different there are
two risks, although I don't think either is very big:

1.  That someone references the queue by name during the building process.
    However, it wouldn't make much sense from a DX POV (given how "Upgrader"
    classes are generally written), and I can't any references to
    `QUEUE_NAME` or `ext-upgrade` in `universe`

2.  That someone generates queue tasks with `weight`s that somehow clash with
    the `weight`s in core-queue. However, this also doesn't make much sense
    from a DX POV (given how "upgrader" classes are generally written).

23 months ago(REF) CiviEventDispacher - Enable getDispatchPolicy()
Tim Otten [Wed, 20 Jul 2022 07:57:31 +0000 (00:57 -0700)]
(REF) CiviEventDispacher - Enable getDispatchPolicy()

23 months agoCRM_Queue_Task - Fire internal events
Tim Otten [Wed, 20 Jul 2022 07:42:36 +0000 (00:42 -0700)]
CRM_Queue_Task - Fire internal events

23 months agoStatus Check - Report the overall status (accurately)
Tim Otten [Wed, 20 Jul 2022 03:38:10 +0000 (20:38 -0700)]
Status Check - Report the overall status (accurately)

Overview
--------

The page-footer includes a summary message about the system status (eg "System
Status: Ok" or "System Status: Error").  The footer has inaccurately summarized
the status.

Before
------

Suppose you have 5 "Error" messages and 1 "OK" message. It will summarize as "System Status: Ok".

(It emphasizes the *least severe* status-message.)

Code is more complex.

After
------

Suppose you have 5 "Error" messages and 1 "OK" message. It will summarize as "System Status: Error".

(It emphasizes the *most severe* status-message.)

Code is less complex.

Comments
--------

The overall value is determined in `CRM_Utils_Check::checkAll()`.  Heretofore,
`checkAll()` sorted the messages by severity and then emphasized the *first*
visible message.

The problem is that the sort-order has flip-flopped, so "first" means different things:

* In v4.7, the messages were descending. So "first" was "most severe".
* In v5.39 (11d593edde82e7de962ec9056cfebe87975fb499), the order was ascending.
  So "first" was "least severe". (It appears accidental.)
* In v5.45 (728c1cc31d0d323f74f7b980a1e183fb499d4e9e), the order flipped back
  to descending, but *only* for the Angular (`civicrm/a/#/status`) -- not the footer.

IMHO, the flip-floppiness means that callers cannot rely on the order returned
by `checkAll()` -- they should instead do a higher-level sort (as in v5.45's
728c1cc31d0d323f74f7b980a1e183fb499d4e9e).  The `uasort()` within `checkAll()`
is therefore redundant.  We might as well skip it -- and simplify the logic.