Coleman Watts [Wed, 8 Jun 2022 00:20:13 +0000 (20:20 -0400)]
Oauth - Use selectWhereClause to check perms instead of overriding API4 Get
Putting permission checks in the BAO ensures that they are always enforced
regardless of which layer accesses them (Api3, Api4, etc) and that they will be
enforced even if this is not the primary entity of the api call (e.g. using joins).
Seamus Lee [Mon, 18 Jul 2022 09:36:33 +0000 (19:36 +1000)]
Merge pull request #23954 from eileenmcnaughton/poly
Poly-fill-me-up
Eileen McNaughton [Mon, 18 Jul 2022 09:18:44 +0000 (21:18 +1200)]
Merge pull request #24004 from demeritcowboy/upload-woes
dev/core#3736 - Fix uploaded file on message template form
Eileen McNaughton [Wed, 6 Jul 2022 08:28:48 +0000 (20:28 +1200)]
Poly-fill-me-up
Eileen McNaughton [Mon, 18 Jul 2022 07:05:05 +0000 (19:05 +1200)]
Merge pull request #23996 from seamuslee001/php8_1_pear_db
[REF][PHP8.1] Apply PR patch to fix issue in php8.1 where mysqli erro…
Seamus Lee [Mon, 18 Jul 2022 02:15:50 +0000 (12:15 +1000)]
Merge pull request #24007 from demeritcowboy/pdf-error
Fix test. Don't hide errors. (Followup to 23999)
demeritcowboy [Sun, 17 Jul 2022 05:04:41 +0000 (01:04 -0400)]
Fix test. Don't hide errors.
demeritcowboy [Sat, 16 Jul 2022 15:29:35 +0000 (11:29 -0400)]
fix missing upload
demeritcowboy [Sat, 16 Jul 2022 14:57:59 +0000 (10:57 -0400)]
Merge pull request #23999 from seamuslee001/null_part3_php81
[REF][PHP8.1] A third batch of fixes where passing in NULL values cau…
Eileen McNaughton [Sat, 16 Jul 2022 06:51:18 +0000 (18:51 +1200)]
Merge pull request #23995 from colemanw/custom_custom
Allow custom fields to have custom fields
Tim Otten [Sat, 16 Jul 2022 00:12:38 +0000 (17:12 -0700)]
Merge pull request #24000 from seamuslee001/property_bag_fixs
[REF][PHP8.1] Fix Return type hints and passing in NULL values causin…
Tim Otten [Fri, 15 Jul 2022 07:59:55 +0000 (00:59 -0700)]
Merge pull request #23997 from seamuslee001/php8_1_null_ext
[REF][PHP8.1] Fix issues in core extensions where passing in NULL val…
Matthew Wire [Thu, 14 Jul 2022 14:29:55 +0000 (15:29 +0100)]
Merge pull request #23974 from colemanw/filterFieldsAfform
Afform - Allow groups and tags and age to be filters
Seamus Lee [Thu, 14 Jul 2022 09:52:49 +0000 (19:52 +1000)]
Merge pull request #23993 from colemanw/searchKitJoinFix
SearchKit - Fix adding deep joins
Seamus Lee [Wed, 13 Jul 2022 23:35:42 +0000 (09:35 +1000)]
[REF][PHP8.1] Apply PR patch to fix issue in php8.1 where mysqli error reporting changed
Seamus Lee [Thu, 14 Jul 2022 02:19:27 +0000 (12:19 +1000)]
Merge pull request #23998 from MegaphoneJon/net-smtp-110
net_smtp upgrade to 1.10.0
Seamus Lee [Thu, 14 Jul 2022 00:50:51 +0000 (10:50 +1000)]
[REF][PHP8.1] Fix Return type hints and passing in NULL values causing deprecation notices in php8.1 in Property Bag
Seamus Lee [Thu, 14 Jul 2022 00:38:14 +0000 (10:38 +1000)]
[REF][PHP8.1] A third batch of fixes where passing in NULL values causes deprecation notices in php8.1
Jon Goldberg [Thu, 14 Jul 2022 00:13:14 +0000 (20:13 -0400)]
net_smtp upgrade to 1.10.0
Seamus Lee [Wed, 13 Jul 2022 23:43:15 +0000 (09:43 +1000)]
[REF][PHP8.1] Fix issues in core extensions where passing in NULL values is no longer supported
Coleman Watts [Wed, 13 Jul 2022 21:30:02 +0000 (17:30 -0400)]
Allow custom fields to have custom fields
Theoretically a custom field could have custom fields! Trippy...
Fixes dev/core#3731
Coleman Watts [Wed, 13 Jul 2022 15:54:25 +0000 (11:54 -0400)]
SearchKit - Fix adding deep joins
This fixes a UI bug that was preventing joins past a depth of 2 to be added.
Eileen McNaughton [Wed, 13 Jul 2022 04:20:59 +0000 (16:20 +1200)]
Merge pull request #23992 from civicrm/5.52
5.52
Seamus Lee [Wed, 13 Jul 2022 00:34:58 +0000 (10:34 +1000)]
Merge pull request #23991 from totten/5.52-civitest
Civi\Test - Fix leak in active module-list for headless test
Tim Otten [Tue, 12 Jul 2022 02:00:59 +0000 (19:00 -0700)]
Civi\Test - Fix leak in active module-list for headless test
Steps to reproduce
------------------
Observed on a `dmaster` build while running these steps:
* Run civix's `make-example.sh`
* Or just run some subset involving a headless test, eg
* civix generate:test --template=headless 'Civi\Civiexample\BarTest'
* cv api extension.install key=$EXMODULE
* phpunit8 ./tests/phpunit/Civi/Civiexample/BarTest.php
Before
------
Fatal error: Uncaught Error: Class 'Civi\Api4\SearchSegment' not found in
/home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/ext/search_kit/Civi/Api4/Service/Spec/Provider/SearchSegmentExtraFieldProvider.php
on line 52
After
-----
Test runs
Eileen McNaughton [Tue, 12 Jul 2022 03:23:07 +0000 (15:23 +1200)]
Merge pull request #23984 from seamuslee001/ref_full_package_upgrades_php8_1
[REF][PHP8.1] Upgrade oauth2-client,zetacomponents/base,htmlpurfier packages …
Seamus Lee [Tue, 12 Jul 2022 02:04:16 +0000 (12:04 +1000)]
Merge pull request #23990 from civicrm/5.52
5.52
Seamus Lee [Tue, 12 Jul 2022 02:03:04 +0000 (12:03 +1000)]
Merge pull request #23988 from seamuslee001/5_52_phpunit_deprecations
[NFC] Restore handling for deprecations in phpunit test runs
Seamus Lee [Mon, 11 Jul 2022 08:10:47 +0000 (18:10 +1000)]
[NFC] Add in convertDeprecationsToExceptions='true' to core extension's phpunit.xml.dist files
Seamus Lee [Mon, 11 Jul 2022 02:26:21 +0000 (12:26 +1000)]
[NFC] Convert Deprecations in tests to exceptions
demeritcowboy [Mon, 11 Jul 2022 13:29:13 +0000 (09:29 -0400)]
Merge pull request #22227 from mlutfy/standalone
CiviCRM Standalone: base classes
demeritcowboy [Mon, 11 Jul 2022 12:03:04 +0000 (08:03 -0400)]
Merge pull request #23986 from seamuslee001/dep_exceptions_ext
[NFC] Add in convertDeprecationsToExceptions='true' to core extension…
Seamus Lee [Mon, 11 Jul 2022 08:10:47 +0000 (18:10 +1000)]
[NFC] Add in convertDeprecationsToExceptions='true' to core extension's phpunit.xml.dist files
Seamus Lee [Mon, 11 Jul 2022 05:21:02 +0000 (15:21 +1000)]
Merge pull request #23985 from seamuslee001/nfc_deprecations
[NFC] Convert Deprecations in tests to exceptions
Seamus Lee [Mon, 11 Jul 2022 02:26:21 +0000 (12:26 +1000)]
[NFC] Convert Deprecations in tests to exceptions
Seamus Lee [Mon, 11 Jul 2022 00:46:57 +0000 (10:46 +1000)]
Merge pull request #23982 from eileenmcnaughton/act_cont
dev/core#3692 Remove hard coded activity_type_id
Seamus Lee [Mon, 11 Jul 2022 00:46:46 +0000 (10:46 +1000)]
Merge pull request #23981 from eileenmcnaughton/act_seq
dev/core#3692 Remove call to deprecated function
Seamus Lee [Sun, 10 Jul 2022 23:42:39 +0000 (09:42 +1000)]
Merge pull request #23979 from eileenmcnaughton/act_status
dev/core#3692 Comment fixes
Seamus Lee [Sun, 10 Jul 2022 23:03:11 +0000 (09:03 +1000)]
[REF] Upgrade oauth2-client,zetacomponents/base,htmlpurfier packages to versions that support php8.1
Eileen McNaughton [Sun, 10 Jul 2022 22:41:12 +0000 (10:41 +1200)]
Merge pull request #23932 from webmaster-cses-org-uk/patch-4
Add support for multiple-selection of contact IDs in _civicrm_api3_custom_data_get()
Eileen McNaughton [Sun, 10 Jul 2022 21:45:37 +0000 (09:45 +1200)]
Remove hard coded activity_type_id
Eileen McNaughton [Sun, 10 Jul 2022 21:42:08 +0000 (09:42 +1200)]
Remove call to deprecated function
Eileen McNaughton [Sun, 10 Jul 2022 21:35:49 +0000 (09:35 +1200)]
Comment fixes
Eileen McNaughton [Sun, 10 Jul 2022 21:04:56 +0000 (09:04 +1200)]
Merge pull request #23978 from demeritcowboy/composerlock
[NFC] fix composer.lock hash
Eileen McNaughton [Sun, 10 Jul 2022 21:04:37 +0000 (09:04 +1200)]
Merge pull request #23977 from demeritcowboy/dompdf-whitespace
[NFC] dompdf patch whitespace fix
demeritcowboy [Sun, 10 Jul 2022 20:42:29 +0000 (16:42 -0400)]
Merge pull request #20588 from mattwire/recaptcharefactor
REF dev/core#2571 Move reCAPTCHA code to extension
demeritcowboy [Sun, 10 Jul 2022 15:58:42 +0000 (11:58 -0400)]
fix lock hash
demeritcowboy [Sun, 10 Jul 2022 15:21:23 +0000 (11:21 -0400)]
Merge pull request #22918 from demeritcowboy/guzzle7
dev/drupal#171 - Allow guzzle 7 for drupal 10
demeritcowboy [Sun, 10 Jul 2022 15:09:46 +0000 (11:09 -0400)]
whitespace fix
demeritcowboy [Sun, 10 Jul 2022 15:07:48 +0000 (11:07 -0400)]
Merge pull request #23946 from seamuslee001/dompdf_upgrade
[REF] Upgrade DOMPDF to 2.x branch
demeritcowboy [Sat, 9 Jul 2022 15:21:10 +0000 (11:21 -0400)]
Merge pull request #23851 from seamuslee001/php81_deprecations
[REF][PHP8.1] Fix a couple of deprecations in php8.1 by specifying th…
Seamus Lee [Sat, 9 Jul 2022 08:27:06 +0000 (18:27 +1000)]
Merge pull request #23976 from civicrm/5.52
5.52
Seamus Lee [Sat, 9 Jul 2022 04:31:53 +0000 (14:31 +1000)]
Merge pull request #23975 from totten/5.52-skip-soaptest
(NFC) SoapTest - Skip this test on Drupal8+ and Backdrop
CiviCRM [Sat, 9 Jul 2022 02:29:00 +0000 (02:29 +0000)]
Set version to 5.53.alpha1
CiviCRM [Sat, 9 Jul 2022 02:24:14 +0000 (02:24 +0000)]
Set version to 5.52.beta1
Tim Otten [Sat, 9 Jul 2022 02:21:35 +0000 (19:21 -0700)]
(NFC) SoapTest - Skip this test on Drupal8+ and Backdrop
Never passed on D8+. Has been failing for a while on Backdrop. There's a
work-a-like extension. No need to monitor results on these configurations.
Seamus Lee [Wed, 6 Jul 2022 02:28:10 +0000 (12:28 +1000)]
Fix installed-fonts cache
Seamus Lee [Tue, 5 Jul 2022 22:32:40 +0000 (08:32 +1000)]
[REF] Upgrade DOMPDF to 2.x branch
Seamus Lee [Sat, 9 Jul 2022 00:51:33 +0000 (10:51 +1000)]
Merge pull request #23971 from seamuslee001/lab_core_3676
[REF] dev/core#3676 Add in html2text/html2text to replace usage of roundcube's version we have in packages
Seamus Lee [Tue, 21 Jun 2022 06:11:57 +0000 (16:11 +1000)]
[REF][PHP8.1] Fix a couple of deprecations in php8.1 by specifying that return type may change in BaseParamQuery and by ensuring that we don't pass null into function_exists in I18n class
Replace some ReturnTypeWillChange with later return types as they should be backward compatible
Dave D Fix
Completely switch to just not empty on the customTranslationFunction check
Seamus Lee [Fri, 8 Jul 2022 22:37:15 +0000 (08:37 +1000)]
Update Base Mailing System Test to match newer output format
Seamus Lee [Fri, 8 Jul 2022 22:31:08 +0000 (08:31 +1000)]
Merge pull request #23968 from eileenmcnaughton/import_note
Fix import falling over when a note is included
Coleman Watts [Fri, 8 Jul 2022 14:10:22 +0000 (10:10 -0400)]
Afform - Allow groups and tags and age to be filters
Seamus Lee [Fri, 8 Jul 2022 05:52:21 +0000 (15:52 +1000)]
[REF] dev/core#3676 Add in html2text/html2text to replace usage of roundcube's version we have in packages
Seamus Lee [Fri, 8 Jul 2022 05:42:28 +0000 (15:42 +1000)]
Add in necessary patch for html2text for php8.1
Eileen McNaughton [Fri, 8 Jul 2022 02:41:32 +0000 (14:41 +1200)]
Merge pull request #23967 from colemanw/angularCleanup
REF - Remove unneeded return from private fn, add comments
Eileen McNaughton [Thu, 7 Jul 2022 22:21:46 +0000 (10:21 +1200)]
Fix import falling over when a note is included
Coleman Watts [Thu, 7 Jul 2022 22:19:26 +0000 (18:19 -0400)]
REF - Remove unneeded return from private fn, add comments
Eileen McNaughton [Thu, 7 Jul 2022 21:57:01 +0000 (09:57 +1200)]
Merge pull request #23965 from MegaphoneJon/contribution-view-perm-fix
Fixes core#3725 'Access CiviContribute' can't view a single contribution
Tim Otten [Thu, 7 Jul 2022 21:46:38 +0000 (14:46 -0700)]
Merge pull request #23925 from seamuslee001/type_hints_2
[REF][PHP8.1] Add in type hints to fix deprecations and add in #[\Ret…
Jon Goldberg [Thu, 7 Jul 2022 18:35:27 +0000 (14:35 -0400)]
Fixes core#3725 'Access CiviContribute' can't view a single contribution
colemanw [Thu, 7 Jul 2022 15:02:32 +0000 (11:02 -0400)]
Merge pull request #23929 from eileenmcnaughton/recur
Upgrade script for contribution_recur amount, fix loading
colemanw [Thu, 7 Jul 2022 15:02:18 +0000 (11:02 -0400)]
Merge pull request #23809 from eileenmcnaughton/invoice_recur
Fix bug whereby editing contribution_recur.amount was not updating single-line-item-template-contributions
colemanw [Thu, 7 Jul 2022 15:00:42 +0000 (11:00 -0400)]
Merge pull request #23964 from eileenmcnaughton/tpl_err
Do not escape error message
Matthew Wire [Thu, 7 Jul 2022 12:38:32 +0000 (13:38 +0100)]
Merge pull request #23937 from demeritcowboy/case-activity-search-filter
dev/core#3709 - Make the activity search filter on manage case less unwieldy
Matthew Wire [Thu, 7 Jul 2022 12:37:26 +0000 (13:37 +0100)]
Merge pull request #23962 from eileenmcnaughton/pledge
Remove another instance of pledges using contribution option group
Matthew Wire [Thu, 7 Jul 2022 12:36:34 +0000 (13:36 +0100)]
Merge pull request #23963 from eileenmcnaughton/tpl
Smarty notice fix
Matthew Wire [Thu, 7 Jul 2022 12:35:55 +0000 (13:35 +0100)]
Merge pull request #23924 from colemanw/afformPopup
Angular - Support popping up an afform or other ang module via ajax modal
Eileen McNaughton [Thu, 7 Jul 2022 09:13:04 +0000 (21:13 +1200)]
Also don't escape in if context
- just a bit less confusing when debugging
Eileen McNaughton [Thu, 7 Jul 2022 08:58:14 +0000 (20:58 +1200)]
Add precautionary purify
Eileen McNaughton [Thu, 7 Jul 2022 08:57:05 +0000 (20:57 +1200)]
Do not escape error message
Eileen McNaughton [Thu, 7 Jul 2022 08:25:32 +0000 (20:25 +1200)]
Smarty notice fix
Seamus Lee [Thu, 7 Jul 2022 07:37:36 +0000 (17:37 +1000)]
Merge pull request #23961 from totten/master-mgdphp-caseacttype
(NFC) mgd-php@1 - Add example+assertions for new case-type
Seamus Lee [Thu, 7 Jul 2022 07:37:26 +0000 (17:37 +1000)]
Merge pull request #23960 from seamuslee001/fix_static_calling_trait
[REF][PHP8.1] Fix deprecations where by calling trait static function…
Eileen McNaughton [Thu, 7 Jul 2022 06:38:04 +0000 (18:38 +1200)]
Merge pull request #23959 from totten/master-casexml-acttype
(NFC) case-xml@1 - Add example+assertions of new activity-type
Eileen McNaughton [Thu, 7 Jul 2022 05:22:57 +0000 (17:22 +1200)]
Remove another instance of pledges using contribution option group
Eileen McNaughton [Thu, 7 Jul 2022 02:06:15 +0000 (14:06 +1200)]
Declare total_amount, make amount an alias
The confusion between amount & total_amount is in
multiple places - this means they are treated 'the same' if passed
into repeattransaction
Eileen McNaughton [Thu, 7 Jul 2022 02:00:34 +0000 (14:00 +1200)]
Fix handling of parameters in repeattransaction
The function was forcing in the value from the original contribution
into amount, rather than the value from the templateContribution
Eileen McNaughton [Wed, 6 Jul 2022 23:04:12 +0000 (11:04 +1200)]
Enotice fix for when campaign is disabled
Eileen McNaughton [Fri, 1 Jul 2022 21:13:07 +0000 (09:13 +1200)]
Upgrade script for contribution_recur amount, fix loading
Eileen McNaughton [Thu, 7 Jul 2022 05:05:27 +0000 (17:05 +1200)]
Merge pull request #23084 from pradpnayak/paypalipnchangemaount
Subscription Amount change not respected in Paypal
Seamus Lee [Thu, 7 Jul 2022 04:23:31 +0000 (14:23 +1000)]
[REF][PHP8.1] Fix deprecations where by calling trait static functions when not from a class that implements the trait is deprecated
Seamus Lee [Thu, 7 Jul 2022 04:14:25 +0000 (14:14 +1000)]
Merge pull request #23958 from civicrm/5.51
5.51
Tim Otten [Thu, 7 Jul 2022 03:15:14 +0000 (20:15 -0700)]
mgd-php@1 - Add example+assertions for new case-type (but without a real `definition`)
Tim Otten [Thu, 7 Jul 2022 03:12:03 +0000 (20:12 -0700)]
case-xml@1 - Add example+assertions of new activity-type
Seamus Lee [Thu, 7 Jul 2022 01:42:59 +0000 (11:42 +1000)]
Merge pull request #23956 from agh1/5.51.0-releasenotes-final
5.51.0 release notes final changes
colemanw [Wed, 6 Jul 2022 23:02:23 +0000 (19:02 -0400)]
Merge pull request #23933 from eileenmcnaughton/require
Import fix - if there are no required fields validateRequiredFields should 'pass'
colemanw [Wed, 6 Jul 2022 22:59:52 +0000 (18:59 -0400)]
Merge pull request #23934 from eileenmcnaughton/url_tokens
dev/core#3713 Use front-end urls for event url tokens
colemanw [Wed, 6 Jul 2022 22:56:36 +0000 (18:56 -0400)]
Merge pull request #23953 from eileenmcnaughton/imp_job
dev/core#3719 fix inconistent handling of job_type:label
Coleman Watts [Wed, 6 Jul 2022 21:10:35 +0000 (17:10 -0400)]
Afform - Close popup dialog after submitting