Jitendra Purohit [Sat, 21 Oct 2023 09:43:21 +0000 (15:13 +0530)]
Fix fatal error on pledge delete
colemanw [Fri, 20 Oct 2023 10:18:40 +0000 (06:18 -0400)]
Merge pull request #27856 from colemanw/emptyRequires
dev/core#4707 Don't error if extension has empty `requires` tag
colemanw [Wed, 18 Oct 2023 23:28:43 +0000 (19:28 -0400)]
Extensions - Don't accept invalid keys, include empty <requires> in test
colemanw [Wed, 18 Oct 2023 23:19:29 +0000 (19:19 -0400)]
UnitTest - Rename & reformat json file
No changes to the file content other than whitespace
colemanw [Wed, 18 Oct 2023 20:13:46 +0000 (16:13 -0400)]
dev/core#4707 Don't error if extension has empty `requires` tag
colemanw [Thu, 19 Oct 2023 23:02:02 +0000 (19:02 -0400)]
Merge pull request #27868 from eileenmcnaughton/567-e
dev/core#4706 Custom data fix
Eileen McNaughton [Thu, 19 Oct 2023 21:37:24 +0000 (10:37 +1300)]
dev/core#4706 Custom data fix
colemanw [Thu, 19 Oct 2023 21:20:28 +0000 (17:20 -0400)]
Merge pull request #27854 from eileenmcnaughton/567
Fix regression when searching by contact ID from quickSearch (if you hit enter quickly)
Eileen McNaughton [Tue, 17 Oct 2023 23:59:52 +0000 (12:59 +1300)]
Fix variable leakage between uf_group_id & contact ID
Matthew Wire [Mon, 16 Oct 2023 20:35:56 +0000 (21:35 +0100)]
Merge pull request #27798 from colemanw/angCheck
Angular - Noisily deprecate 'settings' in favor of 'settingsFactory'
colemanw [Thu, 12 Oct 2023 23:44:23 +0000 (19:44 -0400)]
Angular - Noisily deprecate 'settings' in favor of 'settingsFactory'
Eileen McNaughton [Wed, 11 Oct 2023 22:05:45 +0000 (11:05 +1300)]
Merge pull request #27788 from eileenmcnaughton/567_prem
Add weights to premium screen
Eileen McNaughton [Wed, 11 Oct 2023 21:05:17 +0000 (10:05 +1300)]
Add weights to premium screen
Yashodha Chaku [Wed, 11 Oct 2023 10:42:16 +0000 (16:12 +0530)]
Merge pull request #27780 from eileenmcnaughton/567_pcp
Add some weights to pcp page
Eileen McNaughton [Wed, 11 Oct 2023 05:33:31 +0000 (18:33 +1300)]
Add some weights to pcp page
colemanw [Wed, 11 Oct 2023 01:20:22 +0000 (21:20 -0400)]
Merge pull request #27771 from eileenmcnaughton/567
Do not run financial acls if the setting it not set
Eileen McNaughton [Wed, 11 Oct 2023 00:36:22 +0000 (13:36 +1300)]
Do not run financial acls if the setting it not set
Yeah - continues a fugly fix - but it's quick & works
colemanw [Tue, 10 Oct 2023 13:09:12 +0000 (09:09 -0400)]
Merge pull request #27722 from colemanw/civiCaseSelectWhereClause
CiviCase - Fix SelectWhereClause for Activity queries
colemanw [Tue, 10 Oct 2023 00:34:10 +0000 (20:34 -0400)]
ActivityTest - Fix tearDown to prevent test leakage
colemanw [Sat, 7 Oct 2023 17:30:12 +0000 (13:30 -0400)]
Fix Activity ACL clause generation
Regression was caused by
918e583a146876fb42932a1d959796fd710b7b74 updating DAO::getSelectWhereClause
but not CRM_Contact_BAO_Query::generatePermissionClause. Turns out the code was being duplicated and
the latter could just call the former.
colemanw [Fri, 6 Oct 2023 18:45:01 +0000 (14:45 -0400)]
Fix tests not setting permissions properly
colemanw [Thu, 5 Oct 2023 18:01:25 +0000 (14:01 -0400)]
DAO - Handle OR clauses in getDynamicFkAclClauses, improve sql formatting for readability
Follow-up to
918e583a146876fb42932a1d959796fd710b7b74 - this correctly joins sub-arrays using OR
colemanw [Sat, 7 Oct 2023 13:45:34 +0000 (09:45 -0400)]
Merge pull request #27748 from eileenmcnaughton/register_567
Fix rc regression on register participants action
Seamus Lee [Sat, 7 Oct 2023 03:59:29 +0000 (14:59 +1100)]
Merge pull request #27747 from eileenmcnaughton/567
Regen (rc)
Eileen McNaughton [Sat, 7 Oct 2023 02:47:34 +0000 (15:47 +1300)]
Fix rc regression on register participants action
Fixes an rc bug where contact information was not being loaded per participant,
resulting in emails not going out
Eileen McNaughton [Sat, 7 Oct 2023 01:52:08 +0000 (14:52 +1300)]
Regen (rc)
colemanw [Sat, 7 Oct 2023 01:35:42 +0000 (21:35 -0400)]
Merge pull request #27728 from eileenmcnaughton/surver
Add some more weight fields
colemanw [Sat, 7 Oct 2023 01:34:52 +0000 (21:34 -0400)]
Merge pull request #27741 from eileenmcnaughton/567_event
Fix rc regression - balance amount missing
Eileen McNaughton [Fri, 6 Oct 2023 23:15:41 +0000 (12:15 +1300)]
Fix rc regression - balance amount missing
This is pretty hard to get to (outside the test). You need to configure
an event with a pending contribution and then partially pay it
and go back & send a receipt.
Unfortunately the
Paid amount & Balance amount
got removed from the html version by accident
and the tests didn't pick it up because they were testing
the text version - which had not had many of the recent updates
applied (it was going to be done after but we have since decided to remove the
text version).
This updates the test to check the html version, puts back the removed text
and adds it to the preview screen
colemanw [Sat, 7 Oct 2023 00:50:06 +0000 (20:50 -0400)]
Merge pull request #27742 from eileenmcnaughton/smarty_tag
Fix missing quotes in tpl file
Eileen McNaughton [Sat, 7 Oct 2023 00:43:30 +0000 (13:43 +1300)]
Fix missing quotes in tpl file
This is a longstanding error rather than a regression - but it hard failes when
Smarty3 is enabled. Smarty3 is a pretty good tool for finding issues when testing
the rc it turns out (highlights variable errors in smarty)
so I'm fixing in the rc so as not to be blocked on using smarty with the rc
Eileen McNaughton [Fri, 6 Oct 2023 20:27:23 +0000 (09:27 +1300)]
Merge pull request #27736 from colemanw/afformFnError
Afform - fix undefined function error
colemanw [Fri, 6 Oct 2023 14:37:45 +0000 (10:37 -0400)]
Afform - fix undefined function error
Fixes bug from
1ff8423300d85100e026741111383cdabd5fce05
Eileen McNaughton [Fri, 6 Oct 2023 02:57:57 +0000 (15:57 +1300)]
Merge pull request #27730 from eileenmcnaughton/567
Notice fix
Eileen McNaughton [Fri, 6 Oct 2023 02:11:14 +0000 (15:11 +1300)]
Notice fix
colemanw [Thu, 5 Oct 2023 02:22:53 +0000 (22:22 -0400)]
CiviCase - Add selectWhereClause for activities
Eileen McNaughton [Thu, 5 Oct 2023 23:58:13 +0000 (12:58 +1300)]
Add some more weight fields
CiviCRM [Thu, 5 Oct 2023 05:30:14 +0000 (05:30 +0000)]
Set version to 5.67.beta1
Tim Otten [Thu, 5 Oct 2023 05:28:28 +0000 (22:28 -0700)]
Merge commit '
269f94546c'
Tim Otten [Thu, 5 Oct 2023 05:21:46 +0000 (22:21 -0700)]
Merge pull request #27725 from eileenmcnaughton/new-notice
Enotice fix
Tim Otten [Thu, 5 Oct 2023 04:41:37 +0000 (21:41 -0700)]
Merge pull request #27557 from eileenmcnaughton/bulk_create
dev/core#4567 Update code creating queue entries to save mailing_id
Eileen McNaughton [Thu, 5 Oct 2023 04:02:35 +0000 (17:02 +1300)]
Enotice fix
Tim Otten [Thu, 5 Oct 2023 03:50:37 +0000 (20:50 -0700)]
Merge pull request #27720 from eileenmcnaughton/566
Do not create new contacts during bounce processing
colemanw [Wed, 4 Oct 2023 19:17:07 +0000 (15:17 -0400)]
APIv4 - Don't crash if permission denied to join
Tim Otten [Thu, 5 Oct 2023 00:38:22 +0000 (17:38 -0700)]
Merge pull request #27721 from totten/5.66-rn0
release-notes/5.66.0.md - Add some more late-stage PRs from RC
Tim Otten [Wed, 4 Oct 2023 23:48:34 +0000 (16:48 -0700)]
release-notes/5.66.0.md - Add some more late-stage PRs from RC
Also: some random edits
Eileen McNaughton [Wed, 4 Oct 2023 23:15:12 +0000 (12:15 +1300)]
Do not create new contacts during bounce processing
Eileen McNaughton [Wed, 4 Oct 2023 20:17:03 +0000 (09:17 +1300)]
Merge pull request #27719 from eileenmcnaughton/regen
Re-run regen
Eileen McNaughton [Wed, 4 Oct 2023 19:24:25 +0000 (08:24 +1300)]
Merge pull request #27716 from colemanw/endsWithPolyfill
CRM_Utils_String - Deprecate startsWith and endsWith
Eileen McNaughton [Wed, 4 Oct 2023 19:23:36 +0000 (08:23 +1300)]
Re-run regen
colemanw [Wed, 4 Oct 2023 12:51:07 +0000 (08:51 -0400)]
CRM_Utils_String - Deprecate startsWith and endsWith
colemanw [Wed, 4 Oct 2023 16:44:45 +0000 (12:44 -0400)]
Merge pull request #27718 from MegaphoneJon/initialize-mfg-var
getTree: initialize variable before it's used (PHP8 compat)
Jon Goldberg [Wed, 4 Oct 2023 15:54:29 +0000 (11:54 -0400)]
getTree: initialize variable before it's used
Aidan Saunders [Wed, 4 Oct 2023 15:45:06 +0000 (16:45 +0100)]
Merge pull request #27701 from colemanw/relTab
ContactSummary - Replace Relationships tab with SearchKit display
Eileen McNaughton [Wed, 4 Oct 2023 08:45:48 +0000 (21:45 +1300)]
Merge pull request #27715 from civicrm/5.66
Merge forward: 5.66 RC => master
Tim Otten [Wed, 4 Oct 2023 05:45:44 +0000 (22:45 -0700)]
Merge pull request #27714 from totten/5.66-srchmap-php73
SavedSearchMappingTest - Fix compat with php73
Tim Otten [Wed, 4 Oct 2023 03:42:57 +0000 (20:42 -0700)]
SavedSearchMappingTest - Fix compat with php73
Seamus Lee [Wed, 4 Oct 2023 02:04:02 +0000 (13:04 +1100)]
Merge pull request #27713 from colemanw/contactTypeAutocomplete
APIv4 - Fix autocomplete for Individual,Household,Organization entities
colemanw [Wed, 4 Oct 2023 00:22:13 +0000 (20:22 -0400)]
SearchKit - Fix nonexistant links incorrectly displaying
colemanw [Mon, 2 Oct 2023 16:05:04 +0000 (12:05 -0400)]
ContactSummary - Prevent excessive/infinite refreshing of related tabs
colemanw [Mon, 2 Oct 2023 05:37:14 +0000 (01:37 -0400)]
SearchKit - When refreshing after a task, refresh all displays in a form
colemanw [Mon, 2 Oct 2023 05:14:16 +0000 (01:14 -0400)]
ContactSummary - Add link to manage case in Relationships tab
colemanw [Mon, 2 Oct 2023 05:13:35 +0000 (01:13 -0400)]
SearchKit - Don't crash if join entity doesn't exist
colemanw [Mon, 2 Oct 2023 04:54:28 +0000 (00:54 -0400)]
CiviCase - Add "manage case" link to metadata, make cid optional
colemanw [Mon, 2 Oct 2023 02:41:44 +0000 (22:41 -0400)]
ContactSummary - Remove old relationships tab
colemanw [Mon, 2 Oct 2023 01:48:59 +0000 (21:48 -0400)]
ContactSummary - Add SearchKit display for relationships tab
colemanw [Sun, 1 Oct 2023 18:03:45 +0000 (14:03 -0400)]
Update icon for relationship permission
colemanw [Sun, 1 Oct 2023 14:26:23 +0000 (10:26 -0400)]
RelationshipCache - Add 'add' metadata
colemanw [Sun, 1 Oct 2023 02:41:54 +0000 (22:41 -0400)]
SearchKit - The first display in a tab gets to control the count
Fix weird tab count if > 1 search display in a tab
colemanw [Sun, 1 Oct 2023 01:59:03 +0000 (21:59 -0400)]
Afform - Fix data type when setting entity values
colemanw [Wed, 4 Oct 2023 00:25:28 +0000 (20:25 -0400)]
Merge pull request #27660 from eileenmcnaughton/delete
Separate delete participant form from edit participant form
colemanw [Tue, 3 Oct 2023 23:22:39 +0000 (19:22 -0400)]
APIv4 - Fix autocomplete for Individual,Household,Organization entities
Eileen McNaughton [Tue, 3 Oct 2023 22:11:34 +0000 (11:11 +1300)]
Merge pull request #27691 from totten/master-queue-runloop
Queue::run() - Add API for running several tasks
colemanw [Tue, 3 Oct 2023 22:09:18 +0000 (18:09 -0400)]
Merge pull request #27693 from eileenmcnaughton/remove_math
Replace smarty-math with assigned value
colemanw [Tue, 3 Oct 2023 21:25:02 +0000 (17:25 -0400)]
Merge pull request #27592 from colemanw/afformBool
Afform - Fix display of boolean checkboxes
Tim Otten [Tue, 3 Oct 2023 21:21:16 +0000 (14:21 -0700)]
Rename Queue::runLoop() to Queue::run()
Tim Otten [Tue, 3 Oct 2023 20:56:59 +0000 (13:56 -0700)]
(NFC) RunLoop - Expand docblocks
Eileen McNaughton [Tue, 3 Oct 2023 20:31:16 +0000 (09:31 +1300)]
Merge pull request #27642 from lemniscus/sk-table-header-alignment
SearchKit: Align column headers according to settings
Noah Miller [Tue, 26 Sep 2023 04:39:58 +0000 (00:39 -0400)]
SK: Align column headers according to settings
Eileen McNaughton [Tue, 3 Oct 2023 19:22:44 +0000 (08:22 +1300)]
Merge pull request #27712 from colemanw/contactTypeApi2
[NFC] APIv4 - Update contact type api comment
Aidan Saunders [Tue, 3 Oct 2023 16:33:19 +0000 (17:33 +0100)]
Merge pull request #27700 from colemanw/exportDefaults
APIv4 - Trim output of Export action to only non-default values
Aidan Saunders [Tue, 3 Oct 2023 16:10:35 +0000 (17:10 +0100)]
Merge pull request #27698 from colemanw/afformShareFieldset
SearchKit - Fix and add test for scenario where the same display is used twice on a form
colemanw [Mon, 2 Oct 2023 20:04:03 +0000 (16:04 -0400)]
Managed - Backfill default values when reverting APIv4 entity
colemanw [Tue, 3 Oct 2023 12:56:16 +0000 (08:56 -0400)]
Merge pull request #27484 from totten/master-links
hook_civicrm_links - Add docblocks and event-checker
colemanw [Tue, 3 Oct 2023 12:30:39 +0000 (08:30 -0400)]
APIv4 - Update contact type api comment
Eileen McNaughton [Tue, 3 Oct 2023 09:52:25 +0000 (22:52 +1300)]
Merge pull request #27711 from civicrm/5.66
5.66 to master
Eileen McNaughton [Tue, 3 Oct 2023 09:44:44 +0000 (22:44 +1300)]
Merge pull request #27710 from totten/5.66-links-weights
hook_civicrm_links - Add more weights
Tim Otten [Tue, 19 Sep 2023 05:59:34 +0000 (22:59 -0700)]
hook_civicrm_links - Add more weights:
- contribution.edit.action
- file.manage.delete
- financialItem.batch.row
- Payment.edit.action
Tim Otten [Tue, 3 Oct 2023 05:31:52 +0000 (22:31 -0700)]
Merge pull request #27659 from colemanw/contactTypeApi
APIv4 - Add Individual, Household, Organization pseudo-entities
Tim Otten [Tue, 3 Oct 2023 04:44:13 +0000 (21:44 -0700)]
hook_civicrm_links - Add exception for financialItem.batch.row
Tim Otten [Tue, 3 Oct 2023 04:34:21 +0000 (21:34 -0700)]
hook_civicrm_links - Add exception for `pledge.selector.row` (`is_active`)
Tim Otten [Tue, 19 Sep 2023 06:53:36 +0000 (23:53 -0700)]
hook_civicrm_links - Add exception for basic.CRM_Core_BAO_MessageTemplate.page
Tim Otten [Tue, 19 Sep 2023 05:59:34 +0000 (22:59 -0700)]
hook_civicrm_links - Add more weights:
- contribution.edit.action
- file.manage.delete
- financialItem.batch.row
- Payment.edit.action
Tim Otten [Tue, 19 Sep 2023 05:58:44 +0000 (22:58 -0700)]
hook_civicrm_links.evch.php - Grandfather some more gnarly links
Tim Otten [Tue, 19 Sep 2023 05:31:03 +0000 (22:31 -0700)]
(REF) hook_civicrm_links.evch.php - Move overrides
Tim Otten [Tue, 19 Sep 2023 05:06:54 +0000 (22:06 -0700)]
pcp.user.actions - Decompose deviant list of links
The problem is that:
* `hook_links('pcp.user.actions')` fires with a malformed set links
* The malformed set of links has been specifically encoded into unit tests
So fixing the bad links would likely break some consumer. (I don't see the
consumer in my copy of `universe`, but if someone wrote the test, then they
must've really meant it...)
This patch adds alternative variants (`hook_links('pcp.user.actions.add')` and
`hook_links('pcp.user.actions.all')`) which should replace it.
Tim Otten [Mon, 18 Sep 2023 07:17:22 +0000 (00:17 -0700)]
hook_civicrm_links - Add docblocks and event-checker
colemanw [Tue, 3 Oct 2023 02:16:38 +0000 (22:16 -0400)]
Merge pull request #27695 from eileenmcnaughton/smarty_sort
Fix sort_name & display_name settings to support new-style tokens
Tim Otten [Tue, 3 Oct 2023 01:45:27 +0000 (18:45 -0700)]
Queue::runLoop() - Add explanatory exit message for an aborted queue
Tim Otten [Tue, 3 Oct 2023 01:44:04 +0000 (18:44 -0700)]
Queue - Extract method getStatus()