civicrm-core.git
4 years agoMerge pull request #16275 from seamuslee001/nfC_payment_processor_type_field
colemanw [Sat, 11 Jan 2020 17:00:43 +0000 (12:00 -0500)]
Merge pull request #16275 from seamuslee001/nfC_payment_processor_type_field

[NFC] Explicitly specify that it is the Payment processor Type Name n…

4 years agoMerge pull request #16278 from civicrm/5.22
Seamus Lee [Sat, 11 Jan 2020 02:44:56 +0000 (13:44 +1100)]
Merge pull request #16278 from civicrm/5.22

5.22

4 years agoMerge pull request #16277 from seamuslee001/5.22
Tim Otten [Sat, 11 Jan 2020 00:56:02 +0000 (16:56 -0800)]
Merge pull request #16277 from seamuslee001/5.22

Add release notes for 5.21.1

4 years agoAdd release notes for 5.21.1
Tim Otten [Sat, 11 Jan 2020 00:34:03 +0000 (16:34 -0800)]
Add release notes for 5.21.1

4 years ago[NFC] Explicitly specify that it is the Payment processor Type Name not Payment Proce...
Seamus Lee [Fri, 10 Jan 2020 23:38:23 +0000 (10:38 +1100)]
[NFC] Explicitly specify that it is the Payment processor Type Name not Payment Procesor name field.

4 years agoMerge pull request #15829 from eileenmcnaughton/dedupe3
Seamus Lee [Fri, 10 Jan 2020 23:35:05 +0000 (10:35 +1100)]
Merge pull request #15829 from eileenmcnaughton/dedupe3

Add resolved to return array for get_conflicts

4 years agoMerge pull request #16269 from wmortada/fix-auto-renew-text
Seamus Lee [Fri, 10 Jan 2020 21:01:19 +0000 (08:01 +1100)]
Merge pull request #16269 from wmortada/fix-auto-renew-text

dev/core#1519 Fix auto renew text

4 years agoMerge pull request #16268 from JGaunt/patch-2
Seamus Lee [Fri, 10 Jan 2020 20:53:15 +0000 (07:53 +1100)]
Merge pull request #16268 from JGaunt/patch-2

Update contributor-key.yml

4 years agoMerge pull request #16270 from demeritcowboy/testtest
Matthew Wire [Fri, 10 Jan 2020 18:34:13 +0000 (18:34 +0000)]
Merge pull request #16270 from demeritcowboy/testtest

Update failing test to match intervening changes elsewhere

4 years agoupdate test to match changes elsewhere
demeritcowboy [Fri, 10 Jan 2020 15:17:38 +0000 (10:17 -0500)]
update test to match changes elsewhere

4 years agoUpdate contributor-key.yml
Jade Gaunt [Fri, 10 Jan 2020 13:59:12 +0000 (13:59 +0000)]
Update contributor-key.yml

4 years agoFix auto renew text
William Mortada [Fri, 10 Jan 2020 13:44:31 +0000 (13:44 +0000)]
Fix auto renew text

4 years agoMerge pull request #15306 from bhahumanists/bhahumanists-mailingID
Matthew Wire [Fri, 10 Jan 2020 11:37:36 +0000 (11:37 +0000)]
Merge pull request #15306 from bhahumanists/bhahumanists-mailingID

#1253 Pass mailing id to alterMailContent hook

4 years agoMerge pull request #16195 from demeritcowboy/activityview-recent-items
Matthew Wire [Fri, 10 Jan 2020 11:35:35 +0000 (11:35 +0000)]
Merge pull request #16195 from demeritcowboy/activityview-recent-items

dev/core#1507 Fix recent items for viewing Email activities from contact activities tab

4 years agoMerge pull request #16257 from colemanw/index
Seamus Lee [Fri, 10 Jan 2020 06:30:09 +0000 (17:30 +1100)]
Merge pull request #16257 from colemanw/index

Add more functionality to the api4 $index param

4 years agoMerge pull request #16264 from MegaphoneJon/soft-credit-hooks
Seamus Lee [Fri, 10 Jan 2020 06:29:43 +0000 (17:29 +1100)]
Merge pull request #16264 from MegaphoneJon/soft-credit-hooks

Add pre/post hooks on ContributionSoft entity

4 years agoAdd pre/post hooks on ContributionSoft entity
Jon Goldberg [Thu, 9 Jan 2020 22:34:13 +0000 (17:34 -0500)]
Add pre/post hooks on ContributionSoft entity

4 years agoAdd unit test for Civi\Api4\Utils\ReflectionUtils::parseDocBlock
Coleman Watts [Fri, 10 Jan 2020 01:14:50 +0000 (20:14 -0500)]
Add unit test for Civi\Api4\Utils\ReflectionUtils::parseDocBlock

4 years agoTest fix - legacy api4 wrapper should always return id
Coleman Watts [Thu, 9 Jan 2020 22:35:30 +0000 (17:35 -0500)]
Test fix - legacy api4 wrapper should always return id

4 years agoMerge pull request #15318 from jitendrapurohit/dev-1263
Seamus Lee [Thu, 9 Jan 2020 22:40:28 +0000 (09:40 +1100)]
Merge pull request #15318 from jitendrapurohit/dev-1263

dev/drupal#89 - Drupal 8 - Contact Report does not load any values in…

4 years agoMerge pull request #16258 from samuelsov/i18ncountriesorder
Eileen McNaughton [Thu, 9 Jan 2020 21:31:52 +0000 (10:31 +1300)]
Merge pull request #16258 from samuelsov/i18ncountriesorder

Country/State PseudoConstant not sorted according to the locale

4 years agoMerge pull request #16148 from mattwire/contributionpayment_fullrefund
Eileen McNaughton [Thu, 9 Jan 2020 20:59:31 +0000 (09:59 +1300)]
Merge pull request #16148 from mattwire/contributionpayment_fullrefund

Set contribution status to refunded when it has been refunded

4 years agoMerge pull request #16251 from eileenmcnaughton/line_clean
Matthew Wire [Thu, 9 Jan 2020 20:45:51 +0000 (20:45 +0000)]
Merge pull request #16251 from eileenmcnaughton/line_clean

[REF] Remove never-passed param from getLineItems

4 years agoMerge pull request #16253 from eileenmcnaughton/mem_val2
Matthew Wire [Thu, 9 Jan 2020 20:41:39 +0000 (20:41 +0000)]
Merge pull request #16253 from eileenmcnaughton/mem_val2

Add tax rates to metadata

4 years agoMerge pull request #16247 from eileenmcnaughton/dedupe4
Matthew Wire [Thu, 9 Jan 2020 20:38:21 +0000 (20:38 +0000)]
Merge pull request #16247 from eileenmcnaughton/dedupe4

[REF] Extract location wrangling code.

4 years agoMerge pull request #16254 from eileenmcnaughton/partial_pay
Matthew Wire [Thu, 9 Jan 2020 20:35:31 +0000 (20:35 +0000)]
Merge pull request #16254 from eileenmcnaughton/partial_pay

[REF] rename lineItem & lineItems variable

4 years agoMerge pull request #16240 from MegaphoneJon/core-1512
Seamus Lee [Thu, 9 Jan 2020 20:33:01 +0000 (07:33 +1100)]
Merge pull request #16240 from MegaphoneJon/core-1512

core#1512: Address ID should be exportable

4 years agoMerge pull request #16208 from mattwire/activitytokensfixcaseid
Seamus Lee [Thu, 9 Jan 2020 20:32:31 +0000 (07:32 +1100)]
Merge pull request #16208 from mattwire/activitytokensfixcaseid

Fix activity.case_id token to always display the first case ID

4 years agoMerge pull request #16252 from eileenmcnaughton/line_items_by
Matthew Wire [Thu, 9 Jan 2020 20:31:49 +0000 (20:31 +0000)]
Merge pull request #16252 from eileenmcnaughton/line_items_by

[REF] Move use of priceSetID & amount_override to where they are used

4 years agoCountry/Region PseudoConstant not sorted according to the locale
Samuel Vanhove [Thu, 9 Jan 2020 17:54:51 +0000 (12:54 -0500)]
Country/Region PseudoConstant not sorted according to the locale

4 years agocore#1512: Address ID should be exportable
Jon Goldberg [Wed, 8 Jan 2020 23:01:00 +0000 (18:01 -0500)]
core#1512: Address ID should be exportable

4 years agoImprove civicrm_api4 docblock and use it for help display in Explorer
Coleman Watts [Thu, 9 Jan 2020 16:44:39 +0000 (11:44 -0500)]
Improve civicrm_api4 docblock and use it for help display in Explorer

4 years agoAdd tax rates to metadata
eileen [Thu, 2 Jan 2020 22:03:04 +0000 (11:03 +1300)]
Add tax rates to metadata

This doesn't do anything by itself but it lays the foundation for a solid fix for

https://github.com/civicrm/civicrm-core/pull/15895 - ie by having minimum_fee_with_tax as part of our
generally available metadata we get out of all the complexity of doing this in the js layer - which is
what is driving that bug

4 years agoUnit test for #16148
Jitendra Purohit [Thu, 9 Jan 2020 12:38:17 +0000 (18:08 +0530)]
Unit test for #16148

4 years agoSet contribution status to refunded when it has previously been fully paid and now...
Matthew Wire [Mon, 23 Dec 2019 22:59:13 +0000 (22:59 +0000)]
Set contribution status to refunded when it has previously been fully paid and now payments add up to 0

4 years ago[REF] rename lineItem & lineItems variable
eileen [Thu, 9 Jan 2020 11:55:17 +0000 (00:55 +1300)]
[REF] rename lineItem & lineItems variable

Readability fix -

=======Before========
 refers to an array of lineItems,  refers to a single lineItem

=======After
 refers to an array of line items,  refers to the single (created) line itmem

4 years agoMove use of priceSetID & amount_override to where they are used
eileen [Thu, 9 Jan 2020 07:01:04 +0000 (20:01 +1300)]
Move use of priceSetID & amount_override to where they are used

The field name is misleading since it implies it is useful in general to pass in a priceSetID - however, it has
a very specific usage & meaning & ideally we would deprecate it in favour of something more readable. For now
group the code more logically & comment it

4 years agoMerge pull request #16059 from eileenmcnaughton/mem_val2
Matthew Wire [Thu, 9 Jan 2020 11:07:33 +0000 (11:07 +0000)]
Merge pull request #16059 from eileenmcnaughton/mem_val2

[REF] Cleanup CRM_Member_BAO_Membership::buildMembershipTypeValues

4 years agoMerge pull request #16249 from eileenmcnaughton/ex_exclosed
Seamus Lee [Thu, 9 Jan 2020 09:13:20 +0000 (20:13 +1100)]
Merge pull request #16249 from eileenmcnaughton/ex_exclosed

[REF] Remove enclosed & escaped variables

4 years agoMerge pull request #16248 from eileenmcnaughton/cc
Seamus Lee [Thu, 9 Jan 2020 09:06:48 +0000 (20:06 +1100)]
Merge pull request #16248 from eileenmcnaughton/cc

[NFC] Code comments

4 years agoMerge pull request #16250 from eileenmcnaughton/member
Seamus Lee [Thu, 9 Jan 2020 09:06:04 +0000 (20:06 +1100)]
Merge pull request #16250 from eileenmcnaughton/member

[NFC] Minor cleanup in test class

4 years agodev/core#1263 - Drupal 8 - Contact Report does not load any values in the ACL Group...
Jitendra Purohit [Wed, 18 Sep 2019 07:12:51 +0000 (12:42 +0530)]
dev/core#1263 - Drupal 8 - Contact Report does not load any values in the ACL Group/Role field

4 years ago[REF] Remove never-passed param from getLineItems
eileen [Thu, 9 Jan 2020 05:33:16 +0000 (18:33 +1300)]
[REF] Remove never-passed param from getLineItems

Parameter  was added to getLineItems in https://github.com/civicrm/civicrm-core/commit/25d0c6478ee236a4ac150e8d2b39614602ca4ae8
to support invoicing. However that function no longer calls getLineItems & has not for some time (at least a year). No other functions
pass in this parameter so we can remove it

4 years agoMerge pull request #16245 from eileenmcnaughton/dedupe1
Eileen McNaughton [Thu, 9 Jan 2020 05:16:36 +0000 (18:16 +1300)]
Merge pull request #16245 from eileenmcnaughton/dedupe1

[REF] Minor code simplification in dedupe.

4 years ago[NFC] Minor cleanup in test class
eileen [Thu, 9 Jan 2020 04:54:31 +0000 (17:54 +1300)]
[NFC] Minor cleanup in test class

4 years agoCode comments
eileen [Mon, 25 Nov 2019 03:55:54 +0000 (16:55 +1300)]
Code comments

4 years agoRemove enclosed variable.
eileen [Mon, 25 Nov 2019 04:41:47 +0000 (17:41 +1300)]
Remove enclosed variable.

Given that it can only ever be a double quote parameterizing it is only confusing

4 years ago[REF] Extract location wrangling code.
eileen [Thu, 9 Jan 2020 04:07:23 +0000 (17:07 +1300)]
[REF] Extract location wrangling code.

Note I have deliberately kept this extraction as vanilla as possible wtih the goal being to rationalise in
later iterations

4 years agoSupport index param as array in api explorer
Coleman Watts [Thu, 9 Jan 2020 03:22:37 +0000 (22:22 -0500)]
Support index param as array in api explorer

4 years agocivicrm_api4 - Extend functionality of index param
Coleman Watts [Thu, 9 Jan 2020 03:13:57 +0000 (22:13 -0500)]
civicrm_api4 - Extend functionality of index param

Passing an array allows you to return a single result column, with automatic handling of the select clause.

4 years ago[REF] Minor code simplification in dedupe.
eileen [Thu, 9 Jan 2020 03:08:15 +0000 (16:08 +1300)]
[REF] Minor code simplification in dedupe.

This just tweaks readability by
1) adding a variable for a value nested fairly deeply in an array
2) removing the foundField handling in favour of a ternary since
it's kinda confusing as is

4 years agoMerge pull request #15475 from mecachisenros/externUrl
Seamus Lee [Thu, 9 Jan 2020 02:21:23 +0000 (13:21 +1100)]
Merge pull request #15475 from mecachisenros/externUrl

dev/core#1100 Add externUrl method and civicrm_alterExternUrl hook

4 years agoMerge pull request #16231 from mfb/imap-batch-size
Seamus Lee [Thu, 9 Jan 2020 02:19:08 +0000 (13:19 +1100)]
Merge pull request #16231 from mfb/imap-batch-size

Remove patch hunk now that zetacomponents/Mail#73 has been merged

4 years agoMerge pull request #16241 from eileenmcnaughton/sess
Seamus Lee [Thu, 9 Jan 2020 02:11:55 +0000 (13:11 +1100)]
Merge pull request #16241 from eileenmcnaughton/sess

[REF] move sessionStart functionality to System subclass

4 years agoMerge pull request #16242 from civicrm/5.22
Eileen McNaughton [Thu, 9 Jan 2020 01:21:59 +0000 (14:21 +1300)]
Merge pull request #16242 from civicrm/5.22

5.22 to master

4 years agoMerge pull request #16239 from MegaphoneJon/mailing-60-522
Eileen McNaughton [Thu, 9 Jan 2020 01:19:52 +0000 (14:19 +1300)]
Merge pull request #16239 from MegaphoneJon/mailing-60-522

mailing#60: Fix regression where `is_bulkmail` flag isn't respected

4 years agocivicrm_api4 - auto-adjust select query when passing an index
Coleman Watts [Thu, 9 Jan 2020 01:11:04 +0000 (20:11 -0500)]
civicrm_api4 - auto-adjust select query when passing an index

4 years agoMerge pull request #15778 from agh1/reminder-do-not-email-test
Tim Otten [Thu, 9 Jan 2020 00:27:11 +0000 (16:27 -0800)]
Merge pull request #15778 from agh1/reminder-do-not-email-test

dev/core#1378 Scheduled reminders: do not email if do_not_email or on_hold

4 years ago[REF] move sessionStart functionality to System subclass
eileen [Wed, 8 Jan 2020 23:07:25 +0000 (12:07 +1300)]
[REF] move sessionStart functionality to System subclass

Preparatory to https://github.com/civicrm/civicrm-core/pull/15131/files

4 years agoMerge pull request #16105 from seamuslee001/dev_core_522_204
Seamus Lee [Wed, 8 Jan 2020 22:47:27 +0000 (09:47 +1100)]
Merge pull request #16105 from seamuslee001/dev_core_522_204

dev/core#522 CRM-19767 dev/core#204 Add Case Tokens to emails

4 years agoMerge pull request #15969 from eileenmcnaughton/utfmb8
Seamus Lee [Wed, 8 Jan 2020 22:44:08 +0000 (09:44 +1100)]
Merge pull request #15969 from eileenmcnaughton/utfmb8

Add utf8 to utfmb8 conversion api command

4 years agoMerge pull request #16234 from demeritcowboy/more-t6
Seamus Lee [Wed, 8 Jan 2020 22:36:46 +0000 (09:36 +1100)]
Merge pull request #16234 from demeritcowboy/more-t6

dev/core#495 Make admin settings field labels translatable

4 years agoMerge pull request #16235 from demeritcowboy/more-t7
Eileen McNaughton [Wed, 8 Jan 2020 22:36:25 +0000 (11:36 +1300)]
Merge pull request #16235 from demeritcowboy/more-t7

dev/core#495 Make admin settings field labels translatable

4 years agoMerge pull request #16236 from demeritcowboy/more-t8
Eileen McNaughton [Wed, 8 Jan 2020 22:36:09 +0000 (11:36 +1300)]
Merge pull request #16236 from demeritcowboy/more-t8

dev/core#495 Make admin settings field labels translatable

4 years agoMerge pull request #16237 from demeritcowboy/more-t9
Eileen McNaughton [Wed, 8 Jan 2020 22:35:56 +0000 (11:35 +1300)]
Merge pull request #16237 from demeritcowboy/more-t9

dev/core#495 Make admin settings field labels translatable

4 years agoMerge pull request #16233 from demeritcowboy/more-t5
Seamus Lee [Wed, 8 Jan 2020 22:35:49 +0000 (09:35 +1100)]
Merge pull request #16233 from demeritcowboy/more-t5

dev/core#495 Make admin settings field labels translatable

4 years agoMerge pull request #16232 from demeritcowboy/more-t4
Seamus Lee [Wed, 8 Jan 2020 22:35:38 +0000 (09:35 +1100)]
Merge pull request #16232 from demeritcowboy/more-t4

dev/core#495 Make admin settings field labels translatable

4 years agomailing#60: Fix regression where multiple bulk recipient option isn't respected
Jon Goldberg [Tue, 7 Jan 2020 18:53:52 +0000 (13:53 -0500)]
mailing#60: Fix regression where multiple bulk recipient option isn't respected

test fixes

4 years agomake translatable
demeritcowboy [Wed, 8 Jan 2020 20:38:20 +0000 (15:38 -0500)]
make translatable

4 years agomake translatable
demeritcowboy [Wed, 8 Jan 2020 20:36:40 +0000 (15:36 -0500)]
make translatable

4 years agoMerge pull request #16228 from demeritcowboy/more-t2
Eileen McNaughton [Wed, 8 Jan 2020 20:35:37 +0000 (09:35 +1300)]
Merge pull request #16228 from demeritcowboy/more-t2

dev/core#495 Make admin settings field labels translatable

4 years agoMerge pull request #16229 from demeritcowboy/more-t3
Eileen McNaughton [Wed, 8 Jan 2020 20:33:19 +0000 (09:33 +1300)]
Merge pull request #16229 from demeritcowboy/more-t3

dev/core#495 Make admin settings field labels translatable

4 years agomake translatable
demeritcowboy [Wed, 8 Jan 2020 20:30:48 +0000 (15:30 -0500)]
make translatable

4 years agomake translatable
demeritcowboy [Wed, 8 Jan 2020 20:19:10 +0000 (15:19 -0500)]
make translatable

4 years agomake translatable
demeritcowboy [Wed, 8 Jan 2020 20:13:32 +0000 (15:13 -0500)]
make translatable

4 years agomake translatable
demeritcowboy [Wed, 8 Jan 2020 20:06:37 +0000 (15:06 -0500)]
make translatable

4 years agoUpdate and remove patch hunk now that zetacomponents/Mail#73 was merged.
mark burdett [Wed, 8 Jan 2020 17:56:18 +0000 (09:56 -0800)]
Update and remove patch hunk now that zetacomponents/Mail#73 was merged.

4 years agomake translatable
demeritcowboy [Wed, 8 Jan 2020 14:36:28 +0000 (09:36 -0500)]
make translatable

4 years agomake translatable
demeritcowboy [Wed, 8 Jan 2020 14:30:31 +0000 (09:30 -0500)]
make translatable

4 years agoMerge pull request #16227 from demeritcowboy/more-t
Matthew Wire [Wed, 8 Jan 2020 10:25:23 +0000 (10:25 +0000)]
Merge pull request #16227 from demeritcowboy/more-t

dev/core#495 Make admin settings field labels translatable

4 years agomake translatable
demeritcowboy [Wed, 8 Jan 2020 06:19:57 +0000 (01:19 -0500)]
make translatable

4 years agoMerge pull request #16220 from colemanw/checkmark
Eileen McNaughton [Tue, 7 Jan 2020 23:10:45 +0000 (12:10 +1300)]
Merge pull request #16220 from colemanw/checkmark

Change check.gif to an actual gif (was a PNG)

4 years agoMerge pull request #16222 from colemanw/importable
Eileen McNaughton [Tue, 7 Jan 2020 23:10:16 +0000 (12:10 +1300)]
Merge pull request #16222 from colemanw/importable

Refactor CRM_Contact_BAO_Contact::importableFields() to use metadata

4 years agoMerge pull request #16226 from civicrm/5.22
Eileen McNaughton [Tue, 7 Jan 2020 23:08:13 +0000 (12:08 +1300)]
Merge pull request #16226 from civicrm/5.22

5.22 to master

4 years agoMerge pull request #16225 from demeritcowboy/contribution-view-missing-status
Eileen McNaughton [Tue, 7 Jan 2020 23:06:35 +0000 (12:06 +1300)]
Merge pull request #16225 from demeritcowboy/contribution-view-missing-status

dev/core#1508 Regression/E_NOTICE - Missing table on contribution view

4 years agoMerge pull request #16224 from eileenmcnaughton/set
Eileen McNaughton [Tue, 7 Jan 2020 23:02:29 +0000 (12:02 +1300)]
Merge pull request #16224 from eileenmcnaughton/set

dev/core#495 Add some ts tags on settings

4 years agoput back mistakenly removed variable
demeritcowboy [Tue, 7 Jan 2020 21:07:25 +0000 (16:07 -0500)]
put back mistakenly removed variable

4 years agodev/core#495 Add some ts tags on settings
eileen [Tue, 7 Jan 2020 19:32:19 +0000 (08:32 +1300)]
dev/core#495 Add some ts tags on settings

4 years agoRefactor CRM_Contact_BAO_Contact::importableFields() to use metadata
Coleman Watts [Tue, 7 Jan 2020 18:25:05 +0000 (13:25 -0500)]
Refactor CRM_Contact_BAO_Contact::importableFields() to use metadata

This squares up the recently added metadata with a hardcoded list in the BAO,
removing the hardcoded list in favor of metadata.

4 years agoMerge pull request #15307 from seamuslee001/dev_core_1249
Eileen McNaughton [Tue, 7 Jan 2020 04:26:07 +0000 (17:26 +1300)]
Merge pull request #15307 from seamuslee001/dev_core_1249

dev/core#1249 Allow IPNs to be validated even if the supplied contact…

4 years agoMerge pull request #15670 from eileenmcnaughton/dupe_locks
Seamus Lee [Tue, 7 Jan 2020 03:43:48 +0000 (14:43 +1100)]
Merge pull request #15670 from eileenmcnaughton/dupe_locks

dev/core#1355 Add contention handling for dedupe jobs

4 years agoMerge pull request #15948 from eileenmcnaughton/export_test
Seamus Lee [Tue, 7 Jan 2020 03:30:50 +0000 (14:30 +1100)]
Merge pull request #15948 from eileenmcnaughton/export_test

Revised version of test from #15725

4 years agoMerge pull request #16219 from seamuslee001/nfc_test_followup_16150
Seamus Lee [Tue, 7 Jan 2020 02:40:51 +0000 (13:40 +1100)]
Merge pull request #16219 from seamuslee001/nfc_test_followup_16150

[NFC] Test update following PR #16150, assertEquals first param is th…

4 years agoChange check.gif to an actual gif (was a PNG)
Coleman Watts [Tue, 7 Jan 2020 02:04:04 +0000 (21:04 -0500)]
Change check.gif to an actual gif (was a PNG)

4 years ago[NFC] Test update following PR #16150, assertEquals first param is the expected value...
Seamus Lee [Tue, 7 Jan 2020 01:36:22 +0000 (12:36 +1100)]
[NFC] Test update following PR #16150, assertEquals first param is the expected value not the current value

4 years agoMerge pull request #16150 from jitendrapurohit/dev-1499
Seamus Lee [Tue, 7 Jan 2020 01:33:58 +0000 (12:33 +1100)]
Merge pull request #16150 from jitendrapurohit/dev-1499

dev/core#1499 - Case Resource shows contact names that are not access…

4 years agoMerge pull request #15855 from eileenmcnaughton/test_dep
Seamus Lee [Tue, 7 Jan 2020 01:30:46 +0000 (12:30 +1100)]
Merge pull request #15855 from eileenmcnaughton/test_dep

Deprecate creating partially paid contributions, other than by partially paying a contribution.

4 years agoMerge pull request #16218 from seamuslee001/nfc_add_more_asserts_change_fee_selection
Seamus Lee [Tue, 7 Jan 2020 01:24:03 +0000 (12:24 +1100)]
Merge pull request #16218 from seamuslee001/nfc_add_more_asserts_change_fee_selection

[NFC] Add in more assertions around the content of line items and tot…

4 years ago[NFC] Add in more assertions around the content of line items and total amount of...
Seamus Lee [Mon, 6 Jan 2020 23:48:21 +0000 (10:48 +1100)]
[NFC] Add in more assertions around the content of line items and total amount of the contribution record

4 years agoMerge pull request #16198 from seamuslee001/parent_fetchall
Eileen McNaughton [Mon, 6 Jan 2020 21:14:36 +0000 (10:14 +1300)]
Merge pull request #16198 from seamuslee001/parent_fetchall

[REF] Update fetchAll function signature to match parent function