Tim Otten [Fri, 10 Dec 2021 08:49:55 +0000 (00:49 -0800)]
(REF) CRM/Upgrade - Remove unused entrypoint `verifyPreDBstate()`
Overview
--------
In olden times, upgraders sometimes implemented the method `verifyPreDBstate()`. However, this appears to be unused.
Additionally, it's not clear (from the documentation) how you would use it (if you wanted to).
So... simplify the code....
Before
------
Function exists. But it does nothing. Because no subclasses implement it.
After
-----
Function does not exist. It still does nothing.
demeritcowboy [Fri, 10 Dec 2021 00:12:48 +0000 (19:12 -0500)]
Merge pull request #22187 from eileenmcnaughton/smarty13
Smarty variables] Remove isset from batch form
Eileen McNaughton [Tue, 30 Nov 2021 21:48:44 +0000 (10:48 +1300)]
Remove isset from batch form
Affects url civicrm/financial/financialbatches?reset=1&batchStatus=1
Mathieu Lu [Thu, 9 Dec 2021 21:47:27 +0000 (16:47 -0500)]
Merge pull request #22234 from colemanw/afformDateRange
Afform - Set date-range defaults
Eileen McNaughton [Thu, 9 Dec 2021 21:45:59 +0000 (10:45 +1300)]
Merge pull request #22232 from civicrm/5.45
5.45
Mathieu Lu [Thu, 9 Dec 2021 21:40:47 +0000 (16:40 -0500)]
Merge pull request #22226 from colemanw/deleteBoilerplate
NFC - Delete boilerplate comments and empty functions from upgrade classes
colemanw [Thu, 9 Dec 2021 21:09:38 +0000 (16:09 -0500)]
Merge pull request #22193 from eileenmcnaughton/smarty18
[Smarty variables] remove isset from merge screen
Tim Otten [Thu, 9 Dec 2021 21:02:58 +0000 (13:02 -0800)]
Merge pull request #22231 from colemanw/apiDisabledComponent
dev/core#2984 - Clarify API error when component is disabled
colemanw [Thu, 9 Dec 2021 19:24:25 +0000 (14:24 -0500)]
Merge pull request #22203 from colemanw/revertContactDeletePermission
Revert "Add permission metadata to contact is_deleted field"
Coleman Watts [Thu, 9 Dec 2021 17:34:57 +0000 (12:34 -0500)]
APIv4 - Fix datePicker defaults
Ensures datepickers can select more than the current year (start and end date years were defaulting to 0)
Fixes dev/report#84
demeritcowboy [Thu, 9 Dec 2021 16:24:36 +0000 (11:24 -0500)]
Merge pull request #22214 from yashodha/dev-2979
(dev/core#2979) remove the limit of 15 max values for multiple values…
yashodha [Mon, 6 Dec 2021 07:37:07 +0000 (13:07 +0530)]
change the limit
demeritcowboy [Thu, 9 Dec 2021 03:21:26 +0000 (22:21 -0500)]
Merge pull request #22194 from eileenmcnaughton/smarty19
[Smarty variables] Fix overzealous escaping with smarty default escaping
demeritcowboy [Thu, 9 Dec 2021 03:21:08 +0000 (22:21 -0500)]
Merge pull request #22195 from eileenmcnaughton/smarty20
[Smarty variables] Remove issets relating to auto_renew
Seamus Lee [Thu, 9 Dec 2021 01:42:22 +0000 (12:42 +1100)]
Merge pull request #22230 from agh1/5.45.0-releasenotes-initial
5.45.0 release notes initial run
Coleman Watts [Thu, 9 Dec 2021 00:47:38 +0000 (19:47 -0500)]
Fixes dev/core#2984 - Give clear error message when entity's component is disabled
Previously, using an API from a disabled component would fail in unexpected ways
with cryptic error messages. Now it's clearly not allowed.
Andie Hunt [Wed, 8 Dec 2021 22:16:53 +0000 (17:16 -0500)]
5.45.0 release notes: added boilerplate
Andie Hunt [Wed, 8 Dec 2021 22:11:18 +0000 (17:11 -0500)]
Contributor key: add Chris Garaffa
Andie Hunt [Wed, 8 Dec 2021 22:03:23 +0000 (17:03 -0500)]
5.45.0 release notes: raw from script
colemanw [Wed, 8 Dec 2021 18:28:35 +0000 (13:28 -0500)]
Merge pull request #22192 from eileenmcnaughton/smarty17
[Smarty variables] Remove issets from payment processor form
colemanw [Wed, 8 Dec 2021 18:27:39 +0000 (13:27 -0500)]
Merge pull request #22217 from demeritcowboy/repeat-deprecated
dev/core#2982 - Deprecated warnings for money formatting in Repeat Contributions CiviReport
colemanw [Wed, 8 Dec 2021 16:04:13 +0000 (11:04 -0500)]
Merge pull request #22224 from colemanw/boilerplateFix
NFC - Cleanup messy boilerplate
Coleman Watts [Wed, 8 Dec 2021 14:49:15 +0000 (09:49 -0500)]
NFC - Delete boilerplate comments and empty functions from upgrade classes
Coleman Watts [Wed, 8 Dec 2021 13:44:07 +0000 (08:44 -0500)]
NFC - Cleanup messy boilerplate
Matthew Wire [Wed, 8 Dec 2021 12:07:28 +0000 (12:07 +0000)]
Merge pull request #18158 from mattwire/createProfileContact
Initial refactor of createProfileContact groups
Seamus Lee [Wed, 8 Dec 2021 08:57:40 +0000 (19:57 +1100)]
Merge pull request #22222 from civicrm/5.45
5.45
Seamus Lee [Wed, 8 Dec 2021 02:27:44 +0000 (13:27 +1100)]
Merge pull request #22221 from seamuslee001/nfc_fix_system_test_mysql8
[NFC] Update System Uft8mb4 check to handle for the fact that MySQL8 …
Seamus Lee [Wed, 8 Dec 2021 01:00:25 +0000 (12:00 +1100)]
Merge pull request #22220 from seamuslee001/drupal9_get_version
[REF] Add in getVersion override for Drupal 8/9 to support cv testing…
Seamus Lee [Wed, 8 Dec 2021 00:31:11 +0000 (11:31 +1100)]
Merge pull request #22201 from colemanw/exportPseudoconstantFix
APIv4 Export - Fix logic for exporting pseudoconstant syntax
Seamus Lee [Wed, 8 Dec 2021 00:14:33 +0000 (11:14 +1100)]
[NFC] Update System Uft8mb4 check to handle for the fact that MySQL8 outputs utf8mb3 when the charset has been set to utf8 as utf8mb3 is the underlyling charset for utf8
Seamus Lee [Tue, 7 Dec 2021 23:27:09 +0000 (10:27 +1100)]
[REF] Add in getVersion override for Drupal 8/9 to support cv testing and also cv vars:show picking up the right CMS version
CiviCRM [Tue, 7 Dec 2021 21:48:15 +0000 (21:48 +0000)]
Set version to 5.46.alpha1
CiviCRM [Tue, 7 Dec 2021 21:27:23 +0000 (21:27 +0000)]
Set version to 5.45.beta1
colemanw [Tue, 7 Dec 2021 18:59:41 +0000 (13:59 -0500)]
Merge pull request #22199 from totten/master-mix-dec-all
civix#175 - Switch core extensions to mixins (ang-php, menu-xml, theme-php, case-xml, mgd-php)
demeritcowboy [Tue, 7 Dec 2021 18:49:07 +0000 (13:49 -0500)]
Merge pull request #22219 from demeritcowboy/selenium-webtests
[NFC] Remove Selenium WebTest code from CiviMailUtils
demeritcowboy [Tue, 7 Dec 2021 12:41:02 +0000 (07:41 -0500)]
Merge pull request #22218 from colemanw/fixCanAggregate
SearchKit - Fix undefined variable for searches of Afforms etc.
demeritcowboy [Sun, 21 Nov 2021 03:33:09 +0000 (22:33 -0500)]
remove selenium webtest code
Tim Otten [Tue, 7 Dec 2021 03:58:14 +0000 (19:58 -0800)]
mixin/case-xml - Enable CiviCase during testing
colemanw [Tue, 7 Dec 2021 02:21:37 +0000 (21:21 -0500)]
Merge pull request #22189 from eileenmcnaughton/smarty14
[Smarty variables] Consistently assign isAdmin at php layer
Seamus Lee [Tue, 7 Dec 2021 01:06:37 +0000 (12:06 +1100)]
Merge pull request #22205 from totten/master-hook-conform
APIv4 ConformanceTest - Demonstrate entity APIs which fail to emit `hook_civicrm_post(delete)`
demeritcowboy [Tue, 7 Dec 2021 00:57:48 +0000 (19:57 -0500)]
deprecated money-formatting of non-numeric
Tim Otten [Fri, 3 Dec 2021 07:01:27 +0000 (23:01 -0800)]
(REF) MixinLoader - Convert static to local property
Tim Otten [Fri, 3 Dec 2021 06:43:56 +0000 (22:43 -0800)]
(REF) Mixins - Promote `MixinLoader` to tracked service-object
Tim Otten [Fri, 3 Dec 2021 06:38:02 +0000 (22:38 -0800)]
(REF) Mixins - Move `applyMixins()` logic into `MixinLoader`
Tim Otten [Fri, 3 Dec 2021 06:30:50 +0000 (22:30 -0800)]
(REF) Mixins - Move more aspects of scanning from MixinLoader to MixinScanner
Tim Otten [Fri, 3 Dec 2021 04:50:05 +0000 (20:50 -0800)]
(REF) Mixins - Split apart class-loader and mixin-loader
Tim Otten [Thu, 2 Dec 2021 21:38:23 +0000 (13:38 -0800)]
ext/**.civix.php - Remove _civix_glob(). Not used anymore.
Tim Otten [Thu, 2 Dec 2021 21:35:35 +0000 (13:35 -0800)]
ext/**.civix.php - Remove _civix_find_files(). Not used anymore.
Tim Otten [Thu, 2 Dec 2021 21:30:21 +0000 (13:30 -0800)]
mixin/mgd-php - Remove unused boilerplate
Tim Otten [Thu, 2 Dec 2021 21:24:59 +0000 (13:24 -0800)]
mixin/mgd-php - Convert live `*.mgd.php` from `hook_managed` to `<mixin>`
Tim Otten [Tue, 30 Nov 2021 22:26:58 +0000 (14:26 -0800)]
mixin/mgd-php - Import
Tim Otten [Thu, 2 Dec 2021 21:17:14 +0000 (13:17 -0800)]
mixin/ang-php - Convert live Angular modules from `hook_angularModules` to `<mixin>`
Tim Otten [Wed, 1 Dec 2021 02:54:36 +0000 (18:54 -0800)]
mixin/menu-xml - Remove unused boilerplate
Tim Otten [Wed, 1 Dec 2021 02:47:05 +0000 (18:47 -0800)]
mixin/menu-xml - Convert live menu-items from `hook_xmlMenu` to `<mixin>`
Tim Otten [Tue, 30 Nov 2021 22:26:34 +0000 (14:26 -0800)]
mixin/menu-xml - Import
Tim Otten [Wed, 1 Dec 2021 02:39:49 +0000 (18:39 -0800)]
mixin/case-xml - Remove unused boilerplate
Tim Otten [Tue, 30 Nov 2021 22:26:23 +0000 (14:26 -0800)]
mixin/case-xml - Import
Tim Otten [Wed, 1 Dec 2021 02:30:38 +0000 (18:30 -0800)]
mixin/theme-php - Remove unused boilerplate
Tim Otten [Tue, 30 Nov 2021 22:26:50 +0000 (14:26 -0800)]
mixin/theme-php - Import
Tim Otten [Wed, 1 Dec 2021 01:00:25 +0000 (17:00 -0800)]
mixin/ang-php - Remove unused boilerplate
Tim Otten [Wed, 1 Dec 2021 00:53:40 +0000 (16:53 -0800)]
mixin/ang-php - Convert live Angular modules from `hook_angularModules` to `<mixin>`
Tim Otten [Tue, 30 Nov 2021 22:26:11 +0000 (14:26 -0800)]
mixin/ang-php - Import
Tim Otten [Mon, 6 Dec 2021 23:08:36 +0000 (15:08 -0800)]
Merge pull request #22207 from colemanw/baoDeleteHooks
[REF] - Switch BAOs to use standard delete function which calls hooks
Seamus Lee [Mon, 6 Dec 2021 22:38:38 +0000 (09:38 +1100)]
Merge pull request #22191 from eileenmcnaughton/smarty16
Smarty variables] Remove isset from a.net
demeritcowboy [Mon, 6 Dec 2021 19:26:31 +0000 (14:26 -0500)]
Merge pull request #22190 from eileenmcnaughton/smarty15
[Smarty variables] remove isset from Mail accounts
demeritcowboy [Mon, 6 Dec 2021 17:34:08 +0000 (12:34 -0500)]
Merge pull request #22181 from eileenmcnaughton/smarty8
[Smarty variables] Remove another isset - user dashboard
Yashodha Chaku [Mon, 6 Dec 2021 16:06:52 +0000 (21:36 +0530)]
Merge pull request #22216 from demeritcowboy/th-br
dev/core#2982 - Remove literal `<br/>` tag in header for Repeat Contributions CiviReport
demeritcowboy [Mon, 6 Dec 2021 15:25:11 +0000 (10:25 -0500)]
Merge pull request #22177 from eileenmcnaughton/smarty5
Smarty variables] Remove isset from relationship tab
demeritcowboy [Mon, 6 Dec 2021 14:16:46 +0000 (09:16 -0500)]
remove br tag in header
demeritcowboy [Mon, 6 Dec 2021 13:58:07 +0000 (08:58 -0500)]
Merge pull request #22215 from totten/master-mixin-xdebug
(NFC) tools/mixin/bin/test-all - Work-around segfault in CI
Tim Otten [Mon, 6 Dec 2021 09:29:17 +0000 (01:29 -0800)]
tools/mixin/bin/test-all - Work-around segfault in CI
Coleman Watts [Mon, 6 Dec 2021 03:18:07 +0000 (22:18 -0500)]
SearchKit - Fix undefined variable for searches of Afforms and other non-DAO entities
Coleman Watts [Wed, 1 Dec 2021 21:44:44 +0000 (16:44 -0500)]
APIv4 Export - Fix logic for exporting pseudoconstant syntax
Coleman Watts [Sat, 4 Dec 2021 20:17:07 +0000 (15:17 -0500)]
FinancialType - Use standard delete function which calls hooks
Coleman Watts [Sat, 4 Dec 2021 20:02:15 +0000 (15:02 -0500)]
FinancialAccount - Use standard delete function which calls hooks
Coleman Watts [Fri, 3 Dec 2021 04:51:22 +0000 (23:51 -0500)]
PaymentProcessorType - Use standard delete function which calls hooks
Coleman Watts [Fri, 3 Dec 2021 04:22:49 +0000 (23:22 -0500)]
PaymentProcessor - Use standard delete function which calls hooks
Coleman Watts [Fri, 3 Dec 2021 04:17:28 +0000 (23:17 -0500)]
LocationType - Use standard delete function which calls hooks
Coleman Watts [Fri, 3 Dec 2021 03:46:21 +0000 (22:46 -0500)]
MessageTemplates - Use standard delete function which calls hooks
Coleman Watts [Fri, 3 Dec 2021 03:36:38 +0000 (22:36 -0500)]
MembershipStatus - Use standard delete function which calls hooks
Coleman Watts [Thu, 2 Dec 2021 22:42:34 +0000 (17:42 -0500)]
MembershipType - Use standard delete function which calls hooks
Coleman Watts [Thu, 2 Dec 2021 20:59:40 +0000 (15:59 -0500)]
RelationshipType - Use standard delete function which calls hooks
Coleman Watts [Thu, 2 Dec 2021 20:34:08 +0000 (15:34 -0500)]
WordReplacement - Use generic writeRecords/deleteRecords which call hooks
Coleman Watts [Thu, 2 Dec 2021 20:01:44 +0000 (15:01 -0500)]
OptionGroup - Use standard delete function which calls hooks
Coleman Watts [Thu, 2 Dec 2021 19:42:45 +0000 (14:42 -0500)]
ContactType - Use standard delete function which calls hooks
Coleman Watts [Thu, 2 Dec 2021 16:08:10 +0000 (11:08 -0500)]
CaseType - Use standard delete function which calls hooks
Tim Otten [Fri, 3 Dec 2021 20:34:25 +0000 (12:34 -0800)]
Merge pull request #22211 from totten/master-544-fwd
Merge forward 5.44 => master
Tim Otten [Fri, 3 Dec 2021 20:06:01 +0000 (12:06 -0800)]
Merge remote-tracking branch 'origin/5.44' into master-544-fwd
Tim Otten [Fri, 3 Dec 2021 19:35:36 +0000 (11:35 -0800)]
Merge pull request #22209 from demeritcowboy/reldate
[NFC] Fix test failures for testRelativeDateRanges
Seamus Lee [Fri, 3 Dec 2021 18:52:06 +0000 (05:52 +1100)]
Merge pull request #22210 from MegaphoneJon/optional-before-required
PHP 8 compat - no optional param before required
Jon Goldberg [Fri, 3 Dec 2021 15:59:11 +0000 (10:59 -0500)]
PHP 8 compat - no optional param before required
demeritcowboy [Fri, 3 Dec 2021 14:56:37 +0000 (09:56 -0500)]
fix strict equality issue
Tim Otten [Fri, 3 Dec 2021 00:26:28 +0000 (16:26 -0800)]
ConformanceTest::checkDeletionAllowed - Coverage for `hook_pre`. Fix `Contact`.
1. Expand assertions used for `hook_post` to check `hook_pre`.
2. Recognize the quirks in how `Contact` records are treated in the hooks.
Tim Otten [Thu, 2 Dec 2021 05:48:42 +0000 (21:48 -0800)]
Merge pull request #22206 from totten/5.44-bump0
5.44.0 - Bump version. Tweak notes.
Tim Otten [Thu, 2 Dec 2021 05:47:24 +0000 (21:47 -0800)]
Set version to 5.44.0
Tim Otten [Thu, 2 Dec 2021 05:46:33 +0000 (21:46 -0800)]
release-notes/5.44.0.md
Tim Otten [Thu, 2 Dec 2021 05:43:27 +0000 (21:43 -0800)]
Merge pull request #22182 from MegaphoneJon/core-2974
fixes core#2974, overrides break membership update status when removed
Tim Otten [Thu, 2 Dec 2021 05:07:23 +0000 (21:07 -0800)]
Merge pull request #22202 from agh1/5.44.0-releasenotes-final
5.44.0 release notes: added late changes
Tim Otten [Thu, 2 Dec 2021 04:43:25 +0000 (20:43 -0800)]
Merge pull request #22204 from totten/master-mixin-testall
tools/mixin/bin/test-all - Fix guard for EXT_DIR
Tim Otten [Thu, 2 Dec 2021 04:17:22 +0000 (20:17 -0800)]
ConformanceTest - Demonstrate entity APIs with non-conformant deletion